Reviewed-by: jiewen@intel.com
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star
> Zeng
> Sent: Monday, June 5, 2017 2:41 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Zeng, Star
> Subject: [edk2] [PATCH] MdePkg SmmIoLib: Use NULL
Dandan,
Is it possible to avoid adding IsUnion member variable?
I remember .G syntax supports passing value to sub-statement.
In this case, can you use: vfrDataStructFields [IsUnion]?
Thanks/Ray
> -Original Message-
> From: Bi, Dandan
> Sent: Monday, June 5, 2017 12:31 PM
> To: edk2-devel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=587
The Status check in "if (!EFI_ERROR (Status))" condition is useless,
it should be NULL pointer check. And this patch also fixes a typo
"continous" to "continuous".
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signe
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=579
Cc: Eric Dong
Cc: Liming Gao
Cc: Daniel Díaz
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
BaseTools/Source/C/VfrCompile/EfiVfr.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --gi
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Zeng, Star
> Sent: Monday, June 5, 2017 12:51 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Yao, Jiewen ; Bret
> Barkelew
> Subject: [PATCH] MdePkg SmmMemLib: Remove ASSERT in
> SmmIsBufferOutsideSmmValid
>
> REF: https
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=577
Currently the SmmIsBufferOutsideSmmValid() function in SmmMemLib.c will
ASSERT in certain conditions. Since this function is a "test" function,
it should not be making decisions on how to handle a failure.
Handling a failure should be left to
V2: Update VfrCompiler to use member variable instead of global varable
to indicate whether current date type is Union.
Cc: Eric Dong
Cc: Liming Gao
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
BaseTools/Source/C/VfrCompile/VfrSyntax.g
V2: Update VfrCompiler to use member variable instead of global varable
to indicate whether current date type is Union.
This serie is the POC to update VfrCompiler to support Union type
in VarStore and construct the use cases in DriverSample.
Cc: Eric Dong
Cc: Liming Gao
Cc: Ruiyu Ni
Dandan Bi
Cc: Eric Dong
Cc: Liming Gao
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
.../Universal/DriverSampleDxe/DriverSample.c | 57 ++
.../Universal/DriverSampleDxe/DriverSample.h | 1 +
.../Universal/DriverSampleDx
Hi Ray,
I can update the logic in VfrCompiler to avoid using gUnionTypeStructure. New
patches will send out.
Thanks for your comments.
Regards,
Dandan
-Original Message-
From: Ni, Ruiyu
Sent: Monday, June 5, 2017 10:35 AM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Gao,
Dandan,
Can you avoid using gUnionTypeStructure?
Thanks/Ray
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Monday, June 5, 2017 10:13 AM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric ; Gao, Liming
> Subject: [edk2] [RFC
Cc: Eric Dong
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
BaseTools/Source/C/VfrCompile/VfrSyntax.g | 17 +
BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp | 13 -
BaseTools/Source/C/VfrCompile/VfrUtilityL
Cc: Eric Dong
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
.../Universal/DriverSampleDxe/DriverSample.c | 57 ++
.../Universal/DriverSampleDxe/DriverSample.h | 1 +
.../Universal/DriverSampleDxe/NVDataStruc.
This serie is the POC to update VfrCompiler to support Union type
in VarStore and construct the use cases in DriverSample.
Cc: Eric Dong
Cc: Liming Gao
Dandan Bi (2):
BaseTool/VfrCompile: Support Union type in VFR
MdeModulePkg/DriverSample: Add sample questions to refer union type
BaseTool
14 matches
Mail list logo
