Re: [edk2] [PATCH] MdePkg SmmMemLib: Remove ASSERT in SmmIsBufferOutsideSmmValid

2017-06-04 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Monday, June 5, 2017 12:51 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; Bret > Barkelew > Subject: [PATCH] MdePkg

[edk2] [PATCH] MdePkg SmmMemLib: Remove ASSERT in SmmIsBufferOutsideSmmValid

2017-06-04 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=577 Currently the SmmIsBufferOutsideSmmValid() function in SmmMemLib.c will ASSERT in certain conditions. Since this function is a "test" function, it should not be making decisions on how to handle a failure. Handling a failure should be left

[edk2] [RFC v2 1/2] BaseTool/VfrCompile: Support Union type in VFR

2017-06-04 Thread Dandan Bi
V2: Update VfrCompiler to use member variable instead of global varable to indicate whether current date type is Union. Cc: Eric Dong Cc: Liming Gao Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [RFC v2 0/2] Support Union type in VFR

2017-06-04 Thread Dandan Bi
V2: Update VfrCompiler to use member variable instead of global varable to indicate whether current date type is Union. This serie is the POC to update VfrCompiler to support Union type in VarStore and construct the use cases in DriverSample. Cc: Eric Dong Cc: Liming Gao

[edk2] [RFC v2 2/2] MdeModulePkg/DriverSample: Add sample questions to refer union type

2017-06-04 Thread Dandan Bi
Cc: Eric Dong Cc: Liming Gao Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Universal/DriverSampleDxe/DriverSample.c | 57 ++

Re: [edk2] [RFC 1/2] BaseTool/VfrCompile: Support Union type in VFR

2017-06-04 Thread Bi, Dandan
Hi Ray, I can update the logic in VfrCompiler to avoid using gUnionTypeStructure. New patches will send out. Thanks for your comments. Regards, Dandan -Original Message- From: Ni, Ruiyu Sent: Monday, June 5, 2017 10:35 AM To: Bi, Dandan ; edk2-devel@lists.01.org

Re: [edk2] [RFC 1/2] BaseTool/VfrCompile: Support Union type in VFR

2017-06-04 Thread Ni, Ruiyu
Dandan, Can you avoid using gUnionTypeStructure? Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Dandan Bi > Sent: Monday, June 5, 2017 10:13 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Gao, Liming

[edk2] [RFC 1/2] BaseTool/VfrCompile: Support Union type in VFR

2017-06-04 Thread Dandan Bi
Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- BaseTools/Source/C/VfrCompile/VfrSyntax.g | 17 +

[edk2] [RFC 2/2] MdeModulePkg/DriverSample: Add sample questions to refer union type

2017-06-04 Thread Dandan Bi
Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Universal/DriverSampleDxe/DriverSample.c | 57 ++

[edk2] [RFC 0/2] Support Union type in EFI/Buffer VarStore

2017-06-04 Thread Dandan Bi
This serie is the POC to update VfrCompiler to support Union type in VarStore and construct the use cases in DriverSample. Cc: Eric Dong Cc: Liming Gao Dandan Bi (2): BaseTool/VfrCompile: Support Union type in VFR MdeModulePkg/DriverSample: Add