Re: [edk2] IPv6 Stateless autoconfiguration

2017-06-29 Thread Ye, Ting
Hi Naveen, Yes, EDKII supports IPv6 stateless address autoconfiguration defined in RFC4862. It includes two parts: - generating link-local address - generating global address via stateless address autoconfiguration. The later part requires an IPv6 router to send Router Advertisement with valid

[edk2] IPv6 Stateless autoconfiguration

2017-06-29 Thread Santhapur Naveen
Hello all, I have some queries for which the answers are needed from the experts here. Please help in answering them. Does edk2 support IPv6 stateless address autoconfiguration as mentioned in RFC4862. If yes, then why do we have to configure the dhcpv6 service in such a way that it provides I

[edk2] How to add support to different reg offset definition to share the same driver code?

2017-06-29 Thread Jun Nie
Hi, I am trying to add support to different reg offset and bit offset in PL011 UART. It seems impossible to add macro in platform.dsc to enable undef/redef in the header file with "#ifdef ZX_PL011_FLAG". Is there any proper way to control the reg/bit offset definition? Or we have to adopt the Linu

Re: [edk2] [PATCH] BaseTools: suppress usage instructions with rebuild options

2017-06-29 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Thursday, June 29, 2017 3:10 PM To: edk2-devel@lists.01.org Cc: Ruffin, Chris ; Gao, Liming Subject: [edk2] [PATCH] BaseTo

[edk2] [PATCH v4] EmbeddedPkg/MmcDxe: Align the ExtCSD buffer

2017-06-29 Thread Jun Nie
ExtCSD structure may be read via DMA. So align it to page to avoid data corruption. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jun Nie --- EmbeddedPkg/Universal/MmcDxe/Mmc.h | 2 +- EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 19 ++---

Re: [edk2] [PATCH 3/3] MdeModulePkg/ResetSystem: Implement ResetNotification protocol

2017-06-29 Thread Ni, Ruiyu
I fully agree. Sorry I missed that part. I will update all of them before checking the code in. Regards, Ray >-Original Message- >From: Zeng, Star >Sent: Thursday, June 29, 2017 10:30 PM >To: Ni, Ruiyu ; edk2-devel@lists.01.org >Cc: Zeng, Star >Subject: RE: [PATCH 3/3] MdeModulePkg/Reset

Re: [edk2] [PATCH 2/2] OvmfPkg: update -D E1000_ENABLE from Intel PROEFI v.07 to BootUtil v.22

2017-06-29 Thread Wu, Jiaxin
After patch with "[PATCH 1/2] disable build-time relocation for DXEFV modules", I can pass the platform build, then HTTP boot feature has been verified. Tested-by: Wu Jiaxin Reviewed-by: Wu Jiaxin Thanks, Jiaxin > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Se

Re: [edk2] [PATCH] MdeModulePkg ResetSystem: Update the comments of ResetSystem()

2017-06-29 Thread Bi, Dandan
Star, thanks for detecting that. Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Thursday, June 29, 2017 10:45 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Bi, Dandan ; Zeng, Star Subject:

Re: [edk2] [PATCH 0/2] Correct the comments of PeiResetSystem2

2017-06-29 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng > Sent: Thursday, June 29, 2017 10:53 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: [edk2] [PATCH 0/2] Correct the comments of PeiResetSystem2

Re: [edk2] TCG2 Physical Presence Support in OVMF

2017-06-29 Thread Yao, Jiewen
HI Jason TCG2 PP support requires the presence of TPM2 hardware. Does OVMF support TPM2 hardware? If it supports, you can add code in BDS. You may refer to edk2\Vlv2TbltDevicePkg\Library\PlatformBdsLib\BdsPlatform.c. Thank you Yao Jiewen > -Original Message- > From: edk2-devel [mailto:

[edk2] Tianocore.org about to have new look

2017-06-29 Thread Jarlstrom, Laurie
We are about to change the look of the main Tianocore.org website Stay tuned and let us know how it looks thanks, Laurie laurie.jarlst...@intel.com Intel SSG/STO/EBP (503) 712-9395 ___ edk2-devel mailing list edk2-d

Re: [edk2] DisconnectController API not working.

2017-06-29 Thread TVKR
FYI, I tried an alternative method (below) but that didn't work either (the handle value matches correctly again) EFI_STATUS EFIAPI UefiMain ( IN EFI_HANDLEImageHandle, IN EFI_SYSTEM_TABLE *SystemTable ) { EFI_STATUS Status ; EFI_DEVICE_PATH_FROM_TEXT_PROTOCOL *EfiDevicePathFromT

Re: [edk2] [PATCH 1/5] OvmfPkg: introduce Q35TsegSizeLib (class header and sole lib instance)

2017-06-29 Thread Jordan Justen
On 2017-06-26 16:04:41, Laszlo Ersek wrote: > On 06/27/17 00:36, Jordan Justen wrote: > > > > Why can't SmramInternal.c read the size from the PCD directly? > > If I remember correctly, I wanted to base SmramAccessGetCapabilities() > directly on hardware configuration. At that point (regardless o

Re: [edk2] [staging/cadence-aarch64 PATCH v3 5/6] CadencePkg: Add ACPI tables for Cadence CSP platform.

2017-06-29 Thread Leif Lindholm
On Thu, Jun 22, 2017 at 10:32:00AM +0100, Scott Telford wrote: > Add ACPI tables for Cadence CSP platform configured with a single > Cortex-A53, GIC-500, Cadence UART and Cadence PCIe Root Complex. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Scott Telford Graeme

Re: [edk2] [staging/cadence-aarch64 PATCH v2 6/6] CadencePkg: Add .dsc, .fdf and .dec files for Cadence CSP platform.

2017-06-29 Thread Leif Lindholm
On Thu, Jun 22, 2017 at 09:26:47AM +, Scott Telford wrote: > > -Original Message- > > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > > Sent: 06 June 2017 12:37 > > To: Scott Telford > > Cc: edk2-de...@ml01.01.org; ard.biesheu...@linaro.org; > > graeme.greg...@linaro.org; af...

[edk2] TCG2 Physical Presence Support in OVMF

2017-06-29 Thread Jason Dickens
All, I'm working with a secure boot enabled OVMF build of EDK II and Xen and have questions about TCG2 support, both status in general and specific questions below. I'm trying to get the TCG Physical Presence protocol to work or at least understand more about why it can't in my case. Specif

Re: [edk2] [PATCH] EmbeddedPkg/MmcDxe: Correct argument of ECSD read

2017-06-29 Thread Leif Lindholm
On Thu, Jun 29, 2017 at 10:29:08PM +0800, Jun Nie wrote: > 2017-06-29 20:09 GMT+08:00 Leif Lindholm : > > On Thu, Jun 29, 2017 at 05:02:05PM +0800, Jun Nie wrote: > >> The argument of CMD8 should be stuff bits according to standard > >> JESD84-A44. > > > > OK, I realise that "stuff bits" is a term

[edk2] [PATCH 1/2] MdePkg: Correct the comments of EFI_PEI_RESET2_SYSTEM

2017-06-29 Thread Star Zeng
Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- MdePkg/Include/Pi/PiPeiCis.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdePkg/Include/Pi/PiPeiCis.h b/MdePkg/Include/Pi/PiPeiCis.h index 7cd525512f3d..92d6f0641ede 10

[edk2] [PATCH 2/2] MdeModulePkg PeiCore: Correct the comments of PeiResetSystem2

2017-06-29 Thread Star Zeng
Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- MdeModulePkg/Core/Pei/PeiMain.h | 4 ++-- MdeModulePkg/Core/Pei/Reset/Reset.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/MdeModulePkg/Core/Pei/PeiMain.h b/MdeModu

[edk2] [PATCH 0/2] Correct the comments of PeiResetSystem2

2017-06-29 Thread Star Zeng
Star Zeng (2): MdePkg: Correct the comments of EFI_PEI_RESET2_SYSTEM MdeModulePkg PeiCore: Correct the comments of PeiResetSystem2 MdeModulePkg/Core/Pei/PeiMain.h | 4 ++-- MdeModulePkg/Core/Pei/Reset/Reset.c | 4 ++-- MdePkg/Include/Pi/PiPeiCis.h| 4 ++-- 3 files changed, 6 inser

[edk2] [PATCH] MdeModulePkg ResetSystem: Update the comments of ResetSystem()

2017-06-29 Thread Star Zeng
Update the comments of ResetSystem() that was missed by 37078045d717 and 28426918f0ea. Cc: Ruiyu Ni Cc: Dandan Bi Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c | 3 +++ MdeModulePkg/Universal/Res

Re: [edk2] [PATCH] EmbeddedPkg/MmcDxe: Align the ExtCSD buffer

2017-06-29 Thread Jun Nie
2017-06-29 19:11 GMT+08:00 Leif Lindholm : > On Thu, Jun 29, 2017 at 05:03:50PM +0800, Jun Nie wrote: >> ExtCSD structure may be read via DMA. So align it to >> page to avoid data corruption. > > So, this is possibly a valid thing to do, but this is not what you > said in the last version. The last

Re: [edk2] [PATCH 3/3] MdeModulePkg/ResetSystem: Implement ResetNotification protocol

2017-06-29 Thread Zeng, Star
How about to also update the description in ResetSystemRuntimeDxe.inf/ResetSystem.c/ResetSystemRuntimeDxe.uni? :) For example in *.inf: # This driver implements Reset Architectural Protocol. -> # This driver implements Reset Architectural and Notification Protocol. With that update, Reviewed-by:

Re: [edk2] [PATCH] EmbeddedPkg/MmcDxe: Correct argument of ECSD read

2017-06-29 Thread Jun Nie
2017-06-29 20:09 GMT+08:00 Leif Lindholm : > On Thu, Jun 29, 2017 at 05:02:05PM +0800, Jun Nie wrote: >> The argument of CMD8 should be stuff bits according to standard >> JESD84-A44. > > OK, I realise that "stuff bits" is a term used by the spec, so that is > probably sufficient explanation even t

Re: [edk2] [PATCH 2/3] MdeModulePkg/ResetSystem: Remove unnecessary global variable

2017-06-29 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Thursday, June 29, 2017 4:32 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [edk2] [PATCH 2/3] MdeModulePkg/ResetSystem: Remove unnecessary global vari

Re: [edk2] [PATCH 1/3] MdePkg: Add ResetNotification protocol definition

2017-06-29 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Thursday, June 29, 2017 4:32 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [PATCH 1/3] MdePkg: Add ResetNotification protocol definition Contr

Re: [edk2] [PATCH] EmbeddedPkg/MmcDxe: Correct argument of ECSD read

2017-06-29 Thread Leif Lindholm
On Thu, Jun 29, 2017 at 05:02:05PM +0800, Jun Nie wrote: > The argument of CMD8 should be stuff bits according to standard > JESD84-A44. OK, I realise that "stuff bits" is a term used by the spec, so that is probably sufficient explanation even though the term was known to me. And the MdeModulePkg

Re: [edk2] UEFI ABI calling convention details

2017-06-29 Thread Rafael Machado
Thanks a lot Marvin!! Em qua, 28 de jun de 2017 às 12:02, Marvin H?user < marvin.haeu...@outlook.com> escreveu: > Hey Rafael, > > The UEFI calling conventions are detailed in the UEFI specification, more > specifically section 2.3 of the UEFI 2.7 specification. > > Regards, > Marvin. > > > -O

Re: [edk2] [PATCH 3/3] MdeModulePkg/XhciDxe: Check timeout URB again after stopping endpoint

2017-06-29 Thread Wu, Hao A
The function XhcDequeueTrbFromEndpoint() will return EFI_ALREADY_STARTED to indicate that a 'timeout-detected' Urb finishes just before stopping the relating endpoint. So in this case, I think the caller of XhcDequeueTrbFromEndpoint() may not treat it as an error. If so, the error handling logic i

Re: [edk2] [PATCH] EmbeddedPkg/MmcDxe: Align the ExtCSD buffer

2017-06-29 Thread Leif Lindholm
On Thu, Jun 29, 2017 at 05:03:50PM +0800, Jun Nie wrote: > ExtCSD structure may be read via DMA. So align it to > page to avoid data corruption. So, this is possibly a valid thing to do, but this is not what you said in the last version. The last version said you needed 64-bit alignment, and this

[edk2] [PATCH] EmbeddedPkg/MmcDxe: Align the ExtCSD buffer

2017-06-29 Thread Jun Nie
ExtCSD structure may be read via DMA. So align it to page to avoid data corruption. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jun Nie --- EmbeddedPkg/Universal/MmcDxe/Mmc.h | 2 +- EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 11 --- 2 fi

[edk2] [PATCH] EmbeddedPkg/MmcDxe: Correct argument of ECSD read

2017-06-29 Thread Jun Nie
The argument of CMD8 should be stuff bits according to standard JESD84-A44. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jun Nie --- EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/EmbeddedPkg/Universa

Re: [edk2] [PATCH v5 01/10] BaseTools/GenFfs: add FFS file types for MM modules.

2017-06-29 Thread Gao, Liming
Supreeth: The patches are good to me. Reviewed-by: Liming Gao >-Original Message- >From: Supreeth Venkatesh [mailto:supreeth.venkat...@arm.com] >Sent: Tuesday, June 27, 2017 12:48 AM >To: edk2-devel@lists.01.org >Cc: leif.lindh...@linaro.org; Kinney, Michael D >; Gao, Liming ; >achin.gu

Re: [edk2] [PATCH 2/3] MdeModulePkg/XhciDxe: Dump the CMD/EVENT/INT/BULK ring information

2017-06-29 Thread Wu, Hao A
Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu > Ni > Sent: Wednesday, June 28, 2017 6:40 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A; Tian, Feng; Zeng, Star > Subject: [edk2] [PATCH 2/3]

Re: [edk2] [PATCH 1/3] MdeModulePkg/XhciDxe: Refine IsTransferRingTrb and IsAsyncIntTrb

2017-06-29 Thread Wu, Hao A
Comments are made below. Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu > Ni > Sent: Wednesday, June 28, 2017 6:40 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A; Tian, Feng; Zeng, Star > Subject: [edk2] [PATCH 1

[edk2] [PATCH 0/3] MdeModulePkg/ResetSystem: Implement ResetNotification protocol

2017-06-29 Thread Ruiyu Ni
Ruiyu Ni (3): MdePkg: Add ResetNotification protocol definition MdeModulePkg/ResetSystem: Remove unnecessary global variable MdeModulePkg/ResetSystem: Implement ResetNotification protocol .../Universal/ResetSystemRuntimeDxe/ResetSystem.c | 146 +++-- .../Universal/ResetSyst

[edk2] [PATCH 3/3] MdeModulePkg/ResetSystem: Implement ResetNotification protocol

2017-06-29 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Star Zeng --- .../Universal/ResetSystemRuntimeDxe/ResetSystem.c | 137 - .../Universal/ResetSystemRuntimeDxe/ResetSystem.h | 21 +++- .../ResetSystemRuntimeDxe.inf |

[edk2] [PATCH 1/3] MdePkg: Add ResetNotification protocol definition

2017-06-29 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Liming Gao --- MdePkg/Include/Protocol/ResetNotification.h | 86 + MdePkg/MdePkg.dec | 3 + 2 files changed, 89 insertions(+) create mode 100644 MdePkg/Incl

[edk2] [PATCH 2/3] MdeModulePkg/ResetSystem: Remove unnecessary global variable

2017-06-29 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Star Zeng --- MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c

[edk2] [PATCH] BaseTools: suppress usage instructions with rebuild options

2017-06-29 Thread Yonghong Zhu
From: Chris Ruffin When using edksetup.bat Rebuild, the script outputs usage instructions to the console, when no usage error is encountered. Update the usage instructions and suppress these usage instructions when using the Rebuild, ForceRebuild options. Change-Id: Ica98e19f3d5198df2519106e4c5