[edk2] [PATCH] MdeModulePkg SmmLockBoxDxeLib: Get SmmCommRegion for COMM buffer

2017-07-20 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=593 Currently, SmmCommunciate fails in RestoreLockBox after SmmReadyToLock since COMM buffer is in stack instead of using SmmCommRegion by gEdkiiPiSmmCommunicationRegionTableGuid. This patch is to get SmmCommRegion by gEdkiiPiSmmCommunicationReg

[edk2] [PATCH] QuarkSocPkg/QNCSmmDispatcher: Fix use after free issue #2

2017-07-20 Thread Marvin Häuser
As part of commit 5f82e02, ActiveRecordInDb was introduced as a copy of RecordInDb as latter may be freed by the callback function. This commit replaces an access of RecordInDb after the callback function has been executed with an access to ActiveRecordInDb. Contributed-under: TianoCore Contributi

[edk2] [patch 1/3] MdeModulePkg/SetupBrowser: Record the reset status in all SendForm

2017-07-20 Thread Dandan Bi
After calling SendForm to enter front page, configuration change in some driver may require system reset. Currently the reset status is saved in SendForm level. Then SendForm can return the reset status. IsResetRequired API also can return the reset status before exiting browser. It return the rese

[edk2] [patch 3/3] MdeModulePkg/BMMUiLib: Check reset requirement before exiting UiApp

2017-07-20 Thread Dandan Bi
In UI page, some configuration change may require system reset. BootMaintenanceManagerUiLib misses this check before exiting UiApp to boot other boot options. Now add the check. Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- ..

[edk2] [patch 2/3] MdeModulePkg/BMUiLib: Check reset requirement before exiting UiApp

2017-07-20 Thread Dandan Bi
In UI page, some configuration change may require system reset. BootManagerUiLib misses this check before exiting UiApp to boot other boot options. Now add the check. Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Library/B

[edk2] [patch 0/3] Check reset requirement before exiting UiApp

2017-07-20 Thread Dandan Bi
Patch 1 enahce the IsResetRequired API to return to reset info in system level. Patch 2 Check reset requirement before exiting UiApp (thorugh boot option) Patch 2 Check reset requirement before exiting UiApp (trough boot from file). Cc: Eric Dong Cc: Liming Gao Dandan Bi (3): MdeModulePkg/Setu

[edk2] DHCP Option 61 support

2017-07-20 Thread Santhapur Naveen
Hello all, Does the edk2 support DHCP option 61? I can see some piece of code which makes use of this option in MdeModulePkg\Universal\Network\Dhcp4DxeDhcp4Io.c But I also have found an article https://www.intel.com/content/www/us/en/support/software/manageability-products/07129.html in con

Re: [edk2] [Patch V3 7/8] edk2: Move License.txt file to root

2017-07-20 Thread Kinney, Michael D
Jordan, Thanks for the review. I think the multiple license topic may need more discussion. Is the file organization you recommend documented somewhere? Do you have a link? If a project uses a git submodule, is the license from the submodule added to the parent project? For example, see OpenSS

Re: [edk2] [Patch V3 1/8] BaseTools/PatchCheck: Support Contribution Agreement 1.1

2017-07-20 Thread Jordan Justen
The changes look consistent with my conditional r-b: https://lists.01.org/pipermail/edk2-devel/2017-July/012413.html On 2017-07-19 22:44:04, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=628 > > Update PatchCheck.py to support either > "Contributed-under: TianoCore Con

Re: [edk2] [Patch V3 7/8] edk2: Move License.txt file to root

2017-07-20 Thread Jordan Justen
On 2017-07-20 08:09:52, Kinney, Michael D wrote: > Hi Jordan, > > Yes. The ECP change is on purpose to make ECP license > consistent with the majority of the edk2 content. Nice. For some reason I thought we couldn't make this change previously. You'll update the commit message to note the chang

Re: [edk2] Using NULL| style library linkable in EDK2

2017-07-20 Thread Tim Lewis
Mike -- Ok, I will enter it into Bugzilla later today. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney, Michael D Sent: Thursday, July 20, 2017 10:57 AM To: Tim Lewis ; edk2-devel@lists.01.org; Kinney, Michael D Subject: Re: [edk2]

Re: [edk2] Using NULL| style library linkable in EDK2

2017-07-20 Thread Kinney, Michael D
Hi Tim, You are correct. The use of NULL lib class in [LibrrayClass] section appears to have been functional since at least 2010 when it was added to the BeagleBoardPkg.dsc file. https://github.com/tianocore/edk2/commit/a957d4a7810e3bf1c95e9bb30d83271e407093a0 Though this specific use case is f

Re: [edk2] Creating Event in an EventGroup that has already been signaled

2017-07-20 Thread Andrew Fish
> On Jul 20, 2017, at 9:35 AM, Tomas Pilar (tpilar) > wrote: > > What would be the state of that event post creation. Would it be immediately > signalled and the notify function queued? Or would the EventGroup have to be > signaled a second time for this new event to also become signaled? >

[edk2] Creating Event in an EventGroup that has already been signaled

2017-07-20 Thread Tomas Pilar (tpilar)
What would be the state of that event post creation. Would it be immediately signalled and the notify function queued? Or would the EventGroup have to be signaled a second time for this new event to also become signaled? Cheers, Tom ___ edk2-devel ma

[edk2] Using NULL| style library linkable in EDK2

2017-07-20 Thread Tim Lewis
Per the DSC specification (section 2.7), it is not legal to use a NULL| in the LIbraryClasses section. The reserved library class keyword, NULL is not permitted in any of the [LibraryClasses] sections. The NULL Library class keyword is only permitted within the [Components] section's INF file s

Re: [edk2] [staging/cadence-aarch64 PATCH v4 6/6] CadencePkg: Add .dsc, .fdf and .dec files for Cadence CSP platform.

2017-07-20 Thread Leif Lindholm
On Wed, Jul 19, 2017 at 05:06:21PM +0100, Scott Telford wrote: > Add .dsc, .fdf and .dec files for a Cadence CSP platform configured > with a single Cortex-A53, GIC-500, Cadence UART and Cadence PCIe Root > Complex. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Scott

Re: [edk2] [Patch V3 7/8] edk2: Move License.txt file to root

2017-07-20 Thread Kinney, Michael D
Hi Jordan, Yes. The ECP change is on purpose to make ECP license consistent with the majority of the edk2 content. The summary of all licenses used in all components has been added to Readme.md in the root of the edk2 repo, so any developer that looks at this repo know all the licenses in use w

[edk2] [PATCH 3/3] UefiCpuPkg PiSmmCommunicationSmm: Deprecate SMM Communication ACPI Table

2017-07-20 Thread Star Zeng
Follow UEFI 2.7 spec to deprecate SMM Communication ACPI Table, PiSmmCommunicationSmm will not install SMM Communication ACPI Table anymore. Cc: Jiewen Yao Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- .../PiSmmCommunication/PiSmmCommunicatio

[edk2] [PATCH 1/3] SecurityPkg OpalPasswordSupportLib: Remove include to UefiAcpiDataTable.h

2017-07-20 Thread Star Zeng
Remove redundant include to UefiAcpiDataTable.h as SmmCommunication.h will help to include it. Cc: Jiewen Yao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- SecurityPkg/Library/OpalPasswordSupportLib/OpalPasswordSupportNotify.h | 3 +-- 1 fil

[edk2] [PATCH 0/3] Follow UEFI 2.7 spec to deprecate SMM Communication ACPI Table

2017-07-20 Thread Star Zeng
Delete SMM Communication ACPI Table definition and update PiSmmCommunicationSmm to not install SMM Communication ACPI Table anymore. Star Zeng (3): SecurityPkg OpalPasswordSupportLib: Remove include to UefiAcpiDataTable.h MdePkg: Follow UEFI 2.7 spec to deprecate SMM Communication ACPI Tab

[edk2] [PATCH 2/3] MdePkg: Follow UEFI 2.7 spec to deprecate SMM Communication ACPI Table

2017-07-20 Thread Star Zeng
Delete PiSmmCommunicationAcpiTable.h and delete SMM Communication ACPI Table definition in UefiAcpiDataTable.h. As EFI_SMM_COMMUNICATE_HEADER is defined in both PI spec vol 4 and UEFI spec, move its definition to SmmCommunication.h. Cc: Jiewen Yao Cc: Liming Gao Contributed-under: TianoCore Cont

[edk2] Adding OpenSSL as the submodule of EDKII project...

2017-07-20 Thread Long, Qin
Hi, The Git submodule allows us to keep another Git repository in a subdirectory of main project. The Submodule repository has its own history, which does not interfere with the history of the current repository. This can be used to have external dependencies such as third party libraries. Aft