Re: [edk2] [PATCH] MdePkg/ResetNotification: Rename to UnregisterResetNotify

Reviewed-by: Liming Gao >-Original Message- >From: Ni, Ruiyu >Sent: Wednesday, July 19, 2017 5:15 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [PATCH] MdePkg/ResetNotification: Rename to >UnregisterResetNotify > >UEFI Spec uses

Re: [edk2] [PATCH v2][Patch 2/4] MdePkg/UefiDevicePathLib: Add DevPathFromTextDns and DevPathToTextDns libraries

Reviewed-by: Fu Siyuan -Original Message- From: Wu, Jiaxin Sent: Wednesday, July 26, 2017 11:41 AM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: [PATCH v2][Patch 2/4]

[edk2] [PATCH v2][Patch 2/4] MdePkg/UefiDevicePathLib: Add DevPathFromTextDns and DevPathToTextDns libraries

V2: * Add no IP instance case check. Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- .../Library/UefiDevicePathLib/DevicePathFromText.c | 80 ++

Re: [edk2] [PATCH] UefiCpuPkg/CpuCommonFeaturesLib: Fix the documentation of PpinSupport().

Reviewed-by: Jeff Fan Thanks! -Original Message- From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] Sent: Friday, July 21, 2017 6:20 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff Subject: [PATCH] UefiCpuPkg/CpuCommonFeaturesLib: Fix the documentation of

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Cast the return value of GetPageTableBase().

Reviewed-by: Jeff Fan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Marvin Häuser Sent: Friday, July 21, 2017 6:20 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff Subject: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Cast the

Re: [edk2] [Patch 2/4] MdePkg/UefiDevicePathLib: Add DevPathFromTextDns and DevPathToTextDns libraries

After talk with Siyuan, I agree with the update to handle Dns() case since the input is 0, not NULL of UefiDevicePathLibConvertTextToDeviceNode(). Thanks the comments! Jiaxin > -Original Message- > From: Wu, Jiaxin > Sent: Wednesday, July 26, 2017 10:29 AM > To: Fu, Siyuan

Re: [edk2] [PATCH] MdeModulePkg SmmLockBoxDxeLib: Get SmmCommRegion for COMM buffer

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Friday, July 21, 2017 2:40 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Baraneedharan Anbazhagan > Subject: [PATCH]

Re: [edk2] [PATCH 2/3] MdePkg: Follow UEFI 2.7 spec to deprecate SMM Communication ACPI Table

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Thursday, July 20, 2017 9:56 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; Gao, > Liming > Subject: [PATCH 2/3] MdePkg:

Re: [edk2] [PATCH 1/3] SecurityPkg OpalPasswordSupportLib: Remove include to UefiAcpiDataTable.h

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Thursday, July 20, 2017 9:56 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; Eric > Dong > Subject: [PATCH 1/3] SecurityPkg

Re: [edk2] [PATCH] UefiCpuPkg: Add BOOLEAN casts to return statements.

Marvin, Could you tell what VS version you are using? Jeff -Original Message- From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] Sent: Friday, July 21, 2017 6:20 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff Subject: [PATCH] UefiCpuPkg: Add BOOLEAN casts to return statements. Old

Re: [edk2] [Patch 2/4] MdePkg/UefiDevicePathLib: Add DevPathFromTextDns and DevPathToTextDns libraries

Siyuan, I mean the string of Dns() can't be input as param and the library is inner function of UefiDevicePathLibConvertTextToDeviceNode(). So, the error code for such string looks weird. Moreover, other libraries also don't have such check (e.g. DevPathFromTextIPv4/ DevPathFromTextVlan/...).

Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg LAPIC code.

Marvin, Could the following updating fix your issue? ApicBase = MsrValue & ~0xfff; Thanks! Jeff -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Marvin Häuser Sent: Tuesday, July 25, 2017 12:57 AM To: edk2-devel@lists.01.org Cc: Kinney, Michael

Re: [edk2] [Patch 2/4] MdePkg/UefiDevicePathLib: Add DevPathFromTextDns and DevPathToTextDns libraries

Jiaxin, If "Dns()" is not a valid test represent device path node, I think DevPathFromTextDns() should return an error code for this. Best Regards, Siyuan -Original Message- From: Wu, Jiaxin Sent: Wednesday, July 26, 2017 10:08 AM To: Fu, Siyuan ;

Re: [edk2] [Patch 2/4] MdePkg/UefiDevicePathLib: Add DevPathFromTextDns and DevPathToTextDns libraries

Hi Siyuan, For DevPathFromTextDns(), it's impossible to input the string with "Dns()". The input param is in pair of parentheses follow the given node name. For example, given the "Dns(192.168.10.12,192.168.10.16)" and NodeName "Dns", the param is "192.168.10.12,192.168.10.16". We can check

Re: [edk2] [Patch 0/3] Fix spelling typo in EFI_HTTP_STATUS_CODE

Reviewed-by: Fu Siyuan -Original Message- From: Wu, Jiaxin Sent: Tuesday, July 25, 2017 9:12 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: [Patch 0/3] Fix spelling typo

Re: [edk2] [Patch 0/2] Refine the coding style.

Reviewed-by: Fu Siyuan -Original Message- From: Wu, Jiaxin Sent: Tuesday, July 25, 2017 8:42 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: [Patch 0/2] Refine the coding

Re: [edk2] [PATCH v2 0/3] Check reset requirement before exiting UiApp

Reviewed-by: Liming Gao for this serial. >-Original Message- >From: Bi, Dandan >Sent: Friday, July 21, 2017 4:56 PM >To: edk2-devel@lists.01.org >Cc: Dong, Eric ; Gao, Liming >Subject: [PATCH v2 0/3] Check reset

Re: [edk2] [Patch] MdeModulePkg: Update NonDiscoverableDeviceRegistrationLib file header format

Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Tuesday, July 11, 2017 11:32 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] MdeModulePkg: Update

Re: [edk2] [Patch] BaseTools: Fix the bug that warn() function with only 1 argument

Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Tuesday, July 25, 2017 1:39 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [Patch] BaseTools: Fix the bug that warn() function with only 1 >argument > >In the

Re: [edk2] [Patch] BaseTools: add some comment for .PrebuildEnv file's usage

Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Tuesday, July 25, 2017 1:58 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [Patch] BaseTools: add some comment for .PrebuildEnv file's usage > >This patch add

Re: [edk2] [Patch 2/4] MdePkg/UefiDevicePathLib: Add DevPathFromTextDns and DevPathToTextDns libraries

Hi, Jiaxin Is an empty DNS text node a valid representation, like "Dns()"? Can below code handle such kind of input string? + DeviceNodeStr= TextDeviceNode; + DnsServerIpCount = 0; + while (DeviceNodeStr != NULL) { +GetNextParamStr (); +DnsServerIpCount ++; + } Best Regards,

Re: [edk2] [PATCH 1/1] OvmfPkg/PlatformPei: support >=1TB high RAM, and discontiguous high RAM

On 2017-07-10 20:22:31, Laszlo Ersek wrote: > +STATIC > +EFI_STATUS > +E820HighRamIterate ( > + IN E820_HIGH_RAM_ENTRY_CALLBACK Callback, > + IN OUT VOID *Context > + ) I think a simpler option would be: STATIC EFI_STATUS ScanOrAddE820HighRam ( IN

Re: [edk2] [RFC v1 0/3] Add VIRTIO_F_IOMMU_PLATFORM support

Hi Laszlo, On 07/25/2017 01:17 PM, Laszlo Ersek wrote: Adding Ard On 07/20/17 00:09, Brijesh Singh wrote: I have found that OVMF fails to detect the disk when iommu_platform is set from qemu cli. The failure occurs during the feature bit negotiation. Recently, EDKII introduced IOMMU protocol

Re: [edk2] [PATCH 0/1] OvmfPkg/PlatformPei: support >=1TB high RAM, and discontiguous high RAM

Jordan, can you please ack this? Thanks Laszlo On 07/11/17 05:22, Laszlo Ersek wrote: > The commit message says it all. > > BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1468526 > Repo: https://github.com/lersek/edk2.git > Branch: highram1tb > > Cc: "Dr. David Alan Gilbert"

Re: [edk2] [RFC v1 0/3] Add VIRTIO_F_IOMMU_PLATFORM support

Adding Ard On 07/20/17 00:09, Brijesh Singh wrote: > I have found that OVMF fails to detect the disk when iommu_platform is set > from > qemu cli. The failure occurs during the feature bit negotiation. > > Recently, EDKII introduced IOMMU protocol d1fddc4533bf. SEV patch series > introduced >

Re: [edk2] [Patch v4 3/6] edk2: Update to TianoCore Contribution Agreement 1.1

Hi Jordan, I also considered changing CodeModule to Module. I will make that change. I like the idea of providing a chapter or section reference in a document patch when applicable. I will update the tianocore-docs wiki with that recommendation as well. Mike > -Original Message- >

Re: [edk2] [Patch v4 6/6] edk2: Add Readme.md to root of edk2 repository

Jordan, Yes. I can update Readme.md to provide single link to OvmfPkg/License.txt file. Mike > -Original Message- > From: Justen, Jordan L > Sent: Tuesday, July 25, 2017 10:26 AM > To: Kinney, Michael D ; edk2- > de...@lists.01.org > Cc: Leif Lindholm

Re: [edk2] [Patch v4 3/6] edk2: Update to TianoCore Contribution Agreement 1.1

On 2017-07-24 16:45:13, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=629 > > Update the TianoCore Contribution Agreement from Version 1.0 > to Version 1.1 to cover open source documentation associated > with the TianoCore project. > > Version 1.0 covers source code

Re: [edk2] [Patch v4 6/6] edk2: Add Readme.md to root of edk2 repository

On 2017-07-24 16:45:16, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=643 > > Add Readme.md with a brief description of the EDK II > open source project along with links to contribution > agreement, licenses, and resources. > > Cc: Leif Lindholm

[edk2] [staging/cadence-aarch64 PATCH] CadencePkg: switch to to generic ResetSystemRuntimeDxe

Change CadenceCspResetSystemLib to implement ResetSystemLib, consumed by MdeModulePkg/Universal/ResetSystemRuntimeDxe. Wire all reset variants to ResetCold, except for ResetShutdown and EnterS3WithImmediateWake, which return immediately. Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [Patch V4 0/6] Update to Tiano Contribution Agreement 1.1

Laszlo, If you look at patch V4 #6, you will see the Readme.md has been added that lists all the licenses in use. There are more than just the default BSD license and the 3 components in the OvmfPkg. I prefer the idea of using Readme.md to provide an clear inventory of the licenses in use in

Re: [edk2] [UEFI PI 1.6/EDK2] Missing decorators for EFI_PEI_GET_VARIABLE2.

I think there will be admin you can ask to guide you about the process. Thanks, Star -Original Message- From: Marvin H?user [mailto:marvin.haeu...@outlook.com] Sent: Tuesday, July 25, 2017 9:25 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: RE: [UEFI PI

Re: [edk2] [UEFI PI 1.6/EDK2] Missing decorators for EFI_PEI_GET_VARIABLE2.

Thank you very much! I will request a new member account soon (due to departure, my E-Mail account was deactivated and I had to delete my account). Is a 'Member' status enough to submit ECRs? Thanks, Marvin. > -Original Message- > From: Zeng, Star [mailto:star.z...@intel.com] > Sent:

Re: [edk2] [UEFI PI 1.6/EDK2] Missing decorators for EFI_PEI_GET_VARIABLE2.

ECR 1828: Add decorator 'OPTIONAL' for Attributes parameter of EFI_PEI_GET_VARIABLE2 has been submitted. Thanks, Star -Original Message- From: Zeng, Star Sent: Tuesday, July 25, 2017 5:46 PM To: Marvin H?user ; edk2-devel@lists.01.org Cc: Zeng, Star

[edk2] [Patch 0/3] Fix spelling typo in EFI_HTTP_STATUS_CODE

"HTTP_STATUS_300_MULTIPLE_CHIOCES" This should instead be: "HTTP_STATUS_300_MULTIPLE_CHOICES" Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin Jiaxin Wu (3): MdePkg/Http.h:

[edk2] [Patch 3/3] NetworkPkg/HttpBootDxe: Fix spelling typo in EFI_HTTP_STATUS_CODE

"HTTP_STATUS_300_MULTIPLE_CHIOCES" This should instead be: "HTTP_STATUS_300_MULTIPLE_CHOICES" Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin ---

[edk2] [Patch 2/3] MdeModulePkg/DxeHttpLib: Fix spelling typo in EFI_HTTP_STATUS_CODE

"HTTP_STATUS_300_MULTIPLE_CHIOCES" This should instead be: "HTTP_STATUS_300_MULTIPLE_CHOICES" Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin ---

[edk2] [Patch 1/3] MdePkg/Http.h: Fix spelling typo in EFI_HTTP_STATUS_CODE

"HTTP_STATUS_300_MULTIPLE_CHIOCES" This should instead be: "HTTP_STATUS_300_MULTIPLE_CHOICES" Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin ---

Re: [edk2] [Patch V4 0/6] Update to Tiano Contribution Agreement 1.1

On 07/25/17 01:45, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=628 > https://bugzilla.tianocore.org/show_bug.cgi?id=629 > https://bugzilla.tianocore.org/show_bug.cgi?id=642 > https://bugzilla.tianocore.org/show_bug.cgi?id=643 > > New in V4 > * Revert change to remove

[edk2] [Patch 0/2] Refine the coding style.

Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin Jiaxin Wu (2): MdePkg/Http.h: Refine the coding style. NetworkPkg/HttpDxe: Refine the coding style.

[edk2] [Patch 1/2] MdePkg/Http.h: Refine the coding style.

Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- MdePkg/Include/Protocol/Http.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[edk2] [Patch 2/2] NetworkPkg/HttpDxe: Refine the coding style.

Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- NetworkPkg/HttpDxe/HttpImpl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2] [Patch 3/4] MdeModulePkg/UefiBootManagerLib: Support DNS device path description

This patch is to update UEFI Boot manager to support DNS device path for HTTP(S) network boot. Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin ---

[edk2] [Patch 4/4] NetworkPkg/HttpBootDxe: Update device path node to include DNS information

Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- NetworkPkg/HttpBootDxe/HttpBootClient.c | 138 ++-- NetworkPkg/HttpBootDxe/HttpBootDxe.h|

[edk2] [Patch 1/4] MdePkg/DevicePath.h: Add DNS Device Path definition

This patch adds the DNS device path node definition. Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- MdePkg/Include/Protocol/DevicePath.h | 18 ++ 1 file

[edk2] [Patch 0/4] Add DNS device path node

The series patches implement the DNS device path node according the UEFI Spec 2.7, section 10.3.5.30. Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin Jiaxin Wu (4):

[edk2] [Patch 2/4] MdePkg/UefiDevicePathLib: Add DevPathFromTextDns and DevPathToTextDns libraries

Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- .../Library/UefiDevicePathLib/DevicePathFromText.c | 72 ++

Re: [edk2] [Patch V3 7/8] edk2: Move License.txt file to root

On 07/21/17 01:39, Kinney, Michael D wrote: > Jordan, > > Thanks for the review. > > I think the multiple license topic may need more discussion. > Is the file organization you recommend documented somewhere? > Do you have a link? If a project uses a git submodule, is > the license from the

[edk2] [PATCH 2/2] ShellPkg/ls: Display the file time in local time.

From: Li Huajing Signed-off-by: Li Huajing Reviewed-by: Ruiyu Ni --- ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c | 111 ++- 1 file changed, 110 insertions(+), 1 deletion(-) diff --git

[edk2] [PATCH 1/2] Nt32Pkg/WinNtSimpleFileSystemDxe: Change GetInfo() to get TimeZone.

From: Li Huajing Signed-off-by: Huajing Li Reviewed-by: Ruiyu Ni --- .../WinNtSimpleFileSystem.c| 78 +- 1 file changed, 32 insertions(+), 46 deletions(-) diff --git

[edk2] [PATCH 0/2] Change Shell command ls to display file time in local time.

Li Huajing (2): Nt32Pkg/WinNtSimpleFileSystemDxe: Change GetInfo() to get TimeZone. ShellPkg/ls: Display the file time in local time. .../WinNtSimpleFileSystem.c| 78 ++- ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c | 111 - 2

Re: [edk2] [UEFI PI 1.6/EDK2] Missing decorators for EFI_PEI_GET_VARIABLE2.

Sure, I will help do that. :) Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Marvin H?user Sent: Tuesday, July 25, 2017 5:43 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: Re: [edk2] [UEFI PI 1.6/EDK2]

Re: [edk2] [UEFI PI 1.6/EDK2] Missing decorators for EFI_PEI_GET_VARIABLE2.

Sorry, I remembered 'IN OUT' incorrectly then, you are correct. Only 'OPTIONAL' is lacking. Would be very kind of you if you could help submitting the ECR, I do not have an active account at this point. Thanks, Marvin. > -Original Message- > From: Zeng, Star

Re: [edk2] CorebootPayloadPkg: redirect UEFI Shell to serial

On 07/15/17 15:00, Piotr Król wrote: > 2. There are 2 minor typos like gUEfi instead of gUefi and entrhy > instead of entry, does it make sense to send patches for that ? In > various places I saw more typos like that. Typo corrections are welcome. > 4. I had to move some PCDs to

Re: [edk2] [UEFI PI 1.6/EDK2] Missing decorators for EFI_PEI_GET_VARIABLE2.

As I know submitting ECR needs log in as a member at http://www.uefi.org/memberslogin, I am not sure the whole process. If needed, I can help to submit the ECR. According to EDK2 coding style doc at

[edk2] [PATCH] Nt32Pkg: Add the ResetSystemLib in Nt32 Platform.

From: HuajingLi Signed-off-by: Huajing Li Reviewed-by: Ruiyu Ni --- Nt32Pkg/Library/ResetSystemLib/ResetSystemLib.c| 98 .../ResetSystemLib/ResetSystemLib.inf} | 27 ++--- Nt32Pkg/Nt32Pkg.dsc

Re: [edk2] [UEFI PI 1.6/EDK2] Missing decorators for EFI_PEI_GET_VARIABLE2.

Hey Star, Thanks for your comment! Sorry, I never submited such a report, could you please point me in the right direction? The only way of contact I found on the site of the UEFI Forum were Administration and Press, both don't sound like the right place to post to. Or Is 'Administration'

Re: [edk2] [UEFI PI 1.6/EDK2] Missing decorators for EFI_PEI_GET_VARIABLE2.

Marvin, I think you are right about the statement of decorator 'OPTIONAL', you can submit PI ECR, then it can be aligned with UEFI EFI_GET_VARIABLE. typedef EFI_STATUS (EFIAPI *EFI_GET_VARIABLE)( IN CHAR16 *VariableName, IN EFI_GUID

[edk2] [PATCH] ShellPkg/map: Recognize CDROM change

The patch adds logic to probe the media change for physical block devices. So that when media change happens, the BlockIo is re-installed again. It fixes the issue when CDROM is removed UEFI Shell still shows the BlockIo in the output of "map -r". Contributed-under: TianoCore Contribution

[edk2] Clarification needed for RouteTableSize of EFI_IP4_CONFIG2_INTERFACE_INFO

Hi, I found an inconsistency between UEFI specifcation (v2.7) and EDK2 source. The "RouteTableSize" defined in EFI_IP4_CONFIG2_INTERFACE_INFO is "Size of the following RouteTable , in bytes. May be zero". The related definition can be found in p.1693 of v2.7 specification. However, the edk2