PI has description said If an AP is enabled, then the implementation must
guarantee that a complete initialization sequence is performed on the AP,
so the AP is in a state that is compatible with an MP operating system.
Current implementation just set the AP to idle state when enable this AP
which
On 08/28/17 15:24, Laszlo Ersek wrote:
> Repo: https://github.com/lersek/edk2.git
> Branch: virtio_gpu_map
>
> This series brings IOMMU support to VirtioGpuDxe. The interesting part
> is patch#5.
>
> I formatted the patches with function context, for easier review.
>
> I regression-tested this se
> On Aug 29, 2017, at 1:39 PM, Laszlo Ersek wrote:
>
> On 08/29/17 20:51, Ard Biesheuvel wrote:
>> Hi,
>>
>> Some comments below.
>>
>> On 25 August 2017 at 09:57, Ruiyu Ni wrote:
>>> The patch adds two PciSegmentLib instances that consumes
>>> PciSegmentInfoLib to provide multiple segments P
On 08/29/17 16:02, Brijesh Singh wrote:
>
>
> On 08/28/2017 07:39 AM, Laszlo Ersek wrote:
>> There's a small window between
>>
>> - AllocFwCfgDmaAccessBuffer() mapping the new FW_CFG_DMA_ACCESS object
>> for
>> common buffer operation (i.e., decrypting it), and
>>
>> - InternalQemuFwCfgDmaByte
On 08/29/17 20:51, Ard Biesheuvel wrote:
> Hi,
>
> Some comments below.
>
> On 25 August 2017 at 09:57, Ruiyu Ni wrote:
>> The patch adds two PciSegmentLib instances that consumes
>> PciSegmentInfoLib to provide multiple segments PCI configuration
>> access.
>>
>> BasePciSegmentLibSegmentInfo in
On 29 August 2017 at 20:47, Leif Lindholm wrote:
> On Tue, Aug 29, 2017 at 05:42:22PM +0100, Ard Biesheuvel wrote:
>> We no longer need a resolution for UncachedMemoryAllocationLib so
>> remove it.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel
>
>
On Tue, Aug 29, 2017 at 05:42:22PM +0100, Ard Biesheuvel wrote:
> We no longer need a resolution for UncachedMemoryAllocationLib so
> remove it.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
For the series:
Reviewed-by: Leif Lindholm
> ---
> Plat
On 29 August 2017 at 20:26, Alan Ott wrote:
> On 08/29/2017 12:27 PM, Ard Biesheuvel wrote:
>>
>> Use the proposed BaseTools support for device tree compilation to
>> build the device tree binary from source at build time. Give it its
>> own .inf and a build rule so the tools take care of everythi
On 08/29/2017 12:27 PM, Ard Biesheuvel wrote:
Use the proposed BaseTools support for device tree compilation to
build the device tree binary from source at build time. Give it its
own .inf and a build rule so the tools take care of everything.
Contributed-under: TianoCore Contribution Agreement
Hi,
Some comments below.
On 25 August 2017 at 09:57, Ruiyu Ni wrote:
> The patch adds two PciSegmentLib instances that consumes
> PciSegmentInfoLib to provide multiple segments PCI configuration
> access.
>
> BasePciSegmentLibSegmentInfo instance is a BASE library.
> DxeRuntimePciSegmentLibSegme
On 29 August 2017 at 18:18, Laszlo Ersek wrote:
> On 08/29/17 15:36, Ard Biesheuvel wrote:
>> While modern AARCH64 server systems use ACPI for describing the platform
>> topology to the OS, ARM systems and AARCH64 outside of the server space
>> mostly use device tree binaries, which are compiled f
On 08/29/17 15:36, Ard Biesheuvel wrote:
> While modern AARCH64 server systems use ACPI for describing the platform
> topology to the OS, ARM systems and AARCH64 outside of the server space
> mostly use device tree binaries, which are compiled from device tree
> source files using the device tree c
Just a +1 for 4 separate PCDs.
Tim
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Johnson,
Brian (EXL - Eagan)
Sent: Tuesday, August 29, 2017 10:12 AM
To: Kinney, Michael D ; Yao, Jiewen
; Wang, Jian J ;
edk2-devel@lists.01.org
Subject: Re: [e
It makes no difference to me. But it sounds more flexible and less cumbersome
to use 4 PCDs. That way you don't have to define the meanings of individual
bits, in the code or in the .dec file. And you could use different PCD types
for the different PCDs, eg. FeatureFlag or FixedAtBuild for
P
On 29 August 2017 at 16:53, Marcin Wojtas wrote:
> 2017-08-29 17:48 GMT+02:00 Ard Biesheuvel :
>> On 29 August 2017 at 16:47, Marcin Wojtas wrote:
>>> 2017-08-29 17:46 GMT+02:00 Leif Lindholm :
On Fri, Aug 25, 2017 at 01:25:54PM +0100, Ard Biesheuvel wrote:
> Instead of hardcoding the no
On 29 August 2017 at 16:47, Ard Biesheuvel wrote:
> On 29 August 2017 at 16:44, Leif Lindholm wrote:
>> On Fri, Aug 25, 2017 at 01:10:09PM +0100, Ard Biesheuvel wrote:
>>> This series is a followup to 'ArmPkg/ArmDmaLib: remove dependency on
>>> UncachedMemoryAllocationLib' sent out yesterday, and
We no longer need a resolution for UncachedMemoryAllocationLib so
remove it.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Platform/Hisilicon/HiKey/HiKey.dsc | 2 --
1 file changed, 2 deletions(-)
diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc
b/Pla
No ARM platforms depend on UncachedMemoryAllocationLib anymore, so
remove the library class resolution for it.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 2 --
1 file changed, 2 deletions(-)
diff --git
On 08/29/17 10:17, Long Qin wrote:
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=680
>
> Adding ARM and AARCH64 to SUPPORTED_ARCHITECTURES in SecurityPkg.dsc
> to enable RngTest module build, since this is one platform-independent
> application.
>
> Cc: Chao Zhang
> Cc: Laszlo Ersek
> C
On 29 August 2017 at 16:47, Kinney, Michael D
wrote:
> Ard,
>
> If there is a concern about the size impact, we can add an extra
> Link step that uses --whole-archive to check for duplicate symbols,
> but the link step used to generate final image would not use
> --whole-archive.
>
If the size de
On 29 August 2017 at 16:02, Ard Biesheuvel wrote:
> On 29 August 2017 at 16:00, Leif Lindholm wrote:
>> On Thu, Aug 24, 2017 at 09:21:32PM +0100, Ard Biesheuvel wrote:
>>> Replace the open coded PCI 'emulation' with a simple call into
>>> the NonDiscoverable device registration library, and fix u
Use the proposed BaseTools support for device tree compilation to
build the device tree binary from source at build time. Give it its
own .inf and a build rule so the tools take care of everything.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Platform
Brian,
Do you prefer 4 new PCDs or one new PCD with a bitmask to enable
detection in different phases?
Mike
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On
> Behalf Of Johnson, Brian (EXL - Eagan)
> Sent: Tuesday, August 29, 2017 8:17 AM
> To: Yao, Jie
Ard,
I agree. Adding const would be an improvement too.
But I would prefer to not add a global variable at all.
When could this check ever evaluate to false? Compression has
been supported for a long time now.
It appears that a developer would have to modify
SourceLevelDebugPkg\Include\Transf
Hi Brijesh,
On 08/28/17 13:26, Brijesh Singh wrote:
> When device is behind the IOMMU, driver is require to pass the device
> address of virtio request, response and any memory referenced by those
> request/response to the bus master.
>
> The patch uses IOMMU-like member functions from VIRTIO_DEVI
2017-08-29 17:48 GMT+02:00 Ard Biesheuvel :
> On 29 August 2017 at 16:47, Marcin Wojtas wrote:
>> 2017-08-29 17:46 GMT+02:00 Leif Lindholm :
>>> On Fri, Aug 25, 2017 at 01:25:54PM +0100, Ard Biesheuvel wrote:
Instead of hardcoding the non-cache coherent nature of this device
by invoking
On 29 August 2017 at 16:47, Marcin Wojtas wrote:
> 2017-08-29 17:46 GMT+02:00 Leif Lindholm :
>> On Fri, Aug 25, 2017 at 01:25:54PM +0100, Ard Biesheuvel wrote:
>>> Instead of hardcoding the non-cache coherent nature of this device
>>> by invoking UncachedMemoryAllocationLib directly for allocatin
Ard,
If there is a concern about the size impact, we can add an extra
Link step that uses --whole-archive to check for duplicate symbols,
but the link step used to generate final image would not use
--whole-archive.
Mike
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@
2017-08-29 17:46 GMT+02:00 Leif Lindholm :
> On Fri, Aug 25, 2017 at 01:25:54PM +0100, Ard Biesheuvel wrote:
>> Instead of hardcoding the non-cache coherent nature of this device
>> by invoking UncachedMemoryAllocationLib directly for allocating
>> shared buffers, switch to DmaLib, which encapsulat
On 29 August 2017 at 16:44, Leif Lindholm wrote:
> On Fri, Aug 25, 2017 at 01:10:09PM +0100, Ard Biesheuvel wrote:
>> This series is a followup to 'ArmPkg/ArmDmaLib: remove dependency on
>> UncachedMemoryAllocationLib' sent out yesterday, and removes library
>> entirely.
>>
>> There are two reason
On Fri, Aug 25, 2017 at 01:25:54PM +0100, Ard Biesheuvel wrote:
> Instead of hardcoding the non-cache coherent nature of this device
> by invoking UncachedMemoryAllocationLib directly for allocating
> shared buffers, switch to DmaLib, which encapsulates this at a
> more abstract level. This allows
On Fri, Aug 25, 2017 at 01:10:09PM +0100, Ard Biesheuvel wrote:
> This series is a followup to 'ArmPkg/ArmDmaLib: remove dependency on
> UncachedMemoryAllocationLib' sent out yesterday, and removes library
> entirely.
>
> There are two reasons for this:
> - UncachedMemoryAllocationLib is often abu
On Tue, Aug 29, 2017 at 04:08:07PM +0100, Ard Biesheuvel wrote:
> This driver does not actually use UncachedMemoryAllocationLib anymore,
> so remove the bogus reference.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
> ---
Thank you for implementing this feature! It is very helpful for catching
pointer-related problems. We have used a similar scheme on our systems for
years, and caught several important bugs. Some comments:
* It's possible to implement similar protections in PEI (IA32) by modifying the
GDT de
This driver does not actually use UncachedMemoryAllocationLib anymore,
so remove the bogus reference.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.c | 1 -
Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.inf |
On 29 August 2017 at 16:00, Leif Lindholm wrote:
> On Thu, Aug 24, 2017 at 09:21:32PM +0100, Ard Biesheuvel wrote:
>> Replace the open coded PCI 'emulation' with a simple call into
>> the NonDiscoverable device registration library, and fix up all
>> platform .DSCs/FDFs accordingly.
>>
>> Contribu
On 29 August 2017 at 14:09, Hao Wu wrote:
> Since some static code checkers complain that comparing two macros will
> generate a constant result, this commit uses a global variable to
> reflect the revision information of the debug agent, rather than using a
> macro directly.
>
> Cc: Ruiyu Ni
> C
Hi,
I am trying to combine coreboot and UDK2017 for the Intel Apollo Lake CRB.
I have managed to successfully compile both source trees and stitched it
with the Intel FIT.exe. It boots Windows 10 and the EFI Shell successfully,
but I get the following EDK II progress code error via UART debug por
On Thu, Aug 24, 2017 at 09:21:32PM +0100, Ard Biesheuvel wrote:
> Replace the open coded PCI 'emulation' with a simple call into
> the NonDiscoverable device registration library, and fix up all
> platform .DSCs/FDFs accordingly.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed
Series.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu
> Ni
> Sent: Tuesday, August 29, 2017 1:11 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH 0/3] Update CWD and current mapping properly
> Import
On 08/28/2017 07:39 AM, Laszlo Ersek wrote:
There's a small window between
- AllocFwCfgDmaAccessBuffer() mapping the new FW_CFG_DMA_ACCESS object for
common buffer operation (i.e., decrypting it), and
- InternalQemuFwCfgDmaBytes() setting the fields of the object.
In this window, earlier
While modern AARCH64 server systems use ACPI for describing the platform
topology to the OS, ARM systems and AARCH64 outside of the server space
mostly use device tree binaries, which are compiled from device tree
source files using the device tree compiler.
Currently, such source files and binari
On 29 August 2017 at 08:41, Gao, Liming wrote:
> Ard:
> This is the compiler check option, not debug option. I suggest to add it
> for all configuration.
>
OK, fair enough.
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mail
Reviewed-by: Ruiyu Ni
-Original Message-
From: Wu, Hao A
Sent: Tuesday, August 29, 2017 9:09 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Ni, Ruiyu
Subject: [PATCH] SourceLevelDebugPkg/DebugAgentCommon: Use global variable for
revision
Since some static code checkers complain that c
Since some static code checkers complain that comparing two macros will
generate a constant result, this commit uses a global variable to
reflect the revision information of the debug agent, rather than using a
macro directly.
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
S
On 08/28/17 13:26, Brijesh Singh wrote:
> VirtioScsiDxe driver has been updated to use IOMMU-like member functions
> from VIRTIO_DEVICE_PROTOCOL to translate the system physical address to
> device address. We do not need to do anything special when
> VIRTIO_F_IOMMU_PLATFORM bit is present hence tr
On 08/28/17 13:26, Brijesh Singh wrote:
> When device is behind the IOMMU then driver need to pass the device
> address when programing the bus master. The patch uses VirtioRingMap() to
> map the VRING system physical address to device address.
>
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: To
Hi Ting,
Thanks for your reply. I got your point but my question(s) are
1) I agree that if I add two attempts for the same NIC, there will be a warning
popup. But my question is whether the second attempt also be tried for
connection if first attempt fails to connect?
2) Is it valid to add two a
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Wu, Hao A
> Sent: Tuesday, August 29, 2017 7:44 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Yao, Jiewen
> Subject: [PATCH] IntelSiliconPkg/PlatformVTdSample: Avoid using constant
> result
> 'if'
>
> In this sample dri
In this sample driver, if (0) {...} else {...} statements were used to
illustrate two different using scenarios.
This comment refines the coding style by substituting the 'if (0)'
statement with comments to select sample codes for different cases.
Cc: Jiewen Yao
Contributed-under: TianoCore Cont
On 29 August 2017 at 09:17, Long Qin wrote:
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=680
>
> Adding ARM and AARCH64 to SUPPORTED_ARCHITECTURES in SecurityPkg.dsc
> to enable RngTest module build, since this is one platform-independent
> application.
>
> Cc: Chao Zhang
> Cc: Laszlo Er
Hi Naveen,
For 1), if you configure two attempts with iSCSI Mode "Enabled", you will
receive an warning that you have configured two attempts using same NIC.
If you configure two attempts with iSCSI Mode "Enabled for MPIO", it is valid,
and if the first attempt failed, the second attempt will b
Hello Edk2 team,
We are trying to change the UART Baud rate dynamically from UEFI shell using
"sermode" command in our ARM64 based platform.
I see the code flow of sermode call as below :
ShellCommandRunSerMode() -> SerialSetAttributes() ->
SerialPortSetAttributes()
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=680
Adding ARM and AARCH64 to SUPPORTED_ARCHITECTURES in SecurityPkg.dsc
to enable RngTest module build, since this is one platform-independent
application.
Cc: Chao Zhang
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.
The patches fix several bugs that caused by not updating CWD
and current mapping properly.
Huajing Li (3):
ShellPkg: Rename gShellCurDir to gShellCurMapping
ShellPkg: Fix bug that fails to change CWD after "map -r".
ShellPkg: Update CWD and current mapping when commands return
ShellPkg/App
From: Huajing Li
Some commands may cause current directory or even current mapping
become invalid. For example, "MAP" after unplugging the USB thumb
key may cause current mapping "FS0:" disappear.
This patch updates the CWD and current mapping when commands return.
It also causes the command prom
From: Huajing Li
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Huajing Li
Reviewed-by: Ruiyu Ni
---
ShellPkg/Application/Shell/ShellProtocol.c | 8
ShellPkg/Include/Library/ShellCommandLib.h | 4 ++--
ShellPkg/Library/UefiShellC
From: Huajing Li
When "map -r" runs, the mapping list is re-created but
gShellCurMapping still points to the old mapping list which
is already destroyed.
The patch updates the gShellCurMapping to point to the correct
location in the new mapping list.
Contributed-under: TianoCore Contribution Agr
Ard:
This is the compiler check option, not debug option. I suggest to add it for
all configuration.
Thanks
Liming
>-Original Message-
>From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
>Sent: Tuesday, August 29, 2017 12:59 AM
>To: Gao, Liming
>Cc: Laszlo Ersek ; edk2-devel@lists
Reviewed-by: Eric Dong
-Original Message-
From: Bi, Dandan
Sent: Tuesday, August 29, 2017 2:45 PM
To: edk2-devel@lists.01.org
Cc: Dong, Eric ; Gao, Liming
Subject: [PATCH v2] MdeModulePkg/UefiHiiLib: Fix incorrect check for string
length
REF: https://bugzilla.tianocore.org/show_bug.cg
60 matches
Mail list logo
