[edk2] [platforms: PATCH v2 7/8] Marvell/Armada: Armada70x0Lib: Add support for 32-bit ARM

From: Ard Biesheuvel Add an ARM implementation of ArmPlatformHelper.S. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm --- Platform/Marvell/Armada/Library/Armada70x0Lib/ARM/ArmPlatformHelper.S | 77

[edk2] [platforms: PATCH v2 6/8] Marvell/Armada: Enable dynamic DRAM size detection

Instead of using hardcoded value in PcdSystemMemorySize PCD, obtain DRAM size directly from SoC registers, which are filled by firmware during early initialization stage. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/Marvell/Armada/Library/Arma

[edk2] [platforms: PATCH v2 4/8] Marvell/Armada: Add support from DRAM remapping

The Armada 70x0/80x0 DRAM controller allows a single window of DRAM to be remapped to another location in the physical address space. This allows us to free up some memory in the 32-bit addressable region for peripheral MMIO and PCI MMIO32 and CONFIG spaces. This patch adjusts memory blocks to the

[edk2] [platforms: PATCH v2 8/8] Marvell/Armada: Add 32-bit ARM support

From: Ard Biesheuvel Update the included components and library classes to make this platform build for 32-bit ARM. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm --- Platform/Marvell/Armada/Armada

[edk2] [platforms: PATCH v2 0/8] Armada 7k/8k - memory improvements

Hi, This is a second version of DRAM handling and other general improvements. Two patches were significantly reworked and as a result we support now not only overall size detection, but also remap parameters. This way we are immune to future remap changes done in the early firmware. All above with

[edk2] [platforms: PATCH v2 2/8] Marvell/Armada: Increase preallocated memory region size

From: Ard Biesheuvel In order to prevent fragmentation of the UEFI memory map, increase the sizes of the preallocated regions. Note that this does not increase the memory footprint of UEFI, it just modifies it allocation policy to keep similar region types together. Contributed-under: TianoCore

[edk2] [platforms: PATCH v2 5/8] Marvell/Armada: Add MemoryInitPeiLib that reserves secure region

From: Ard Biesheuvel The default MemoryInitPeiLib implementation insists on reserving the region occupied by our own FV, while this is not necessary at all (the compressed payload is uncompressed elsewhere, so the moment we enter DXE core, we don't care about the FV contents in memory) So clone

[edk2] [platforms: PATCH v2 1/8] Marvell/Armada: Implement EFI_RNG_PROTOCOL driver for EIP76 TRNG

From: Ard Biesheuvel Add an implementation of EFI_RNG_PROTOCOL so that the OS loader has access to entropy for KASLR and other purposes (i.e., seeding the OS's entropy pool very early on). Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Signed-off-by: Marci

[edk2] [platforms: PATCH v2 3/8] Marvell/Armada: Remove custom reset library residues

When switching to generic PSCI reset library, obsolete parts of previous custom reset library (PCDs, documentation) remained. Remove them. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm --- Platform/Marvell/Armada/Armada70x0.dsc

Re: [edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for AP initialization logic.

Hi Laszlo, I think I have clear about your raised issues for Ovmf platform. In this case, I think your platform not suit for this code change. How about I do below change based on the new code: - if (CpuMpData->CpuCount == 0) { TimedWaitForApFinish ( CpuMpData,

[edk2] 答复: [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for AP initialization logic.

Laszlo, I agree BZ#251 can not be closed if commit 0594ec417c89 does not work for OVMF. I will reopen it. Jeff 发件人: Laszlo Ersek 发送时间: 2017年10月25日 1:40 收件人: Dong, Eric; edk2-devel@lists.01.org 抄送: Ni, Ruiyu

[edk2] 答复: [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for AP initialization logic.

Johnson, For OVMF case, we knew the actual processor number. But for most real platform cases, we have no this knowledge on the first time sending broadcast INIT-SIPI-SIPI. Jeff 发件人: Brian J. Johnson 发送时间: 2017年10月25日 6:30 收件人: Laszlo Ersek

Re: [edk2] [RFC PATCH] ArmPkg: add driver to add distro installer HTTP boot options

Hi, Leif and Laszlo The HTTP restriction is actually not supported now. If server replies a HTTP redirect response, the current HTTP boot driver will only print new URL address on the screen then abort the HTTP boot. It won't attempt to download the image from the new address. BestRegards Fu S

Re: [edk2] [PATCH v3 0/6] Implement heap guard feature

Hi, Just a warm reminding. I didn't see any feedbacks on the v3 patch. If no more comments, I'll check in the patch soon. Thanks, Jian > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J > Wang > Sent: Monday, October 23, 2017 8:51 AM > To

Re: [edk2] [PATCH v2] MdeModulePkg/Variable/RuntimeDxe: delete & lock MOR in the absence of SMM

Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Tuesday, October 24, 2017 11:38 PM To: edk2-devel-01 Cc: Yao, Jiewen ; Dong, Eric ; Zeng, Star Subject: [edk2] [PATCH v2] MdeModulePkg/Variable/RuntimeDx

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

Hi Laszlo, Thanks for the feedback. I'd like to explain a bit more here first and will update the commit message later. The multiple RT_CODE entries issue was reported by LUV test suite from https://01.org/linux-uefi-validation You're right this issue is caused by my commit c1cab54ce57c, which t

[edk2] [PATCH] Shellpkg/editor: Fix a bug that may modifies Line[-1]

The original code as below intend to set the character before last column to CHAR_NULL. Line[(LastCol % (ARRAY_SIZE (Line) - 1)) - 1] = CHAR_NULL; But when LastCol % (ARRAY_SIZE (Line) - 1)) equals to 0, Line[-1] is modified. We should change to code as below: Line[(LastCol - 1) % (ARRAY_SIZE

Re: [edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for AP initialization logic.

On 10/24/2017 12:40 PM, Laszlo Ersek wrote: Hi Eric, On 10/24/17 17:23, Dong, Eric wrote: Laszlo, -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, October 24, 2017 6:16 PM To: Dong, Eric ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Paolo Bonzini Subject: R

Re: [edk2] Shell Non-conformity to the Spec

Ah, now I remember. It was about aliases and case sensitivity, not environment variables. Tim Sent from my Windows 10 phone From: Carsey, Jaben Sent: Tuesday, October 24, 2017 1:11 PM To: Tim Lewis; jim.dai...@dell.com; Ni, Ruiyu Cc: edk2-devel@lists.01.org Subject: Re: [edk2] Shell Non-conformi

Re: [edk2] Shell Non-conformity to the Spec

I don't remember. Is there a defect in the Bugzilla? > -Original Message- > From: Tim Lewis [mailto:tim.le...@insyde.com] > Sent: Tuesday, October 24, 2017 12:14 PM > To: Carsey, Jaben ; jim.dai...@dell.com; Ni, Ruiyu > > Cc: edk2-devel@lists.01.org > Subject: RE: [edk2] Shell Non-confor

Re: [edk2] Shell Non-conformity to the Spec

Jaben -- Wasn't there are previous e-mail thread about this? Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Carsey, Jaben Sent: Tuesday, October 24, 2017 11:29 AM To: jim.dai...@dell.com; Ni, Ruiyu Cc: edk2-devel@lists.01.org Subject: Re: [

Re: [edk2] Shell Non-conformity to the Spec

Yes. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > jim.dai...@dell.com > Sent: Tuesday, October 24, 2017 11:20 AM > To: Carsey, Jaben ; Ni, Ruiyu > Cc: edk2-devel@lists.01.org > Subject: [edk2] Shell Non-conformity to the Spec > Importance

[edk2] Shell Non-conformity to the Spec

The shell spec says that "Each environment variable has a case-sensitive name ...". In the EfiShellSetEnv function of ShellProtocol.c a case-insensitive compare is performed against the variable that is to be set to see if it is one of the read-only variables. That means one cannot set a variable

Re: [edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for AP initialization logic.

Hi Eric, On 10/24/17 17:23, Dong, Eric wrote: > Laszlo, > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Tuesday, October 24, 2017 6:16 PM >> To: Dong, Eric ; edk2-devel@lists.01.org >> Cc: Ni, Ruiyu ; Paolo Bonzini >> Subject: Re: [edk2] [Patch 2/2] UefiC

Re: [edk2] [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer

On Tue, Oct 24, 2017 at 06:23:11PM +0200, Laszlo Ersek wrote: > On 10/24/17 17:28, Dong, Eric wrote: > > Laszlo, > > > > Thanks for your willing to review all CPU changes. We also found Ovmf is a > > very special system and need to take it in to consideration when do the > > changes. > > > > Re

Re: [edk2] 答复: [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for AP initialization logic.

Hi Jeff, On 10/24/17 16:24, Fan Jeff wrote: > Laszlo, > > How about to skip the condition check on CpuCount? > - if (CpuMpData->CpuCount == 0) { > TimedWaitForApFinish ( > CpuMpData, > PcdGet32 (PcdCpuMaxLogicalProcessorNumber) - 1, > PcdGet32 (PcdCpuApInit

Re: [edk2] [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer

On 10/24/17 17:28, Dong, Eric wrote: > Laszlo, > > Thanks for your willing to review all CPU changes. We also found Ovmf is a > very special system and need to take it in to consideration when do the > changes. > > Reviewed-by: Eric Dong Thank you Eric! Can one (or more) of the Stewards ACK

Re: [edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for AP initialization logic.

Laszlo, Add more comments for TimedWaitForApFinish function in mail. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Dong, Eric > Sent: Tuesday, October 24, 2017 11:24 PM > To: Laszlo Ersek ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Paolo B

[edk2] [PATCH v2] MdeModulePkg/Variable/RuntimeDxe: delete & lock MOR in the absence of SMM

VariableRuntimeDxe deletes and locks the MorLock variable in MorLockInit(), with the argument that any protection provided by MorLock can be circumvented if MorLock can be overwritten by unprivileged code (i.e., outside of SMM). Extend the argument and the logic to the MOR variable, which is suppo

Re: [edk2] [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer

Laszlo, Thanks for your willing to review all CPU changes. We also found Ovmf is a very special system and need to take it in to consideration when do the changes. Reviewed-by: Eric Dong Thanks, Eric > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday,

Re: [edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for AP initialization logic.

Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, October 24, 2017 6:16 PM > To: Dong, Eric ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Paolo Bonzini > Subject: Re: [edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for > AP initialization

Re: [edk2] [RFC PATCH] ArmPkg: add driver to add distro installer HTTP boot options

On Tue, Oct 24, 2017 at 03:32:51PM +0200, Laszlo Ersek wrote: > > Convenience. And given that I only noticed yesterday that the boot > > fails on HTTP redirects, of somewhat restricted value. > > > > Is that an official policy decision, or just a restriction of the > > implementation? > > Hm, I'm

Re: [edk2] [PATCH] ShellPkg/HandleParsingLib: Remove unnecessary CatSPrint call

Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Monday, October 23, 2017 10:38 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: [PATCH] ShellPkg/HandleParsingLib: Remove unnecessary CatSPrint > call > Importance: High > > Contributed-under: TianoC

[edk2] 答复: [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for AP initialization logic.

Laszlo, How about to skip the condition check on CpuCount? - if (CpuMpData->CpuCount == 0) { TimedWaitForApFinish ( CpuMpData, PcdGet32 (PcdCpuMaxLogicalProcessorNumber) - 1, PcdGet32 (PcdCpuApInitTimeOutInMicroSeconds) ); - } For OVMF platfo

[edk2] [PATCH 0/2] IntelSiliconPkg: Add Pre-Memory DMA protection in PEI

This series patch adds Pre-Memory DMA protection in PEI. The purpose is to make sure when the system memory is initialized, the DMA protection takes effect immediately. The IntelVTdPmrPei driver is updated to remove the global variable and add VTD_INFO_PPI notification. The VTdInfoSample driver i

[edk2] [PATCH 1/2] IntelSiliconPkg/VtdPmrPei: Add premem support.

Remove memory discovered dependency to support both premem VTD_INFO_PPI and postmem VTD_INFO_PPI. If VTD_INFO_PPI is installed before memory is ready, this driver protects all memory region. If VTD_INFO_PPI is installed or reinstalled after memory is ready, this driver allocates DMA buffer and pro

[edk2] [PATCH 2/2] IntelSiliconPkg/VtdPeiSample: Add premem support.

Before memory is ready, this sample produces one VTd engine. After memory and silicon is initialized, this sample produces both IGD VTd engine and all-rest VTd engine by reinstall the FV_INFO_PPI. This update is to demonstrate how to support pre-mem VTd usage. Cc: Star Zeng Contributed-under: Ti

Re: [edk2] [RFC PATCH] ArmPkg: add driver to add distro installer HTTP boot options

On 10/24/17 14:36, Leif Lindholm wrote: > On Tue, Oct 24, 2017 at 02:10:44PM +0200, Laszlo Ersek wrote: >> On 10/21/17 15:10, Ard Biesheuvel wrote: >>> To make it easier for power users to provision a 'desktop' system [as >>> opposed to a VM or server] from scratch, introduce a driver that adds >>>

[edk2] [PATCH 2/2] IntelSiliconPkg/VtdPeiSample: Add premem support.

Before memory is ready, this sample produces one VTd engine. After memory and silicon is initialized, this sample produces both IGD VTd engine and all-rest VTd engine by reinstall the FV_INFO_PPI. This update is to demonstrate how to support pre-mem VTd usage. Cc: Zeng Star Contributed-under: Ti

[edk2] [PATCH 0/2] Add Pre-Memory DMA protection in PEI

This series patch adds Pre-Memory DMA protection in PEI. The purpose is to make sure when the system memory is initialized, the DMA protection takes effect immediately. The IntelVTdPmrPei driver is updated to remove the global variable and add VTD_INFO_PPI notification. The VTdInfoSample driver i

[edk2] [PATCH 1/2] IntelSiliconPkg/VtdPmrPei: Add premem support.

Remove memory discovered dependency to support both premem VTD_INFO_PPI and postmem VTD_INFO_PPI. If VTD_INFO_PPI is installed before memory is ready, this driver protects all memory region. If VTD_INFO_PPI is installed or reinstalled after memory is ready, this driver allocates DMA buffer and pro

Re: [edk2] [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer

Hi Steven, On 10/24/17 13:02, Shi, Steven wrote: > Hi Laszlo, > I happen hope to know how to well test the IOMMU/VT-D feature on OVMF. Can > you give me some hints? first of all, please let us not discuss questions that are unrelated to a patch under that patch. If you have a question about OVMF

Re: [edk2] [RFC PATCH] ArmPkg: add driver to add distro installer HTTP boot options

On Tue, Oct 24, 2017 at 02:10:44PM +0200, Laszlo Ersek wrote: > On 10/21/17 15:10, Ard Biesheuvel wrote: > > To make it easier for power users to provision a 'desktop' system [as > > opposed to a VM or server] from scratch, introduce a driver that adds > > boot options to the boot menu that can lau

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

On 10/23/17 08:50, Jian J Wang wrote: > More than one entry of RT_CODE memory might cause boot problem for some > old OSs. This patch will fix this issue to keep OS compatibility as much > as possible. > > Cc: Eric Dong > Cc: Jiewen Yao > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2] [RFC PATCH] ArmPkg: add driver to add distro installer HTTP boot options

On 10/21/17 15:10, Ard Biesheuvel wrote: > To make it easier for power users to provision a 'desktop' system [as > opposed to a VM or server] from scratch, introduce a driver that adds > boot options to the boot menu that can launch network installers over > HTTP straight off the Internet. > > Cur

Re: [edk2] [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer

Hi Laszlo, I happen hope to know how to well test the IOMMU/VT-D feature on OVMF. Can you give me some hints? Steven Shi Intel\SSG\STO\UEFI Firmware Tel: +86 021-61166522 iNet: 821-6522 > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Lasz

[edk2] [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer

UefiCpuPkg hosts a number of modules (SMM infrastructure, MP-initialization) that may behave differently enough between virtualization guests and physical boards that they merit regression testing and review specifically from a virtualization perspective. Add Laszlo as a UefiCpuPkg reviewer (not m

Re: [edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for AP initialization logic.

CC Paolo On 10/23/17 09:22, Eric Dong wrote: > Current logic always waiting for a specific value to collect all APs > count. This logic may caused some platforms cost too much time to > wait for time out. > This patch add new logic to collect APs count. It adds new variable > NumApsExecuting to de

Re: [edk2] [Patch] UefiCpuPkg/S3Resume2Pei: Handle Communicate Ppi not exist issue.

// // Attempt to use content from SMRAM first // GuidHob = GetFirstGuidHob (&gEfiAcpiVariableGuid); if (GuidHob != NULL) { The code may could use this condition above to skip SignalEndOfS3Resume(). We can see two places already in S3Resume.c. Thanks, Star -Original Message- Fro

Re: [edk2] [PATCH v1 1/1] CryptoPkg/BaseCryptLib: remove some duplicate initializations.

The patch was already push @b5a985ca9237b551618cd97b1b71af2fff55e209 I forgot to inform that. Thanks, Laszlo. Best Regards & Thanks, LONG, Qin -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Tuesday, October 24, 2017 3:51 PM

Re: [edk2] [PATCH v1 1/1] CryptoPkg/BaseCryptLib: remove some duplicate initializations.

Qin, On 10/23/17 05:02, Long, Qin wrote: > This looks good to me. > Reviewed-by: Long Qin qin.l...@intel.com Do you want me to push the patch, or do you prefer to push it yourself? Thanks! Laszlo > From: Peter Jones [mailto:pjo...@redhat.com] > Sent: Saturday, October

[edk2] 答复: [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for AP initialization logic.

Sure. Done. 发件人: Ni, Ruiyu 发送时间: 2017年10月24日 15:18 收件人: Fan Jeff; Dong, Eric; edk2-devel@lists.01.org 主题: RE: [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for AP initializa

[edk2] 答复: [Patch 0/2] Enhance collect AP Count logic

Reviewed-by: Jeff Fan 发件人: Eric Dong 发送时间: 2017年10月23日 15:22 收件人: edk2-devel@lists.01.org 主题: [edk2] [Patch 0/2] Enhance collect AP Count logic Current logic always waiting for a specific value to collect all APs count. This logic may c

Re: [edk2] [Patch 0/2] Add IPv6 support condition check for HTTP/ISCSI.

Reviewed-by: Karunakar p Thanks, Karunakar -Original Message- From: Wu, Jiaxin [mailto:jiaxin...@intel.com] Sent: Tuesday, October 24, 2017 12:50 PM To: Karunakar P; edk2-devel@lists.01.org Cc: Ye, Ting; Fu, Siyuan Subject: RE: [edk2] [Patch 0/2] Add IPv6 support condition check for HTT

Re: [edk2] [Patch 0/2] Add IPv6 support condition check for HTTP/ISCSI.

Hi Karunakar, If you have no more comments, can you reply the below series patches with Reviewed-by/Tested-By tags, then I can go on the commit process? [Patch v3 0/3] NetworkPkg/IScsiDxe: Display InitiatorInfo correctly. NetworkPkg/IScsiDxe: Fix the incorrect/needless DHCP process.

Re: [edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for AP initialization logic.

Jeff, I see. Thanks for mentioning that😊 Reviewed-by: Ruiyu Ni Do you mind to also give a r-b? Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Fan Jeff > Sent: Tuesday, October 24, 2017 2:27 PM > To: Ni, Ruiyu ; Dong, Eric ; e

Re: [edk2] [Patch 0/2] Add IPv6 support condition check for HTTP/ISCSI.

Hi Jiaxin, Yes, I believe this issue(#) is not the regression for previous issues we have fixed. I created a new bug For #3 and below are the details https://bugzilla.tianocore.org/show_bug.cgi?id=743 Could you please let me know the scheduled check in date for previously reported issue/Featu