Re: [edk2] [Patch] ShellPkg: Add error message if failed to place receive token in ping command.

2017-11-14 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Fu, Siyuan Sent: Wednesday, November 15, 2017 12:10 PM To: edk2-devel@lists.01.org Cc: Wu, Jiaxin ; Ye, Ting ; Ni, Ruiyu Subject: [Patch] ShellPkg: Add error

Re: [edk2] [Patch] MdeModulePkg/SNP: remove redundant DEBUG print in SNP Transmit.c

2017-11-14 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Fu, Siyuan Sent: Wednesday, November 15, 2017 11:15 AM To: edk2-devel@lists.01.org Cc: Wu, Jiaxin ; Ye, Ting Subject: [Patch] MdeModulePkg/SNP: remove redundant DEBUG print in SNP

Re: [edk2] [PATCH v5] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-11-14 Thread Zeng, Star
How about the code to filter out paging capabilities from UEFI memory map in Page.c CoreGetMemoryMap(), then with maximum compatibility, the UEFI memory map could be same with before 14dde9e903bb9a719ebb8f3381da72b19509bc36 [MdeModulePkg/Core: Fix out-of-sync issue in GCD]. Thanks, Star

Re: [edk2] [Patch] ShellPkg: Add error message if failed to place receive token in ping command.

2017-11-14 Thread Wu, Jiaxin
Reviewed-by: Wu Jiaxin > -Original Message- > From: Fu, Siyuan > Sent: Wednesday, November 15, 2017 12:10 PM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin ; Ye, Ting ; Ni, > Ruiyu > Subject: [Patch]

Re: [edk2] [Patch V2] NetworkPkg: Print error message to screen if error occurs during HTTP boot.

2017-11-14 Thread Wu, Jiaxin
Reviewed-by: Wu Jiaxin > -Original Message- > From: Fu, Siyuan > Sent: Wednesday, November 15, 2017 9:52 AM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin ; Ye, Ting > Subject: [Patch V2] NetworkPkg: Print error message to

Re: [edk2] [Patch] NetworkPkg: Fix incorrect SizeofHeaders returned from HttpTcpReceiveHeader().

2017-11-14 Thread Wu, Jiaxin
Reviewed-by: Wu Jiaxin > -Original Message- > From: Fu, Siyuan > Sent: Wednesday, November 15, 2017 10:45 AM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin ; Ye, Ting ; > Karunakar P > Subject:

Re: [edk2] [Patch] MdeModulePkg/SNP: remove redundant DEBUG print in SNP Transmit.c

2017-11-14 Thread Wu, Jiaxin
Reviewed-by: Wu Jiaxin > -Original Message- > From: Fu, Siyuan > Sent: Wednesday, November 15, 2017 11:15 AM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin ; Ye, Ting > Subject: [Patch] MdeModulePkg/SNP: remove redundant

Re: [edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] BensonGlacier: Enable generic SPI device

2017-11-14 Thread Wei, David
Reviewed-by: zwei4 Thanks, David Wei Intel SSG/STO/UEFI BIOS > -Original Message- > From: Rytkonen, Teemu S > Sent: Wednesday, November 15, 2017 1:16 AM > To: edk2-devel@lists.01.org > Cc: Ryu, Misun ;

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] SueCreek Bypass

2017-11-14 Thread zwei4
Add code in ACPI table for TI audio codec under I2C5. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: zwei4 --- .../BensonGlacier/BoardInitPostMem/BoardInit.c | 33 +++- .../BoardInitPostMem/BoardInitPostMem.inf | 1 +

Re: [edk2] [Patch V2 1/2] MdeModulePkg/UsbBusDxe: Add UsbControlTransfer() error check

2017-11-14 Thread Zeng, Star
Mike, UEFI spec, EFI_USB_IO_PROTOCOL.UsbControlTransfer(), in the description. Thanks, Star -Original Message- From: Kinney, Michael D Sent: Wednesday, November 15, 2017 12:00 PM To: Zeng, Star ; edk2-devel@lists.01.org; Kinney, Michael D

[edk2] [Patch] ShellPkg: Add error message if failed to place receive token in ping command.

2017-11-14 Thread Fu Siyuan
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan Cc: Wu Jiaxin Cc: Ye Ting Cc: Ruiyu Ni --- ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 9 +++--

Re: [edk2] [Patch V2 1/2] MdeModulePkg/UsbBusDxe: Add UsbControlTransfer() error check

2017-11-14 Thread Kinney, Michael D
Star, I am curious. Which spec statement are you referring to? Mike > -Original Message- > From: Zeng, Star > Sent: Tuesday, November 14, 2017 6:59 PM > To: Kinney, Michael D ; > edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star >

Re: [edk2] [Patch] NetworkPkg: Fix incorrect SizeofHeaders returned from HttpTcpReceiveHeader().

2017-11-14 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Fu, Siyuan Sent: Wednesday, November 15, 2017 10:45 AM To: edk2-devel@lists.01.org Cc: Wu, Jiaxin ; Ye, Ting ; Karunakar P Subject: [Patch] NetworkPkg:

[edk2] [Patch] MdeModulePkg/SNP: remove redundant DEBUG print in SNP Transmit.c

2017-11-14 Thread Fu Siyuan
This patch is to remove some redundant DEBUG output in SNP transmit function. In case of return EFI_NOT_READY in PxeTransmit, the SNP driver is indicate the caller that the transmit queue is full, it's a very common situation druing transmit, not a critical error. So the patch move the DEBUG lever

Re: [edk2] [Patch V2] NetworkPkg: Print error message to screen if error occurs during HTTP boot.

2017-11-14 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Fu, Siyuan Sent: Wednesday, November 15, 2017 9:52 AM To: edk2-devel@lists.01.org Cc: Wu, Jiaxin ; Ye, Ting Subject: [Patch V2] NetworkPkg: Print error message to screen if error

Re: [edk2] [Patch V2 1/2] MdeModulePkg/UsbBusDxe: Add UsbControlTransfer() error check

2017-11-14 Thread Zeng, Star
Mike, I do not insist on the check that the Direction is not EfiUsbNoData, and I know the functionality should have no improvement with the check. So, you can have my Reviewed-by: Star Zeng . I raised the question just for consideration from literally, as according to the

[edk2] [Patch] NetworkPkg: Fix incorrect SizeofHeaders returned from HttpTcpReceiveHeader().

2017-11-14 Thread Fu Siyuan
This patch is to fix a bug that the HttpTcpReceiveHeader() may return incorrect SizeofHeaders, which will include some already received message-body. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan Cc: Wu Jiaxin Cc: Ye

Re: [edk2] [Patch V2 1/2] MdeModulePkg/UsbBusDxe: Add UsbControlTransfer() error check

2017-11-14 Thread Kinney, Michael D
Star, For that case both DataLength and RequestedDataLength will be 0 and the new path will not be taken. Are you concerned that the USB HC Protocol could return a non zero DataLength for the EfiUsbNoData case? Even if it does, the new path can never be taken because 0 is less than all UINTN

Re: [edk2] [Patch V2 1/2] MdeModulePkg/UsbBusDxe: Add UsbControlTransfer() error check

2017-11-14 Thread Zeng, Star
Mike, Do you think it is better or not to also check the Direction is not EfiUsbNoData? UEFI spec, EFI_USB_IO_PROTOCOL.UsbControlTransfer(): If the Direction parameter is EfiUsbNoData, Data is NULL, and DataLength is 0, then no data phase exists for the control transfer. Thanks, Star

Re: [edk2] [Patch V2 2/2] MdeModulePkg/UsbMassStorageDxe: Check Get Max LUN status/value

2017-11-14 Thread Zeng, Star
Mike, With a minor typo "that o not" fixed to "that do not" in the commit log, Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Kinney, Michael D Sent: Wednesday, November 15, 2017 9:03 AM To: edk2-devel@lists.01.org Cc: Zeng, Star

Re: [edk2] [staging/Customized-Secure-Boot] Sync Customized-Secure-Boot From edk2/master

2017-11-14 Thread Zhang, Chao B
HI Cinnamon: We plan to update staging with latest EDK2 core and sync ECR1689 Out Of band Auth Variable Management, ECR 1263 Customized Secure Boot, ECR1557 and TCG PFP spec 00.21 PCR[7] measurement to staging. That requires big effort. We will notify the community after all the jobs are

[edk2] [Patch V2] NetworkPkg: Print error message to screen if error occurs during HTTP boot.

2017-11-14 Thread Fu Siyuan
V2 update: Add error message is URI address is not correct. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan Cc: Wu Jiaxin Cc: Ye Ting --- NetworkPkg/HttpBootDxe/HttpBootImpl.c| 21

[edk2] [Patch] MdeModulePkg/UsbMassStorageDxe: Enhance Request Sense Handling

2017-11-14 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=782 Update the Request Sense check for the Request Sense Key of USB_BOOT_SENSE_UNIT_ATTENTION. For this Sense Key, the Additional Sense Key to EFI_STATUS mappings are: USB_BOOT_ASC_MEDIA_CHANGE -> EFI_MEDIA_CHANGE USB_BOOT_ASC_NOT_READY->

[edk2] [Patch V2 1/2] MdeModulePkg/UsbBusDxe: Add UsbControlTransfer() error check

2017-11-14 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=767 The USB I/O Protocol function ControlTransfer() has a DataLength parameter that specifies the size of the Data buffer. The UsbBusDxe module implements the USB I/O Protocol using the services of the USB2 Host Controller Protocol. The DataLength

[edk2] [Patch V2 0/2] Add Max LUN status/value checks

2017-11-14 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=767 Add error check to USB I/O Protocol UsbControlTransfer() for the number of bytes actually transfered. If less than requested, then return EFI_DEVICE_ERROR. Check Get Max LUN status/value in USB Mass Storage Driver to handle cases where USB

[edk2] [Patch V2 2/2] MdeModulePkg/UsbMassStorageDxe: Check Get Max LUN status/value

2017-11-14 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=767 If a USB Mass Storage device does not support the Get Max LUN command, then the USB I/O Protocol ControlTransfer() service may return an error. If an error is returned for this command, then assume that the device does not support multiple LUNs

Re: [edk2] [RFC 0/1] Stack trace support in X64 exception handling

2017-11-14 Thread Paulo Alcantara
Hi, On 14/11/2017 15:41, Brian J. Johnson wrote: On 11/14/2017 11:23 AM, Andrew Fish wrote: On Nov 14, 2017, at 8:33 AM, Brian J. Johnson > wrote: On 11/14/2017 09:37 AM, Paulo Alcantara wrote: Hi Fan, On 14/11/2017 12:03, Fan Jeff

Re: [edk2] [RFC 0/1] Stack trace support in X64 exception handling

2017-11-14 Thread Brian J. Johnson
On 11/14/2017 11:23 AM, Andrew Fish wrote: On Nov 14, 2017, at 8:33 AM, Brian J. Johnson > wrote: On 11/14/2017 09:37 AM, Paulo Alcantara wrote: Hi Fan, On 14/11/2017 12:03, Fan Jeff wrote: Paul, I like this feature very much. Actually,

Re: [edk2] [PATCH 0/4] BaseTools: Add VS2017 support, including ARM and AARCH64

2017-11-14 Thread Pete Batard
Hi Kurt, On 2017.11.14 16:16, Kurt Kennett wrote: Does this build and boot a platform? Not yet, but I believe I got pretty close to a full build for ARM. However, the resources I can devote to finalizing ARM image generation, and even more so, to add the missing resources for AARCH64 image

Re: [edk2] [RFC 0/1] Stack trace support in X64 exception handling

2017-11-14 Thread Andrew Fish
> On Nov 14, 2017, at 8:33 AM, Brian J. Johnson wrote: > > On 11/14/2017 09:37 AM, Paulo Alcantara wrote: >> Hi Fan, >> On 14/11/2017 12:03, Fan Jeff wrote: >>> Paul, >>> >>> I like this feature very much. Actually, I did some POC one year ago but I >>> did finalize it.

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] BensonGlacier: Enable generic SPI device

2017-11-14 Thread Teemu Rytkonen
-Enable generic SPI device for BensonGlacier config to be used with SenseHat board. -Enable GPIO config to enable SenseHat board programming Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Teemu Rytkonen ---

Re: [edk2] [PATCH 0/4] BaseTools: Add VS2017 support, including ARM and AARCH64

2017-11-14 Thread Pete Batard
Hi Liming, On 2017.11.14 16:03, Gao, Liming wrote: In fact, I have sent one patch serial to add VS2017 tool chain for IA32 and X64. https://lists.01.org/pipermail/edk2-devel/2017-October/016175.html I missed that proposal, else I would have used it as my base. Thanks for pointing it out.

Re: [edk2] [RFC 1/1] UefiCpuPkg/CpuExceptionHandlerLib/X64: Add stack trace support

2017-11-14 Thread Brian J. Johnson
On 11/14/2017 09:30 AM, Paulo Alcantara wrote: Hi Andrew, On 14/11/2017 12:01, Andrew Fish wrote: C> Paulo, Cool feature. How does this code deal with VC++ that code does not store the frame pointer and requires symbols to unwind. I haven't tested in with MSVC, so I'd hope to get some help

Re: [edk2] 答复: [RFC 0/1] Stack trace support in X64 exception handling

2017-11-14 Thread Brian J. Johnson
On 11/14/2017 09:37 AM, Paulo Alcantara wrote: Hi Fan, On 14/11/2017 12:03, Fan Jeff wrote: Paul, I like this feature very much. Actually, I did some POC one year ago but I did finalize it. In my POC, I could use EBP to tack the stack frame on IAS32 arch. But for x64, I tried to use

Re: [edk2] [PATCH 0/4] BaseTools: Add VS2017 support, including ARM and AARCH64

2017-11-14 Thread Kurt Kennett
Does this build and boot a platform? This should not be committed until a platform is building and booting to UEFI shell, IMO. K2 -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Pete Batard Sent: Tuesday, November 14, 2017 4:32 AM To:

Re: [edk2] [PATCH 0/4] BaseTools: Add VS2017 support, including ARM and AARCH64

2017-11-14 Thread Gao, Liming
Pete: Thanks for your contribution. In fact, I have sent one patch serial to add VS2017 tool chain for IA32 and X64. https://lists.01.org/pipermail/edk2-devel/2017-October/016175.html In my patch, I disable warning 4701&4703, because they are also disabled in VS2015. In tools_def.template,

Re: [edk2] [PATCH 0/2] Refine UDF related codes

2017-11-14 Thread Paulo Alcantara
Hi Hao, On 14/11/2017 05:51, Hao Wu wrote: The series will do the following refinements: a. Merge the discovery of the El Torito feature on CD/DVD media into the detect of UDF; b. Avoid possible loss track of the allocated buffer pointer in UdfDxe. Cc: Paulo Alcantara

Re: [edk2] 答复: [RFC 0/1] Stack trace support in X64 exception handling

2017-11-14 Thread Paulo Alcantara
Hi Fan, On 14/11/2017 12:03, Fan Jeff wrote: Paul, I like this feature very much. Actually, I did some POC one year ago but I did finalize it. In my POC, I could use EBP to tack the stack frame on IAS32 arch. But for x64, I tried to use –keepexceptiontable flag to explain stack frame from

Re: [edk2] [PATCH] CorebootModulePkg/CbSupportDxe: Remove duplicated IO Space addition

2017-11-14 Thread Ma, Maurice
Looks good to me. Reviewed-by: Maurice Ma Thanks Maurice -Original Message- From: You, Benjamin Sent: Tuesday, November 14, 2017 12:41 AM To: edk2-devel@lists.01.org Cc: Ma, Maurice ; Agyeman, Prince Subject:

Re: [edk2] [RFC 1/1] UefiCpuPkg/CpuExceptionHandlerLib/X64: Add stack trace support

2017-11-14 Thread Paulo Alcantara
Hi Andrew, On 14/11/2017 12:01, Andrew Fish wrote: C> Paulo, Cool feature. How does this code deal with VC++ that code does not store the frame pointer and requires symbols to unwind. I haven't tested in with MSVC, so I'd hope to get some help from Intel's guys to help supporting and

Re: [edk2] [RFC 1/1] UefiCpuPkg/CpuExceptionHandlerLib/X64: Add stack trace support

2017-11-14 Thread Andrew Fish
> On Nov 14, 2017, at 6:26 AM, Fan Jeff wrote: > > Andrew, > > We could use he EIP offset in Paul’s trace message and work with the > generated map file under debug directory for debug trace. It would also be possible to use gdb. Given 0 0x7E510F7F @

Re: [edk2] [PATCH v5] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-11-14 Thread Wang, Jian J
Hi Laszlo, I did some investigation works on this issue. I think I found the root cause and tend to believe this is a Fedora kernel issue. Here're proves: memmap output patterns in which Fedora 26 failed to boot: 1) BS_DataAE20-AE20EFFF 000F 0002600F

[edk2] 答复: [RFC 1/1] UefiCpuPkg/CpuExceptionHandlerLib/X64: Add stack trace support

2017-11-14 Thread Fan Jeff
Andrew, We could use he EIP offset in Paul’s trace message and work with the generated map file under debug directory for debug trace. Jeff 发件人: Andrew Fish 发送时间: 2017年11月14日 22:01 收件人: Paulo Alcantara 抄送:

[edk2] 答复: 答复: [RFC 0/1] Stack trace support in X64 exception handling

2017-11-14 Thread Fan Jeff
Paul, Sorry, correct some import words in my last mail. “I did NOT finalize my POC”.:-) Jeff From: edk2-devel on behalf of Fan Jeff Sent: Tuesday, November 14, 2017 10:03:20 PM To: Paulo

[edk2] 答复: [RFC 0/1] Stack trace support in X64 exception handling

2017-11-14 Thread Fan Jeff
Paul, I like this feature very much. Actually, I did some POC one year ago but I did finalize it. In my POC, I could use EBP to tack the stack frame on IAS32 arch. But for x64, I tried to use �Ckeepexceptiontable flag to explain stack frame from the debug section of image. I may workson MSFT

Re: [edk2] [RFC 1/1] UefiCpuPkg/CpuExceptionHandlerLib/X64: Add stack trace support

2017-11-14 Thread Andrew Fish
Paulo, Cool feature. How does this code deal with VC++ that code does not store the frame pointer and requires symbols to unwind. Also on the page fault you can print the fault address since it is in CR2. It should be possible to post process the text file and make a symbolicated backtrace.

Re: [edk2] [RFC 0/1] Stack trace support in X64 exception handling

2017-11-14 Thread Paulo Alcantara
Hi, On 14/11/2017 10:47, Paulo Alcantara wrote: Hi, This series adds stack trace support during a X64 CPU exception. Informations like back trace, stack contents and image module names (that were part of the call stack) will be dumped out. We already have such support in ARM/AArch64 (IIRC)

[edk2] [RFC 0/1] Stack trace support in X64 exception handling

2017-11-14 Thread Paulo Alcantara
Hi, This series adds stack trace support during a X64 CPU exception. Informations like back trace, stack contents and image module names (that were part of the call stack) will be dumped out. We already have such support in ARM/AArch64 (IIRC) exception handling (thanks to Ard), and then I

[edk2] [RFC 1/1] UefiCpuPkg/CpuExceptionHandlerLib/X64: Add stack trace support

2017-11-14 Thread Paulo Alcantara
This patch adds stack trace support during a X64 CPU exception. It will dump out back trace, stack contents as well as image module names that were part of the call stack. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Eric Dong Cc: Laszlo Ersek

[edk2] [PATCH 0/4] BaseTools: Add VS2017 support, including ARM and AARCH64

2017-11-14 Thread Pete Batard
Seeing that Visual Studio Update 4 finally added native ARM64 compilation support and this is an open task: https://github.com/tianocore/tianocore.github.io/wiki/Tasks This series is broken down into: - A preliminary patch, to eliminate new warnings that would be produced for VS2017/IA32 - IA32

[edk2] [PATCH 2/4] BaseTools: Add VS2017 IA32 and X64 support

2017-11-14 Thread Pete Batard
For the sake of reducing toolchain combinations, only one variation is supported: x86 tools (MS default) with External ASL and no EBC. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Pete Batard --- BaseTools/Conf/tools_def.template | 108

[edk2] [PATCH 1/4] MdeModulePkg, NetworkPkg: Fix VS2017 IA32 warnings

2017-11-14 Thread Pete Batard
This is a preliminary patch before the introduction of VS2017 support. Without this, IA32 compilation will produce the following warnings: * warning C4701: potentially uninitialized local variable used * warning C4703: potentially uninitialized local pointer variable used Contributed-under:

[edk2] [PATCH 3/4] BaseTools: Add VS2017 ARM support

2017-11-14 Thread Pete Batard
Requires the silencing of the following warnings: * warning C4100: unreferenced formal parameter * warning C4127: conditional expression is constant * warning C4214: nonstandard extension used: bit field types other than int Also requires _ARM_WINAPI_PARTITION_DESKTOP_SDK_AVAILABLE to be defined

[edk2] [PATCH 4/4] BaseTools: Add VS2017 AARCH64 support

2017-11-14 Thread Pete Batard
Requires the silencing of the same warnings as ARM. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Pete Batard --- BaseTools/Conf/build_rule.template| 4 +- BaseTools/Conf/tools_def.template | 32 ++-

Re: [edk2] [PATCH edk2-platforms]: resolving Hikey platform build error

2017-11-14 Thread Ard Biesheuvel
On 14 November 2017 at 11:16, Kalyan Nagabhirava wrote: > > "Instance of library class [CapsuleLib] is not found" build error is coming > for Hikey platform, to resolve this issueadded CapsuleLib to > "LibraryClasses.common" section > > diff --git

Re: [edk2] [PATCH] ShellPkg/Shell: Check the OpenVolume result in OpenRootByHandle()

2017-11-14 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Tuesday, November 14, 2017 4:41 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: RE: [PATCH] ShellPkg/Shell: Check

Re: [edk2] [PATCH] ShellPkg/Shell: Check the OpenVolume result in OpenRootByHandle()

2017-11-14 Thread Wu, Hao A
> -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, November 14, 2017 4:38 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: RE: [PATCH] ShellPkg/Shell: Check the OpenVolume result in > OpenRootByHandle() > > How about changing the function header comments

[edk2] [Patch 3/3 V2] BaseTools: Update Makefile to support FFS file generation

2017-11-14 Thread Yonghong Zhu
Update Makefile to support FFS file generation. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu Signed-off-by: Yunhua Feng --- BaseTools/Source/Python/AutoGen/AutoGen.py

[edk2] [PATCH] ArmVirtPkg/ArmVirtQemu: use non-accelerated CopyMem for VariableRuntimeDxe

2017-11-14 Thread Ard Biesheuvel
The VariableRuntimeDxe driver may use CopyMem () on NOR flash regions, assuming such regions always have full memory semantics. Given that those regions cannot be mapped as ordinary memory on ARM (due to the fact that the NOR flash requires device semantics while in write mode) this prevents us

Re: [edk2] [Patch] BaseTools: Fix the bug to collect source files per build rule family

2017-11-14 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Tuesday, November 14, 2017 1:53 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [Patch] BaseTools: Fix the bug to collect source files per build rule >family >

[edk2] [PATCH] CorebootModulePkg/CbSupportDxe: Remove duplicated IO Space addition

2017-11-14 Thread Benjamin You
Since UefiCpuPkg's CpuDxe Driver already adds Local Apic's MMIO space to GCD, CorebootModulePkg's CbSupportDxe should not do this again. Doing this again causes error return status from GCD service, and ASSERT (FALSE) with debug build, so the duplicated addition is removed. Cc: Maurice Ma

Re: [edk2] [PATCH] ShellPkg/Shell: Check the OpenVolume result in OpenRootByHandle()

2017-11-14 Thread Ni, Ruiyu
How about changing the function header comments from > + @retval EFI_MEDIA_CHANGED The device has a different medium in it or > the medium is no longer supported. To: > + @retval others Error status returned from > EFI_SIMPLE_FILE_SYSTEM_PROTOCOL->OpenVolume(). Because MEDIA_CHANGED is

[edk2] [Patch 2/3 V2] BaseTools: Update Trim to generate VfrBinOffset Binary

2017-11-14 Thread Yonghong Zhu
Its usage is "Trim --Vfr-Uni-Offset -o $(OUTPUT_DIR)(+)$(MODULE_NAME)VfrOffset.sec --ModuleName=$(MODULE_NAME) --DebugDir=$(DEBUG_DIR)" Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- BaseTools/Source/Python/Trim/Trim.py | 81

[edk2] [Patch 0/3 V2] BaseTools: Enable multiple thread to generate FFS file

2017-11-14 Thread Yonghong Zhu
These patches enable multiple thread to generate ffs file by merge FFS file's generation into Make phase. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu Yonghong Zhu (3): BaseTools: GenFfs

[edk2] [Patch 1/3 V2] BaseTools: GenFfs support to get alignment value from SectionFile

2017-11-14 Thread Yonghong Zhu
Update GenFfs tool to get alignment value from SectionFile when use the new option -n 0. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Source/C/GenFfs/GenFfs.c | 135