[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] I2S Audio Configure

2017-12-21 Thread zwei4
Customize I2S virtual bus ID for different boards. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: zwei4 --- .../BensonGlacier/BoardInitPostMem/BoardGpios.c| 10 --- .../BensonGlacier/BoardInitPostMem/BoardGpios.h| 10 --- .../BensonGlacier/BoardInitPostMem

Re: [edk2] [Patch 0/2] Fix some issues in HttpBootDxe driver.

2017-12-21 Thread Wang, Fan
Patch series reviewed by Wang, Fan . Best Regards Fan -Original Message- From: Wu, Jiaxin Sent: Thursday, December 21, 2017 2:51 PM To: edk2-devel@lists.01.org Cc: Wang, Fan ; Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: [Patch 0/2] Fix some issues in HttpBootDxe driver. Cc: Wang Fan

Re: [edk2] [Patch] NetworkPkg: Recycle the ICMP error message in PXE driver.

2017-12-21 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu, > Siyuan > Sent: Thursday, December 21, 2017 3:46 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Wang, Fan ; Wu, > Jiaxin > Subject: [edk2] [Patch] NetworkPkg: Rec

Re: [edk2] [Patch] MdeModulePkg/DpcLib: return error if failed to locate DPC protocol.

2017-12-21 Thread Wang, Fan
Reviewed by Wang, Fan -Original Message- From: Fu, Siyuan Sent: Friday, December 22, 2017 2:14 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Wu, Jiaxin ; Wang, Fan Subject: [Patch] MdeModulePkg/DpcLib: return error if failed to locate DPC protocol. This patch updates the constructor

Re: [edk2] [Patch] NetworkPkg: Remove redundant check in PXE driver.

2017-12-21 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu, > Siyuan > Sent: Thursday, December 21, 2017 3:46 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Wang, Fan ; Wu, > Jiaxin > Subject: [edk2] [Patch] NetworkPkg: Re

Re: [edk2] [Patch] MdeModulePkg/DpcLib: return error if failed to locate DPC protocol.

2017-12-21 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu, > Siyuan > Sent: Friday, December 22, 2017 2:14 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Wang, Fan ; Wu, > Jiaxin > Subject: [edk2] [Patch] MdeModulePkg/DpcL

[edk2] [PATCH 0/3] fix GCC optimizations and warnings for SetJump/LongJump

2017-12-21 Thread M1cha
I've already discussed this in past but never actually sent proper patches for some reason. This patch series is about fixing problems with these functions when using GCC. M1cha (3): MdePkg: add RETURNS_TWICE attribute MdePkg/BaseLib: add attribute 'RETURNS_TWICE' to SetJump MdePkg: add NOR

[edk2] [PATCH 1/3] MdePkg: add RETURNS_TWICE attribute

2017-12-21 Thread M1cha
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Zimmermann --- MdePkg/Include/Base.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h index 22ab5d3715fb..c863de407418 100644 --- a/MdePkg/Include/Base.h +++

[edk2] [PATCH 2/3] MdePkg/BaseLib: add attribute 'RETURNS_TWICE' to SetJump

2017-12-21 Thread M1cha
When compiling with any ARM toolchain and Os, registers can get trashed when returning for the second time from SetJump because GCC only handles this correctly when using standard names like 'setjmp' or 'getcontext'. When different names are used you have to use the attribute 'returns_twice' to tel

[edk2] [PATCH 3/3] MdePkg: add NORETURN attribute to LongJump and InternalLongJump

2017-12-21 Thread M1cha
This fixes compiler warnings when using them in functions which should return a value but rely on LongJump to never return instead. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Zimmermann --- MdePkg/Include/Library/BaseLib.h | 1 + MdePkg/Library/BaseLi

Re: [edk2] [Patch 1/3] NetworkPkg/TcpDxe: Check FragmentBuffer for NULL before use

2017-12-21 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Friday, December 22, 2017 3:07 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Wang, Fan ; Ye, > Ting ; Wu, Jiaxin > Subject: [Patch 1/3] NetworkPkg/TcpDxe: Check FragmentBuffer for NULL > before use > > Accordin

Re: [edk2] [Patch 2/3] NetworkPkg/TcpDxe: Remove the redundant code.

2017-12-21 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jiaxin Wu > Sent: Friday, December 22, 2017 3:07 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Wang, Fan ; Fu, > Siyuan ; Wu, Jiaxin > Subject: [edk2] [Patch 2/3]

[edk2] [PATCH] SecurityPkg: Remove RngTest Application from SecurityPkg

2017-12-21 Thread Long Qin
BZ#: https://bugzilla.tianocore.org/show_bug.cgi?id=820 Remove the RngTest application from SecurityPkg, which was only for unit test. Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Long Qin --- SecurityPkg/Application/RngTest/RngTest.c| 234 --

[edk2] [Patch 2/3] NetworkPkg/TcpDxe: Remove the redundant code.

2017-12-21 Thread Jiaxin Wu
The function SockGroup() is not used by any other code. So, it can be deleted. Cc: Fu Siyuan Cc: Wang Fan Cc: Ye Ting Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- NetworkPkg/TcpDxe/SockInterface.c | 46 --- NetworkPkg

[edk2] [Patch 0/3] NetworkPkg/TcpDxe: Fix some issues in TcpDxe driver.

2017-12-21 Thread Jiaxin Wu
Cc: Fu Siyuan Cc: Wang Fan Cc: Ye Ting Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin Jiaxin Wu (3): NetworkPkg/TcpDxe: Check FragmentBuffer for NULL before use NetworkPkg/TcpDxe: Remove the redundant code. NetworkPkg/TcpDxe: Check TCP payload for releas

[edk2] [Patch 1/3] NetworkPkg/TcpDxe: Check FragmentBuffer for NULL before use

2017-12-21 Thread Jiaxin Wu
According the Spec, the FragmentBuffers in FragmentTable are allocated by the application when calling Receive() function. This patch is to check whether the FragmentBuffer is valid or not. Cc: Fu Siyuan Cc: Wang Fan Cc: Ye Ting Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off

[edk2] [PATCH edk2-platforms 0/3] Platform/NXP-Added NXP PCI Host Bridge Driver

2017-12-21 Thread Vabhav
Following patches will add support of NXP PCI Host Bridge Driver in edk2-platforms directory 'edk2-platforms/Platform/NXP' Updated Directory structure for added folders in 'edk2-platforms/Platform/NXP' will be: Platform/NXP/Drivers/PciHostBridgeDxe/ |-- PciHostBridgeDxe.c |-- PciHostBridgeDxe.i

[edk2] [PATCH edk2-platforms 1/3] Platform/NXP : Add PCI Host Bridge Libary

2017-12-21 Thread Vabhav
Added PCIe Host Bridge Library to provide helper functions which will be used by PCIe Host bridge Dxe Driver Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vabhav --- Platform/NXP/Include/PciCntrlLib.h | 323 +++ Platform/NXP/Include/PciLib.h

[edk2] [PATCH edk2-platforms 3/3] Compilation:Modify dsc, fdf files

2017-12-21 Thread Vabhav
Enabling support for compilation of PciHost Bridge Library, PciHostBridge Dxe Driver and include respective serdes functions Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vabhav --- Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 31 Platform/

[edk2] [PATCH edk2-platforms 3/3] SATA : Added SATA controller initialization driver.

2017-12-21 Thread Meenakshi Aggarwal
Add driver to initialize SATA controller and apply any platform specific errata. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal --- Platform/NXP/Drivers/SataInitDxe/SataInit.c | 122 +++ Platform/NXP/Drivers/SataInitDxe/SataInit

[edk2] [PATCH edk2-platforms 2/3] PciEmulation : Add support for Pci Emulation layer.

2017-12-21 Thread Meenakshi Aggarwal
SATA and USB will use this pci emulation layer Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal --- Platform/NXP/Drivers/PciEmulation/PciEmulation.c | 624 + Platform/NXP/Drivers/PciEmulation/PciEmulation.h | 306 ++ Platfo

[edk2] [PATCH edk2-platforms 0/3] Cover letter:Pci Emulation and SATA support

2017-12-21 Thread Meenakshi Aggarwal
Following patches add support for pci emulation layer and SATA on NXP boards. Null Library for USB is also present to give completeness to Pci Emulation layer. Meenakshi Aggarwal (3): USB: Added Support of DWC3 USB controller. PciEmulation : Add support for Pci Emulation layer. SATA : Added

[edk2] [PATCH] CryptoPkg/OpensslLib: Update OpenSSL version to 1.1.0g

2017-12-21 Thread Long Qin
Update the supported OpenSSL version to the latest 1.1.0g (02-Nov-2017). The changes includes: - Re-generate the OpensslLib[crypto].inf using process_files.pl script to reflect the openssl source changes. - Update OpenSSL-HOWTO.txt - On Visual Studio Build: adding "/wd4819" to disable one add

[edk2] [PATCH edk2-platforms 1/3] USB: Added Support of DWC3 USB controller.

2017-12-21 Thread Meenakshi Aggarwal
Added library for DWC3 USB controller and enabled USB support in pci emulation layer. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal --- .../NXP/Library/UsbHcdNullLibrary/UsbHcdLibNull.c | 25 +++ .../NXP/Library/UsbHcdNullLibrary/UsbHc

[edk2] [Patch] MdeModulePkg/DpcLib: return error if failed to locate DPC protocol.

2017-12-21 Thread Fu Siyuan
This patch updates the constructor of DpcLib to return error if failed to locate DPC protocol. Cc: Ye Ting Cc: Wu Jiaxin Cc: Wang Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan --- MdeModulePkg/Library/DxeDpcLib/DpcLib.c | 2 +- 1 file changed, 1 insertio

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: Fix incorrect Guard page setup for APs

2017-12-21 Thread Wang, Jian J
You're right. It will be updated to use more accurate wording. Thanks for catching it. Regards, Jian > -Original Message- > From: Yao, Jiewen > Sent: Friday, December 22, 2017 1:22 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Dong, Eric > Subject: RE: [edk2] [PA

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: Fix incorrect Guard page setup for APs

2017-12-21 Thread Yao, Jiewen
I do not think we have AP guard page before, right? So I suggest we change commit message to be: Add missing Guard page setup for APs. With commit message update, reviewed-by: jiewen@intel.com > -Original Message- > From: Wang, Jian J > Sent: Friday, December 22, 2017 12:26 PM > To:

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: Fix incorrect Guard page setup for APs

2017-12-21 Thread Wang, Jian J
Hi, Anyone has any comments on this? Regards, Jian > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J > Wang > Sent: Thursday, December 21, 2017 9:27 AM > To: edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Yao, Jiewen ; > Dong, Eric > Sub

Re: [edk2] [PATCH] MdePkg Acpi60.h: Add missing PCCT subspace type 1 and 2 definitions

2017-12-21 Thread Yao, Jiewen
reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng > Sent: Wednesday, December 20, 2017 5:49 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Gao, Liming ; > Zeng, Star > Subject: [edk2] [PATCH] M

Re: [edk2] [PATCH] MdePkg Acpi60.h: Add missing PCCT subspace type 1 and 2 definitions

2017-12-21 Thread Gao, Liming
Reviewed-by: Star Zeng >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star >Zeng >Sent: Wednesday, December 20, 2017 5:49 PM >To: edk2-devel@lists.01.org >Cc: Yao, Jiewen ; Gao, Liming >; Zeng, Star >Subject: [edk2] [PATCH] MdePkg Acpi60.h: Ad

[edk2] [PATCH] UefiCpuPkg: Delete redundant PcdGetSize PcdCpuFeaturesSupport

2017-12-21 Thread Song, BinX
When CpuCommonFeaturesLib use RegisterCpuFeaturesLib to register CPU features, the CpuFeaturesData->BitMaskSize has already been initialized. So delete redundant PcdGetSize PcdCpuFeaturesSupport in CpuInitDataInitialize. Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Ag

Re: [edk2] [PATCH V2] UefiCpuPkg: Keep library class header file definition independent

2017-12-21 Thread Song, BinX
Hi Mike, Thanks for your suggestion. After discussion with Eric, I know there is a function named IsCpuFeatureSupported() to do the feature valid/invalid check. User should do IsCpuFeatureSupported() check first and then RegisterCpuFeature(). So there is no need to add any code to do the same wo

Re: [edk2] [RFC] MdeModulePkg/PciHostBridge: Add address translation support

2017-12-21 Thread Guo Heyi
On Thu, Dec 21, 2017 at 05:43:17PM +0800, Ni, Ruiyu wrote: > On 12/20/2017 11:26 PM, Ard Biesheuvel wrote: > >On 20 December 2017 at 15:17, gary guo wrote: > >>On Wed, Dec 20, 2017 at 09:13:58AM +, Ard Biesheuvel wrote: > >>>Hi Heyi, > >>> > >>>On 20 December 2017 at 08:21, Heyi Guo wrote: >

Re: [edk2] [PATCH] IntelSiliconPkg MicrocodeUpdateDxe: Fix (ExtendedTableLength & 0x3)!=0

2017-12-21 Thread Chaganty, Rangasai V
Reviewed-by: rangasai.v.chaga...@intel.com -Original Message- From: Yao, Jiewen Sent: Wednesday, December 20, 2017 7:09 PM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Chaganty, Rangasai V Subject: RE: [PATCH] IntelSiliconPkg MicrocodeUpdateDxe: Fix (ExtendedTableLength & 0x3)!=0 Revi

Re: [edk2] [RFC] MdeModulePkg/PciHostBridge: Add address translation support

2017-12-21 Thread Ard Biesheuvel
On 21 December 2017 at 09:59, Ni, Ruiyu wrote: > On 12/21/2017 5:52 PM, Ard Biesheuvel wrote: >> >> On 21 December 2017 at 09:48, Ni, Ruiyu wrote: >>> >>> On 12/21/2017 5:14 PM, Guo Heyi wrote: On Thu, Dec 21, 2017 at 08:32:37AM +, Ard Biesheuvel wrote: > > > On 21

Re: [edk2] [RFC] MdeModulePkg/PciHostBridge: Add address translation support

2017-12-21 Thread Ni, Ruiyu
On 12/21/2017 5:52 PM, Ard Biesheuvel wrote: On 21 December 2017 at 09:48, Ni, Ruiyu wrote: On 12/21/2017 5:14 PM, Guo Heyi wrote: On Thu, Dec 21, 2017 at 08:32:37AM +, Ard Biesheuvel wrote: On 21 December 2017 at 08:27, Guo Heyi wrote: On Wed, Dec 20, 2017 at 03:26:45PM +, Ard B

Re: [edk2] [RFC] MdeModulePkg/PciHostBridge: Add address translation support

2017-12-21 Thread Ard Biesheuvel
On 21 December 2017 at 09:48, Ni, Ruiyu wrote: > On 12/21/2017 5:14 PM, Guo Heyi wrote: >> >> On Thu, Dec 21, 2017 at 08:32:37AM +, Ard Biesheuvel wrote: >>> >>> On 21 December 2017 at 08:27, Guo Heyi wrote: On Wed, Dec 20, 2017 at 03:26:45PM +, Ard Biesheuvel wrote: > >

Re: [edk2] [RFC] MdeModulePkg/PciHostBridge: Add address translation support

2017-12-21 Thread Ni, Ruiyu
On 12/21/2017 5:14 PM, Guo Heyi wrote: On Thu, Dec 21, 2017 at 08:32:37AM +, Ard Biesheuvel wrote: On 21 December 2017 at 08:27, Guo Heyi wrote: On Wed, Dec 20, 2017 at 03:26:45PM +, Ard Biesheuvel wrote: On 20 December 2017 at 15:17, gary guo wrote: On Wed, Dec 20, 2017 at 09:13:58

Re: [edk2] [RFC] MdeModulePkg/PciHostBridge: Add address translation support

2017-12-21 Thread Ni, Ruiyu
On 12/20/2017 11:26 PM, Ard Biesheuvel wrote: On 20 December 2017 at 15:17, gary guo wrote: On Wed, Dec 20, 2017 at 09:13:58AM +, Ard Biesheuvel wrote: Hi Heyi, On 20 December 2017 at 08:21, Heyi Guo wrote: PCIe on some ARM platforms requires address translation, not only for legacy IO

Re: [edk2] [RFC] MdeModulePkg/PciHostBridge: Add address translation support

2017-12-21 Thread Guo Heyi
On Thu, Dec 21, 2017 at 08:32:37AM +, Ard Biesheuvel wrote: > On 21 December 2017 at 08:27, Guo Heyi wrote: > > On Wed, Dec 20, 2017 at 03:26:45PM +, Ard Biesheuvel wrote: > >> On 20 December 2017 at 15:17, gary guo wrote: > >> > On Wed, Dec 20, 2017 at 09:13:58AM +, Ard Biesheuvel wr

[edk2] [Patch V2] MdeModulePkg/IpIoLib: add more error handling code to DxeIpIoLib.

2017-12-21 Thread Fu Siyuan
V2 update: Add missing "Status =" when call GetModeData() In DxeIpIo, there are several places not check the returned value of called functions. This patch is to add the error handling to these functions. Cc: Ye Ting Cc: Wu Jiaxin Cc: Wang Fan Contributed-under: TianoCore Contribution Agreeme

Re: [edk2] [Patch] MdeModulePkg/IpIoLib: add more error handling code to DxeIpIoLib.

2017-12-21 Thread Ye, Ting
Hi Siyuan, Please add "status =" for calling GetModeData with IP4/IP6. Others are good to me. + Ip.Ip6->GetModeData ( +Ip.Ip6, +&Ip6ModeData, +NULL, +NULL +); Reviewed-by: Ye Ting Best Regards, Ting

Re: [edk2] [Patch] MdeModulePkg/IpIoDxe: Update API description to match the function implementation.

2017-12-21 Thread Wu, Jiaxin
Hi Siyuan , I can't apply this patch, but looks good to me. Reviewed-by: Jiaxin Wu Thanks, Jiaxin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu, > Siyuan > Sent: Wednesday, December 13, 2017 3:31 PM > To: edk2-devel@lists.01.org > Cc:

Re: [edk2] [Patch] MdeModulePkg/IpIoLib: add more error handling code to DxeIpIoLib.

2017-12-21 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu, > Siyuan > Sent: Wednesday, December 13, 2017 3:07 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Wang, Fan ; Wu, > Jiaxin > Subject: [edk2] [Patch] MdeModulePkg/

Re: [edk2] [Patch] MdeModulePkg/IpIoLib: Check the input parameters before use them.

2017-12-21 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu, > Siyuan > Sent: Wednesday, December 13, 2017 4:07 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Wang, Fan ; Wu, > Jiaxin > Subject: [edk2] [Patch] MdeModulePkg/I

Re: [edk2] [Patch] MdeModulePkg/Ip4Dxe: Remove redundant code in Ip4Config2InitInstance().

2017-12-21 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu, Siyuan Sent: Wednesday, December 13, 2017 10:24 AM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Wang, Fan ; Wu, Jiaxin Subject: [edk2] [Patch] MdeModulePkg/Ip4Dxe: Remove r

Re: [edk2] [RFC] MdeModulePkg/PciHostBridge: Add address translation support

2017-12-21 Thread Ard Biesheuvel
On 21 December 2017 at 08:27, Guo Heyi wrote: > On Wed, Dec 20, 2017 at 03:26:45PM +, Ard Biesheuvel wrote: >> On 20 December 2017 at 15:17, gary guo wrote: >> > On Wed, Dec 20, 2017 at 09:13:58AM +, Ard Biesheuvel wrote: >> >> Hi Heyi, >> >> >> >> On 20 December 2017 at 08:21, Heyi Guo

Re: [edk2] [RFC] MdeModulePkg/PciHostBridge: Add address translation support

2017-12-21 Thread Guo Heyi
On Wed, Dec 20, 2017 at 03:26:45PM +, Ard Biesheuvel wrote: > On 20 December 2017 at 15:17, gary guo wrote: > > On Wed, Dec 20, 2017 at 09:13:58AM +, Ard Biesheuvel wrote: > >> Hi Heyi, > >> > >> On 20 December 2017 at 08:21, Heyi Guo wrote: > >> > PCIe on some ARM platforms requires addr

Re: [edk2] [Patch 00/14] Enable Structure PCD support in edk2

2017-12-21 Thread Gao, Liming
Star: Thanks for your comments. I will update the patches and send new version for review. >-Original Message- >From: Zeng, Star >Sent: Thursday, December 21, 2017 3:16 PM >To: Gao, Liming ; edk2-devel@lists.01.org >Cc: Zhu, Yonghong ; Zeng, Star > >Subject: RE: [Patch 00/14] Enable St

Re: [edk2] [Patch] MdeModulePkg/SnpDxe: Check the value of Nii->Id before use it directly.

2017-12-21 Thread Wu, Jiaxin
Thanks to catch that. The UNDI is started by SNP driver. Then, Nii->Id changes to the none-zero value. But currently, UNDI seems not follow that. > -Original Message- > From: Fu, Siyuan > Sent: Thursday, December 21, 2017 3:39 PM > To: Wu, Jiaxin ; edk2-devel@lists.01.org > Cc: Wang,

Re: [edk2] [Patch] CryptoPkg/TlsLib: Add some parameter check and clarification.

2017-12-21 Thread Long, Qin
Reviewed-by: Long Qin Best Regards & Thanks, LONG, Qin -Original Message- From: Wu, Jiaxin Sent: Thursday, December 21, 2017 1:17 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Long, Qin ; Fu, Siyuan ; Wu, Jiaxin Subject: [Patch] CryptoPkg/TlsLib: Add some parameter check and clarific