Re: [edk2] [Patch] MdeModulePkg PCD: Add more debug message to show SkuId update

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Gao, Liming Sent: Tuesday, February 27, 2018 1:38 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [Patch] MdeModulePkg PCD: Add more debug message to show SkuId update

Re: [edk2] [Patch] MdeModulePkg PCD: Fix the issue to set the big SkuId

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Tuesday, February 27, 2018 1:37 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [edk2] [Patch]

Re: [edk2] [RFC] Add Platform Include path in modules

Hi Laszlo/Michael, Thanks for your feedback on this proposal. I looked at the structured PCDs and UEFI Platform Initialization Distribution Packaging Specification. Here is my take on these. 1. structured PCDs are good if we want to declare single complex structure. But consider a case

[edk2] [PATCH] BaseTools: Fix report not used --pcd value incorrectly

Argument --pcd gUefiOvmfPkgTokenSpaceGuid.test10=H"{1}", If the PCD is not used, report value {0x01, 0x00}, is incorrect. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yunhua Feng

Re: [edk2] [Patch] BaseTools:Override the MAKE_FLAGS by BuildOptions in DSC

Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Saturday, February 24, 2018 9:54 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools:Override the

[edk2] [patch 1/2] BaseTool/VfrCompile: make delete[] match with new[]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=764 Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- BaseTools/Source/C/VfrCompile/VfrCompiler.cpp | 14

[edk2] [patch 2/2] BaseTool/VfrCompile: Fix potential memory leak issue

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=771 Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp | 4 1

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

On 2/27/2018 8:48 AM, Guo Heyi wrote: Hi Laszlo, I agree the current patch makes the code ugly, and turning the logic into a normal loop should be the perfect solution. If Ray also agrees on it, I can try to do that. Thanks and regards, Heyi On Mon, Feb 26, 2018 at 05:23:29PM +0100, Laszlo

[edk2] [Patch] MdeModulePkg PCD: Add more debug message to show SkuId update

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Star Zeng --- MdeModulePkg/Universal/PCD/Dxe/Pcd.c | 6 +- MdeModulePkg/Universal/PCD/Pei/Pcd.c | 6 +- 2 files changed, 10 insertions(+), 2 deletions(-)

[edk2] [Patch] MdeModulePkg PCD: Fix the issue to set the big SkuId

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Star Zeng --- MdeModulePkg/Universal/PCD/Dxe/Service.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/PCD/Dxe/Service.c

Re: [edk2] [Patch] EmulatorPkg: Undefine CR3 macro in Host.h

Reviewed-by: Jordan Justen On 2018-02-22 22:22:18, Liming Gao wrote: > CR3 has been used as structure field name in BaseLib IA32_TASK_STATE_SEGMENT. > Undefine CR3 to make sure there is no conflict to it. > > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2] [RFC v1 1/1] MdeModulePkg/Usb: Use Pcd for UsbBootIoBlocks

I don't prefer to add PCD, unless we cannot find: 1. spec content to describe the max/min blocks 2. error handling when the blocks number is bigger than HW expects. Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ming Huang >

[edk2] [PATCH] UefiCpuPkg/CpuExceptionHandlerLib: fix incorrect init of exception stack

The field KnownGoodStackTop in CPU_EXCEPTION_INIT_DATA is initialized to the start address of array mNewStack. This is wrong. It must be the end of mNewStack. This patch fixes this mistake. Cc: Ruiyu Ni Cc: Eric Dong Cc: Laszlo Ersek

Re: [edk2] [PATCH v2 0/2] Update memory test driver to handle more reliable memory

Reviewed-by: Liming Gao Please add the bugzilar link in commit log. >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Ruiyu Ni >Sent: Saturday, February 10, 2018 10:41 PM >To: edk2-devel@lists.01.org >Subject: [edk2]

Re: [edk2] [Patch] NetworkPkg/HttpDxe: Support HTTP Delete Method.

Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Tuesday, February 27, 2018 11:53 AM > To: edk2-devel@lists.01.org > Cc: Karunakar P ; Ye, Ting ; > Fu, Siyuan ; Wu, Jiaxin

[edk2] [Patch] NetworkPkg/HttpDxe: Support HTTP Delete Method.

Per the request to support HttpMethodDelete: https://bugzilla.tianocore.org/show_bug.cgi?id=879, This patch is to enable the HTTP Delete Method. Cc: Karunakar P Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

Hi Heyi, Thanks for looking into my suggestion. You already mentioned the value I thought. :) The value is to get better boot performance by setting the MAX_RECONNECT_REPAIR to a smaller number. 10 times reconnect may be suitable for consumer products like laptop. However, it may be not

Re: [edk2] [RFC v3 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

Hi Laszlo, Just a note that comment [6] has not been fully applied in my RFC v4, that I didn't touch the outer ALIGN_VALUE() yet. As you said, it is an independent issue and I think it can be fixed before or after my proposed change. I can do something after Ray comments on it. Regards, Heyi

[edk2] [RFC v4 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

PCI address translation is necessary for some non-x86 platforms. On such platforms, address value (denoted as "device address" or "address in PCI view") set to PCI BAR registers in configuration space might be different from the address which is used by CPU to access the registers in memory BAR or

[edk2] [RFC v4 0/3] Add translation support to generic PciHostBridge

Please note: this is still *RFC* version, so we have not gone thru all the code in EDK2 for applying the change of PciSegmentLib definition. v4: - Modify the code according to the comments from Ray, Laszlo and Ard (Please see the notes of Patch 1/3) - Ignore translation of bus in

[edk2] [RFC v4 3/3] MdeModulePkg/PciBus: return CPU address for GetBarAttributes

According to UEFI spec 2.7, PciIo->GetBarAttributes should return host address (CPU view ddress) rather than device address (PCI view address), and device address = host address + address translation offset, so we subtract translation from device address before returning. Contributed-under:

[edk2] [RFC v4 2/3] MdeModulePkg/PciBus: convert host address to device address

According to UEFI spec 2.7, PciRootBridgeIo->Configuration() should return host address (CPU view ddress) rather than device address (PCI view address), so in function GetMmioAddressTranslationOffset we need to convert the range to device address before comparing. And device address = host

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

Hi Ard, Sorry for the late of seeing this patch. I have one question: why don't we implement a runtime serial port lib, which will switch UART base address in virtual address map change? I think this will be useful when we want to debug runtime driver in OS stage. And if we have a runtime version

[edk2] [patch v2] MdePkg/BaseSafeIntLib: Fix VS2015 IA32 NOOPT build failure

v2: Add [LibraryClasses] section in INF file and refine coding style. There are VS2015 NOOPT IA32 build failure like below in BaseSafeIntLib. XXX.lib(XXX.obj): error LNK2001: unresolved external symbol __allmul XXX.lib(XXX.obj): error LNK2001: unresolved external symbol __allshl XXX.lib(XXX.obj):

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

Hi Laszlo, I agree the current patch makes the code ugly, and turning the logic into a normal loop should be the perfect solution. If Ray also agrees on it, I can try to do that. Thanks and regards, Heyi On Mon, Feb 26, 2018 at 05:23:29PM +0100, Laszlo Ersek wrote: > On 02/26/18 09:29, Heyi

Re: [edk2] [RFC] Add Platform Include path in modules

Hi Pankaj, I agree with Laszlo that you should evaluate use of PCDs. There are a few methods for a driver to use platform specific values/behavior. These are: * PCDs * Library class/Library Instance * Protocol/PPI One issue with the proposal is that it adds a hidden dependency to modules.

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

On 02/26/18 09:29, Heyi Guo wrote: > Function BmRepairAllControllers may recursively call itself if some > driver health protocol returns EfiDriverHealthStatusReconnectRequired. > However, driver health protocol of some buggy third party driver may > always return such status even after one and

Re: [edk2] [RFC] Add Platform Include path in modules

On 02/26/18 11:55, Pankaj Bansal wrote: > Hi, > > Consider a simple driver which needs that some data structures be > filled by the Platform, which is using the driver. > > Driver.c #include > > Struct a = platformVal; > > We can define platformVal in Platform.h, which would be unique to the

Re: [edk2] [patch] MdePkg/BaseSafeIntLib: Fix VS2015 IA32 NOOPT build failure

On 02/26/18 07:22, Dandan Bi wrote: > There are VS2015 NOOPT IA32 build failure like below in BaseSafeIntLib. > XXX.lib(XXX.obj): error LNK2001: unresolved external symbol __allmul > XXX.lib(XXX.obj): error LNK2001: unresolved external symbol __allshl > XXX.lib(XXX.obj): error LNK2001: unresolved

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On 02/24/18 15:25, Ard Biesheuvel wrote: > Commit 4bf95a9f361e ("MdeModulePkg/ResetSystemRuntimeDxe: Add more > debug message") broke the DEBUG build for all platforms that rely on > MMIO mapped UART devices, since it introduces a DEBUG() print that > may trigger at runtime, at which such UART

[edk2] [PATCH] MdePkg/Include/IndustryStandard: Add PCI Express 4.0 header file

The header includes Physical Layer PCI Express Extended Capability definitions described in section 7.7.5 of PCI Express Base Specification rev. 4.0. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Felix Polyudov ---

[edk2] [RFC v2] Add Platform Include path in modules

When we are writing the drivers for IP modules, then sometimes we want that Platform specific customizations or platform dependent values be supplied to IP module driver. normally we achieve this using Pcd values. But sometimes we want to use header files for such data.e.g. if the values are

[edk2] [PATCH] BaseTools: Fix flexible PCD single quote and double quote bugs

1. Argument --pcd format as below: Some examples that to match --pcd format and DSC format --pcd DSC format L"ABC"L"ABC" "AB\\\"C" "AB\"C" "AB\tC" "AB\tC" "AB\\\'C"

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

Hi Sunny, I didn't consider it as a value necessary for platform override, for the retry count should only have some impact on boot performance and it only happens when there is something wrong. May I know what value you will use for your platform and why? Thanks and regards, Gary (Heyi Guo)

Re: [edk2] [RFC] Add Platform Include path in modules

Hi, Consider a simple driver which needs that some data structures be filled by the Platform, which is using the driver. Driver.c #include Struct a = platformVal; We can define platformVal in Platform.h, which would be unique to the platform being built. This Platform.h can be placed in

Re: [edk2] [PATCH 7/7] ovmf: add DxeTpm2MeasureBootLib

On 02/23/18 14:23, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The library registers a security management handler, to measure images > that are not measure in PEI phase. > > This seems to work for example with the qemu PXE rom: > > Loading driver

Re: [edk2] [PATCH 6/7] ovmf: link with Tcg2ConfigDxe module

On 02/23/18 14:23, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The module allows to tweak and interact with the TPM. Note that many > actions are broken due to implementation of qemu TPM (providing it's > own ACPI table), and the lack of PPI

Re: [edk2] [PATCH 5/7] ovmf: link with Tcg2Dxe module

On 02/23/18 14:23, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This module measures and log the boot environment. It also produces > the Tcg2 protocol, which allows for example to read the log from OS: > > [0.00] efi: EFI v2.70 by EDK II

Re: [edk2] [PATCH 4/7] ovmf: link with Tcg2Pei module

On 02/23/18 14:23, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This module will initialize TPM device, measure reported FVs and BIOS > version. > > CC: Laszlo Ersek > CC: Stefan Berger >

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

Hi Heyi, Just a suggestion. Is it better to use a PCD instead of a define for MAX_RECONNECT_REPAIR? So that we can easily override it in our platform dsc file. Regards, Sunny Wang -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent:

[edk2] [PATCH] EmbeddedPkg/Drivers: add virtual keyboard driver

The virtual keyboard could simulate a keyboard. User could simulate a key value when pattern is matched. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang --- .../Drivers/VirtualKeyboardDxe/ComponentName.c | 184

[edk2] [platform][PATCH 2/4] Platform/Hisilicon/HiKey960: enable virtual keyboard

Enable virtual keyboard on HiKey960 platform. The platform driver read pattern from memory or GPIO pin. When the value is matched, it simulates a hotkey that is used to adjust sequence of boot options. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang

[edk2] [platform][PATCH 4/4] Platform/Hisilicon/HiKey: enable virtual keyboard

Enable virtual keyboard driver on HiKey platform. The platform driver reads pattern from memory or GPIO pin. When the value is matched, it simulates a key value that is used to adjust the sequence of boot options. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian

[edk2] [platform][PATCH 3/4] Platform/Hisilicon/HiKey: add gpio platform driver

Add gpio platform driver to enable GPIO in HiKey platform. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang --- .../Hisilicon/HiKey/HiKeyGpioDxe/HiKeyGpioDxe.c| 68 ++

[edk2] [platform][PATCH 0/4] enable virtual keyboard

Changelog: v1: * Enable GPIO driver. * Enable virtual keyboard driver. Haojian Zhuang (4): Platform/Hisilicon/HiKey960: add gpio platform driver Platform/Hisilicon/HiKey960: enable virtual keyboard Platform/Hisilicon/HiKey: add gpio platform driver Platform/Hisilicon/HiKey: enable

[edk2] [platform][PATCH 1/4] Platform/Hisilicon/HiKey960: add gpio platform driver

Add gpio platform driver to enable GPIO in HiKey960 platform. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang --- Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 + Platform/Hisilicon/HiKey960/HiKey960.fdf | 1 +

[edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

Function BmRepairAllControllers may recursively call itself if some driver health protocol returns EfiDriverHealthStatusReconnectRequired. However, driver health protocol of some buggy third party driver may always return such status even after one and another reconnect. The endless iteration will

[edk2] [Patch V3] DSC spec: Add flexible PCD value format into spec

V3: Update the Pcd value format in [Components] section V2: update EBNF for Array format. Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong