Re: [edk2] [PATCH v1 17/18] StandaloneMmPkg: Add application to test MM communication protocol.

2018-04-30 Thread Achin Gupta
Hi Supreeth, I agree with Jiewen that these should not be a part of this series. Can you push these in a separate series? cheers, Achin On Fri, Apr 06, 2018 at 03:42:22PM +0100, Supreeth Venkatesh wrote: > This patch adds a simple application that uses the MM > communication protocol to pass a c

Re: [edk2] [PATCH v1 16/18] BaseTools/AutoGen: Update header file for MM modules.

2018-04-30 Thread Achin Gupta
Hi Supreeth, CIL. On Fri, Apr 06, 2018 at 03:42:21PM +0100, Supreeth Venkatesh wrote: > This patch corrects the Module Type Header file for Management Mode(MM) > as specified in PI v1.6 Specification. Also, it updates parameter for > auto generated template functions from EFI_SMM_SYSTEM_TABLE2 to

Re: [edk2] [PATCH v1 15/18] ArmPkg: Extra action to update permissions for S-ELO MM Image.

2018-04-30 Thread Achin Gupta
Hi Supreeth, This file was originally contributed by Ard a while back so worth poking him and Leif for review. If MM is expected to be the only use case of this library then it might make sense to pull in under the StandaloneMmPkg instead of relying on PcdStandaloneMmEnable. Cheers, Achin On Fri

Re: [edk2] [PATCH v1 14/18] StandaloneMmPkg: Describe the declaration, definition and fdf files.

2018-04-30 Thread Achin Gupta
Hi Supreeth, One CIL. On Fri, Apr 06, 2018 at 03:42:19PM +0100, Supreeth Venkatesh wrote: > This patch describes the package declarations, definitions and firmware > device files for creating standalone management mode image with > core/foundation and drivers. > > Contributed-under: TianoCore Co

Re: [edk2] [PATCH v2 1/1] EmbeddedPkg/Drivers: add virtual keyboard driver

2018-04-30 Thread Leif Lindholm
On Thu, Mar 08, 2018 at 09:34:48PM +0800, Haojian Zhuang wrote: > This driver is used to simulate a keyboard. For example, user > could read GPIO setting or data from RAM address. If the value > matches the expected pattern, it could trigger a key pressed > event. > > User needs to implement hooks

[edk2] [PATCH edk2-platforms v1] Platform/ARM: Map Platform Boot Timeout PCD to global NV variable

2018-04-30 Thread Alexei Fedorov
From: Alexei Fedorov Table 13 of UEFI Specification 2.7A describes Timeout global variable as NV (non-volatile), however gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut is defined in [PcdsFixedAtBuild.common] section of edk2-platforms\Platform\ARM\VExpressPkg\ArmVExpress.dsc.inc. This prevents Ti

Re: [edk2] [PATCH v1] MdeModulePkg/Bus: Enable ascending resource list

2018-04-30 Thread Roman Bacik
On Sat, Apr 28, 2018 at 11:53 AM, Roman Bacik wrote: > Enable resource list sorted in ascending order required by some SoCs. > > Cc: Vladimir Olovyannikov > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Roman Bacik > --- > MdeModulePkg/Bus/Pci/PciBusD

Re: [edk2] [PATCH v1 12/18] StandaloneMmPkg/CpuMm: Add CPU driver suitable for ARM Platforms.

2018-04-30 Thread Achin Gupta
Hi Supreeth, Usual comment about copyright years and invalid comments. I also noticed some TODOs and have provided comments for them. Please see inline On Fri, Apr 06, 2018 at 03:42:17PM +0100, Supreeth Venkatesh wrote: > This patch adds a simple CPU driver that exports the > EFI_MM_CONFIGURATION

Re: [edk2] [PATCH] [PATCH v1] MdeModulePkg/Core: Fix MaxAddress in Gcd

2018-04-30 Thread Roman Bacik
Will change subject to: "[edk2] [PATCH v2] MdeModulePkg/Core: Fix MaxAddress in Gcd" for the next version if required. On Fri, Apr 27, 2018 at 3:36 PM, Roman Bacik wrote: > When BottomUp search is used the MaxAddress is incorrectly chosen to > be BaseAddress instead of EndAddress. > > Contribute

Re: [edk2] [PATCH v2] BaseTools/VolInfo: Update EFI FV FILETYPES for new MM types.

2018-04-30 Thread Yao, Jiewen
Thanks. Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ezra > Godfrey > Sent: Monday, April 30, 2018 7:34 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v2] BaseTools/VolInfo: Update EFI FV FILETYP

[edk2] [PATCH v2] BaseTools/VolInfo: Update EFI FV FILETYPES for new MM types.

2018-04-30 Thread Ezra Godfrey
Add support for the following types to VolInfo: EFI_FV_FILETYPE_MM_STANDALONE EFI_FV_FILETYPE_MM_CORE_STANDALONE Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ezra Godfrey --- BaseTools/Source/C/VolInfo/VolInfo.c | 8 1 file changed, 8 insertions(+) diff --

Re: [edk2] [PATCH v1 11/18] StandaloneMmPkg: MM driver entry point library.

2018-04-30 Thread Achin Gupta
Hi Supreeth, Some of the DXE references will have to be removed and copyright years need to be updated. If that sounds reasonable then.. Acked-by: Achin Gupta cheers, Achin On Fri, Apr 06, 2018 at 03:42:16PM +0100, Supreeth Venkatesh wrote: > This patch implements module entry point library fo

Re: [edk2] [PATCH] BaseTools/VolInfo: Add the EFI_FV_FILETYPE_MM_STANDALONE file type.

2018-04-30 Thread egodfrey . qdt
Hey Jiewen, Yes I will update this for the MM_CORE_STANDALONE as well. Thanks, Ezra -Original Message- From: Yao, Jiewen Sent: Friday, April 27, 2018 5:05 PM To: egodfrey.qdt ; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH] BaseTools/VolInfo: Add the EFI_FV_FILETYPE_MM_STANDALONE

Re: [edk2] [PATCH v1] ArmPkg: Fix bug in Generic Waitchdog driver

2018-04-30 Thread Ard Biesheuvel
On 27 April 2018 at 15:58, AlexeiFedorov wrote: > In ArmPkg\Drivers\GenericWatchdogDxe\GenericWatchdogDxe.c > the following functions > WatchdogWriteOffsetRegister(); > WatchdogWriteCompareRegister(); > WatchdogEnable(); > WatchdogDisable(); > provide write access to ARM Generic Watchdog registers

Re: [edk2] [PATCH] ArmVirtPkg: use protocol-based DevicePathLib instance for most DXE modules

2018-04-30 Thread Laszlo Ersek
On 04/24/18 08:16, Ard Biesheuvel wrote: > On 24 April 2018 at 02:50, Laszlo Ersek wrote: >> Port OvmfPkg commit 5c3481b0b611e to ArmVirtPkg. Some explanation should >> be in order (because 5c3481b0b611e doesn't offer any): >> >> - The UefiDevicePathLibDevicePathProtocol instance uses the Device P

Re: [edk2] [PATCH edk2-platforms v7 0/2] add platform boot options

2018-04-30 Thread Laszlo Ersek
On 04/28/18 07:41, Haojian Zhuang wrote: > Changelog: > v7: > * Fix memory leakage on DevicePath. > v6: > * Remove redundant definition -- "GRUB_FILE_NAME". > v5: > * Avoid to merge device path and grub's file path in driver. > Merge them directly in DSC file. > * Avoid duplicated code