Even though MMIO shares the address space with ordinary memory, the
accesses involved are *not* ordinary memory accesses, and so it is
a bad idea to let the compiler generate them using pointer dereferences.
Instead, introduce a set of internal accessors implemented in assembler,
and call those fr
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
Cc: Yonghong Zhu
---
2_fdf_design_discussion/21_processing_overview.md | 1 +
2_fdf_design_discussion/22_flash_description_file_format.md | 6 +++---
2_fdf_design_discussion/24_[fd]_sections.md
According to VTd spec, Software writes the value read from this
field (F) to Clear it. But current code is using 0 to clear the
field, that is incorrect.
And R_FSTS_REG register value clearing should be not in the for loop.
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.1
S
Remove -T, -P, -h flags in the help info of DP to
align with current code implementation.
Cc: Liming Gao
Cc: Ruiyu Ni
Cc: Jaben Carsey
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi
---
ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni | 4 +---
1 file changed,
Issue:
When run "dp -s" or ("dp -v") command in shell several times,
the summary reuslts are different each time.
The root cause is that the previous global data "SummaryData"
is not cleaned when the dp command is callled next time.
This patch initializes the global data "SummaryData"
when the dp
Run dp command now:
Firstly it will get performance records from FPDT and then
parse the DP command. And if encounter invalid parameters,
it will exit directly. Thus the performance records got before
are invalid. And what's worse is that the memory allocated in
getting performance records phase is
ECC tool report some coding style issue in UefiShellAcpiViewCommandLib.
This patch series is to clean these issues.
Cc: Sami Mujawar
Cc: Evan Lloyd
Cc: Sami Mujawar
Cc: Evan Lloyd
Cc: Jaben Carsey
Cc: Ruiyu Ni
Dandan Bi (2):
ShellPkg/UefiShellAcpiViewCommandLib: Fix ECC issues
ShellPkg/
Make the function comments follow EDK2 coding style.
Cc: Sami Mujawar
Cc: Evan Lloyd
Cc: Sami Mujawar
Cc: Evan Lloyd
Cc: Jaben Carsey
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 130 +
1. Separate variable definition and initialization.
2. Make the variable naming following Edk2 rule.
Naming convention of local variable:
a.First character should be upper case.
b.Must contain lower case characters.
c.No white space characters.
Cc: Sami Mujawar
Cc: Evan Lloyd
Cc: Sami Mujawar
C
Make the comment align with Edk2 coding style.
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi
---
.../DisplayUpdateProgressLibGraphics.c | 6 +++---
.../DisplayUpdateProgressLibText/DisplayUpdateProgress
Reviewed-by: Star Zeng
-Original Message-
From: Bi, Dandan
Sent: Tuesday, June 5, 2018 4:36 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [patch] MdeModulePkg/DisplayUpdateProgressLib: Fix ECC issues
Make the comment align with Edk2 coding style.
Cc: Star Zeng
C
On Tue, Jun 05, 2018 at 09:30:04AM +0200, Ard Biesheuvel wrote:
> Even though MMIO shares the address space with ordinary memory, the
> accesses involved are *not* ordinary memory accesses, and so it is
> a bad idea to let the compiler generate them using pointer dereferences.
>
> Instead, introdu
On 06/05/18 09:30, Ard Biesheuvel wrote:
> Even though MMIO shares the address space with ordinary memory, the
> accesses involved are *not* ordinary memory accesses, and so it is
> a bad idea to let the compiler generate them using pointer dereferences.
I think I slightly disagree with the wordin
On Tue, Jun 5, 2018 at 1:00 PM, Ard Biesheuvel
wrote:
> Even though MMIO shares the address space with ordinary memory, the
> accesses involved are *not* ordinary memory accesses, and so it is
> a bad idea to let the compiler generate them using pointer dereferences.
>
> Instead, introduce a set o
Hello Ting,
1. We did not enable MPIO.
2. in IScsiStart(), at this point
//
// Select the first login session. Abort others.
//
if (Private->Session == NULL) {
Private->Session = Session;
BootSelected = AttemptConfigData->AttemptConfigIndex;
//
// Don't validat
Hi Dandan Bi,
Your patch contains a number of modifications like the one below:
-#ifndef ACPIPARSER_H_
-#define ACPIPARSER_H_
+#ifndef __ACPIPARSER_H__
+#define __ACPIPARSER_H__
which violate CCS
"3.3.2 Include Files"
"4.3.5.4 The names of guard macros shall end with an underscore character.
Hi Chao and Jiewen,
There are new fields in TPM2 ACPI table for getting TCG event log under OS.
https://trustedcomputinggroup.org/wp-content/uploads/TCG_ACPIGeneralSpecification_v1.20_r8.pdf
Page 11.
Log Area Minimum Length (LAML)
Log Area Start Address (LASA)
I remember they are not existed in
On 5 June 2018 at 10:39, Leif Lindholm wrote:
> On Tue, Jun 05, 2018 at 09:30:04AM +0200, Ard Biesheuvel wrote:
>> Even though MMIO shares the address space with ordinary memory, the
>> accesses involved are *not* ordinary memory accesses, and so it is
>> a bad idea to let the compiler generate th
KVM on ARM refuses to decode load/store instructions used to perform
I/O to emulated devices, and instead relies on the exception syndrome
information to describe the operand register, access size, etc.
This is only possible for instructions that have a single input/output
register (as opposed to o
On Tue, Jun 05, 2018 at 01:05:43PM +0200, Ard Biesheuvel wrote:
> KVM on ARM refuses to decode load/store instructions used to perform
> I/O to emulated devices, and instead relies on the exception syndrome
> information to describe the operand register, access size, etc.
> This is only possible fo
This patch includes, ArmPlatformClock in PL011 lib.
In case of NULL implemenation of Clock Lib, Pcd
value will be used for PL011 frequency.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Udit Kumar
---
ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c | 7
Some platform support dynamic clocking, Which is controlled
by some jumper setting or hardware registers.
Result of that PCD PL011UartClkInHz needs to be updated for
frequency change.
This patch implements support for dynamic frequency for
PL011 uart.
This patch implement NULL lib for such platform
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Meenakshi Aggarwal
---
Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 +
Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 +
Platform/Hisilicon/D05/D05.dsc | 2 ++
Hi,
My team is developing a board booting Linux from an on-board eMMC,
and we find that EmmcReadWrite() debug print is too verbose for INFO level.
//
https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c#L904
DEBUG ((EFI_D_INFO, "Emmc%a(): Part %d Lba .
On Mon, Jun 04, 2018 at 09:13:45PM +0200, Ard Biesheuvel wrote:
> On 4 June 2018 at 21:08, Leif Lindholm wrote:
> > On Mon, Jun 04, 2018 at 08:53:53PM +0200, Marcin Wojtas wrote:
> >> 2018-06-04 19:46 GMT+02:00 Leif Lindholm :
> >> >> diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8kCapsule.fdf
Dear Ladies and Gentlemen,
We invite you to the Open Source Firmware Conference 2018
( www.osfc.io ) which takes place at the 12th - 15th September
in Erlangen, Germany.
The OSFC 2018 is the first conference focusing exclusively on Open
Source firmware.
Therefore, our mission is to provide an app
2018-06-05 13:59 GMT+02:00 Leif Lindholm :
> On Mon, Jun 04, 2018 at 09:13:45PM +0200, Ard Biesheuvel wrote:
>> On 4 June 2018 at 21:08, Leif Lindholm wrote:
>> > On Mon, Jun 04, 2018 at 08:53:53PM +0200, Marcin Wojtas wrote:
>> >> 2018-06-04 19:46 GMT+02:00 Leif Lindholm :
>> >> >> diff --git a/S
On 5 June 2018 at 13:45, wrote:
> Hi,
>
> My team is developing a board booting Linux from an on-board eMMC,
> and we find that EmmcReadWrite() debug print is too verbose for INFO level.
>
> //
> https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c#L904
>
On Mon, Jun 04, 2018 at 06:44:33PM +0530, Thomas Abraham wrote:
> On Fri, Jun 1, 2018 at 3:04 AM, Leif Lindholm
> wrote:
> > On Wed, May 23, 2018 at 02:51:34PM +0100, AlexeiFedorov wrote:
> >> From: Alexei Fedorov
> >>
> >> Programming Reference for Base FVPs describes 2 Generic Memory-mapped
>
1. Add a Common PCD rules section to introduce 1)the *B, *F, *P, *M's
meaning, 2) the PCD display order, 3) both display hex value and
integer for UINT* type PCD.
2. Update some items to match with code, eg: UEFI Spec Version
3. Update some typo, eg: Fv Name.
Cc: Liming Gao
Cc: Michael Kinney
Cc
On 5 June 2018 at 01:35, Udit Kumar wrote:
> Some platform support dynamic clocking, Which is controlled
> by some jumper setting or hardware registers.
> Result of that PCD PL011UartClkInHz needs to be updated for
> frequency change.
> This patch implements support for dynamic frequency for
> PL0
On 5 June 2018 at 01:35, Udit Kumar wrote:
> This patch includes, ArmPlatformClock in PL011 lib.
>
> In case of NULL implemenation of Clock Lib, Pcd
> value will be used for PL011 frequency.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Udit Kumar
> ---
> ArmPlatfo
On 5 June 2018 at 14:23, Ard Biesheuvel wrote:
> On 5 June 2018 at 01:35, Udit Kumar wrote:
>> Some platform support dynamic clocking, Which is controlled
>> by some jumper setting or hardware registers.
>> Result of that PCD PL011UartClkInHz needs to be updated for
>> frequency change.
>> This p
Please see my comment in-lined
> -Original Message-
> From: edk2-devel On Behalf Of Udit Kumar
> Sent: 05 June 2018 00:36
> To: edk2-devel@lists.01.org; ard.biesheu...@linaro.org;
> leif.lindh...@linaro.org
> Subject: [edk2] [PATCH 1/2] ArmPlatformPkg: PL011 Dynamic clock freq Support
>
>
Hi Mike,
Yes, build tool will return error code when build break. This is the document
patch to add '!error' statement.
Best Regards,
Zhu Yonghong
-Original Message-
From: Kinney, Michael D
Sent: Tuesday, June 05, 2018 4:06 AM
To: Zhu, Yonghong ; edk2-devel@lists.01.org; Kinney,
Micha
From: Yunhua Feng
If the PCD's datum type is UINT8, UINT16, UINT32 or UINT64, then in
the report will display both hexadecimal format and integer format
of PCD value.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng
---
BaseTo
On 06/05/18 13:05, Ard Biesheuvel wrote:
> KVM on ARM refuses to decode load/store instructions used to perform
> I/O to emulated devices, and instead relies on the exception syndrome
> information to describe the operand register, access size, etc.
> This is only possible for instructions that hav
Thanks to fix it.
Reviewed by: jiewen@intel.com
thank you!
Yao, Jiewen
> 在 2018年6月5日，上午1:07，Zeng, Star 写道：
>
> According to VTd spec, Software writes the value read from this
> field (F) to Clear it. But current code is using 0 to clear the
> field, that is incorrect.
>
> And R_FSTS_REG
On Mon, Apr 23, 2018 at 10:15:41PM +0200, Laszlo Ersek wrote:
> On 04/23/18 08:21, Haojian Zhuang wrote:
> > Changelog:
> > v4:
> > * Add BootCount parameter in the interface.
> > * Clean the logic on boot options according to Laszlo's comment.
> > v3:
> > * Update the name of interface.
> >
Thanks Haoijian,
Series Reviewed-by: Leif Lindholm
Pushed as 9bb89f3323..da3e09e28d.
On Mon, Jun 04, 2018 at 01:44:36PM +0800, Haojian Zhuang wrote:
> Changelog:
> v8:
> * Rebase for virtual keyboard driver.
> v7:
> * Fix memory leakage on DevicePath.
> v6:
> * Remove redundant definition
Yes, if you want this feature, you may file a Bugzilla to track it.
https://bugzilla.tianocore.org/
Thank you
Yao Jiewen
From: Lin, Derek (HPS UEFI Dev) [mailto:derek.l...@hpe.com]
Sent: Tuesday, June 5, 2018 2:55 AM
To: Zhang, Chao B ; Yao, Jiewen
Cc: edk2-devel@lists.01.org; Spottswood, Jason
On Mon, Jun 04, 2018 at 10:01:44PM +0530, Meenakshi Aggarwal wrote:
> This patch add function EfiTimeToWday() which returns
> day of the week.
> It is needed by our upcoming patches in edk2-platforms.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Vabhav Sharma
> Sig
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Tuesday, June 5, 2018 5:54 PM
> To: Udit Kumar
> Cc: edk2-devel@lists.01.org; Leif Lindholm
> Subject: Re: [edk2][PATCH 1/2] ArmPlatformPkg: PL011 Dynamic clock freq
> Support
>
> On 5 June 2018 at
Thanks Ard,
I accept all of your comments, I will take care in v2
Regards
Udit
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Tuesday, June 5, 2018 5:55 PM
> To: Udit Kumar
> Cc: edk2-devel@lists.01.org; Leif Lindholm
> Subject: Re: [edk2][PATCH
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Tuesday, June 5, 2018 5:56 PM
> To: Udit Kumar
> Cc: edk2-devel@lists.01.org; Leif Lindholm
> Subject: Re: [edk2][PATCH 1/2] ArmPlatformPkg: PL011 Dynamic clock freq
> Support
>
> On 5 June 2018 at
> -Original Message-
> From: Alexei Fedorov [mailto:alexei.fedo...@arm.com]
> Sent: Tuesday, June 5, 2018 6:01 PM
> To: Udit Kumar ; edk2-devel@lists.01.org;
> ard.biesheu...@linaro.org; leif.lindh...@linaro.org
> Subject: RE: [edk2] [PATCH 1/2] ArmPlatformPkg: PL011 Dynamic clock freq
>
Any updates on this patch?
Do you require to know my "default value of IER"?
Thanks,
Leo.
-Original Message-
From: edk2-devel On Behalf Of Duran, Leo
Sent: Friday, May 25, 2018 8:38 AM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
Subject: Re: [edk2] [PATCH] MdeM
It will be better to have the information that may could be added into the
commit message.
1. Did you meet real issue without this patch?
2. what is the default value of IER in your case?
Thanks,
Star
-Original Message-
From: Duran, Leo [mailto:leo.du...@amd.com]
Sent: Wednesday, June
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong
Zhu
Sent: Tuesday, June 05, 2018 8:37 PM
To: edk2-devel@lists.01.org
Cc: Feng, YunhuaX ; Gao, Liming
Subject: [edk2] [Patch] BaseT
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong
Zhu
Sent: Tuesday, June 05, 2018 1:31 PM
To: edk2-devel@lists.01.org
Cc: Feng, YunhuaX ; Gao, Liming
Subject: [edk2] [Patch] BaseToo
Hi Star,
I came across a 16550 model (simulation) which required clearing IER, and it
seems that's allowed in the 16650 spec, as noted here:
http://www.ti.com/lit/ds/symlink/pc16550d.pdf
8.4.2 FIFO Polled Mode Operation
With FCR0=1 resetting IER0, IER1, IER2, IER3 or all to zero puts the UART in
Hi Alexei,
Current in the Edk2 implementation, the guard macros in the include header
files start with underscore and end with underscore. And the number of
underscore usually used here is one or two.
And the check tool (ECC) also follow above rule to do the check. So it will
report error for
Jim,
I think the problem you're seeing is that the USB keyboard driver you're using
is downrev and needs to be updated.
If you look at
https://github.com/tianocore/edk2/commit/dd190645eb43424706eb1709d0032c69a1935d9f
there was a fix checked in to address exactly the issue you're running into.
Some platform support dynamic clocking, Which is controlled
by some jumper setting or hardware registers.
Result of that PCD PL011UartClkInHz needs to be updated for
frequency change.
This patch implements support for dynamic frequency for
PL011 uart.
This patch implements default lib, which is usi
[v2]
Incorporated review comments of v1
Udit Kumar (2):
ArmPlatformPkg: PL011 Dynamic clock freq Support
ArmPlatformPkg: Include PL011UartClock Lib
ArmPlatformPkg/ArmPlatformPkg.dec | 1 +
ArmPlatformPkg/Include/Library/PL011UartClockLib.h | 32 +++
.../P
This patch includes, PL011UartClock lib.
In case of no implemenation of this Clock Lib,
Pcd value will be used for PL011 frequency.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Udit Kumar
---
ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c | 5 +++--
A
[v2]
Updated name of clock lib
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Meenakshi Aggarwal
---
Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 +
Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 +
Platform/Hisilicon/D05/D05.dsc
57 matches
Mail list logo
