Re: [edk2] Reg: Intel Rangley Support in EDK

2018-07-17 Thread You, Benjamin
Hi, Dhanasekar, Linux boot parameters allow specifying serial baudrate. An example would be: earlycon=uart8250,mmio32,0x,115200n81 console=ttyS2,115200 Please make sure the serial device info (including MMIO or I/O address and the device name) matches your platform in above settings.

[edk2] [Patch v2] UefiCpuPkg/MpInitLib: Optimize get processor number performance.

2018-07-17 Thread Eric Dong
Current function has low performance because it calls GetApicId many times. New logic call GetApicId once and base on this value to search the processor. V2 changes: Rollback V1 change which base on stack info to get AP index because this solution may return error AP index if stack buffer

[edk2] UefiCpuPkg/MpInitLib: Fix S3 resume hang issue.

2018-07-17 Thread Eric Dong
When resume from S3 and CPU loop mode is MWait mode, if driver calls APs to do task at EndOfPei point, the APs can't been wake up and bios hang at that point. The root cause is PiSmmCpuDxeSmm driver wakes up APs with HLT mode during S3 resume phase to do SMM relocation. After this task,

Re: [edk2] [PATCH 1/1] MdeModulePkg/PciBusDxe: Fix small memory leak in FreePciDevice

2018-07-17 Thread Ni, Ruiyu
On 7/3/2018 11:32 PM, Thomas Palmer wrote: When cleaning the PciIoDevice, also free the BusNumberRange Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas Palmer --- MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.c | 5 + 1 file changed, 5 insertions(+) diff

Re: [edk2] [Patch] BaseTools: Remove the duplicate Pcd items

2018-07-17 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Tuesday, July 17, 2018 10:04 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools: Remove the duplicate Pcd items > > The case is

Re: [edk2] 答复: [Patch] UefiCpuPkg/MpInitLib: Optimize get processor number performance.

2018-07-17 Thread Dong, Eric
Hi All, As stack maybe overflow in some case and it will caused error AP index been returned. Also I don't find any register will be used different in each Aps. So I will update my patch to only base on APIC ID to get the AP. Thanks, Eric > -Original Message- > From: edk2-devel

Re: [edk2] [PATCH v1] ShellPkg: add UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc

2018-07-17 Thread Ni, Ruiyu
On 7/17/2018 6:59 PM, AlexeiFedorov wrote: This patch adds UefiShellAcpiViewCommandLib INF file into [Components] section of ShellPkg.dsc so this library can be built in ShellPkg level build. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Alexei Fedorov --- All the

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix incorrect check of SMM mode

2018-07-17 Thread Wang, Jian J
Hi Laszlo, Regards, Jian > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, July 17, 2018 10:37 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Yao, Jiewen ; > Zeng, Star > Subject: Re: [PATCH] UefiCpuPkg/CpuDxe: fix incorrect

Re: [edk2] [Patch v3 0/3] Optimize load uCode performance

2018-07-17 Thread Dong, Eric
Hi Laszlo, > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Wednesday, July 18, 2018 12:38 AM > To: Dong, Eric > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [Patch v3 0/3] Optimize load uCode performance > > Hi

Re: [edk2] [Patch v3 3/3] UefiCpuPkg/MpInitLib: Load uCode once for each core.

2018-07-17 Thread Dong, Eric
Hi Laszlo & Ray, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, July 17, 2018 10:07 PM > To: Ni, Ruiyu ; Dong, Eric > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [Patch v3 3/3] UefiCpuPkg/MpInitLib: Load uCode once for > each core. > > On

Re: [edk2] [Patch v3 0/3] Optimize load uCode performance

2018-07-17 Thread Laszlo Ersek
On 07/17/18 18:38, Laszlo Ersek wrote: > Hi Eric, > > On 07/16/18 05:08, Eric Dong wrote: >> Use below three rules to optimize load uCode performance: >> 1. Let BSP relocate uCode from flash to memory for better performance. >> 2. BSP caches the CPU ID and address of uCode so AP doesn’t need to

Re: [edk2] [Patch v3 0/3] Optimize load uCode performance

2018-07-17 Thread Laszlo Ersek
Hi Eric, On 07/16/18 05:08, Eric Dong wrote: > Use below three rules to optimize load uCode performance: > 1. Let BSP relocate uCode from flash to memory for better performance. > 2. BSP caches the CPU ID and address of uCode so AP doesn’t need to look >for the uCode again if the CPU ID is

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix incorrect check of SMM mode

2018-07-17 Thread Laszlo Ersek
On 07/13/18 07:53, Jian J Wang wrote: > Current IsInSmm() method makes use of gEfiSmmBase2ProtocolGuid.InSmm() to > check if current processor is in SMM mode or not. But this is not correct > because gEfiSmmBase2ProtocolGuid.InSmm() can only detect if the caller is > running in SMRAM or from SMM

Re: [edk2] [Patch v3 3/3] UefiCpuPkg/MpInitLib: Load uCode once for each core.

2018-07-17 Thread Laszlo Ersek
On 07/17/18 12:02, Ni, Ruiyu wrote: > On 7/16/2018 11:08 AM, Eric Dong wrote: >> GetProcessorLocationByApicId (GetInitialApicId (), NULL, NULL, >> ); >> +  if (ThreadId != 0) { >> +    // >> +    // Skip loading microcode if it is not the first thread in one core. >> +    // >> +    return; >> + 

Re: [edk2] [PATCH 0/2] ArmVirtPkg/ArmVirtQemu: enable the IPv6 stack

2018-07-17 Thread Laszlo Ersek
On 07/13/18 08:45, Ard Biesheuvel wrote: > On 13 July 2018 at 01:41, Laszlo Ersek wrote: >> Repo: https://github.com/lersek/edk2.git >> Branch: armvirt_ipv6_bz1007 >> >> Tested the "-D NETWORK_IP6_ENABLE" ArmVirtQemu build with PXEv4, PXEv6, >> HTTPv4, HTTPv6 netboot. >> >> Build-tested the

Re: [edk2] Reg: Intel Rangley Support in EDK

2018-07-17 Thread Dhanasekar Jaganathan
Hi Nate, Ben, After changing Windows -> Translation = CP437 in Putty, I can able to see proper Shell and BIOS setup. After Grub, I am not seeing OS installation Process. I have changed Kernal Parameters too. May Linux Server Installation(via serial) use different character setting or baud

[edk2] [PATCH v1] ShellPkg: add UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc

2018-07-17 Thread AlexeiFedorov
This patch adds UefiShellAcpiViewCommandLib INF file into [Components] section of ShellPkg.dsc so this library can be built in ShellPkg level build. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Alexei Fedorov --- All the changes can be reviewed at

Re: [edk2] [Patch v3 3/3] UefiCpuPkg/MpInitLib: Load uCode once for each core.

2018-07-17 Thread Ni, Ruiyu
On 7/16/2018 11:08 AM, Eric Dong wrote: GetProcessorLocationByApicId (GetInitialApicId (), NULL, NULL, ); + if (ThreadId != 0) { +// +// Skip loading microcode if it is not the first thread in one core. +// +return; + } + Eric, Is it possible that Thread#0 is disabled while

Re: [edk2] [Patch v3 1/3] UefiCpuPkg/MpInitLib: Relocate uCode to memory to save time.

2018-07-17 Thread Ni, Ruiyu
On 7/16/2018 11:08 AM, Eric Dong wrote: Read uCode from memory has better performance than from flash. But it needs extra effort to let BSP copy uCode from flash to memory. Also BSP already enable cache in SEC phase, so it use less time to relocate uCode from flash to memory. After verification,

Re: [edk2] [Patch v3 2/3] UefiCpuPkg/MpInitLib: Use BSP uCode for APs if possible.

2018-07-17 Thread Ni, Ruiyu
On 7/16/2018 11:08 AM, Eric Dong wrote: + + if (IsBspCallIn && (LatestRevision != 0)) { +CpuMpData->ProcessorSignature = Eax.Uint32; +CpuMpData->ProcessorFlags = ProcessorFlags; +CpuMpData->MicrocodeDataAddress = (UINTN) MicrocodeData; +CpuMpData->MicrocodeRevision =

[edk2] [Patch][edk2-platforms/devel-IntelAtomProcessorE3900] Enable VT-d DMA remapping for DMA protection.

2018-07-17 Thread zwei4
(1) Add VT-d modules into FDF file. (2) Add Setup option and configuration policy for pre-boot VT-d enabling. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: David Wei CC: Mang Guo --- .../Common/Include/Guid/SetupVariable.h| 4 ++-