Re: [edk2] [PATCH] BaseTools: Update build report for StructurePcd value

2018-07-26 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Thursday, July 26, 2018 9:07 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [PATCH] BaseTools: Update buil

Re: [edk2] [PATCH] BaseTools: Fix build crash when fdf is empty file

2018-07-26 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Thursday, July 26, 2018 11:19 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [PATCH] BaseTools: Fix build c

Re: [edk2] Reg: Intel Rangley Support in EDK

2018-07-26 Thread Dhanasekar Jaganathan
Hi Jiewen/Chasel, I am working in Intel Rangeley Micor server. I am trying to use to FSP 1.0 binary in latest EDK 2 open source. Is it possible to integrate FSP binary in EDK 2 source?. If so, Can you please me to build EDK2 source with FSP binary and provide me the steps?. FYI, I have booted mi

[edk2] [Patch] IntelFrameworkModulePkg SmmRuntimeDxeReportStatusCodeLib: Add missing EFIAPI

2018-07-26 Thread Liming Gao
https://bugzilla.tianocore.org/show_bug.cgi?id=1059 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Steven Shi --- .../SmmRuntimeDxeReportStatusCodeLibFramework/SmmRuntimeDxeSupport.c | 1 + 1 file changed, 1 insertion(+) diff --git a/IntelFrameworkMo

[edk2] [Patch] IntelFrameworkModulePkg IsaSerialDxe: Update algorithm to calculate Divisor

2018-07-26 Thread Liming Gao
To align the way in MdeModulePkg SerialPortLib and PciSioSerialDxe driver, Divisor is added by one when the reminder is more than half (16 * BaudRate). Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Ruiyu Ni --- IntelFrameworkModulePkg/Bus/Isa/IsaSerialDxe

Re: [edk2] Reg: Intel Rangley Support in EDK

2018-07-26 Thread You, Benjamin
Hi Dhanasekar, You can check out Maintainers.txt in the root directory of the EDK2 tree for a list of maintainers for each package. For FSP related packages, you can consult following folks: Jiewen Yao Chasel Chiu Thanks, - ben > From: Dhanasekar Jaganathan [mailto:jdhanasekar...@gmail.c

Re: [edk2] Reg: Intel Rangley Support in EDK

2018-07-26 Thread Dhanasekar Jaganathan
Hi Ben, Thanks for sharing. I am unable to find owners of FSP. Where Can I get those details ?. Thanks, Dhanasekar On Fri, Jul 27, 2018 at 6:15 AM, You, Benjamin wrote: > Hi Dhanasekar, > > Here is a link: > https://firmware.intel.com/sites/default/files/resources/ > A_Tour_Beyond_BIOS_Using_t

[edk2] [Patch] SecurityPkg: HashLib: Add SHA384, SHA512 HashLib

2018-07-26 Thread Zhang, Chao B
Add SHA384, 512 Hash lib support. Now only CryptoPkg support PEI/DXE version. Cc: Long Qin Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chao Zhang Signed-off-by: Zhang, Chao B --- SecurityPkg/Include/Library/HashLib.h | 2 +- .../HashInstanceLibSha384/H

Re: [edk2] [PATCH 0/6] CapsuleApp: Some enhancements

2018-07-26 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng > Sent: Friday, July 13, 2018 5:09 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Yao, Jiewen > ; Zeng, Star > Subject: [edk2] [PATCH 0/6

Re: [edk2] [PATCH] MdeModulePkg DxeCapsuleLibFmp: Refine the code to check FmpImageSize.

2018-07-26 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng > Sent: Thursday, July 26, 2018 3:30 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zeng, Star > Subject: [edk2] [PATCH] MdeModulePkg DxeCapsul

Re: [edk2] FFS Alignment and the FDF Specification

2018-07-26 Thread Zhu, Yonghong
How about get the doc from https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Draft-Specification ? This is current latest. Or https://edk2-docs.gitbooks.io/edk-ii-fdf-specification/content/v/release/1.28.01/ , this is the one match with UDK2018. And current latest BaseTools it s

Re: [edk2] FFS Alignment and the FDF Specification

2018-07-26 Thread Tim Lewis
1.28. 2.5.6 says: Alignment - Data (value is one of: 1, 2 4, 8, 16, 32, 64 128, 512, 1K, 2K, 4K, 8K, 16K,32K, 64K) byte aligned The grammar 3.2.1 says: ::= {"Auto"} {"8"} {"16"} {"32"} {"64"} {"128"}{"512"} {"1K"} {"4K"} {"32K"} {"64K"} This is the version from the EDK2 specs page. -Orig

Re: [edk2] [PATCH 1/1] MdeModulePkg/PciBusDxe: Fix small memory leak in FreePciDevice

2018-07-26 Thread Zeng, Star
Reviewed-by: Star Zeng and pushed the patch at 07eba7069d4c23e9b15caa1e729682a88ddf4ada. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, Ruiyu Sent: Wednesday, July 18, 2018 12:34 PM To: Thomas Palmer ; edk2-devel@lists.01.org Cc

Re: [edk2] [PATCH v1] MdeModulePkg: Fix memory leak in FvSimpleFileSystem driver

2018-07-26 Thread Zeng, Star
Reviewed-by: Star Zeng and pushed the patch at b5bd3ed64898db1088a9468446a0d2d0dc7185e8 with changing the title a little to " MdeModulePkg FvSimpleFileSystemDxe: Fix memory leak in Read function ". Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org]

Re: [edk2] FFS Alignment and the FDF Specification

2018-07-26 Thread Zhu, Yonghong
Which version of FDF spec you use now ? I remember current we already support 16M ffs alignment. FDF spec Version 1.28 have such info "Per PI 1.6 to extend FFS alignment to 16M". Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

[edk2] FFS Alignment and the FDF Specification

2018-07-26 Thread Tim Lewis
Is my understanding correct: the FDF specification only supports a maximum of 64KB alignment for files (section 2.5.6), but the PI specification supports (table 7), up to 16MB alignment. Or am I misreading it? Thanks, Tim -Original Message- From: edk2-devel On Behalf Of Andrew Fish Sent

Re: [edk2] Reg: Intel Rangley Support in EDK

2018-07-26 Thread You, Benjamin
Hi Dhanasekar, Here is a link: https://firmware.intel.com/sites/default/files/resources/A_Tour_Beyond_BIOS_Using_the_Intel_Firmware_Support_Package_Version_1_1_with_the_EFI_Developer_Kit_II.pdf You may also consult the owners of the FSP related packages in the EDK2 repo for any questions. Than

Re: [edk2] [PATCH 1/6] MdeModulePkg CapsuleApp: Fix VS2012 build failure caused by 5410502

2018-07-26 Thread Bi, Dandan
Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: Zeng, Star Sent: Thursday, July 26, 2018 6:17 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Yao, Jiewen ; Bi, Dandan Subject: [PATCH 1/6] MdeModulePkg CapsuleApp: Fix VS2012 build failure caused by 5410502 The build fa

Re: [edk2] [PATCH v1] MdeModulePkg: Fix memory leak in FvSimpleFileSystem driver

2018-07-26 Thread Ard Biesheuvel
(add maintainers) On 25 July 2018 at 21:47, Vladimir Olovyannikov wrote: > FvSimpleFileSystem on read always allocates a FileBuffer, and never frees > it. This causes memory leaks. It is especially bad for reading scripts > line-by-line. In some cases memory leak can exceed 1GB. > > Contributed-u

[edk2] [PATCH] BaseTools: Update build report for StructurePcd value

2018-07-26 Thread Yonghong Zhu
From: Yunhua Feng Update build report to display the structure Pcd value that from FDF file. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yunhua Feng --- BaseTools/Source/Python/build/BuildReport.py | 14 -- 1 file changed

Re: [edk2] [PATCH 0/5] CapsuleApp: Some enhancements

2018-07-26 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Thursday, July 26, 2018 6:17 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > ; Yao, Jiewen ; Zhu, > Yonghong > Subject: [PATCH 0/5] CapsuleApp: Some enhancements > > V2: Last patch i

Re: [edk2] Reg: Intel Rangley Support in EDK

2018-07-26 Thread Dhanasekar Jaganathan
Hi Nate, Ben, Can you please provide me the steps to integrate FSP with latest EDK2 source ?. I didnt get clear steps from net (seems steps are compatible with latest source). Which are the changes I have to do in latest EDK2 source and in which location I have to copy FSP binary ?. My FSP ver

[edk2] [PATCH 3/6] MdeModulePkg CapsuleApp: Refine -N option help information

2018-07-26 Thread Star Zeng
-N option is used to append a Capsule Header to an existing FMP capsule image with its ImageTypeId supported by the system. Cc: Michael D Kinney Cc: Jiewen Yao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdeModulePkg/Application/Capsul

[edk2] [PATCH 4/6] MdeModulePkg CapsuleApp: Index need be decimal for -P GET option

2018-07-26 Thread Star Zeng
Also adjust the help information to be not too long to be suitable for different display resolutions. Cc: Michael D Kinney Cc: Jiewen Yao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 13

[edk2] [PATCH 6/6] MdeModulePkg CapsuleApp: Check capsule header for -D and -N options

2018-07-26 Thread Star Zeng
Then meaningful error message can be shown when the input image is unexpected. Cc: Michael D Kinney Cc: Jiewen Yao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 101 ++--

[edk2] [PATCH 5/6] MdeModulePkg CapsuleApp: Prompt info for -C option

2018-07-26 Thread Star Zeng
Cc: Michael D Kinney Cc: Jiewen Yao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 17 + MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 2 +- 2 files changed, 14 ins

[edk2] [PATCH 1/6] MdeModulePkg CapsuleApp: Fix VS2012 build failure caused by 5410502

2018-07-26 Thread Star Zeng
The build failure is like below. xxx\CapsuleApp.c(868) : error C2275: 'EFI_GUID' : illegal use of this type as an expression xxx/UefiBaseType.h(29) : see declaration of 'EFI_GUID' xxx\CapsuleApp.c(868) : error C2146: syntax error : missing ';' before identifier 'ImageTypeId' xxx\Capsule

[edk2] [PATCH 2/6] MdeModulePkg CapsuleApp: Fix -D failed to dump Nest FMP capsule

2018-07-26 Thread Star Zeng
Cc: Michael D Kinney Cc: Jiewen Yao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Application/CapsuleApp/Ca

[edk2] [PATCH 0/5] CapsuleApp: Some enhancements

2018-07-26 Thread Star Zeng
V2: Last patch is new added. Cc: Michael D Kinney Cc: Jiewen Yao Cc: Yonghong Zhu Star Zeng (6): MdeModulePkg CapsuleApp: Fix VS2012 build failure caused by 5410502 MdeModulePkg CapsuleApp: Fix -D failed to dump Nest FMP capsule MdeModulePkg CapsuleApp: Refine -N option help information

Re: [edk2] [PATCH] MdeModulePkg: Remove redundant library classes and guides in inf files

2018-07-26 Thread Laszlo Ersek
On 07/26/18 03:57, shenglei wrote: > Some redundant libraray classes and guides have been removed in inf files. The typos in the commit message should please be corrected when the patch is pushed: - libraray -> library - guides -> GUIDs (this was really confusing for a second) Thanks! Laszlo >

Re: [edk2] [PATCH edk2-platforms v2 1/1] Silicon/SynQuacer: add optional OP-TEE DT node

2018-07-26 Thread Sumit Garg
On Thu, 26 Jul 2018 at 13:20, Daniel Thompson wrote: > > On Thu, Jul 26, 2018 at 09:39:37AM +0200, Ard Biesheuvel wrote: > > On 26 July 2018 at 09:36, Daniel Thompson > > wrote: > > > On Wed, Jul 25, 2018 at 12:04:58PM +0200, Ard Biesheuvel wrote: > > >> On 23 July 2018 at 15:19, Sumit Garg wro

Re: [edk2] [Patch v3 3/3] UefiCpuPkg/MpInitLib: Not use disabled AP when call StartAllAPs.

2018-07-26 Thread Ni, Ruiyu
> +if (GetApState (CpuData) == CpuStateDisabled && !WakeUpDisabledAps) { > + continue; > +} > + > CpuData->ApFunction = (UINTN) Procedure; > CpuData->ApFunctionArgument = (UINTN) ProcedureArgument; > SetApState (CpuData, CpuStateReady); E

Re: [edk2] [Patch v3 3/3] UefiCpuPkg/MpInitLib: Not use disabled AP when call StartAllAPs.

2018-07-26 Thread Ni, Ruiyu
With that, Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, July 26, 2018 4:36 PM > To: Dong, Eric ; edk2-devel@lists.01.org > Cc: Laszlo Ersek > Subject: RE: [Patch v3 3/3] UefiCpuPkg/MpInitLib: Not use disabled AP when > call > StartAllAPs. >

Re: [edk2] [PATCH edk2-platforms v2 1/1] Silicon/SynQuacer: add optional OP-TEE DT node

2018-07-26 Thread Daniel Thompson
On Thu, Jul 26, 2018 at 09:39:37AM +0200, Ard Biesheuvel wrote: > On 26 July 2018 at 09:36, Daniel Thompson wrote: > > On Wed, Jul 25, 2018 at 12:04:58PM +0200, Ard Biesheuvel wrote: > >> On 23 July 2018 at 15:19, Sumit Garg wrote: > >> > OP-TEE is optional on Developerbox controlled via SCP firm

Re: [edk2] [PATCH edk2-platforms v2 1/1] Silicon/SynQuacer: add optional OP-TEE DT node

2018-07-26 Thread Ard Biesheuvel
On 26 July 2018 at 09:36, Daniel Thompson wrote: > On Wed, Jul 25, 2018 at 12:04:58PM +0200, Ard Biesheuvel wrote: >> On 23 July 2018 at 15:19, Sumit Garg wrote: >> > OP-TEE is optional on Developerbox controlled via SCP firmware. To check >> > if we need to delete OP-TEE DT node, we use DRAM1 re

Re: [edk2] [PATCH edk2-platforms v2 1/1] Silicon/SynQuacer: add optional OP-TEE DT node

2018-07-26 Thread Daniel Thompson
On Wed, Jul 25, 2018 at 12:04:58PM +0200, Ard Biesheuvel wrote: > On 23 July 2018 at 15:19, Sumit Garg wrote: > > OP-TEE is optional on Developerbox controlled via SCP firmware. To check > > if we need to delete OP-TEE DT node, we use DRAM1 region info as SCP > > firmware conditionally carves out

[edk2] [PATCH] MdeModulePkg DxeCapsuleLibFmp: Refine the code to check FmpImageSize.

2018-07-26 Thread Star Zeng
The code to check FmpImageSize again OFFSET_OF (EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER, UpdateHardwareInstance) can be refined to check against FmpImageHeaderSize. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdeModulePkg/Library/DxeC

[edk2] [platforms: PATCH v2 3/6] Marvell/Library: ComPhyLib: Configure RXAUI in ARM-TF

2018-07-26 Thread Marcin Wojtas
From: Grzegorz Jaszczyk Replace the comphy initialization for RXAUI with appropriate SMC call, so the ARM-TF will execute required serdes configuration. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Library/ComPhyLib/ComPhySipSvc.h |

[edk2] [platforms: PATCH v2 2/6] Marvell/Library: ComPhyLib: Configure PCIE in ARM-TF

2018-07-26 Thread Marcin Wojtas
From: Grzegorz Jaszczyk Replace the ComPhy initialization for PCIE with appropriate SMC call, so the ARM-TF will execute required serdes configuration. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/Library/Armada7k8kSampleA

[edk2] [platforms: PATCH v2 5/6] Marvell/Library: ComPhyLib: Remove both PHY and PIPE selector config

2018-07-26 Thread Marcin Wojtas
From: Grzegorz Jaszczyk Now the ComPhy configuration is handled in ARM-TF, therefore there is no need to configure PHY or PIPE selector in UEFI. Remove unused code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Library/ComPhyLib/ComPhy

[edk2] [platforms: PATCH v2 4/6] Marvell/Library: ComPhyLib: Configure USB in ARM-TF

2018-07-26 Thread Marcin Wojtas
From: Grzegorz Jaszczyk Replace the comphy initialization for USB with appropriate SMC call, so the ARM-TF will execute required serdes configuration. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Library/ComPhyLib/ComPhyCp110.c | 167

[edk2] [platforms: PATCH v2 6/6] Marvell/Library: ComPhyLib: Clean up the library after rework

2018-07-26 Thread Marcin Wojtas
From: Grzegorz Jaszczyk Because all ComPhy related initialization was moved to ARM-TF all register definitions and some related routines/structures became unused. This commit removes them. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/

[edk2] [platforms: PATCH v2 0/6] Armada7k8k ComPhy rework

2018-07-26 Thread Marcin Wojtas
Hi, The second version of the patchset brings minor corrections, that were pointed out during review. Details can be found int the commit logs. The patches are available in the github: https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/comphy-upstream-r20180726 I'm looking f

[edk2] [platforms: PATCH v2 1/6] Marvell/Library: ComPhyLib: Configure SATA, SGMII and SFI in ARM-TF

2018-07-26 Thread Marcin Wojtas
From: Grzegorz Jaszczyk Because it is now available to configure SerDes lanes via SiP services in the EL3, there is no need to maintain same code within UEFI. This patch reworks serdes for: SATA, SGMII, HS-SGMII and SFI interfaces. The next interfaces will be addressed in upcoming commits. Param