Re: [edk2] [Patch v4 1/5] UefiCpuPkg/PiSmmCpuDxeSmm: Use GDT/IDT saved in Smram.

2018-08-14 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of Eric Dong > Sent: Wednesday, August 15, 2018 10:15 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Laszlo Ersek > Subject: [edk2] [Patch v4 1/5] UefiCpuPkg/PiSmmCpuDxeSmm: Use GDT/IDT > saved in Sm

Re: [edk2] [Patch v4 3/5] UefiCpuPkg/CpuS3DataDxe: Change Memory Type and address limitation.

2018-08-14 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of Eric Dong > Sent: Wednesday, August 15, 2018 10:15 AM > To: edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Ni, Ruiyu > Subject: [edk2] [Patch v4 3/5] UefiCpuPkg/CpuS3DataDxe: Change Memory > Type and ad

[edk2] [Patch][edk2-platforms/devel-IntelAtomProcessorE3900] UP2 PCIe NIC.

2018-08-14 Thread zwei4
Disable PCIe root port 1 of UP2, which is connected to a onboard RealTek PCIe NIC. If this PCIe NIC is enabled, Windows 10 installation will fail. This patch is a temporary solution. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: David Wei CC: Mike Wu CC: Mang Guo ---

Re: [edk2] [PATCH edk2-platforms v1 07/38] Silicon/Hisilicon/D06: Wait for all disk ready

2018-08-14 Thread Ming
在 8/14/2018 11:26 PM, Leif Lindholm 写道: > On Fri, Aug 10, 2018 at 09:44:29AM +0800, Ming wrote: >>> Which is exactly what an event is for. >>> At the point where the SAS controller driver is currently updating the >>> variable, it can instead call SignalEvent (). >>> >>> The WaitForDiskReady () f

[edk2] [PATCH 1/1] OvmfPkg: link Sha384 and Sha512 support into Tcg2Pei and Tcg2Dxe

2018-08-14 Thread Gary Lin
Sha384 and Sha512 were added to HashInstanceLib recently. To make them available in Tcg2Pei and Tcg2Dxe, we have to link both libraries. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Laszlo Ersek Cc: Marc-André Lureau Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Gary Lin

Re: [edk2] [PATCH v1 0/2] add DwMmcHcDxe driver

2018-08-14 Thread Chris Co
> -Original Message- > From: Leif Lindholm > Sent: Tuesday, August 14, 2018 9:32 AM > To: Haojian Zhuang > Cc: edk2-devel@lists.01.org; Ard Biesheuvel ; > Chris Co > Subject: Re: [edk2][PATCH v1 0/2] add DwMmcHcDxe driver > > Haojian, > > This is kind of massive. > Is there any way it

Re: [edk2] [PATCH v2 02/27] MdeModulePkg UiApp: Remove redundant functions

2018-08-14 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Zhang, Shenglei > Sent: Wednesday, August 15, 2018 9:46 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Dong, Eric > Subject: [PATCH v2 02/27] MdeModulePkg UiApp: Remove redundant > functions > > The functions that are never called

Re: [edk2] [PATCH v2 22/27] MdeModulePkg HiiDatabaseDxe: Remove a redundant function

2018-08-14 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Zhang, Shenglei > Sent: Wednesday, August 15, 2018 9:46 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Dong, Eric > Subject: [PATCH v2 22/27] MdeModulePkg HiiDatabaseDxe: Remove a > redundant function > > The function GetStorageWi

[edk2] [Patch v4 5/5] UefiCpuPkg/RegisterCpuFeaturesLib: Combine implementation.

2018-08-14 Thread Eric Dong
V1 changes: > Current code logic can't confirm CpuS3DataDxe driver start before > CpuFeaturesDxe driver. So the assumption in CpuFeaturesDxe not valid. > Add implementation for AllocateAcpiCpuData function to remove this > assumption. V2 changes: > Because CpuS3Data memory will be copy to smram at

[edk2] [Patch v4 4/5] UefiCpuPkg/CpuS3DataDxe: Remove below 4G limitation.

2018-08-14 Thread Eric Dong
Because PrepareApStartupVector() stores StackAddress to "mExchangeInfo->StackStart" (which has type (VOID*)), and because "UefiCpuPkg/PiSmmCpuDxeSmm/X64/MpFuncs.nasm" reads the latter with: add edi, StackStartAddressLocation add rax, qword [edi] mov rsp, rax

[edk2] [Patch v4 3/5] UefiCpuPkg/CpuS3DataDxe: Change Memory Type and address limitation.

2018-08-14 Thread Eric Dong
Because CpuS3Data memory will be copy to smram at SmmReadyToLock point, the memory type no need to be ACPI NVS type, also the address not limit to below 4G. This change remove the limit of ACPI NVS memory type and below 4G. V4 Changes: 1. Create AllocateZeroPages and use it. It's easy to use than

[edk2] [Patch v4 2/5] UefiCpuPkg/AcpiCpuData.h: Remove AcpiNVS and Below 4G limitation.

2018-08-14 Thread Eric Dong
ACPI_CPU_DATA structure first introduced to save data in normal boot phase. Also this data will be used in S3 phase by one PEI driver. So in first phase, this data is been defined to use ACPI NVS memory type and must below 4G. Later in order to fix potential security issue, PiSmmCpuDxeSmm driver a

[edk2] [Patch v4 0/5] Change CpuS3Data memory type and address limitation

2018-08-14 Thread Eric Dong
Because CpuS3Data memory will be copy to smram at SmmReadToLock point by PiSmmCpuDxeSmm driver, the memory type no need to be ACPI NVS type, also the address not limit to below 4G. This change remove the limit of ACPI NVS memory type and below 4G. Cc: Marvin H user Cc: Fan Jeff Cc: Laszlo Ers

[edk2] [Patch v4 1/5] UefiCpuPkg/PiSmmCpuDxeSmm: Use GDT/IDT saved in Smram.

2018-08-14 Thread Eric Dong
Current implementation will copy GDT/IDT at SmmReadyToLock point from ACPI NVS memory to Smram. Later at S3 resume phase, it restore the memory saved in Smram to ACPI NVS. It can directly use GDT/IDT saved in Smram instead of restore the original ACPI NVS memory. This patch do this change. V4 chan

Re: [edk2] EDK II Stable Tag release edk2-stable201808 and quiet period starting today

2018-08-14 Thread Zhang, Chao B
Hi Laszlo: 8 667abfaf8a16 UefiCpuPkg: Removing ipf which is no longer supported from edk2. 9 df49a85dbcc6 CorebootModulePkg: Removing ipf from edk2. 10 04c7f9023ffe CorebootPayloadPkg: Removing ipf from edk2. 11 4fcb0d54584f NetworkPkg: Removing ipf which is no longer supported from

Re: [edk2] [PATCH v2 07/27] MdeModulePkg SdMmcPciHcDxe: Remove redundant functions

2018-08-14 Thread Wu, Hao A
Sorry for missing this patch previously. Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > shenglei > Sent: Wednesday, August 15, 2018 9:46 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Zeng, Sta

Re: [edk2] [PATCH 1/1] OvmfPkg: Resolve HashInstanceLibSha384 and HashInstanceLibSha512

2018-08-14 Thread Gary Lin
On Tue, Aug 14, 2018 at 06:37:51PM +0200, Laszlo Ersek wrote: > Hi Gary, > > (+ Marc-André) > > On 08/14/18 09:36, Gary Lin wrote: > > Sha384 and Sha512 were added to HashInstanceLib recently. Resolve those > > two libraries to enable SHA384 and SHA512 support in TPM. > > > > Cc: Ard Biesheuvel

[edk2] [PATCH v2 22/27] MdeModulePkg HiiDatabaseDxe: Remove a redundant function

2018-08-14 Thread shenglei
The function GetStorageWidth that is never called has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Star Zeng Reviewed-by: Laszlo Ersek --- .../Univers

[edk2] [PATCH v2 21/27] MdeModulePkg TerminalDxe: Remove a redundant function

2018-08-14 Thread shenglei
The function UnicodeFiFoGetKeyCount that is never called has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Ruiyu Ni Reviewed-by: Star Zeng Reviewed-by:

[edk2] [PATCH v2 27/27] MdeModulePkg UiApp: Remove a redundant function and a variable

2018-08-14 Thread shenglei
1.After the cleanup at "MdeModulePkg UiApp: Remove redundant functions", the function "IsResetReminderFeatureEnable()" and the variable "mFeaturerSwitch" become redundant so they have been removed. 2.Therefore, the "IF" expression has also been removed, whose judgment condition is "IsResetRem

[edk2] [PATCH v2 20/27] MdeModulePkg SdBlockIoPei: Remove a redundant function

2018-08-14 Thread shenglei
The function SdPeimUnlinkMemBlock that is never called has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 v2: Remove the comment that mentioned 'SdPeimUnlinkMemBlock' within function SdPeimFreeMemPool(). Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Ag

[edk2] [PATCH v2 19/27] MdeModulePkg EmmcBlockIoPei: Remove a redundant function

2018-08-14 Thread shenglei
The function EmmcPeimUnlinkMemBlock that is never called has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 v2: Remove the comment that mentioned 'EmmcPeimUnlinkMemBlock' within function EmmcPeimFreeMemPool(). Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribut

[edk2] [PATCH v2 26/27] MdeModulePkg SetupBrowserDxe: Remove a redundant function

2018-08-14 Thread shenglei
The function IsDevicePathExist that is never called has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- .../Universal/SetupBrowserDxe/IfrParse.c | 33 -

[edk2] [PATCH v2 17/27] MdeModulePkg PiSmmCore: Remove redundant functions

2018-08-14 Thread shenglei
The functions that are never called have been removed. They are IsImageInsideSmram,FindImageRecord,SmmRemoveImageRecord, SmmMemoryAttributesTableConsistencyCheck,DumpSmmMemoryMapEntry, SmmMemoryMapConsistencyCheckRange,SmmMemoryMapConsistencyCheck, DumpSmmMemoryMap,ClearGuardMapBit,SetGuardMapBit,A

[edk2] [PATCH v2 24/27] MdeModulePkg IScsiDxe: Remove a redundant function

2018-08-14 Thread shenglei
The function IScsiFindTcbByITT that is never called has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Laszlo Ersek --- .../Universal/Network/IScsiDxe/IS

[edk2] [PATCH v2 18/27] MdeModulePkg Ps2KeyboardDxe: Remove a redundant function

2018-08-14 Thread shenglei
The function DisableKeyboard that is never called has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Ruiyu Ni Reviewed-by: Laszlo Ersek Reviewed-by: Star

[edk2] [PATCH v2 25/27] MdeModulePkg Tcp4Dxe: Remove redundant functions

2018-08-14 Thread shenglei
The functions that are never called have been removed. They are SockRcvdErr,SockGroup and TcpPawsOK. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Laszlo Ersek --- ..

[edk2] [PATCH v2 16/27] MdeModulePkg Core/Dxe: Remove redundant functions

2018-08-14 Thread shenglei
The functions that are never called have been removed. They are ClearGuardMapBit,SetGuardMapBit,IsHeadGuard, IsTailGuard and CoreEfiNotAvailableYetArg0. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-

[edk2] [PATCH v2 23/27] MdeModulePkg Ip4Dxe: Remove a redundant function

2018-08-14 Thread shenglei
The function Ip4Config2OnDhcp4Event that is never called has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Laszlo Ersek --- .../Universal/Network/Ip4Dxe

[edk2] [PATCH v2 15/27] MdeModulePkg UsbBusPei: Remove redundant functions

2018-08-14 Thread shenglei
The functions that are never called have been removed. They are PeiHubSetHubFeature,IsPortConnectChange and PeiUsbClearDeviceFeature. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei R

[edk2] [PATCH v2 14/27] MdeModulePkg UsbBusDxe: Remove redundant functions

2018-08-14 Thread shenglei
The functions that are never called have been removed. They are UsbHubCtrlSetHubFeature,UsbHubCtrlResetTT,UsbHcReset, UsbHcAsyncIsochronousTransfer,UsbHcGetState,UsbHcSetState and UsbHcIsochronousTransfer. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contribute

[edk2] [PATCH v2 13/27] MdeModulePkg UsbBotPei: Remove redundant functions

2018-08-14 Thread shenglei
The functions that are never called have been removed. They are PeiUsbSetConfiguration,PeiUsbSetDeviceAddress, IsPortConnect,IsPortConnectChange,IsPortLowSpeedDeviceAttached and PeiUsbGetDescriptor. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under

[edk2] [PATCH v2 10/27] MdeModulePkg XhciPei: Remove redundant functions

2018-08-14 Thread shenglei
The functions that are never called have been removed. They are XhcPeiReadDoorBellReg and UsbHcUnlinkMemBlock. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Ruiyu Ni R

[edk2] [PATCH v2 11/27] MdeModulePkg UfsBlockIoPei: Remove redundant functions

2018-08-14 Thread shenglei
The functions that are never called have been removed. They are UfsPeimUnlinkMemBlock,UfsPeimRequestSense, UfsPeimInquiry,UfsRwAttributes,UfsClearFlag,UfsReadFlag and UfsFindAvailableSlotInTmrl. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 v2: Remove the comment that mentioned 'UfsPeimUnlin

[edk2] [PATCH v2 05/27] MdeModulePkg NvmExpressDxe: Remove redundant functions

2018-08-14 Thread shenglei
The functions that are never called have been removed. They are ReadNvmeAdminSubmissionQueueBaseAddress, ReadNvmeAdminCompletionQueueBaseAddress and ReadNvmeAdminQueueAttributes https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribut

[edk2] [PATCH v2 06/27] MdeModulePkg PciBusDxe: Remove redundant functions

2018-08-14 Thread shenglei
The functions that are never called have been removed. They are UpStreamBridgesAttributes and GetHpcPciAddressFromRootBridge. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-

[edk2] [PATCH v2 12/27] MdeModulePkg UfsPassThruDxe: Remove redundant functions

2018-08-14 Thread shenglei
The functions that are never called have been removed. They are UfsClearFlag and UfsFindAvailableSlotInTmrl. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Hao Wu Revie

[edk2] [PATCH v2 04/27] MdeModulePkg EhciDxe: Remove redundant functions

2018-08-14 Thread shenglei
The functions that are never called have been removed. They are EhcDumpRegs,EhcDisableAsyncSchd and EhcDisablePeriodSchd https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: L

[edk2] [PATCH v2 08/27] MdeModulePkg UhciPei: Remove redundant functions

2018-08-14 Thread shenglei
The functions that are never called have been removed. They are IoMmuFreeBuffer,DelinkMemoryBlock,IsMemoryBlockEmptied ,IsTDLinkPtrQHOrTD,GetCurrentFrameNumber,GetQHHorizontalLinkPtr and GetQHHorizontalValidorInvalid. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong

[edk2] [PATCH v2 09/27] MdeModulePkg XhciDxe: Remove redundant functions

2018-08-14 Thread shenglei
The functions that are never called have been removed. They are XhcReadDoorBellReg and XhcWriteOpReg16. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Ruiyu Ni Reviewed

[edk2] [PATCH v2 03/27] MdeModulePkg AtaAtapiPassThru: Remove redundant functions

2018-08-14 Thread shenglei
The functions that are never called have been removed. They are AhciCheckDeviceStatus,AhciPortReset,DRDYReady, DRDYReady2,WaitForBSYClear2 and AtaSoftReset. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 v2: DRDYReady, DRDYReady2, WaitForBSYClear2 and AtaSoftReset are added to the commit mess

[edk2] [PATCH v2 07/27] MdeModulePkg SdMmcPciHcDxe: Remove redundant functions

2018-08-14 Thread shenglei
The functions that are never called have been removed. They are SdCardGetCsd and SdCardGetScr. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/

[edk2] [PATCH v2 02/27] MdeModulePkg UiApp: Remove redundant functions

2018-08-14 Thread shenglei
The functions that are never called have been removed. They are EnableResetReminderFeature, DisableResetReminderFeature and DisableResetRequired. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH v2 00/27] MdeModulePkg Remove redundant functions

2018-08-14 Thread shenglei
https://bugzilla.tianocore.org/show_bug.cgi?id=1062 v2: 1.Fix typos in 18/27, 19/27, 20/27, 21/27, 22/27, 23/27 and 24/27. 2.Remove redundant comments in 11/27, 19/27 and 20/27. 3.Add four funcitions to the commit message in 03/27 4.Add a new patch 27/27. 5.Edit the commit message of 17/27. sheng

[edk2] [PATCH v2 01/27] MdeModulePkg CapsuleApp: Remove a redundant function

2018-08-14 Thread shenglei
The function DumpImageAuthentication that is never called has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Star Zeng --- .../Application/CapsuleApp/Cap

Re: [edk2] [PATCH] NetworkPkg: Remove the redundant code and definition.

2018-08-14 Thread Wu, Jiaxin
Looks good to me. Reviewed-by: Jiaxin Wu > -Original Message- > From: Li, Songpeng > Sent: Monday, August 13, 2018 10:45 AM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin ; Fu, Siyuan > Subject: [PATCH] NetworkPkg: Remove the redundant code and definition. > > Cc: Jiaxin Wu > Cc: Si

Re: [edk2] DxeIpl module cannot find DXE entry point

2018-08-14 Thread Zeng, Star
You may try report the FVMAIN_COMPACT with the way like below. Then PeiCore's FvInfo notification will decompress the FVMAIN_COMPACT and build FV HOB for decompressed FVMAIN for DXE phase. FvInfo is the standard way, FvHob is produce for DXE phase. PeiCore only processes FvHob when PcdFramework

Re: [edk2] question about uefi calling convention

2018-08-14 Thread krishnaLee
thank you,Laszlo. krishna. At 2018-08-14 21:54:03, "Laszlo Ersek" wrote: >On 08/14/18 11:09, krishnaLee wrote: >> Hi, >> In uefi 2.6 specification -> 2.3.4 x64 Platforms, >> "Paging mode is enabled and any memory space defined by the UEFI memory map >> is identity mapped (virtual addres

Re: [edk2] EDK II Stable Tag release edk2-stable201808 and quiet period starting today

2018-08-14 Thread Kinney, Michael D
Laszlo, Thank you for this valuable feedback on the commit activity in the quiet period. I agree with your analysis. Bugzillas should have been entered for all of these changes and discussed on the mailing list and approved before commit. We will learn from this experience and apply it as we co

Re: [edk2] [PATCH edk2/MdePkg v1 1/1] MdePkg Cper.h: Add generic error macros for ARM platform

2018-08-14 Thread Kinney, Michael D
Leif, I have no objections to this commit being made before the edk2 stable tag. I see a Bugzilla for this topic as well: https://bugzilla.tianocore.org/show_bug.cgi?id=1087 I have updated the Bugzilla approving this change for edk2-stable201808. Thanks, Mike > -Original Message- >

Re: [edk2] [Patch 0/4] Vlv2TbltDevicePkg: Add FmpDevicePkg support

2018-08-14 Thread Kinney, Michael D
Hi Laszlo, I should have entered a Bugzilla for this item so I could clearly document why this is required before the stable tag and sent email to edk2-devel to inform everyone that this Bugzilla should be considered for the stable tag release to give the community a chance to vote if it should b

Re: [edk2] [PATCH edk2/MdePkg v1 1/1] MdePkg Cper.h: Add generic error macros for ARM platform

2018-08-14 Thread Leif Lindholm
On Sun, Aug 12, 2018 at 10:01:48PM +0800, Ming Huang wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang Mike, Liming. Could we merge this during the quiet period? It's basically an omission - these are defined since (at least) UEFI 2.6. > --- > MdePkg/I

Re: [edk2] [PATCH 1/1] OvmfPkg: Resolve HashInstanceLibSha384 and HashInstanceLibSha512

2018-08-14 Thread Laszlo Ersek
Hi Gary, (+ Marc-André) On 08/14/18 09:36, Gary Lin wrote: > Sha384 and Sha512 were added to HashInstanceLib recently. Resolve those > two libraries to enable SHA384 and SHA512 support in TPM. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Laszlo Ersek > Contributed-under: TianoCore Contrib

Re: [edk2] [PATCH v1 0/2] add DwMmcHcDxe driver

2018-08-14 Thread Leif Lindholm
Haojian, This is kind of massive. Is there any way it could be broken into more patches? The NonDiscoverableDeviceDxe patch is OK, but the changes to DwMmcHcDxe are gargantuan. Chris - does any of this turn into something you could use for your platforms? / Leis On Fri, Aug 10, 2018 at 04:4

Re: [edk2] [PATCH v1 edk-platforms 0/2] Fix missing PL011UartClockLib

2018-08-14 Thread Leif Lindholm
Hi Haojian, On Thu, Aug 09, 2018 at 10:45:04AM +0800, Haojian Zhuang wrote: > Fix build failure by appending PL011UartClockLib I don't think these patches are required. Commit 1160c702c24f ("Platform: Add PL011UartClockLib resolution to all PL011UartLib users") added this resolution to Silicon/H

Re: [edk2] [PATCH edk2-platforms v1 22/38] Platform/Hisilicon/D06: Add OemNicLib

2018-08-14 Thread Leif Lindholm
On Tue, Aug 14, 2018 at 10:38:14AM +0800, Ming wrote: > > > 在 8/9/2018 6:19 PM, Leif Lindholm 写道: > > On Thu, Aug 09, 2018 at 02:16:49PM +0800, Ming wrote: > +UINT16 crc_tab[256] = { > >>> > >>> CrcTable. > >> > >> Modify it in v2. > >> > >>> Hmm. > >>> This might be useful to add to a core

Re: [edk2] [PATCH edk2-platforms v1 27/38] Platform/Hisilicon/D06: Add EarlyConfigPeim peim

2018-08-14 Thread Leif Lindholm
On Tue, Aug 14, 2018 at 10:31:02AM +0800, Ming wrote: > >>> That { goes at the end of the previous line. > >>> > +StartupAp (); > >>> > >>> Hmm. At some point, we want to rename that function, to align with my > >>> comments above. > >> > > As this function is use in several platforms, if

Re: [edk2] [PATCH edk2-platforms v1 30/38] Hisilicon/D06: add apei driver

2018-08-14 Thread Leif Lindholm
On Fri, Aug 10, 2018 at 10:46:34AM +0800, Ming wrote: > >> --- /dev/null > >> +++ b/Silicon/Hisilicon/Hi1620/Drivers/Apei/Apei.inf > >> +[sources.common] > >> + Apei.c > > > > Apei.h? > > As Apei.h is included by Apei.c, so I think Apei.h > is no need to add here. Will the build system still g

Re: [edk2] [PATCH edk2-platforms v1 07/38] Silicon/Hisilicon/D06: Wait for all disk ready

2018-08-14 Thread Leif Lindholm
On Fri, Aug 10, 2018 at 09:44:29AM +0800, Ming wrote: > > Which is exactly what an event is for. > > At the point where the SAS controller driver is currently updating the > > variable, it can instead call SignalEvent (). > > > > The WaitForDiskReady () function can be changed to wait/check for th

Re: [edk2] [PATCH] NetworkPkg: Remove the redundant code and definition.

2018-08-14 Thread Laszlo Ersek
On 08/13/18 04:45, Songpeng Li wrote: > Cc: Jiaxin Wu > Cc: Siyuan Fu > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1064 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Songpeng Li > --- > NetworkPkg/IScsiDxe/IScsiDxe.inf | 1 - > NetworkPkg/IScsiDxe/IScs

Re: [edk2] EDK II Stable Tag release edk2-stable201808 and quiet period starting today

2018-08-14 Thread Laszlo Ersek
On 08/08/18 16:16, Kinney, Michael D wrote: > Hello, > > I sent an RFC for review on EDK II stable tags. > > https://lists.01.org/pipermail/edk2-devel/2018-June/026474.html > > There were no objections and we would like to move forward > with the an EDK II Stable Tag release. The original goal was

Re: [edk2] [Patch 0/4] Vlv2TbltDevicePkg: Add FmpDevicePkg support

2018-08-14 Thread Laszlo Ersek
Hi, On 08/10/18 08:25, Guo, Mang wrote: > Reviewed-by: Guo Mang please consider the diffstat on this patch set: > 28 files changed, 2032 insertions(+), 252 deletions(-) May I ask why this patch set has been committed during the quiet period, before the upcoming stable tag? See "[edk2] EDK II

Re: [edk2] [Patch V2] BaseTools: Clean up not used code in BuildClassObject

2018-08-14 Thread Carsey, Jaben
I believe that we should try to move more towards specific imports rather than import * or entire modules. I would therefore prefer we do the OrderedDict change in the other direction and remove the collections.OrderedDict items. That being said, opinions... The code is still better with this

Re: [edk2] Question about SecurityPkg/DxeTcg2PhysicalPresenceLib

2018-08-14 Thread Laszlo Ersek
Hello Heyi, (+ Marc-André and Stefan) On 08/14/18 08:18, heyi@linaro.org wrote: > Hi Jiewen, > > I searched the code in EDK2, and found there is another implementation > of DxeTcg2PhysicalPresenceLib for OVMF: the function > Tcg2PhysicalPresenceLibProcessRequest() is called in > PlatformBootM

Re: [edk2] question about uefi calling convention

2018-08-14 Thread Laszlo Ersek
On 08/14/18 11:09, krishnaLee wrote: > Hi, > In uefi 2.6 specification -> 2.3.4 x64 Platforms, > "Paging mode is enabled and any memory space defined by the UEFI memory map > is identity mapped (virtual address equals physical address)" ... > is that mean if I write C code like " void *pointer=0xa

Re: [edk2] DxeIpl module cannot find DXE entry point

2018-08-14 Thread Laszlo Ersek
On 08/14/18 14:00, Hristo Mihaylov wrote: > Hello, Laszlo, > > There is a PEIM that executes BuildFvHob with the FVMAIN_COMPACT address and > size, the function also exits normally. > > The crash occurs here: > https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c

Re: [edk2] [Patch v3 1/5] UefiCpuPkg/PiSmmCpuDxeSmm: Use GDT/IDT saved in Smram.

2018-08-14 Thread Laszlo Ersek
On 08/13/18 03:54, Dong, Eric wrote: > Hi Laszlo, > >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Laszlo Ersek >> Sent: Friday, August 10, 2018 11:40 PM >> To: Dong, Eric ; edk2-devel@lists.01.org >> Cc: Ni, Ruiyu >> Subject: Re: [edk2]

Re: [edk2] [Patch v3 3/5] UefiCpuPkg/CpuS3DataDxe: Change Memory Type and address limitation.

2018-08-14 Thread Laszlo Ersek
On 08/13/18 07:52, Ni, Ruiyu wrote: > Ignore my previous mail. > > You could use AllocatePages() instead of directly calling > gBS->AllocatePages(). > Then rename the AllocateBootServiceMemory() to AllocateZeroPages() to better > reflect the function behavior. > > Thanks/Ray > >> -Original

Re: [edk2] DxeIpl module cannot find DXE entry point

2018-08-14 Thread Hristo Mihaylov
Hello, Laszlo, There is a PEIM that executes BuildFvHob with the FVMAIN_COMPACT address and size, the function also exits normally. The crash occurs here: https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c#L469 and the platform uses UDK2015 packages. I also up

[edk2] question about uefi calling convention

2018-08-14 Thread krishnaLee
Hi, In uefi 2.6 specification -> 2.3.4 x64 Platforms, "Paging mode is enabled and any memory space defined by the UEFI memory map is identity mapped (virtual address equals physical address)" ... is that mean if I write C code like " void *pointer=0xabcd",the pointer is virtual address ,is equal

[edk2] [PATCH edk2-platforms v2 43/43] Platform/Hisilicon/D0x: Update version string to 18.08

2018-08-14 Thread Ming Huang
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D03/D03.dsc | 2 +- Platform/Hisilicon/D05/D05.dsc | 2 +- Platform/Hisilicon/D06/D06.dsc | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Platform/Hisilicon/D03/D03.ds

[edk2] [PATCH edk2-platforms v2 42/43] Hisilicon/D06: Add edk2-non-osi Shell components

2018-08-14 Thread Ming Huang
Add Hisilicon Oem Shell libraries for some commands,such as biosupdate, getmac, setmac, provision, acpistartos, brdinfo, sfpinfo. biosupdate example: ifconfig -s eth2 static 192.168.2.68 255.255.255.0 192.168.2.1 biosupdate serverIp -u user -p password -f D06.fd -m master acpistartos example: ifc

[edk2] [PATCH edk2-platforms v2 39/43] Silicon/Hisilicon/Setup: Support SPCR table switch

2018-08-14 Thread Ming Huang
If install SPCR table, KVM will not output while install or boot some OS, like ubuntu, so add SPCR switch setup item and set it disable by default. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo --- Silicon/Hisilicon/Drivers/HisiAcpiPla

[edk2] [PATCH edk2-platforms v2 41/43] Hisilicon/D06: Add PciPlatformLib

2018-08-14 Thread Ming Huang
Add a Null PciPlatformLib for build D06. The switch generic PciHostBridge patch set add two api for PciPlatform driver, so need to implement the two api for D06. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/D06.dsc

[edk2] [PATCH edk2-platforms v2 38/43] Silicon/Hisilicon/D06: Add I2C Bus Exception handle function

2018-08-14 Thread Ming Huang
During the period of I2c accessing, if the board is reset unexpectedly, and because the I2c client can not reset, the SDA will be always pull down, then it cause I2C bus Exception. Follow the Hi1620 I2C FS chapter 1.8.2 design, add I2C Bus Exception handle function. It will Config SCL and SDA to G

[edk2] [PATCH edk2-platforms v2 40/43] Silicon/Hisilicon/setup: Support SMMU switch

2018-08-14 Thread Ming Huang
Select without SMMU iort while SMMU item is disable, Select with SMMU iort while SMMU item is enable. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Drivers/HisiAcpiPlatformDxe/UpdateAcpiTable.c | 88 1 file changed,

[edk2] [PATCH edk2-platforms v2 36/43] Platform/Hisilicon/D06: Add capsule upgrade support

2018-08-14 Thread Ming Huang
This module support updating the boot CPU firmware only. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/D06.dsc | 14 Platform/Hisilicon/D06/D06.fdf

[edk2] [PATCH edk2-platforms v2 37/43] Silicon/Hisilicon/D06: Modify for close slave core clock.

2018-08-14 Thread Ming Huang
From: ZhenYao When BIOS booting, the power consumption is too high, so need close some clusters clock that don't work to reduce power consumption. The implementation of functions is in edk2-non-osi. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: ZhenYao --- Silicon/His

[edk2] [PATCH edk2-platforms v2 31/43] Hisilicon/D0x: Update SMBIOS type9 info

2018-08-14 Thread Ming Huang
From: Sun Yuanchen Move board level code to OemMiscLibD0x for unifying D0x. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sun Yuanchen --- Platform/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.inf | 1 + Platform/Hisilicon/D05/Library/OemMiscLibD05/OemMiscLib

[edk2] [PATCH edk2-platforms v2 35/43] Silicon/Hisilicon/D06: Add some Lpc macro to LpcLib.h

2018-08-14 Thread Ming Huang
Add some Lpc macro to LpcLib.h for D06. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Include/Library/LpcLib.h | 51 +++- 1 file changed, 49 insertions(+), 2 deletions(-) diff --git a/Silicon/Hisilicon/Include/Library/Lpc

[edk2] [PATCH edk2-platforms v2 33/43] Platform/Hisilicon/D06: Add PciHostBridgeLib

2018-08-14 Thread Ming Huang
PciHostBridgeLib which is need by PciHostBridgeDxe, provide root bridges and deal with resource conflict. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/D06.dsc | 2 +- Platform/Hisilicon/D06/Li

[edk2] [PATCH edk2-platforms v2 32/43] Platform/Hisilicon/D06: Add EarlyConfigPeim peim

2018-08-14 Thread Ming Huang
This peim configuare SMMU,BSP,MN(Miscellaneous Node). Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/D06.dsc| 1 + Platform/Hisilicon/D06/D06.fdf| 1 + Platform/Hisil

[edk2] [PATCH edk2-platforms v2 30/43] Platform/Hisilicon/D06: Add OemNicConfig2P Driver

2018-08-14 Thread Ming Huang
This Driver provide Get/Set Mac function. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/D06.dsc | 2 +- Platform/Hisilicon/D06/D06.fdf | 2 +- Platform

[edk2] [PATCH edk2-platforms v2 28/43] Platform/Hisilicon/D06: Enable ACPI PPTT

2018-08-14 Thread Ming Huang
From: Heyi Guo Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi Guo --- Platform/Hisilicon/D06/D06.dsc | 1 + Platform/Hisilicon/D06/D06.fdf | 2 ++ 2 files changed, 3 insertions(+) diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc index be

[edk2] [PATCH edk2-platforms v2 34/43] Hisilicon/D06: add apei driver

2018-08-14 Thread Ming Huang
From: Luqi Jiang This driver provide a means for the platform to convey error information to OSPM. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Luqi Jiang --- Platform/Hisilicon/D06/D06.dsc | 1 + Platform/Hisilicon/D06/D06.fdf

[edk2] [PATCH edk2-platforms v2 29/43] Platform/Hisilicon/D06: Add OemNicLib

2018-08-14 Thread Ming Huang
OemNicLib provide nic related api like GetMac,SetMac. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/D06.dsc | 1 + Platform/Hisilicon/D06/Library/OemNicLib/OemNicLib.inf | 35 ++ Platform/Hisilicon/D06/Libr

[edk2] [PATCH edk2-platforms v2 24/43] Hisilicon/I2C: Fix a typo issue

2018-08-14 Thread Ming Huang
Modify spedd to Speed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Library/I2CLib/I2CHw.h | 2 +- Silicon/Hisilicon/Library/I2CLib/I2CLib.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Silicon/Hisilicon/Librar

[edk2] [PATCH edk2-platforms v2 25/43] Silicon/Hisilicon/D06: Optimize HNS config CDR post time

2018-08-14 Thread Ming Huang
From: shaochangliang Use I2C 400KB speed for config CDR. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Library/I2CLib/I2CLib.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/Silicon/Hisilicon/Library/I2CLib/

[edk2] [PATCH edk2-platforms v2 23/43] Silicon/Hisilicon/D06: Add I2C delay for HNS auto config

2018-08-14 Thread Ming Huang
Because I2C Port5 salve device connect under I2C extender (9545 device), it will cost more time to access I2C slave device, so add delay time for HNS auto config. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Library/I2CLib/I2CHw.h | 3

[edk2] [PATCH edk2-platforms v2 26/43] Silicon/Hisilicon/Setup: Add Setup Item "EnableGOP"

2018-08-14 Thread Ming Huang
From: Yang XinYi Add Setup Item "EnableGOP" for D06, This Item only takes effect on VGA device SM750. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yang XinYi --- Silicon/Hisilicon/Include/Library/OemConfigData.h| 1 + Silicon/Hisilicon/Hi1620/Hi1620OemConf

[edk2] [PATCH edk2-platforms v2 21/43] Silicon/Hisilicon/I2C: Refactor I2C library

2018-08-14 Thread Ming Huang
The hunk of waiting TX/TX finish is used by ten times, so move there hunks to a function CheckI2CTimeOut(). Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Library/I2CLib/I2CHw.h | 4 + Silicon/Hisilicon/Library/I2CLib/I2CLib.c | 161 +++

[edk2] [PATCH edk2-platforms v2 27/43] Hisilicon/Hi1620: Add ACPI PPTT table

2018-08-14 Thread Ming Huang
From: Heyi Guo This driver fetches information from MADT, so it is adaptable for partial good and 1P/2P, since MADT is updated for different configurations by certain mechanism. Since L2 cache is also private resource of core, so we need to set the next level of cache for L1I and L1D, which is

[edk2] [PATCH edk2-platforms v2 22/43] Silicon/Hisilicon/D06: Fix I2C enable fail issue for D06

2018-08-14 Thread Ming Huang
I2C may enable failed in D06, so retry I2C enable while enable failed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Library/I2CLib/I2CLib.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/Silicon/H

[edk2] [PATCH edk2-platforms v2 19/43] Silicon/Hisilicon/D06: Stop watchdog

2018-08-14 Thread Ming Huang
according as watchdog design on D06, watchdog should be stopped before boot a option. This is an out of band watchdog timer in BMC; it is used to monitor the whole BIOS boot process and reset the system in case BIOS hangs somewhere, i.e. it is armed when system is power on, and disabled before han

[edk2] [PATCH edk2-platforms v2 16/43] Hisilicon/D06: Add Debug Serial Port Init Driver

2018-08-14 Thread Ming Huang
From: Heyi Guo Hi1620 have two physical PL011 serial ports on the board, one for serial port console (described by ACPI SPCR) and the other for standard debug port (described by ACPI DBG2). This driver is to initialize the debug UART, not the serial console. Contributed-under: TianoCore Contribu

[edk2] [PATCH edk2-platforms v2 20/43] Hisilicon/I2C: Modify I2CLib.c for coding style

2018-08-14 Thread Ming Huang
Correct coding style for I2CLib.c before adding other I2CLib patches. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Library/I2CLib/I2CLib.c | 1034 ++-- 1 file changed, 499 insertions(+), 535 deletions(-) diff --git a/Sil

[edk2] [PATCH edk2-platforms v2 14/43] Silicon/Hisilicon/D06: Wait for all disk ready

2018-08-14 Thread Ming Huang
This patch is relative to D06 SasDxe driver. The SasDxe set a variable to notice this libray. Here Wait for all disk ready for 15S at most. D06: For using straight-through hard disk backboard, some disk need 15 seconds to ready. Actually, wait less 15 seconds here(minus the time from end of SAS dr

[edk2] [PATCH edk2-platforms v2 13/43] Hisilicon/D06: Add OemMiscLibD06

2018-08-14 Thread Ming Huang
This library include BoardFeatureD06.c and OemMiscLibD06.c c file, use for several modules like PciHostBridgeLib and Smbios. Enlarge macro PCIEDEVICE_REPORT_MAX for D06. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/D06.dsc

[edk2] [PATCH edk2-platforms v2 18/43] Hisilicon/D06: Add Hi1620OemConfigUiLib

2018-08-14 Thread Ming Huang
From: Yang XinYi This library is added for oem setup menu item. Setup item include: 1 DDR option item; 2 BMC option item; 3 Ras option item; 4 Misc option item; Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yang XinYi --- Silicon/Hisilicon/HisiPkg.dec

[edk2] [PATCH edk2-platforms v2 15/43] Silicon/Hisilicon/Acpi: Unify HisiAcipPlatformDxe

2018-08-14 Thread Ming Huang
The EFI_ACPI_STATIC_RESOURCE_AFFINITY_TABLE struct is used by UpdateAcpiTable.c and Srat aslc. The struct may be different according to chips, so move some macro to PlatformArch.h. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Hi1610/Incl

  1   2   >