Thank you!
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, September 12, 2018 1:14 PM
> To: edk2-devel@lists.01.org
> Cc: Laszlo Ersek ; Dong, Eric ;
> Yao, Jiewen
> Subject: [Patch] UefiCpuPkg PiSmmCpuDxeSmm: Update SmiEntry function
> run
From: "bob.c.f...@intel.com"
If Structure PCD and Normal Pcd refer to the
same EFI variable, do EFI variable merge, otherwise, do
EFI variable combination.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng
Cc: Liming Gao
---
BaseTools/Source/Python/AutoGen/AutoGe
Bob:
Please update commit message title with the detail information.
Thanks
Liming
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>BobCF
>Sent: Friday, September 07, 2018 3:45 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming
>Subject: [edk2]
Yonghong:
Please list which items are corrected in the commit message.
Thanks
Liming
>-Original Message-
>From: Zhu, Yonghong
>Sent: Friday, September 07, 2018 3:08 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming ; Kinney, Michael D
>; Shaw, Kevin W
>Subject: [Patch] INF spec: Correct
Reviewed-by: Liming Gao
>-Original Message-
>From: Zhu, Yonghong
>Sent: Friday, September 07, 2018 3:56 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming ; Kinney, Michael D
>; Shaw, Kevin W
>Subject: [Patch] Build spec: correct the Operator used in the expression for
>Table 12
>
>Fixes:
1. Remove jmp _SmiHandler, and run the code at the same position.
2. Fix up the function call address as the absolute address.
Verify OVMF SMM boot to shell with VS2017, GCC5 and XCODE5 tool chain.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
Cc: Laszlo Ersek
Reviewed-by: Hess Chen
Chen, Hess
Intel China Software Center
Tel: +86-21-6116-6740
Email: hesheng.c...@intel.com
-Original Message-
From: Zhu, Yonghong
Sent: Wednesday, September 5, 2018 11:27 AM
To: edk2-devel@lists.01.org
Cc: Chen, Hesheng ; Gao, Liming
Subject: [Patch] BaseTools: F
The patch's subject is too generic.
Best Regards,
Zhu Yonghong
-Original Message-
From: Zhao, ZhiqiangX
Sent: Wednesday, September 12, 2018 9:41 AM
To: edk2-devel@lists.01.org
Cc: Zhao, ZhiqiangX ; Gao, Liming
; Zhu, Yonghong ; Feng, Bob C
Subject: [PATCH] BaseTools: pcd in commandLi
StructurePcd, SkuA does not define any structure pcd overwrite,
But SkuA inherit from DEFAULT sku, and DEFAULT sku define
structure pcd overwrite, the pcd value of SkuA should same with
DEFAULT sku.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: ZhiqiangX Zhao
Cc: Liming G
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunshan Tu
---
.../Common/Features/UsbDeviceDxe/XdciDWC.c | 12 ++--
.../PeiFspPolicyInitLib/PeiFspCpuPolicyInitLib.c | 1 +
.../PlatformBootManagerLib/PlatformBootManager.c | 2 ++
.../PlatformSettings/Platfor
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong
Zhu
Sent: Tuesday, September 11, 2018 10:51 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming
Subject: [edk2] [Patch] BaseTools: Report
Mike,
Do you require to still use MSVC intrinsic function?
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni,
> Ruiyu
> Sent: Tuesday, September 11, 2018 10:27 AM
> To: Kinney, Michael D ; 'edk2-devel@lists.01.org'
>
> Cc: Yao, Jiewen ; Gao,
Hi Laszlo and Ard,
Retiring the PcdSetNxForStack is not the intention of this patch series. It's
just
a side effect of solving problem stated in BZ#1116. Sorry again for the
misleading
title. I'm not insisting that we have to remove this PCD anyway (My personal
opinion. Others might have differe
Reviewed-by: Star Zeng
-Original Message-
From: Bi, Dandan
Sent: Monday, September 10, 2018 3:12 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan ; Ni, Ruiyu ; Zeng,
Star
Subject: [patch 3/3] MdeModulePkg: Avoid key notification called more than once
From: Dandan Bi
REF: https://bugzil
From: zhijufan
This patch align the boolean type PCD value's display in the build
report. Original it may display 0x0, also may use 0 for the same PCD.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python
Reviewed-by: Star Zeng
-Original Message-
From: Ni, Ruiyu
Sent: Monday, September 10, 2018 6:05 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Kinney, Michael D
; Zeng, Star
Subject: [PATCH] MdeModulePkg/ConPlatform: Support short-form USB device path
Today's implementation does an ex
In command line, the latter full assign value in commandLine
should override the former field assign value.
For example, --pcd Token.pcd.field="" --pcd Token.pcd=H"{}".
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: ZhiqiangX Zhao
Cc: Liming Gao
Cc: Yonghong Zhu
Cc: Bob
We have some internal feature, required to run the code at the each SMI
entrypoint, instead of common code.
That is why we write code in previous way.
I suggest we keep using the previous way and provide a good example on how to
handle absolute address in new way.
Can we provide an update for b
Jiewen:
Because nasm doesn't generate the absolute address, we can change the below
code, but we need to fix up its value at boot time like current _SmiHandler
way.
Could you let me know why can't use current way?
Thanks
Liming
>-Original Message-
>From: Yao, Jiewen
>Sent: Wednesd
The original code is below. Can we rollback to the indirect call?
mov rax, ASM_PFX(CpuSmmDebugEntry)
callrax
Thank you
Yao Jiewen
> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, September 12, 2018 8:59 AM
> To: Yao, Jiewen ; Laszlo Ersek ;
> edk2-devel@lists.01.
Jiewen:
After do more verification, I recall this change. Current code is really
required. Without it, OVMF SMM can't boot. So, below code can't be removed.
The reason is that nasm _SmiEntryPoint() function is copied to another memory
location and run. But, _ SmiEntryPoint() calls the externa
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
> Biesheuvel
> Sent: Wednesday, September 12, 2018 5:03 AM
> To: Ni, Ruiyu
> Cc: edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH 0/5] expire the use of PcdSetNxForStack
>
> On 11 Sept
Laszlo,
Thanks for the comments.
(1)Agree. It’ll be updated in v2.
(2)DEBUG_ERROR level won’t print word “ERROR” on console. I think an “ERROR”
word in log should get the attention more easily.
(3)How about log both of them? GUID value may be more friendly to log
parser but
a GUI
Laszlo,
Thanks for the comment. I think it’ll ok to add it in a separate patch.
Just a little confuse about “a separate patch”. Does it mean a separate patch
file
in the same patch series or a separate patch which needs a separate BZ tracker?
Regards,
Jian
From: Laszlo Ersek [mailto:ler...@red
Laszlo,
Thanks for the comments.
(1)Sure. My fault. I thought it’s just very small change for compiler
warning.
(2)From language point view, it’s a valid warning. But from code logic,
it’s invalid.
(3)Agree. It’ll be dropped.
(4)Agree. I’ll change it.
Regards,
Jian
From:
HI
Would you please add info on what unit test has been done?
Thank you
Yao Jiewen
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Tuesday, September 11, 2018 11:06 PM
> To: Gao, Liming ; edk2-devel@lists.01.org
> Cc: Y
On 11 September 2018 at 11:13, Ni, Ruiyu wrote:
> On 9/11/2018 4:57 PM, Ard Biesheuvel wrote:
>>
>> On 11 September 2018 at 07:16, Jian J Wang wrote:
>>>
>>> BZ#: https://bugzilla.tianocore.org/show_bug.cgi?id=1116
>>>
>>> Since the stack memory is allocated as EfiBootServicesData, its NX
>>> pro
> -Original Message-
> From: Laszlo Ersek
> Sent: Tuesday, September 11, 2018 1:50 PM
> To: Duran, Leo ; edk2-devel@lists.01.org
> Cc: Eric Dong ; Ruiyu Ni
> Subject: Re: [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTRRs
> prior to MTRR change.
>
> On 09/11/18 17:41, Leo Du
On 09/11/18 17:41, Leo Duran wrote:
> The default behavior is to disable MTRRs prior to an MTRR change.
> However, on SMT platforms with shared CPU resources it may be desirable to
> skip the default behavior, and leave the current state of the Enable bit.
>
> Cc: Eric Dong
> Cc: Laszlo Ersek
>
On 09/07/18 02:07, Robinson, Herbie wrote:
> This is a fix for a double cluster allocation when the disk is full. The
> double allocation happens because FatGrowEof calls FatAllocateCluster without
> immediately marking the each returned cluster as allocated. The fix is to
> move the FatSetFat
On 09/11/18 07:16, Jian J Wang wrote:
> BZ#: https://bugzilla.tianocore.org/show_bug.cgi?id=1116
>
> Since PcdSetNxForStack is expired, remove related config code.
> PcdDxeNxMemoryProtectionPolicy cannot be used as dynamic PCD.
> There's no need to add it in code to replace PcdSetNxForStack.
>
> Cc
The default behavior is to disable MTRRs prior to an MTRR change.
However, on SMT platforms with shared CPU resources it may be desirable to
skip the default behavior, and leave the current state of the Enable bit.
Cc: Eric Dong
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreemen
This patch adds a flag that will allow us to skip disabling MTRRs on SMT
platforms where the MTRR Enable bit is shared across threads in a CPU core.
The default behavior is unchanged, so existing implementations are not
affected by this patch.
Leo Duran (1):
UefiCpuPkg/MtrrLib: Add flag to skip
On 09/04/18 15:43, Stephen Benjamin wrote:
> On Tue, Sep 4, 2018 at 7:02 AM Laszlo Ersek wrote:
>>
>> On 09/04/18 09:17, Jiaxin Wu wrote:
>>> This patch is to resolve the lock-up issue if the value of HTTP header
>>> is blank. The issue is recorded @
>>> https://bugzilla.tianocore.org/show_bug.cg
On 09/10/18 10:20, Liming Gao wrote:
> This change is wrong introduced by e21e355e2ca7fefb15b4df7078f995d3fb9c2b89
> It is not required. So, revert it.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao
> Cc: Jiewen Yao
> ---
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/
Jian,
On 09/11/18 06:47, Jian J Wang wrote:
> BZ#: https://bugzilla.tianocore.org/show_bug.cgi?id=1166
>
> Cc: Dandan Bi
> Cc: Hao A Wu
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang
> ---
> UefiCpuPkg/CpuMpPei/CpuPaging.c | 23 ---
>
On 09/10/18 05:22, Jian J Wang wrote:
> BZ#: https://bugzilla.tianocore.org/show_bug.cgi?id=1165
>
> HOB gEfiAcpiVariableGuid is a must have data for S3 resume if
> PcdAcpiS3Enable is set to TRUE. Current code in CpuS3.c doesn't
> embody this strong binding between them. An error message and
> ASS
On 09/10/18 07:07, Zeng, Star wrote:
> I agree to add the ASSERT, but even with the ASSERT, I still suggest moving
> //
> // Patch SmmS3ResumeState->SmmS3Cr3
> //
> InitSmmS3Cr3 ();
>
> into
> GuidHob = GetFirstGuidHob (&gEfiAcpiVariableGuid);
> if (GuidHob != NULL) {
> ..
On 09/07/18 19:01, Liran Alon wrote:
>
>
>> On 7 Sep 2018, at 11:44, Laszlo Ersek wrote:
>>
>> (+Ard)
>>
>> On 09/06/18 21:08, Nikita Leshenko wrote:
>>> Hi,
>>>
>>> We ran into a bug in EDK2 relating to PCI-Express in PciBusDxe. Here's the
>>> flow
>>> of the bug:
>>>
>>> 1. PciBusDxe/PciEnume
Hi Ard,
Sorry for the title which misleads you (I used a wrong word too. Shame!).
The real problem this patch series try to address is the confusion in these
two PCDs, PcdSetNxForStack and PcdDxeNxMemoryProtectionPolicy.
One of them will enable NX feature in cpu but another won’t. And there’s
also
On 9/11/2018 4:57 PM, Ard Biesheuvel wrote:
On 11 September 2018 at 07:16, Jian J Wang wrote:
BZ#: https://bugzilla.tianocore.org/show_bug.cgi?id=1116
Since the stack memory is allocated as EfiBootServicesData, its NX protection
can be covered by BIT4 of PcdDxeNxMemoryProtectionPolicy. To avoi
On 9/11/2018 1:16 PM, Jian J Wang wrote:
+if ((PcdGet64 (PcdDxeNxMemoryProtectionPolicy) & BIT4) != 0
I suggest to use (1 << EfiBootServicesData) to replace BIT4.
--
Thanks,
Ray
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.
On 11 September 2018 at 07:16, Jian J Wang wrote:
> BZ#: https://bugzilla.tianocore.org/show_bug.cgi?id=1116
>
> Since the stack memory is allocated as EfiBootServicesData, its NX protection
> can be covered by BIT4 of PcdDxeNxMemoryProtectionPolicy. To avoid confusing
> in setting related PCDs, P
UDK2018 eMMC driver may fail to switch eMMC to HS400 mode. This platform
temporary solution limits eMMC controller to maximal HS200 mode.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: David Wei
CC: Mike Wu
CC: Mang Guo
---
.../Board/LeafHill/BoardInitPostMem/BoardIni
44 matches
Mail list logo
