[edk2] [PATCH V2] BaseTools: Code should not update the variable that save the raw data.

Hi Liming, I have update the patch title with more information, please check the attached patch file. Best Regards, Zhiqiang Zhao -Original Message- From: Gao, Liming Sent: Tuesday, September 25, 2018 9:05 AM To: Zhao, ZhiqiangX ; edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Feng, Bob

[edk2] [PATCH] PurleyOpenBoardPkg: fix build error

Fix format error of gEfiPchSetTmcSrcClkProtocolGuid in PchRcPkg.dec. Build error is: error 3000: Invalid GUID value format gEfiPchSetTmcSrcClkProtocolGuid = {0xfbaa2549, 0x53d, 0x4012, 0x86, 0x6c, 0x7a, 0x86, 0xcc, 0x21, 0xae, 0x21} ( = ) Cc: Jiewen Yao Contributed-under: TianoCore Contri

Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Revert "Skip MSR access when the pair is invalid"

Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Tuesday, September 25, 2018 1:22 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Dong, Eric > > Subject: [edk2] [PATCH] UefiCpuPkg/MtrrLib: R

[edk2] [PATCH 1/2] NetworkPkg/HttpDxe: fix read memory access overflow in HTTPBoot.

The input param String of AsciiStrStr() requires a pointer to Null-terminated string, however in HttpTcpReceiveHeader(), the Buffersize before AllocateZeroPool() is equal to the size of TCP header, after the CopyMem(), it might not end with Null-terminator. It might cause memory access overflow

[edk2] [PATCH 2/2] NetworkPkg/HttpUtilitiesDxe: fix read memory access overflow.

The input param String of AsciiStrStr() requires a pointer to Null-terminated string, however in HttpUtilitiesParse(), the Buffersize before AllocateZeroPool() is equal to the size of TCP header, after the CopyMem(), it might not end with Null-terminator. It might cause memory access overflow.

[edk2] [PATCH 0/2] fix read memory access overflow in HTTPBoot.

The input param String of AsciiStrStr() requires a pointer to Null-terminated string, however in HttpTcpReceiveHeader() and HttpUtilitiesParse(), the Buffersize before AllocateZeroPool() is equal to the size of TCP header, after the CopyMem(), it might not end with Null-terminator. It might cau

Re: [edk2] [PATCH v2 1/2] MdePkg/IndustryStandard: Add Global Plaform header file

Thanks Mike for your comments. On Mon, 24 Sep 2018 at 22:20, Kinney, Michael D wrote: > > Hi Ard, > > The initial content is only from the TEE Client API Specification. > I noticed that there is an errata to that spec as well. Does this > content follow the errata? Yes. > > I also noticed that

Re: [edk2] [PATCH v2 1/2] MdePkg/IndustryStandard: Add Global Plaform header file

On Tue, 25 Sep 2018 at 10:27, Sumit Garg wrote: > > Thanks Mike for your comments. > > On Mon, 24 Sep 2018 at 22:20, Kinney, Michael D > wrote: > > > > Hi Ard, > > > > The initial content is only from the TEE Client API Specification. > > I noticed that there is an errata to that spec as well. D

[edk2] [Patch] Build Spec: Update EBNF of --pcd for String type to at least one char

Update the '*' in the EBNF to '+' which means in the string there at least need one char. the case like "" is not supported. Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- appendix_d_buildexe_command/d

Re: [edk2] [PATCH v2 0/5] Support windowsize to benefit tftp/pxe download performance.

Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Tuesday, September 25, 2018 9:12 AM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Carsey, Jaben ; Shao, Ming ; Laszlo Ersek ; Wu, Jiaxin Subject: [PATCH v2 0/5] Support windowsize to benefit tftp/pxe download p

[edk2] [Patch][edk2-platforms/devel-IntelAtomProcessorE3900] Disable VT-d and Pre-boot VT-d setup option

Disable VT-d and Pre-boot VT-d setup option since it caused system hang in variable initialization after Windows 10 installer restart the system. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Guo Mang --- .../Common/PlatformSettings/PlatformSetupDxe/Cpu.vfi |

[edk2] [Patch] Build Spec: Add some clarification of Build report section

1. Add the section header of Global PCD Section 2. Add 'INF DEFAULT' in the module PCD section Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- 13_build_reports/136_global_pcd_section.md | 13 +++

Re: [edk2] [Patch v3 00/14] Update MSR definitions

On 09/25/18 04:08, Eric Dong wrote: > Current MSR definition are follow the SDM 2016-09 version. The latest SDM is > 2018-05. This patch serial update the MSR related definition to follow the > latest SDM 2018-05 version. MSR related defintion are saved at > UefiCpuPkg\Include\Register\. > > V3

Re: [edk2] [Patch 1/6] MdeModulePkg/Tcp4Dxe: Add the clarification compared to TcpDxe in NetworkPkg.

On 09/25/18 05:44, Jiaxin Wu wrote: > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205 > > This patch is to add the driver usage/difference clarification > compared to TcpDxe in NetworkPkg. > > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution A

Re: [edk2] [Patch 1/6] MdeModulePkg/Tcp4Dxe: Add the clarification compared to TcpDxe in NetworkPkg.

On 09/25/18 05:44, Jiaxin Wu wrote: > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205 > > This patch is to add the driver usage/difference clarification > compared to TcpDxe in NetworkPkg. > > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution A

Re: [edk2] [Patch 2/6] MdeModulePkg/IScsiDxe: Add the clarification compared to IScsiDxe in NetworkPkg.

On 09/25/18 05:44, Jiaxin Wu wrote: > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205 > > This patch is to add the driver usage/difference clarification > compared to IScsiDxe in NetworkPkg. > > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution

[edk2] [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as unused

This fixes unused const variable gcc 7.3 compilation error. Array is not simply removed as the list of invalid characters might be salient in future and for easy documentation. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Tomas Pilar --- ShellPkg/Application/Shell/Shell

Re: [edk2] [Patch 3/6] MdeModulePkg/UefiPxeBcDxe: Add the clarification compared to UefiPxeBcDxe in NetworkPkg.

On 09/25/18 05:44, Jiaxin Wu wrote: > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205 > > This patch is to add the driver usage/difference clarification > compared to UefiPxeBcDxe in NetworkPkg. > > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribu

Re: [edk2] [Patch 4/6] NetworkPkg/TcpDxe: Add the clarification compared to Tcp4Dxe in MdeModulePkg.

On 09/25/18 05:44, Jiaxin Wu wrote: > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205 > > This patch is to add the driver usage/difference clarification > compared to Tcp4Dxe in MdeModulePkg. > > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Laszlo Ersek > Contributed-under: TianoCore Contributio

Re: [edk2] [Patch 5/6] NetworkPkg/IScsiDxe: Add the clarification compared to IScsiDxe in MdeModulePkg.

On 09/25/18 05:44, Jiaxin Wu wrote: > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205 > > This patch is to add the driver usage/difference clarification > compared to IScsiDxe in MdeModulePkg. > > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Laszlo Ersek > Contributed-under: TianoCore Contributi

Re: [edk2] [Patch 6/6] NetworkPkg/UefiPxeBcDxe: Add the clarification compared to UefiPxeBcDxe in MdeModulePkg.

On 09/25/18 05:44, Jiaxin Wu wrote: > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205 > > This patch is to add the driver usage/difference clarification > compared to UefiPxeBcDxe in MdeModulePkg. > > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Laszlo Ersek > Contributed-under: TianoCore Contri

Re: [edk2] [PATCH v2 4/4] MdeModulePkg/PciHostBridge: Move declaration of mIoMmu to header file

On 09/25/18 08:21, Ruiyu Ni wrote: > The change doesn't have functionality impact. > It just renames the mIoMmuProtocol to mIoMmu and moves the\ > declaration from PciRootBridgeIo.c to PciHostBridge.h. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Suggest

Re: [edk2] [PATCH v2 4/4] MdeModulePkg/PciHostBridge: Move declaration of mIoMmu to header file

On 09/25/18 08:21, Ruiyu Ni wrote: > The change doesn't have functionality impact. > It just renames the mIoMmuProtocol to mIoMmu and moves the\ > declaration from PciRootBridgeIo.c to PciHostBridge.h. Before pushing the patch, please remove the stray backslash from the commit message. Thanks Las

Re: [edk2] [PATCH v2 5/5] UefiCpuPkg/PiSmmCpuDxeSmm: [CVE-2017-5753] Fix bounds check bypass

On 09/25/18 08:12, Hao Wu wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1194 > > Speculative execution is used by processor to avoid having to wait for > data to arrive from memory, or for previous operations to finish, the > processor may speculate as to what will be executed. > >

Re: [edk2] [PATCH v2 0/4] Fix a bug that prevents PMEM access

Reviewed-by: Star Zeng with Laszlo's minor comment handled. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Tuesday, September 25, 2018 2:21 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v2 0/4] Fix a bug that

Re: [edk2] [PATCH v2 1/5] MdePkg/BaseLib: Add new AsmLfence API

Hi Hao, On 09/25/18 08:12, Hao Wu wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1193 > > This commit will add a new BaseLib API AsmLfence(). This API will perform > a serializing operation on all load-from-memory instructions that were > issued prior to the call of this function. Pl

Re: [edk2] [Question] Testing environment regarding SMM driver

Thanks Laszlo and Andrew for the answers, from what I can see, is not possible to do what I meant but your answers gave me some ideas. Thanks a lot. BR, poxyran On 9/21/2018 4:05 PM, Laszlo Ersek wrote: > On 09/21/18 20:15, poxyran wrote: >> Hello again, >> >> my question is: is it possible to

Re: [edk2] Minimum tianocore payload

Hi all, Thanks for your suggestions! I've been able to remove some unused modules comparing both Quartz dsc versions and finally to avoid any info on screen I've added a very rude patch but it works: --- a/IntelFrameworkModulePkg/Universal/BdsDxe/FrontPage.c +++ b/IntelFrameworkModulePkg/Uni

Re: [edk2] Tianocore and TPM2 pcr values

Hi Jorge: PCR 0 should change if you use different core boot payload + UEFI. So your case seems to be an issue. Can you provide more detailed info? -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jorge Fernandez Monteagudo Sent: Monday, Se

Re: [edk2] [PATCH v1 7/7] BaseTools/GenFds: create and use new variable in FdfParser

Reviewed-by: Bob Feng -Original Message- From: Carsey, Jaben Sent: Monday, September 24, 2018 10:28 PM To: edk2-devel@lists.01.org Cc: Feng, Bob C ; Zhu, Yonghong ; Gao, Liming Subject: [PATCH v1 7/7] BaseTools/GenFds: create and use new variable in FdfParser replace lots of '}' and

Re: [edk2] [PATCH v1 6/7] BaseTools/GenFds: Remove duplicate function calls

Reviewed-by: Bob Feng -Original Message- From: Carsey, Jaben Sent: Monday, September 24, 2018 10:28 PM To: edk2-devel@lists.01.org Cc: Feng, Bob C ; Zhu, Yonghong ; Gao, Liming Subject: [PATCH v1 6/7] BaseTools/GenFds: Remove duplicate function calls every call to GetAprioriSection()

Re: [edk2] [PATCH v3] MdePkg/SynchronizationLib: fix Interlocked[De|In]crement return value

Hi, On 09/13/18 11:50, Ruiyu Ni wrote: > Today's InterlockedIncrement()/InterlockedDecrement() guarantees to > perform atomic increment/decrement but doesn't guarantee the return > value equals to the new value. > > The patch fixes the behavior to use "XADD" instruction to guarantee > the return v

Re: [edk2] Tianocore and TPM2 pcr values

Hi Chao! PCR0 has not changed in any of the test I've done! What info do you need? I'm using: coreboot: ae05d095b36ac835a6b1a221e6858065e5486888, master branch tianocore: 07ecd98ac18d6792181856faca7d4bed1b587261, coreboot branch Attached are the changes I've done to tianocore to get TPM2 sup

Re: [edk2] [PATCH v3] MdePkg/SynchronizationLib: fix Interlocked[De|In]crement return value

On 09/13/18 11:50, Ruiyu Ni wrote: > diff --git a/MdePkg/Library/BaseSynchronizationLib/X64/GccInline.c > b/MdePkg/Library/BaseSynchronizationLib/X64/GccInline.c > index 5224dd063f..4c4d6e3fc7 100644 > --- a/MdePkg/Library/BaseSynchronizationLib/X64/GccInline.c > +++ b/MdePkg/Library/BaseSynchron

Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTRRs prior to MTRR change.

Hi Ray & Eric, Where are we on this?... Here are my last two replies: > > Hi Ray, > > Please pardon the late reply. > > The main problem with changes to "caller" code is that dependencies > > are SoC-specific, so the detection code would not scale over time. > > Again, the proposed PCD does not a

Re: [edk2] [PATCH V3 3/6] MdeModulePkg S3SaveStateDxe: Use new EfiLocateFirstAcpiTable()

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Monday, September 17, 2018 5:08 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Younas khan > ; Kinney, Michael D > ; Gao, Liming ; Yao, > Jiewen ; Wang, Jian J > Subject: [PATCH V3 3/6] MdeModulePkg S3S

Re: [edk2] [Patch] BaseTools: Fix the wrong reference _GetSkuIds() in AutoGen code

Reviewed-by: Jaben Carsey > -Original Message- > From: Zhu, Yonghong > Sent: Monday, September 24, 2018 11:23 PM > To: Gao, Liming ; edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Zhu, Yonghong > > Subject: RE: [Patch] BaseTools: Fix the wrong reference _GetSkuIds() in > AutoGen code > Im

Re: [edk2] [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as unused

I would prefer we just delete this. Ray, What do you think? > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Tomas Pilar (tpilar) > Sent: Tuesday, September 25, 2018 3:15 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH] ShellPkg:

Re: [edk2] [PATCH] MdeModulePkg XhciDxe: Set HSEE Bit if SERR# Enable Bit is set

Hi Star, Ard With this patch, my platforms which use NonDiscoverableDevices layer for supporting generic Xhci controller, fail in a strange way: "Synchronous Exception at 0x3F910AFC PC 0x3F910AFC (0x3F908000+0x8AFC) [ 0] DxeCore.dll PC 0x3F910AE0 (0x3F908000+0x8AE0)

Re: [edk2] [PATCH] MdeModulePkg XhciDxe: Set HSEE Bit if SERR# Enable Bit is set

On Tue, 25 Sep 2018 at 17:41, Marcin Wojtas wrote: > > Hi Star, Ard > > With this patch, my platforms which use NonDiscoverableDevices layer > for supporting generic Xhci controller, fail in a strange way: > "Synchronous Exception at 0x3F910AFC > PC 0x3F910AFC (0x3F908000+0x8AF

Re: [edk2] [PATCH v3] MdePkg/SynchronizationLib: fix Interlocked[De|In]crement return value

On 09/25/18 16:22, Laszlo Ersek wrote: > On 09/13/18 11:50, Ruiyu Ni wrote: > >> diff --git a/MdePkg/Library/BaseSynchronizationLib/X64/GccInline.c >> b/MdePkg/Library/BaseSynchronizationLib/X64/GccInline.c >> index 5224dd063f..4c4d6e3fc7 100644 >> --- a/MdePkg/Library/BaseSynchronizationLib/X64/

Re: [edk2] [PATCH] MdeModulePkg XhciDxe: Set HSEE Bit if SERR# Enable Bit is set

On Tue, 25 Sep 2018 at 17:51, Ard Biesheuvel wrote: > > On Tue, 25 Sep 2018 at 17:41, Marcin Wojtas wrote: > > > > Hi Star, Ard > > > > With this patch, my platforms which use NonDiscoverableDevices layer > > for supporting generic Xhci controller, fail in a strange way: > > "Synchronous Exceptio

Re: [edk2] [PATCH] MdeModulePkg XhciDxe: Set HSEE Bit if SERR# Enable Bit is set

> On Sep 25, 2018, at 8:41 AM, Marcin Wojtas wrote: > > Hi Star, Ard > > With this patch, my platforms which use NonDiscoverableDevices layer > for supporting generic Xhci controller, fail in a strange way: > "Synchronous Exception at 0x3F910AFC > PC 0x3F910AFC (0x3F908000+0x00

Re: [edk2] [PATCH] MdeModulePkg XhciDxe: Set HSEE Bit if SERR# Enable Bit is set

Hi Andrew, wt., 25 wrz 2018 o 18:25 Andrew Fish napisał(a): > > > > On Sep 25, 2018, at 8:41 AM, Marcin Wojtas wrote: > > Hi Star, Ard > > With this patch, my platforms which use NonDiscoverableDevices layer > for supporting generic Xhci controller, fail in a strange way: > "Synchronous Exceptio

[edk2] [PATCH] MdeModulePkg: XhciDxe: Prevent illegal memory access in XhcSetHsee

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1206 Newly added XhcSetHsee() routine reads 4 bytes into a UINT16 variable causing issues on PCIE and NonDiscoverable Xhci controllers. Fix that. Cc: Ruiyu Ni Cc: Fei1 Wang Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [PATCH v3] MdePkg/SynchronizationLib: fix Interlocked[De|In]crement return value

On 09/25/18 18:18, Laszlo Ersek wrote: > On 09/25/18 16:22, Laszlo Ersek wrote: >> On 09/13/18 11:50, Ruiyu Ni wrote: >> >>> diff --git a/MdePkg/Library/BaseSynchronizationLib/X64/GccInline.c >>> b/MdePkg/Library/BaseSynchronizationLib/X64/GccInline.c >>> index 5224dd063f..4c4d6e3fc7 100644 >>> --

Re: [edk2] [PATCH] MdeModulePkg: XhciDxe: Prevent illegal memory access in XhcSetHsee

On Tue, 25 Sep 2018 at 19:59, Marcin Wojtas wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1206 > > Newly added XhcSetHsee() routine reads 4 bytes into > a UINT16 variable causing issues on PCIE and NonDiscoverable > Xhci controllers. Fix that. > > Cc: Ruiyu Ni > Cc: Fei1 Wang >

Re: [edk2] [PATCH v3] MdePkg/SynchronizationLib: fix Interlocked[De|In]crement return value

On 09/25/18 20:29, Laszlo Ersek wrote: > So here's what I'm going to do. I will submit a standalone, "surgical" > patch, for fixing the regression introduced in 17634d026f96. Filed about that. > Additionally, I will file a TianoCore BZ about

[edk2] [PATCH] MdePkg/BaseSynchronizationLib: fix XADD operands in GCC IA32/X64 assembly

Currently, "gcc-4.8.5-28.el7_5.1.x86_64" generates the following code for me, from the XADD inline assembly added to "X64/GccInline.c" in commit 17634d026f96: > 4383 : > UINT32 > EFIAPI > InternalSyncIncrement ( > IN volatile UINT32*Value > ) > { > 4383: 55

Re: [edk2] [PATCH v2 0/5] Support windowsize to benefit tftp/pxe download performance.

On 09/25/18 03:11, Jiaxin Wu wrote: > *v2: The first three patches(1/2/3) are the same with version 1, just update > the last two > patches (4/5): > I) windowsize.> > This patch has been discarded since we rename and redefine the PCD in > NetworkPkg instead > of MdeModulePkg. The replacement is

Re: [edk2] [PATCH v2 4/5] NetworkPkg: Define one PCD for PXE to specify MTFTP windowsize.

On 09/25/18 03:11, Jiaxin Wu wrote: > *v2: Rename and redefine the PCD in NetworkPkg instead of MdeModulePkg. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=886 > > This patch is to define one new PCD for PXE driver to specify MTFTP > windowsize so as > to improve the PXE download perfo

Re: [edk2] [PATCH v2 5/5] NetworkPkg/UefiPxeBcDxe: Use the specified MTFTP windowsize.

On 09/25/18 03:11, Jiaxin Wu wrote: > *v2: Since the new PCD (PcdPxeTftpWindowSize) was renamed/defined in > NetworkPkg instead of MdeModulePkg, this new version is to update the > consuming PXE driver. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=886 > > This patch is to use the specifi

Re: [edk2] [PATCH v2 0/5] [CVE-2017-5753] Bounds Check Bypass issue in SMI handlers

On 09/25/18 08:12, Hao Wu wrote: > V2 changes: > A. Rename the newly introduced BaseLib API to 'AsmLfence', and makes it >IA32/X64 specific. > > B. Add brief comments before calls of the AsmLfence() to state the >purpose. > > C. Refine the patch for Variable/RuntimeDxe driver and make the

Re: [edk2] [PATCH v2 0/5] [CVE-2017-5753] Bounds Check Bypass issue in SMI handlers

On 09/25/18 22:51, Laszlo Ersek wrote: > On 09/25/18 08:12, Hao Wu wrote: >> V2 changes: >> A. Rename the newly introduced BaseLib API to 'AsmLfence', and makes it >>IA32/X64 specific. >> >> B. Add brief comments before calls of the AsmLfence() to state the >>purpose. >> >> C. Refine the pa

[edk2] [PATCH v2] MdeModulePkg: XhciDxe: Prevent illegal memory access in XhcSetHsee

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1206 Newly added XhcSetHsee() routine reads 4 bytes into a UINT16 variable causing issues on PCIE and NonDiscoverable Xhci controllers. Fix that. Cc: Ruiyu Ni Cc: Fei1 Wang Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [RFC] Create new edk2-test repo

This is a proposal to create a new repository for tests called edk2-test. The purpose of this repository is to provide test harnesses and test cases to test EDK II based firmware. There is test related content in edk2-staging branches and as that content is completed, a location for tests is requ

Re: [edk2] [PATCH v2] MdeModulePkg: XhciDxe: Prevent illegal memory access in XhcSetHsee

Good observation. Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Marcin Wojtas [mailto:m...@semihalf.com] Sent: Wednesday, September 26, 2018 5:58 AM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Kinney, Michael D ; Gao, Liming ; leif.lindh...@linaro.org; ard.biesheu...@

Re: [edk2] [PATCH v2] MdeModulePkg: XhciDxe: Prevent illegal memory access in XhcSetHsee

Just pushed it at e5cd809087e5710e019d2766fab13c59a2e2ac28. Really thanks. Star -Original Message- From: Zeng, Star Sent: Wednesday, September 26, 2018 8:30 AM To: Marcin Wojtas ; edk2-devel@lists.01.org Cc: Tian, Feng ; Kinney, Michael D ; Gao, Liming ; leif.lindh...@linaro.org; ard.bi

Re: [edk2] [Patch 6/6] NetworkPkg/UefiPxeBcDxe: Add the clarification compared to UefiPxeBcDxe in MdeModulePkg.

Thanks the correction, I will refine all the patches according your comments before committing the patches. Best Regards! Jiaxin > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, September 25, 2018 6:31 PM > To: Wu, Jiaxin ; edk2-devel@lists.01.org >

Re: [edk2] [PATCH] UefiCpuPkg SecCore:Add a GUID removed previously

Reviewed-by: Eric Dong And pushed 67998a547e47b231533f5b6668ac352f6c69104b > -Original Message- > From: Zhang, Shenglei > Sent: Tuesday, September 25, 2018 11:51 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [PATCH] UefiCpuPkg SecCore:Add a GUID removed previously > > Th

Re: [edk2] [PATCH v2 5/5] UefiCpuPkg/PiSmmCpuDxeSmm: [CVE-2017-5753] Fix bounds check bypass

Reviewed-by: Eric Dong > -Original Message- > From: Wu, Hao A > Sent: Tuesday, September 25, 2018 2:13 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Laszlo Ersek ; > Yao, Jiewen ; Kinney, Michael D > ; Dong, Eric > Subject: [PATCH v2 5/5] UefiCpuPkg/PiSmmCpuDxeSmm: [CVE-2017-5753] >

Re: [edk2] [PATCH v2 4/5] NetworkPkg: Define one PCD for PXE to specify MTFTP windowsize.

> > git-am complained about trailing whitespace: > > > (4) and here. > > With those fixed: > > Reviewed-by: Laszlo Ersek > I will fix them. Thanks reminder. /Jiaxin ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailm

Re: [edk2] [PATCH v2 0/5] Support windowsize to benefit tftp/pxe download performance.

> > MdeModulePke/Mtftp4Dxe: Support windowsize in read request > operation. > > NetworkPkg/Mtftp6Dxe: Support windowsize in read request operation. > > ShellPkg/TftpDynamicCommand: Add one option for tftp command to > > specify windowsize. > > NetworkPkg: Define one PCD for PXE to speci

Re: [edk2] [PATCH v2 5/5] UefiCpuPkg/PiSmmCpuDxeSmm: [CVE-2017-5753] Fix bounds check bypass

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, September 25, 2018 8:09 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Kinney, Michael D; Yao, Jiewen; Dong, Eric > Subject: Re: [edk2] [PATCH v2 5/5] UefiCpuPkg/

Re: [edk2] [PATCH v2 1/5] MdePkg/BaseLib: Add new AsmLfence API

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, September 25, 2018 9:01 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Yao, Jiewen; Gao, Liming; Kinney, Michael D > Subject: Re: [edk2] [PATCH v2 1/5] MdePkg/BaseLib: Add new AsmLfence API > > Hi Hao,

Re: [edk2] [PATCH v2 0/5] [CVE-2017-5753] Bounds Check Bypass issue in SMI handlers

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Wednesday, September 26, 2018 4:57 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Kinney, Michael D; Zeng, Star; Yao, Jiewen; Dong, Eric; Gao, Liming > Subject: Re: [edk2]

Re: [edk2] [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as unused

I agree to delete it! We have git history which can tell us how to re-add them in future.:) > -Original Message- > From: Carsey, Jaben > Sent: Tuesday, September 25, 2018 10:51 PM > To: Tomas Pilar (tpilar) ; edk2-devel@lists.01.org; Ni, > Ruiyu > Subject: RE: [edk2] [PATCH] ShellPkg: Ma

Re: [edk2] [PATCH] UefiCpuPkg/CpuMpPei: fix unsafe way to get stack pointer

Hi, Since the patch will introduce "#if defined(...)" macro in code, which violates edk2 coding style, it's suggested to add exception to static checker. I'll wait for one or two days in case there's other suggestions. If no objection then, I'll withdraw this patch and close BZ#1186 as not-fix.

[edk2] [PATCH] IntelFsp2Pkg/GenCfgOpt.py: support FixedAtBuild PCD

FixedAtBuild PCD is suggested to be used instead of FeatureFlag PCD so extend this tool to support. Also skipped PCDs which commented out by '#'. Cc: Jiewen Yao Cc: Gao Liming Cc: Zhu Yonghong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chasel Chiu --- IntelFsp2Pkg/

Re: [edk2] [PATCH 2/3] IntelFsp2Pkg: Fix typo in SplitFspBin

Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Chiu, Chasel > Sent: Friday, September 21, 2018 7:28 AM > To: Desimone, Nathaniel L ; Patrick > Georgi ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH 2/

Re: [edk2] [PATCH 3/3] IntelFsp2Pkg: Tell git to format SplitFspBin.py with native newlines

Hi Patrick Do you agree that we only need merge 2/3 and discard 1/3 and 3/3? I will push 2/3 after get your confirmation. Thank you Yao Jiewen > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Desimone, Nathaniel L > Sent: Thursday, September

Re: [edk2] [PATCH] IntelFsp2Pkg/GenCfgOpt.py: support FixedAtBuild PCD

Hi Chasel Would you please add the unit test information? Also, please file a Bugzilla for that. Thank you Yao Jiewen > -Original Message- > From: Chiu, Chasel > Sent: Wednesday, September 26, 2018 11:05 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Gao, Liming > ; Zhu, Yonghong ;

Re: [edk2] [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as unused

On 9/25/2018 10:50 PM, Carsey, Jaben wrote: I would prefer we just delete this. Ray, What do you think? Not sure I sent it or not. I also prefer to delete it. Git history can help in future if we need it again. ___ edk2-devel mailing list edk2-deve

Re: [edk2] [Patch v3 00/14] Update MSR definitions

On 9/25/2018 10:08 AM, Eric Dong wrote: Current MSR definition are follow the SDM 2016-09 version. The latest SDM is 2018-05. This patch serial update the MSR related definition to follow the latest SDM 2018-05 version. MSR related defintion are saved at UefiCpuPkg\Include\Register\. V3 chang

Re: [edk2] [RFC MdeModulePkg/UefiBootManagerLib v1 1/1] MdeModulePkg/UefiBootManagerLib: Fix raid card repair fail issue

> @@ -507,12 +552,13 @@ BmRepairAllControllers ( > FormBrowser2, > &HiiHandles[Index], > 1, > - PcdGetPtr (PcdDriverHealthConfigureForm), > +

[edk2] [PATCH] IntelFsp2Pkg/GenCfgOpt.py: support FixedAtBuild PCD

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1210 FixedAtBuild PCD is suggested to be used instead of FeatureFlag PCD so extend this tool to support. Also skipped PCDs which commented out by '#'. Test: Verified with FixedAtBuild PCD for including or excluding lines in generated UPD header

Re: [edk2] Tianocore and TPM2 pcr values

Hi Chao! Maybe the traces I get from the debug build and gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x7 gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x800A044F gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x2F can help. De: edk2-devel

Re: [edk2] Tianocore and TPM2 pcr values

Hi Jorge Yes, it is always good to enable serial port debug. There are lots of debug message in Tcg2Dxe driver. We can know what is wrong. In pure UEFI BIOS, the PEI driver extends to PCR0, and DXE image measurement lib extend to PCR2, PCR4, PCR5. The DXE driver extends variable to PCR1/7, and

Re: [edk2] Tianocore and TPM2 pcr values

Hi Yao > Yes, it is always good to enable serial port debug. There are lots of debug > message in Tcg2Dxe driver. We can know what is wrong. >From the log I've been able to see that "measure" messages start once >Tcg2Dxe.efi. From the beggining I can only see "ProtectUefiImageCommon" message

Re: [edk2] Tianocore and TPM2 pcr values

ProtectUefiImageCommon is not related. Below code is the Tcg2Dxe entrypoint, I expect you can see some message there: DriverEntry() if (CompareGuid (PcdGetPtr(PcdTpmInstanceGuid), &gEfiTpmDeviceInstanceNoneGuid) || CompareGuid (PcdGetPtr(PcdTpmInstanc

Re: [edk2] Tianocore and TPM2 pcr values

Yes, from log I see: Loading driver at 0x0008F3F2000 EntryPoint=0x0008F3F2240 Tcg2Dxe.efi InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D750DF 8F410C18 ProtectUefiImageCommon - 0x8F4107C0 - 0x8F3F2000 - 0xD800 PROGRESS CODE: V03040002 I0 InterfaceId - 0x

Re: [edk2] Tianocore and TPM2 pcr values

That means the TPM2 device works well. We have code to dump the final event log at Tcg2GetEventLog(). // Dump Event Log for debug purpose if ((EventLogLocation != NULL) && (EventLogLastEntry != NULL)) { DumpEventLog (EventLogFormat, *EventLogLocation, *EventLogLastEntry, mTcgDxeData.Final