On 10/5/2018 8:19 PM, Tim Lewis wrote:
Jaben --
Following on this: shouldn't this be a spec issue? If you are asking people
to depend on the behavior.
I agree. So I suggest submit a Spec ECR for this change.
Since it was checked in, we can revert it if the ECR is rejected.
Thanks,
Tim
Looks good to me. I will push this to Python3 branch.
Reviewed-by: Yonghong Zhu
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gary Lin
Sent: Tuesday, October 2, 2018 11:36 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming
Subject: [edk2] [PATCH]
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: Chiu, Chasel
Sent: Monday, October 08, 2018 4:11 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen ; Gao, Liming ;
Zhu, Yonghong ; Chiu, Chasel
Subject: [PATCH V2] IntelFsp2Pkg/GenCfgOpt.py: Support PCD input
On 10/8/2018 9:23 PM, jim.dai...@dell.com wrote:
-Original Message-
diff --git a/MdePkg/Library/BaseLib/FilePaths.c
b/MdePkg/Library/BaseLib/FilePaths.c
index d6f3758ecb..5d3de01894 100644
--- a/MdePkg/Library/BaseLib/FilePaths.c
+++ b/MdePkg/Library/BaseLib/FilePaths.c
@@ -2,6 +2,7
Hi Jian,
Not aware this comments before I send out V2 patch, will include this info in
commit message when I check in the code.
Thanks,
Eric
> -Original Message-
> From: Wang, Jian J
> Sent: Tuesday, October 9, 2018 10:03 AM
> To: edk2-devel ; Dong, Eric
> ; edk2-devel@lists.01.org
>
V2 changes:
Only disable paging in 32 bit mode, no matter it is enable or not.
V1 changes:
PEI Stack Guard needs to enable paging. This might cause #GP in the
transition from 32-bit PEI to 64-bit SMM due to the code trying to
write CR3 register with PML4 page table while the processor is enabled
On 10/9/2018 10:05 AM, Dong, Eric wrote:
Add BZ link for this issue: https://bugzilla.tianocore.org/show_bug.cgi?id=1232
Thanks,
Eric
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
Eric Dong
Sent: Tuesday, October 9, 2018 9:51 AM
To:
> -Original Message-
> From: Ni, Ruiyu
> Sent: Tuesday, October 9, 2018 10:07 AM
> To: Laszlo Ersek ; Bi, Dandan ;
> edk2-devel@lists.01.org
> Cc: Gao, Liming ; Zeng, Star
> Subject: Re: [edk2] [patch] MdeModulePkg/HiiDB: Fix incorrect structure
> convention for checkbox
>
> On 10/8/2018
Add BZ link for this issue: https://bugzilla.tianocore.org/show_bug.cgi?id=1232
Thanks,
Eric
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Eric Dong
> Sent: Tuesday, October 9, 2018 9:51 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ;
On 10/8/2018 11:15 PM, Laszlo Ersek wrote:
On 10/08/18 16:32, Bi, Dandan wrote:
what were the practical consequences (symptoms) of this issue? Did some
checkboxes not work? (I'm asking because SecureBootConfigDxe uses some
checkboxes.)
1. The bug is in function
Forgot one thing: this issue is caused by introducing of PEI stack guard so
please
add the revision id of related check in for references in message.
Regards,
Jian
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org]
> Sent: Tuesday, October 09, 2018 9:59 AM
Thanks for fixing this issue.
Reviewed-by: Jian J Wang
> -Original Message-
> From: Dong, Eric
> Sent: Tuesday, October 09, 2018 9:51 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Laszlo Ersek ; Wang,
> Jian J
> Subject: [Patch] UefiCpuPkg/S3Resume2Pei: disable paging before
PEI Stack Guard needs to enable paging. This might cause #GP in the
transition from 32-bit PEI to 64-bit SMM due to the code trying to
write CR3 register with PML4 page table while the processor is enabled
with PAE paging.
Simply disabling paging before updating CR3 can solve this conflict.
Reviewed-by: Star Zeng
-Original Message-
From: Gao, Liming
Sent: Monday, October 8, 2018 10:52 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Subject: RE: [edk2] [Patch 0/2] Update BrotliCompress to the latest version
1.0.5
Star:
Thank you for review. I just find Brotli 1.0.6 has been
This code is based on oniguruma,a opensource regular expression project.
So I want to keep the origin code as much as possible.And I distinguish my
changing by comment them out instead of removing.
Actually the function is unused.
Thanks,
Dongao.
-Original Message-
From: edk2-devel
Yes. The binary version edk2-BaseTools-win32 doesn't work now. It will not be
maintained.
If you still want to use the binary version BaseTools, you can switch to
version dd00d6c9eed34b5b4d3fb0c5a5714ceeaed76165 of edk2-BaseTools-win32. It
can work.
And, I strongly suggest to run BaseTools
(meta)
On 10/08/18 17:26, jim.dai...@dell.com wrote:
> Resending, as I never saw this email on the mailing list.
I did -- here's a link to the original in one of the archives too:
Does this mean that I should expect the Win32 tools to not work any more "out
of the box" for building images using GenFds?
K2
-Original Message-
From: Zhu, Yonghong
Sent: Sunday, October 7, 2018 5:35 PM
To: Kurt Kennett ; edk2-devel@lists.01.org
Cc: Zhu, Yonghong
Subject: RE: GenFds
Resending, as I never saw this email on the mailing list.
>-Original Message-
>From: Ni, Ruiyu [mailto:ruiyu...@intel.com]
>Sent: Monday, October 8, 2018 2:00 AM
>To: Dailey, Jim; edk2-devel@lists.01.org
>Cc: michael.d.kin...@intel.com; liming@intel.com
>Subject: Re: [edk2] [PATCH]
On 10/08/18 16:32, Bi, Dandan wrote:
> Hi Laszlo,
>
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Monday, October 08, 2018 8:19 PM
>> To: Bi, Dandan ; edk2-devel@lists.01.org
>> Cc: Zeng, Star ; Gao, Liming
>> Subject: Re: [edk2] [patch]
On 8 October 2018 at 16:52, Marcin Wojtas wrote:
> pon., 8 paź 2018 o 15:43 Ard Biesheuvel
> napisał(a):
>>
>> On 8 October 2018 at 15:37, Marcin Wojtas wrote:
>> > pon., 8 paź 2018 o 15:27 Ard Biesheuvel
>> > napisał(a):
>> >>
>> >> On 8 October 2018 at 15:17, Marcin Wojtas wrote:
>> >> >
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Gao, Liming
> Sent: Sunday, October 07, 2018 6:42 PM
> To: Tomas Pilar (tpilar) ; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] BaseTools: Allow multiple PciDeviceId in Fdf
>
Seems good to me.
Any thoughts Ray?
Reviewed-by: Jaben Carsey
> -Original Message-
> From: jim.dai...@dell.com [mailto:jim.dai...@dell.com]
> Sent: Thursday, October 04, 2018 9:47 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ruiyu
> Subject: [edk2] [PATCH] ShellPkg-Cd:
pon., 8 paź 2018 o 15:43 Ard Biesheuvel napisał(a):
>
> On 8 October 2018 at 15:37, Marcin Wojtas wrote:
> > pon., 8 paź 2018 o 15:27 Ard Biesheuvel
> > napisał(a):
> >>
> >> On 8 October 2018 at 15:17, Marcin Wojtas wrote:
> >> > pon., 8 paź 2018 o 15:07 Ard Biesheuvel
> >> > napisał(a):
>
Star:
Thank you for review. I just find Brotli 1.0.6 has been released. Based on
v1.0.5, there is the minor change in source file. They have no functionality
impact. I have pushed the additional patches in
https://github.com/lgao4/edk2/tree/Brotli to integrate 1.0.6 change. Could you
help
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jiaxin Wu
> Sent: Sunday, October 07, 2018 8:03 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ye, Ting ;
> Fu, Siyuan ; Wu, Jiaxin ; Bi,
> Dandan
> Subject:
Hi Laszlo,
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Monday, October 08, 2018 7:55 PM
> To: Bi, Dandan ; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Kinney, Michael D
> ; Gao, Liming
> Subject: Re: [edk2] [patch
Hi Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Monday, October 08, 2018 8:19 PM
> To: Bi, Dandan ; edk2-devel@lists.01.org
> Cc: Zeng, Star ; Gao, Liming
> Subject: Re: [edk2] [patch] MdeModulePkg/HiiDB: Fix incorrect structure
> convention for
On Mon, Oct 08, 2018 at 03:20:27PM +0530, Sumit Garg wrote:
> On Fri, 5 Oct 2018 at 20:33, Leif Lindholm wrote:
> >
> > On Wed, Oct 03, 2018 at 11:33:01AM +0200, Ard Biesheuvel wrote:
> > > On 3 October 2018 at 09:43, Sumit Garg wrote:
> > > > Add following APIs to communicate with OP-TEE
>-Original Message-
>From: Ni, Ruiyu [mailto:ruiyu...@intel.com]
>Sent: Monday, October 8, 2018 1:42 AM
>To: Dailey, Jim; edk2-devel@lists.01.org
>Cc: jaben.car...@intel.com
>Subject: Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment
>variable
>
>
>On 10/4/2018 12:02 AM,
On 09/30/18 00:23, Laszlo Ersek wrote:
> Repo: https://github.com/lersek/edk2.git
> Branch: inline_asm_rw_ops_1208
>
> This series mainly fixes the operand constraints (missing input-output
> qualifications) in "BaseSynchronizationLib/*/GccInline.c".
>
> (It would be better to remove these
On 8 October 2018 at 15:37, Marcin Wojtas wrote:
> pon., 8 paź 2018 o 15:27 Ard Biesheuvel
> napisał(a):
>>
>> On 8 October 2018 at 15:17, Marcin Wojtas wrote:
>> > pon., 8 paź 2018 o 15:07 Ard Biesheuvel
>> > napisał(a):
>> >>
>> >> On 8 October 2018 at 14:59, Marcin Wojtas wrote:
>> >> >
pon., 8 paź 2018 o 15:27 Ard Biesheuvel napisał(a):
>
> On 8 October 2018 at 15:17, Marcin Wojtas wrote:
> > pon., 8 paź 2018 o 15:07 Ard Biesheuvel
> > napisał(a):
> >>
> >> On 8 October 2018 at 14:59, Marcin Wojtas wrote:
> >> > Hi Ard,
> >> >
> >> > pon., 8 paź 2018 o 14:41 Ard Biesheuvel
On 8 October 2018 at 15:28, Marcin Wojtas wrote:
> Hi Ard,
>
> pon., 8 paź 2018 o 14:52 Ard Biesheuvel
> napisał(a):
>>
>> On 5 October 2018 at 15:26, Marcin Wojtas wrote:
>> > From: Tomasz Michalec
>> >
>> > This patch implements ArmadaBoarDescLib library for
>> > Armada8040 Development
Hi Ard,
pon., 8 paź 2018 o 14:52 Ard Biesheuvel napisał(a):
>
> On 5 October 2018 at 15:26, Marcin Wojtas wrote:
> > From: Tomasz Michalec
> >
> > This patch implements ArmadaBoarDescLib library for
> > Armada8040 Development Board and add to it ArmadaBoardDescSdMmcGet
> > function with
On 8 October 2018 at 15:17, Marcin Wojtas wrote:
> pon., 8 paź 2018 o 15:07 Ard Biesheuvel
> napisał(a):
>>
>> On 8 October 2018 at 14:59, Marcin Wojtas wrote:
>> > Hi Ard,
>> >
>> > pon., 8 paź 2018 o 14:41 Ard Biesheuvel
>> > napisał(a):
>> >>
>> >> (add MdeModulePkg maintainers)
>> >>
>>
>-Original Message-
>From: Ni, Ruiyu [mailto:ruiyu...@intel.com]
>Sent: Monday, October 8, 2018 2:00 AM
>To: Dailey, Jim; edk2-devel@lists.01.org
>Cc: michael.d.kin...@intel.com; liming@intel.com
>Subject: Re: [edk2] [PATCH] MdePkg-BaseLib: Fix PathCleanUpDirectories() error
pon., 8 paź 2018 o 15:07 Ard Biesheuvel napisał(a):
>
> On 8 October 2018 at 14:59, Marcin Wojtas wrote:
> > Hi Ard,
> >
> > pon., 8 paź 2018 o 14:41 Ard Biesheuvel
> > napisał(a):
> >>
> >> (add MdeModulePkg maintainers)
> >>
> >> On 5 October 2018 at 15:25, Marcin Wojtas wrote:
> >> > From:
On 8 October 2018 at 14:59, Marcin Wojtas wrote:
> Hi Ard,
>
> pon., 8 paź 2018 o 14:41 Ard Biesheuvel
> napisał(a):
>>
>> (add MdeModulePkg maintainers)
>>
>> On 5 October 2018 at 15:25, Marcin Wojtas wrote:
>> > From: Tomasz Michalec
>> >
>> > Some SD Host Controlers use different values in
Hi Ard,
pon., 8 paź 2018 o 14:41 Ard Biesheuvel napisał(a):
>
> (add MdeModulePkg maintainers)
>
> On 5 October 2018 at 15:25, Marcin Wojtas wrote:
> > From: Tomasz Michalec
> >
> > Some SD Host Controlers use different values in Host Control 2 Register
> > to select UHS Mode. This patch adds
On 5 October 2018 at 15:26, Marcin Wojtas wrote:
> From: Tomasz Michalec
>
> This patch implements ArmadaBoarDescLib library for
> Armada8040 Development Board and add to it ArmadaBoardDescSdMmcGet
> function with description of connected Xenon host controllers.
>
> Contributed-under: TianoCore
On 5 October 2018 at 15:26, Marcin Wojtas wrote:
> The newest changes in the SdMmcOverride protocol added additional
> arguments to the NotifyPhase and Capability routines. Update
> according places in the Synquacer Emmc driver.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
>
(add MdeModulePkg maintainers)
On 5 October 2018 at 15:25, Marcin Wojtas wrote:
> Some SdMmc host controllers are run by clocks with different
> frequency than it is reflected in Capabilities Register 1.
> It is allowed by SDHCI specification ver. 4.2 - if BaseClkFreq
> field value of the
(add MdeModulePkg maintainers)
On 5 October 2018 at 15:25, Marcin Wojtas wrote:
> From: Tomasz Michalec
>
> Some SD Host Controlers need to do additional opperations after clock
> frequency switch.
>
controllers
operations
Otherwise, this looks fine to me
Reviewed-by: Ard Biesheuvel
> This
(add MdeModulePkg maintainers)
On 5 October 2018 at 15:25, Marcin Wojtas wrote:
> From: Tomasz Michalec
>
> Some SD Host Controlers use different values in Host Control 2 Register
> to select UHS Mode. This patch adds a new UhsSignaling type routine to
> the NotifyPhase of the SdMmcOverride
(add MdeModulePkg maintainers)
On 5 October 2018 at 15:25, Marcin Wojtas wrote:
> In order to ensure bigger flexibility in the NotifyPhase
> routine of the SdMmcOverride protocol, enable using an
> optional phase-specific data. This will allow to exchange
> more information between the protocol
Hi Dandan,
On 10/08/18 03:29, Dandan Bi wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1224
>
> When covert IFR binary to EFI_IFR_CHECKBOX structure,
> Current code has following incorrect code logic:
> IfrCheckBox = (EFI_IFR_CHECKBOX *) (IfrOpHdr + 1);
> The correct one should be:
On 10/08/18 08:39, Ni, Ruiyu wrote:
> On 9/28/2018 2:18 PM, Ming Huang wrote:
>>
>>
>> On 9/26/2018 1:00 PM, Ni, Ruiyu wrote:
@@ -507,12 +552,13 @@ BmRepairAllControllers (
FormBrowser2,
[Index],
Hi Ray,
On 10/08/18 05:07, Ni, Ruiyu wrote:
>> -Original Message-
>> From: Laszlo Ersek
>> Sent: Tuesday, October 2, 2018 6:14 PM
>> To: Ni, Ruiyu ; Zhang, Chao B
>> Cc: Zhang, Shenglei ; edk2-devel@lists.01.org;
>> Kinney, Michael D
>> Subject: Re: [edk2] [PATCH v3 00/16] Removed
Hi Dandan,
On 10/08/18 05:31, Dandan Bi wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1225
>
> According to UEFI spec, the string expression of UTF8 vendor
> device node should be displayed as: VenUtf8(). Current code
> display it as: VenUft8() by mistake when convert device
>
On 10/05/18 22:43, Rebecca Cran wrote:
> I don't see any information about time/place/etc. - should there be an
> attachment?
There is an attachment on the original invite email, called "invite.cs".
I see it on the instance of the invite that I got in my inbox directly,
not reflected from the
On 10/08/18 05:04, Gao, Liming wrote:
> Laszlo:
>We meet with this failure in GCC4.8 and GCC4.9, but not in GCC5. We don't
> verify earlier version than GCC4.8.
>GCC48 is the specific tool chain for GCC4.8. But, GCC49 is the general
> tool chain that can be used with GCC4.9 or the
On Mon, Oct 08, 2018 at 03:56:48PM +0800, Dongao Guo wrote:
>
> comment unused variable to avoid warning,and modify inf build option.
>
Why not just remove the variables altogether instead of commenting them out?
Is it on purpose?
Gary Lin
> Cc: Liming Gao
> Contributed-under: TianoCore
On Fri, 5 Oct 2018 at 20:33, Leif Lindholm wrote:
>
> On Wed, Oct 03, 2018 at 11:33:01AM +0200, Ard Biesheuvel wrote:
> > On 3 October 2018 at 09:43, Sumit Garg wrote:
> > > Add following APIs to communicate with OP-TEE pseudo/early TAs:
> > > 1. OpteeInit
> > > 2. OpteeOpenSession
> > > 3.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1231
Build system already support override PCD value by command
line so add this support to GenCfgOpt.py
Also update revision to 0.53
Test: Verified UPD header files generated can reflect different
PCD values from --pcd build command
comment unused variable to avoid warning,and modify inf build option.
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dongao Guo
---
.../RegularExpressionDxe/Oniguruma/regexec.c | 28 +++---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1231
Build system already support override PCD value by command
line so add this support to GenCfgOpt.py
Test: Verified UPD header files generated can reflect different
PCD values from --pcd build command input
Cc: Jiewen Yao
Cc: Gao
On 10/4/2018 11:03 PM, jim.dai...@dell.com wrote:
MdePkg-BaseLib: Fix PathCleanUpDirectories() error involving "\..\.."
The loop that removes "\..\" errs when multiple "\.." sequences are
in the path. Before this change the code would modify a path like
"FS0:\efi\tools\..\.." to
On 10/8/2018 11:31 AM, Dandan Bi wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1229
When converting DebugPort device path from text,
current code use VENDOR_DEFINED_MESSAGING_DEVICE_PATH structure
for Debug port device node.
typedef struct {
EFI_DEVICE_PATH_PROTOCOL Header;
On 10/8/2018 11:31 AM, Dandan Bi wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1228
According to UEFI spec,for ACPI Expanded Device Path
when HID=PNP0A03 or CID=PNP0A03 and HID != PNP0A08,
the device path node can be displayed as: PciRoot(UID|UIDSTR)
When HID=PNP0A08 or
On 10/8/2018 11:31 AM, Dandan Bi wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1226
According to UEFI Spec, for ACPI Expanded Device Path,
when HIDSTR=empty, CIDSTR=empty, UID STR!=empty,
the ACPI Expanded Device Path node can be displayed as
AcpiExp(HID,CID,UIDSTR) format.
And if
On 10/8/2018 11:31 AM, Dandan Bi wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1227
According to UEFI Spec, ACPI Expanded Device Path can be display
AcpiEx(HID|HIDSTR,(CID|CIDSTR,UID|UIDSTR)), but current code display
UID|UIDSTR before CID|CIDSTR.
This patch is to fix this issue.
On 10/8/2018 11:31 AM, Dandan Bi wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1225
According to UEFI spec, the string expression of UTF8 vendor
device node should be displayed as: VenUtf8(). Current code
display it as: VenUft8() by mistake when convert device
path node to text.
On 10/4/2018 12:02 AM, jim.dai...@dell.com wrote:
Create a homefilesystem environment variable whose value is the file
system on which the executing shell is located. For example: "FS14:".
This eliminates the need for people to have to try and find the "boot"
file system in their startup
On 9/28/2018 2:18 PM, Ming Huang wrote:
On 9/26/2018 1:00 PM, Ni, Ruiyu wrote:
@@ -507,12 +552,13 @@ BmRepairAllControllers (
FormBrowser2,
[Index],
1,
-
Disable DCI which allows debug over USB3.0.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: David Wei
CC: Mike Wu
CC: Mang Guo
---
.../Common/PlatformSettings/PlatformSetupDxe/SouthClusterConfig.vfi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Wu, Jiaxin
Sent: Monday, October 8, 2018 11:03 AM
To: edk2-devel@lists.01.org
Cc: Carsey, Jaben ; Fu, Siyuan ;
Ye, Ting ; Bi, Dandan ; Wu, Jiaxin
Subject: [Patch 0/2] Correct comments to align with the input parameter.
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Wu, Jiaxin
Sent: Monday, October 8, 2018 11:08 AM
To: edk2-devel@lists.01.org
Cc: Fu, Siyuan ; Ye, Ting ; Bi, Dandan
; Wu, Jiaxin
Subject: [Patch] MdeModulePkg/Tcp4Dxe: Remove the trailing white space in one
line.
Cc:
68 matches
Mail list logo