On 2018/10/15 12:55, Hao Wu wrote:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1249
We found potential dead codes within File.c during the code coverage test.
After manual review, we think the below ones are positive reports:
A. For function GetAllocationDescriptor():
Due to the all the
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, October 16, 2018 10:41 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Yao, Jiewen ;
> Zhang, Chao B ; Wang, Jian J
>
> Subject: [PATCH] MdeModulePkg Variable: Fix Timestamp zeroing issue on
> A
Reviewed-by: Feng, Bob C
-Original Message-
From: Zhao, ZhiqiangX
Sent: Wednesday, October 10, 2018 4:41 PM
To: edk2-devel@lists.01.org
Cc: Zhao, ZhiqiangX ; Gao, Liming
; Zhu, Yonghong ; Feng, Bob C
Subject: [PATCH] BaseTool: Support different PCDs that refers to the same EFI
variab
The series will address a couple of bugs within the UDF related codes.
Please refer to the log message of each commit for more details.
Cc: Paulo Alcantara
Cc: Ruiyu Ni
Cc: Jiewen Yao
Cc: Star Zeng
Hao Wu (10):
MdeModulePkg/PartitionDxe: Add check for underlying device block size
MdeModu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=828
Within ReadFile():
Add checks to ensure that when getting the raw data or the Allocation
Descriptors' data from a FE/EFE, it will not consume data beyond the
size of a FE/EFE.
Cc: Paulo Alcantara
Cc: Ruiyu Ni
Cc: Jiewen Yao
Cc: Star Zeng
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=828
Within FindAnchorVolumeDescriptorPointer():
Add a check for the underlying device block size to ensure it is greater
than the size of an Anchor Volume Descriptor Pointer.
Cc: Paulo Alcantara
Cc: Ruiyu Ni
Cc: Jiewen Yao
Cc: Star Zeng
Cont
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=828
The commit refines the boundary checks for file/path name string to
prevent possible buffer overrun.
Cc: Paulo Alcantara
Cc: Ruiyu Ni
Cc: Jiewen Yao
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1254
This commit will add an additional check within function GetPdFromLongAd()
when getting a Partition Descriptor from given a Long Allocation
Descriptor.
According to UDF 2.60 Spec, Section 2.2.13:
> The partition reference numbers used are d
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=828
Within GetVolumeSize():
The boundary check will validate the 'NumberOfPartitions' field of a
Logical Volume Integrity Descriptor matches the data within the relating
Logical Volume Descriptor.
Cc: Paulo Alcantara
Cc: Ruiyu Ni
Cc: Jiewen Ya
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1175
This commit will update the UdfGetInfo() function with the support of
EFI_FILE_SYSTEM_VOLUME_LABEL data information request.
Cc: Paulo Alcantara
Cc: Ruiyu Ni
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1255
For function ReadFile():
If the line
Status = GetAedAdsData (
...
);
is reached multiple times during the 'for' loop, freeing the data pointed
by variable 'Data' may potentially lead to variable 'Ad' referencing the
already-freed d
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=828
Within ResolveSymlink():
The boundary check will validate the 'LengthofComponentIdentifier' field
of a Path Component matches the data within the relating (Extended) File
Entry.
Cc: Paulo Alcantara
Cc: Ruiyu Ni
Cc: Jiewen Yao
Cc: Star Zen
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1253
Within function SetFileInfo():
This commit will fix a typo where 'Minute' should be used instead of
'Second'.
Cc: Paulo Alcantara
Cc: Ruiyu Ni
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu
--
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1252
Calling the 'SetPosition' service of the EFI_FILE_PROTOCOL with 'Position'
equals to 0x for a file is to set the current position to
the end of the file. But the current implementation of function
UdfSetPosition() is to set it
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
---
MdeModulePkg/Library/BrotliCustomDecompressLib/dec/decode.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/MdeModulePkg/Library/BrotliCustomDecompressLib/dec/decode.c
b/MdeMod
Hi Ruiyu,
> -Original Message-
> From: Ni, Ruiyu
> Sent: Tuesday, October 16, 2018 11:05 AM
> To: Dong, Eric ; edk2-devel@lists.01.org
> Cc: Laszlo Ersek
> Subject: Re: [Patch 3/4] UefiCpuPkg/RegisterCpuFeaturesLib: Add logic to
> support semaphore type.
>
> On 10/15/2018 10:49 AM, Eric
Hao,
If these code removing will make the function to be not matched with its
original implementation purpose according to the function description,
and the description is not updated, the code's readability will be
sacrificed. I prefer to keep the code's readability and follow the
function's
On 10/16/2018 3:11 PM, shenglei wrote:
Remove FatBinPkg and modify Maintainers.txt.
https://bugzilla.tianocore.org/show_bug.cgi?id=1105
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
FatBinPkg/EnhancedFatDxe/AArch64/Fat.efi | Bin 26752
On 2018/10/16 14:59, Zeng, Star wrote:
On 2018/10/15 12:55, Hao Wu wrote:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1249
We found potential dead codes within File.c during the code coverage
test.
After manual review, we think the below ones are positive reports:
A. For function Get
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, October 16, 2018 3:50 PM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu; Zeng, Star
> Subject: Re: [edk2] [PATCH v1 7/7] MdeModulePkg/UdfDxe: Handle dead
> codes in FileSystemOperations.c
>
> On 2018/10/16 14:59, Zeng, Star
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Zeng, Star
> Sent: Tuesday, October 16, 2018 3:46 PM
> To: Wu, Hao A; Leif Lindholm
> Cc: Ni, Ruiyu; edk2-devel@lists.01.org; Zeng, Star
> Subject: Re: [edk2] [PATCH v1 6/7] MdeModulePkg/UdfDxe:
Note:
Since PATCH v2 1/6 ~ 5/6 have not been changed, add the 'Reviewed-by:' tag
during the v1 series review.
V2 changes:
A. Drop PATCH v1 6/7, since removing those codes will make the function
MangleFileName() not matching its original implementation purpose
(according to the function des
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1247
For functions DuplicateFid() and DuplicateFe(), this commit will use error
handling logic instead of ASSERTs for memory allocation failure.
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu
Reviewed
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1248
This commit will refine the ASSERTs in function GetLongAdLsn() and
GetAllocationDescriptorLsn() when the logical sector number cannot be
returned due to unrecognized media format.
Error handling logic will be used for those ASSERTs.
Cc: Rui
This commit adds ASSERTs to address false positive reports of NULL
pointer dereference issues raised from static analysis with regard to
function ReadDirectoryEntry().
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu
Reviewed-by: Paulo Alcantara
Reviewe
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1248
Within function UdfOpen():
This commit will use debug messages instead of using ASSERT when an error
occurs after calling GetFileSize().
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu
Reviewed-by
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1249
We found potential dead codes within File.c during the code coverage test.
After manual review, we think the below ones are positive reports:
A. In function UdfRead():
else if (IS_FID_DELETED_FILE (Parent->FileIdentifierDesc)) {
Statu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1249
We found potential dead codes within File.c during the code coverage test.
After manual review, we think the below ones are positive reports:
A. For function GetAllocationDescriptor():
Due to the all the calling places for this function, th
From: Hess Chen
Change the criteria of the checkpoint of "#ifndef" to remove the requirement of
prefix '_'.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hess Chen
---
BaseTools/Source/Python/Ecc/Check.py| 2 +-
BaseTools/Source/Python/Ecc/EccToolError.py | 2
From: Hess Chen
The tool now can detect the error that the content between double
quotes contains another double quotes or enter key.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hess Chen
---
.../Source/Python/UPT/Library/UniClassObject.py| 23 +++
From: Hess Chen
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hess Chen
---
BaseTools/Source/Python/Ecc/Check.py | 12 +++-
BaseTools/Source/Python/Ecc/c.py | 8 ++--
2 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/BaseTools/Source/Pytho
On 10/11/2018 9:05 PM, jim.dai...@dell.com wrote:
Is the line:
Size = gST->Hdr.HeaderSize;
possibly a better way of handling this? Either way:
Reviewed-by: Jim Dailey
Thanks! I will stick to use sizeof().
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@li
On 10/15/2018 02:33 AM, Supreeth Venkatesh wrote:
Please use a commit message less than 80 Cols.
On 10/13/2018 04:42 PM, Eric Jin wrote:
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin
---
...rTaskPriorityServicesBBTes
Commit Message less than 80 cols please.
On 10/13/2018 04:51 PM, Eric Jin wrote:
For the SD device, no same as the eMMC, the 'EraseLengthGranularity' is 1.
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin
---
.../BlackB
On 10/14/2018 03:06 AM, Eric Jin wrote:
Add the EFI_SIMPLE_NETWORK_RECEIVE_MULTICAST bit in the Enable parameter
Add one checkpoint to MCastFilterCount is zero
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin
---
.../Sim
Reviewed-by: Supreeth Venkatesh
If the commit message is broken down into multiple lines less than 80 cols.
On 10/13/2018 04:19 PM, Eric Jin wrote:
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin
---
.../AuthVariableSer
Reviewed-by: Supreeth Venkatesh
On 10/13/2018 05:27 PM, Eric Jin wrote:
Possible numeric underflow when calculating the starting LBA for
ReadBlocks_Func test
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin
---
.../Prot
On 10/13/2018 05:33 PM, Eric Jin wrote:
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin
---
.../BlackBoxTest/DevicePathFromTextBBTestCoverage.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff -
On 10/14/2018 02:31 AM, Eric Jin wrote:
Ensure the HwErrRecVariable could be deleted before the test exit.
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin
---
.../BlackBoxTest/VariableServicesBBTestFunction.c
On 10/14/2018 04:54 AM, Eric Jin wrote:
Correct the guid of EFI_GUID gEfiBlueToothIoProtocolGuid and
gEfiBlueToothConfigProtocolGuid
Add BlueToothLE support test in the EfiCompliant part
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off
FYI
On 10/15/2018 02:33 AM, Supreeth Venkatesh wrote:
Please use a commit message less than 80 Cols.
On 10/13/2018 04:42 PM, Eric Jin wrote:
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin
---
...rTaskPriorityServicesB
On 10/13/2018 05:21 PM, Eric Jin wrote:
UEFI Spec clarify the Toggle state
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin
---
.../SimpleTextInputEx/BlackBoxTest/Guid.c | 7 +-
.../SimpleTextInputEx/BlackBoxTest/
On 10/14/2018 03:25 AM, Eric Jin wrote:
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin
---
.../DevicePathToTextBBTestCoverage.c | 43 ++-
.../BlackBoxTest/DevicePathToTextBBTestMain.c | 26
Reviewed-by: Supreeth Venkatesh
On 10/13/2018 04:30 PM, Eric Jin wrote:
The Results output from ExtractConfigFunction() may be different during two
calls in some case.
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin
---
Please use a commit message less than 80 Cols.
On 10/13/2018 04:42 PM, Eric Jin wrote:
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin
---
...rTaskPriorityServicesBBTestCreateEventEx.c | 26 +++
.../Black
Commit Message less than 80 cols please.
On 10/13/2018 04:51 PM, Eric Jin wrote:
For the SD device, no same as the eMMC, the 'EraseLengthGranularity' is 1.
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin
---
.../BlackBoxT
Reviewed-by: Supreeth Venkatesh
On 10/14/2018 02:58 AM, Eric Jin wrote:
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin
---
uefi-sct/SctPkg/Library/SctLib/Print.c | 6 --
1 file changed, 4 insertions(+), 2 deletions
On 10/14/2018 05:26 PM, Eric Jin wrote:
The EraseSize in the EraseBlocks conf test should be bytes.
Cover the case that the size of the data to erase is a
multiple of the 'EraseLengthGranularity' value of an Erase Block
Protocol instance. And check whether the data on adjacent blocks
are mista
FYI
On 10/15/2018 03:08 AM, Supreeth Venkatesh wrote:
Commit Message less than 80 cols please.
On 10/13/2018 04:51 PM, Eric Jin wrote:
For the SD device, no same as the eMMC, the 'EraseLengthGranularity' is 1.
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution
Thanks a lot Liming!
Em seg, 15 de out de 2018 às 23:10, Gao, Liming
escreveu:
> Rafael:
> https://bugzilla.tianocore.org/show_bug.cgi?id=686 public now. You can
> view it. I also send the patches to fix it. Please check.
>
> Thanks
> Liming
> >-Original Message-
> >From: edk2-devel [m
Hi Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, October 16, 2018 1:13 AM
> To: Dong, Eric ; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu
> Subject: Re: [Patch 4/4] UefiCpuPkg/PiSmmCpuDxeSmm: Add logic to support
> semaphore type.
>
> On 10/15/1
https://bugzilla.tianocore.org/show_bug.cgi?id=1257
Binary python tool is not supported anymore. So, the freeze python tool
step is not required.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
Cc: Yonghong Zhu
---
BaseTools/BuildNotes.txt | 3 +-
Thank you for the feedback.
Comments below.
On 10/15/2018 4:58 PM, Jeremiah Cox wrote:
Some additional feedback...
General
---
We would like to have a discussion around goals, what are the top issues we are
trying to solve with these solutions? We believe a primary challenge is getting
Hi Ruiyu,
> -Original Message-
> From: Ni, Ruiyu
> Sent: Tuesday, October 16, 2018 11:16 AM
> To: Dong, Eric ; edk2-devel@lists.01.org
> Cc: Laszlo Ersek
> Subject: Re: [Patch 4/4] UefiCpuPkg/PiSmmCpuDxeSmm: Add logic to
> support semaphore type.
>
> On 10/15/2018 10:49 AM, Eric Dong wro
the case is:
in the DSC:
[PcdsFixedAtBuild.common]
TokenSpaceGuid.TestFixedPcd|0xFFEAA000
[PcdsDynamicExDefault.common.DEFAULT]
!if TokenSpaceGuid.PcdFlag == TRUE
TokenSpaceGuid.PcdTest|TokenSpaceGuid.TestFixedPcd
!endif
Then build with --pcd TokenSpaceGuid.PcdFlag=TRUE, it report failure,
but i
V2 changes include:
1. Include the change for CpuCommonFeaturesLib which used to set MSR base on
its scope info.
2. Include the change for CpuS3DataDxe driver which also handle the AcpiCpuData
data.
3. Update code base on feedback for V1 changes.
V1 changes include:
In a system which has multipl
v2 changes:
1. Add more description about why we do this change.
2. Change structure field type from pointer to EFI_PHYSICAL_ADDRESS because it
will
be share between PEI and DXE.
In order to support semaphore related logic, add new definition for it.
In a system which has multiple cores, curr
Because this driver needs to set MSRs saved in normal boot phase, sync semaphore
logic from RegisterCpuFeaturesLib code which used for normal boot phase.
Detail see below change for RegisterCpuFeaturesLib:
UefiCpuPkg/RegisterCpuFeaturesLib: Add logic to support semaphore type.
Cc: Ruiyu Ni
Cc:
Add new core/package dependence types which consumed by different MSRs.
Cc: Ruiyu Ni
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
.../Include/Library/RegisterCpuFeaturesLib.h | 25 ++
1 file changed, 21 insertio
V2 changes include:
1. Add more description for the code part which need easy to understand.
2. Refine some code base on feedback for V1 changes.
V1 changes include:
In a system which has multiple cores, current set register value task costs
huge times.
After investigation, current set MSR task c
AcpiCpuData add new fields, keep these fields if old data already existed.
Cc: Ruiyu Ni
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/UefiCpuPkg/Cpu
Because MSR has scope attribute, driver has no needs to set
MSR for all APs if MSR scope is core or package type. This patch
updates code to base on the MSR scope value to add MSR to the register
table.
Cc: Ruiyu Ni
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-
From: Hess Chen
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hess Chen
---
BaseTools/Source/Python/Ecc/Check.py | 60
BaseTools/Source/Python/Ecc/Configuration.py | 3 ++
BaseTools/Source/Python/Ecc/EccToolError.py | 2 +
BaseToo
Series Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni
Sent: Tuesday, October 16, 2018 1:43 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v2 00/12] Need to validate data from HW
The patches c
Hi,
Reviewed-by: Benjamin You
Thanks,
- ben
> -Original Message-
> From: Wonkyu Kim [mailto:norwayfores...@gmail.com]
> Sent: Tuesday, October 16, 2018 6:45 AM
> To: edk2-devel@lists.01.org
> Cc: You, Benjamin ; Agyeman, Prince
> ; gauml...@gmail.com;
> stefan.reina...@coreboot.org; Wi
Oh, Remember the missing update in UsbMassBoot.h about adding back '.', you can
do that when pushing patches.
- Read some blocks from the device by SCSI 16 byte cmd.
+ Read or write some blocks from the device by SCSI 16 byte cmd
Thanks,
Star
-Original Message-
From: Zeng, Star
Sent
Series Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Wu, Hao A
Sent: Tuesday, October 16, 2018 4:15 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Paulo Alcantara ; Paulo
Alcantara ; Ni, Ruiyu ; Zeng, Star
; Yao, Jiewen
Subject: [PATCH v2 0/6] Code refinements in UdfDx
67 matches
Mail list logo
