[edk2] [PATCH v1 1/1] ArmPkg/OpteeLib: Fix compilation issues for ARM (32-bit)

2018-11-01 Thread Sumit Garg
Correct usage of EFI_PHYSICAL_ADDRESS (always 64-bit) vs. pointers (depending on architecture). Reported-by: Leif Lindholm Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sumit Garg --- ArmPkg/Library/OpteeLib/Optee.c | 14 +++--- 1 file changed, 7 insertions(+),

Re: [edk2] [Patch 1/1] BaseTools tools_def.template: Add GCC link script in X86 ASLDLINK_FLAGS

2018-11-01 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Thursday, November 01, 2018 10:47 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong Subject: [Patch 1/1] BaseTools tools_def.template: Add GCC link script in X86 ASLDLINK_FLAGS This fix r

[edk2] [Patch V3] BaseTools: Use common cc flag for building PcdValueInit.

2018-11-01 Thread BobCF
V3: Update the patch to avoid "reduce" function fail. V2: Support to extract the common cc flag from a combined cc flag string. For example MSFT:*_*_IA32_CC_FLAGS = /D DISABLE_NEW_DEPRECATED_INTERFACES /DDEF_IA32 MSFT:*_*_X64_CC_FLAGS = /DDEF_X64 /D DISABLE_NEW_DEPRECATED_INTERFACES V1: Use com

Re: [edk2] [PATCH edk2-platforms 01/27] Platform/Microsoft: Add OpteeClientPkg dec

2018-11-01 Thread Sumit Garg
+ OP-TEE ML. On Fri, 2 Nov 2018 at 06:11, Chris Co wrote: > > Hi Sumit, > > Our full OpteeClientPkg has: > - Our OpteeClientAPI implementation. I was monitoring the merge progress on > OpteeLib and will look into moving over now that it is available. > - The fTPM and AuthVar TA binaries. In our

Re: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all module types

2018-11-01 Thread Zeng, Star
Liming, Will you help push the patch series? Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gao, Liming Sent: Thursday, November 1, 2018 9:31 PM To: Jeff Brasen ; Ni, Ruiyu ; edk2-devel@lists.01.org Cc: Kinney, Michael D ; Gao, L

[edk2] [Patch V2] BaseTools: Use common cc flag for building PcdValueInit.

2018-11-01 Thread BobCF
V2: Support to extract the common cc flag from a combined cc flag string. For example MSFT:*_*_IA32_CC_FLAGS = /D DISABLE_NEW_DEPRECATED_INTERFACES /DDEF_IA32 MSFT:*_*_X64_CC_FLAGS = /DDEF_X64 /D DISABLE_NEW_DEPRECATED_INTERFACES V1: Use common cc flags for building pcdinitvalue. The common cc fl

Re: [edk2] [PATCH] BaseTools/Eot: Remove a duplication code in EotMain class

2018-11-01 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Wednesday, October 31, 2018 3:49 PM To: edk2-devel@lists.01.org Cc: Chen, Hesheng Subject: [edk2] [PATCH] BaseTools/Eot: R

[edk2] [PATCH v2 3/5] Revert "OvmfPkg/QemuVideoDxe: Helper functions for unaligned port I/O."

2018-11-01 Thread yuchenlin via edk2-devel
From: yuchenlin This reverts commit 05a5379458725234de8a05780fcb5da2c12680e4. The VMWare SVGA display device implemented by Qemu (-vga vmware) uses an I/O-type BAR which is laid out such that some register offsets are not aligned to the read/write width with which they are expected to be accesse

[edk2] [PATCH v2 5/5] OvmfPkg: simply use the Bochs interface for vmsvga

2018-11-01 Thread yuchenlin via edk2-devel
From: yuchenlin BAR |std vga | vmsvga - 0| Framebuffer | I/O space 1| Reserved | Framebuffer 2| MMIO | FIFO Because of the PCI BARs difference between std vga and vmsvga, we can not simply recognize the "QEMU VMWare SVGA" a

[edk2] [PATCH v2 0/5] OvmfPkg: simply use the Bochs interface for vmsvga

2018-11-01 Thread yuchenlin via edk2-devel
From: yuchenlin In this series, replace the original vmsvga driver to Bochs interface. Simply revert vmsvga driver implementation. After it, use Bochs interface for initializing vmsvga. Because of the PCI BARs difference between std vga and vmsvga. We can not simply recognize the "QEMU VMWare S

[edk2] [PATCH v2 2/5] Revert "OvmfPkg/QemuVideoDxe: VMWare SVGA device support"

2018-11-01 Thread yuchenlin via edk2-devel
From: yuchenlin This reverts commit c137d95081690d4877fbeb5f1856972e84ac32f2. The VMWare SVGA model now -- since commit 104bd1dc70 in QEMU -- falls back to stdvga (that is, Bochs) if we don't setup VMWare SVGA FIFO. To simplify QemuVideoDxe, we don't intend to implement the VMWare SVGA FIFO set

[edk2] [PATCH v2 4/5] Revert "OvmfPkg: VMWare SVGA display device register definitions"

2018-11-01 Thread yuchenlin via edk2-devel
From: yuchenlin This reverts commit 9bcca53fe466cdff397578328d9d87d257aba493. We reverted VMWare SVGA driver. We don't need these definitions too. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: yuchenlin --- OvmfPkg/Include/IndustryStandard/VmwareSvga.h | 104 -

[edk2] [PATCH v2 1/5] Revert "OvmfPkg/QemuVideoDxe: list "UnalignedIoInternal.h" in the INF file"

2018-11-01 Thread yuchenlin via edk2-devel
From: yuchenlin This reverts commit b2959e9f1a57279506ca46d56bc424fd7fa6b62a. The VMWare SVGA display device implemented by Qemu (-vga vmware) uses an I/O-type BAR which is laid out such that some register offsets are not aligned to the read/write width with which they are expected to be accesse

[edk2] [PATCH] UnixPkg: Remove UnixPkg and update Maintainers.txt

2018-11-01 Thread Shenglei Zhang
UnixPkg is deprecated. The same functionality is supported using the EmulatorPkg. Please see EmulatorPkg/README for more information about EmulatorPkg. https://bugzilla.tianocore.org/show_bug.cgi?id=1291 Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney Contributed-under:

Re: [edk2] [PATCH v3 1/1] BaseTools: Explicitly close files after readlines

2018-11-01 Thread Feng, Bob C
Reviewed-by: Bob C Feng Thanks, Bob -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] Sent: Friday, November 2, 2018 10:02 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [PATCH v3 1/1] BaseTools: Explicitly close files after readlines From:

Re: [edk2] [PATCH 0/4] OvmfPkg: simply use the Bochs interface for vmsvga

2018-11-01 Thread yuchenlin via edk2-devel
On 2018-11-02 03:02, Philippe Mathieu-Daudé wrote: Hi Yu-chen Lin, On 24/10/18 8:40, yuchen...@synology.com wrote: From: yuchenlin In this series, replace the original vmsvga driver to Bochs interface. This is the 'v2' of your previous patch 'OvmfPkg: initialize bochs when initializing vmsv

Re: [edk2] [PATCH 1/4] Revert "OvmfPkg/QemuVideoDxe: VMWare SVGA device support"

2018-11-01 Thread yuchenlin via edk2-devel
On 2018-11-02 02:58, Philippe Mathieu-Daudé wrote: Hi Yu-chen Lin, On 24/10/18 8:40, yuchen...@synology.com wrote: From: yuchenlin This reverts commit c137d95081690d4877fbeb5f1856972e84ac32f2. Can we have a comment here about why we need to revert this patch? (same for patches 2 and 3).

Re: [edk2] [PATCH 4/4] OvmfPkg: simply use the Bochs interface for vmsvga

2018-11-01 Thread yuchenlin via edk2-devel
On 2018-11-02 02:54, Philippe Mathieu-Daudé wrote: Hi Yu-chen Lin, On 24/10/18 8:40, yuchen...@synology.com wrote: From: yuchenlin BAR |std vga | vmsvga - 0| Framebuffer | I/O space 1| Reserved | Framebuffer 2| MMIO | FI

[edk2] [PATCH v3 1/1] BaseTools: Explicitly close files after readlines

2018-11-01 Thread Michael Johnson
From: mjohn4 Rework some file open().readlines to open, readlines, close. This prevents excessive file handles being open at the same time, which may be a problem with alternative python environments. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael

Re: [edk2] [Patch] BaseTools: Use common cc flag for building PcdValueInit.

2018-11-01 Thread Gao, Liming
Bob: I find this patch can't handle below case to retrieve the common option. Please help check it. [BuildOptions] MSFT:*_*_IA32_CC_FLAGS = /D DISABLE_NEW_DEPRECATED_INTERFACES /DDEF_IA32 MSFT:*_*_X64_CC_FLAGS = /DDEF_X64 /D DISABLE_NEW_DEPRECATED_INTERFACES Thanks Liming >-Original

Re: [edk2] [PATCH edk2-platforms 05/27] Silicon/NXP: Add UART library support for i.MX platforms

2018-11-01 Thread Chris Co via edk2-devel
Hi Leif, > -Original Message- > From: Leif Lindholm > Sent: Thursday, November 1, 2018 2:00 AM > To: Chris Co > Cc: edk2-devel@lists.01.org; Ard Biesheuvel ; > Michael D Kinney > Subject: Re: [PATCH edk2-platforms 05/27] Silicon/NXP: Add UART library > support for i.MX platforms > > On

Re: [edk2] [Patch] BaseTools: Add checking to EFI variable attribute.

2018-11-01 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Thursday, November 01, 2018 11:07 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] BaseTools: Add checking to EFI variable attribute. > >This patch is going to add a check that only if t

Re: [edk2] [PATCH v2 1/1] BaseTools: Explicitly close files after readlines

2018-11-01 Thread Feng, Bob C
Thanks, this patch looks good. A minor comment that for the following part, would you please move the with block into a try... except block? def __RetrievePcdValue(self): -Content = open(str(self.MetaFile), 'r').readlines() +with open(str(self.MetaFile), 'r') as File: +

Re: [edk2] [edk2-test][Patch v2] uefi-sct/SctPkg:Assign 0 to the tail of HwErrRecVariableName.

2018-11-01 Thread Jin, Eric
Supreeth, Thank you for the reminder. I correct them in the commit. Thanks. Best Regards Eric -Original Message- From: Supreeth Venkatesh Sent: Friday, November 2, 2018 4:23 AM To: Jin, Eric ; edk2-devel@lists.01.org Subject: Re: [edk2-test][Patch v2] uefi-sct/SctPkg:Assign 0 to the ta

Re: [edk2] [PATCH 2/6] IntelFrameworkModulePkg: fix build for AARCH64/ARM

2018-11-01 Thread Gao, Liming
Leif: There is one mistake in comments >+ #^M. Could you clean it? With this change, Reviewed-by: Liming Gao . Besides, have you verified AARCH64 GCC build? Thanks Liming >-Original Message- >From: Leif Lindholm [mailto:leif.lindh...@linaro.org] >Sent: Thursday, November 01, 201

Re: [edk2] [PATCH 1/1] MdePkg/Base.h: Implement BASE_CR() via OFFSET_OF().

2018-11-01 Thread Gao, Liming
The change is good. Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Marvin H?user >Sent: Thursday, November 01, 2018 4:09 AM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Gao, Liming > >Subject: [edk2] [PATCH 1/1

Re: [edk2] [Patch] MdeModulePkg: Remove the trailing space in three source files.

2018-11-01 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Gao, Liming Sent: Thursday, November 1, 2018 9:38 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [Patch] MdeModulePkg: Remove the trailing space in three source files. The recent changes in these three source files in

Re: [edk2] [PATCH 4/6] MdeModulePkg: drop DebugSupportDxe from AARCH64 components

2018-11-01 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Leif Lindholm [mailto:leif.lindh...@linaro.org] Sent: Thursday, November 1, 2018 11:37 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Wang, Jian J Subject: [PATCH 4/6] MdeModulePkg: drop DebugSupportDxe from AARCH64 componen

[edk2] [PATCH v2 1/1] BaseTools: Explicitly close files after readlines

2018-11-01 Thread Michael Johnson
From: mjohn4 Rework some file open().readlines to open, readlines, close. This prevents excessive file handles being open at the same time, which may be a problem with alternative python environments. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael

Re: [edk2] [PATCH edk2-platforms 01/27] Platform/Microsoft: Add OpteeClientPkg dec

2018-11-01 Thread Chris Co via edk2-devel
Hi Sumit, Our full OpteeClientPkg has: - Our OpteeClientAPI implementation. I was monitoring the merge progress on OpteeLib and will look into moving over now that it is available. - The fTPM and AuthVar TA binaries. In our current design, the TA binaries are loaded at runtime. We could host the

Re: [edk2] [PATCH v1 1/1] BaseTools: Explicitly close files after readlines

2018-11-01 Thread Feng, Bob C
Hi Michael, For the file operation, I would suggest to use with statement. with statement will automatically close the file after the nested block of code. The advantage of using a with statement is that it is guaranteed to close the file no matter how the nested block exits. For example

Re: [edk2] [Patch] MdeModulePkg: Remove the trailing space in three source files.

2018-11-01 Thread Ni, Ruiyu
My fault! Thanks! Reviewed-by: Ruiyu Ni > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Liming Gao > Sent: Thursday, November 1, 2018 9:38 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: [edk2] [Patch] MdeModulePkg: Remove the

Re: [edk2] [PATCH 6/6] SignedCapsulePkg: enable package build for AARCH64/ARM

2018-11-01 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com thank you! Yao, Jiewen > 在 2018年11月1日,下午11:37,Leif Lindholm 写道: > > This package is used by several platforms in edk2-platforms, so ensure it > can be built directly by adding AARCH64/ARM to SUPPORTED_ARCHITECTURES. > > Also force-include CompilerIntrinsicsLi

Re: [edk2] [PATCH 5/6] SecurityPkg: fix package build on ARM

2018-11-01 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com thank you! Yao, Jiewen > 在 2018年11月1日,下午11:36,Leif Lindholm 写道: > > The CompilerIntrinsicsLib and BaseStackCheckLib need to be included in > order for an ARM build of the package .dsc to succeed - so add them. > > Cc: Chao Zhang > Cc: Jiewen Yao > Contribut

[edk2] [PATCH v1 1/1] BaseTools: Explicitly close files after readlines

2018-11-01 Thread Michael Johnson
From: mjohn4 Rework some file open().readlines to open, readlines, close. This prevents excessive file handles being open at the same time, which may be a problem with alternative python environments. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael

Re: [edk2] [edk2-test][Patch v2] uefi-sct/SctPkg:Assign 0 to the tail of HwErrRecVariableName.

2018-11-01 Thread Supreeth Venkatesh
Reviewed-by: Supreeth Venkatesh There are some unintentional indentation changes in "switch" statement. Please take care of that before (if intentional, ok as well) commit. On Thu, 2018-11-01 at 10:52 +0800, Eric Jin wrote: > Add definition of HwErrRecVariableNamePrefixLength, > HwErrRecVariab

Re: [edk2] [edk2-test][Patch] uefi-sct/SctPkg:Assign 0 to the tail of the HwErrRecVariableName

2018-11-01 Thread Supreeth Venkatesh
Hi Eric, I could not find any reference regarding "magic numbers" in edk2 C coding standards document. So, I guess I am fine with documenting "magic numbers" with comments. Thanks, Supreeth -Original Message- From: Jin, Eric Sent: Wednesday, October 31, 2018 9:09 PM To: Supreeth Venkat

Re: [edk2] [PATCH 0/4] OvmfPkg: simply use the Bochs interface for vmsvga

2018-11-01 Thread Philippe Mathieu-Daudé
Hi Yu-chen Lin, On 24/10/18 8:40, yuchen...@synology.com wrote: From: yuchenlin In this series, replace the original vmsvga driver to Bochs interface. This is the 'v2' of your previous patch 'OvmfPkg: initialize bochs when initializing vmsvga': https://lists.01.org/pipermail/edk2-devel/201

Re: [edk2] [PATCH 1/4] Revert "OvmfPkg/QemuVideoDxe: VMWare SVGA device support"

2018-11-01 Thread Philippe Mathieu-Daudé
Hi Yu-chen Lin, On 24/10/18 8:40, yuchen...@synology.com wrote: From: yuchenlin This reverts commit c137d95081690d4877fbeb5f1856972e84ac32f2. Can we have a comment here about why we need to revert this patch? (same for patches 2 and 3). Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH 4/4] OvmfPkg: simply use the Bochs interface for vmsvga

2018-11-01 Thread Philippe Mathieu-Daudé
Hi Yu-chen Lin, On 24/10/18 8:40, yuchen...@synology.com wrote: From: yuchenlin BAR |std vga | vmsvga - 0| Framebuffer | I/O space 1| Reserved | Framebuffer 2| MMIO | FIFO Because of the PCI BARs difference between std v

Re: [edk2] [PATCH edk2-platforms 10/27] Silicon/NXP: Add iMX6Pkg dec

2018-11-01 Thread Leif Lindholm
On Fri, Sep 21, 2018 at 08:26:00AM +, Chris Co wrote: > This adds PCD declarations common across NXP i.MX6 SoCs > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Christopher Co > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Michael D Kinney > --- > Silicon/NXP/i

Re: [edk2] [PATCH edk2-platforms 09/27] Silicon/NXP: Add headers for SoC-specific i.MX packages to use

2018-11-01 Thread Leif Lindholm
On Fri, Sep 21, 2018 at 08:26:00AM +, Chris Co wrote: > This adds common headers for other NXP i.MX SoC packages. > More specifically, this adds i.MX-generic GPIO, IoMux, and > Platform definitions. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Christopher Co >

Re: [edk2] [PATCH edk2-platforms 07/27] Silicon/NXP: Add i.MX display library support

2018-11-01 Thread Leif Lindholm
On Fri, Sep 21, 2018 at 08:25:58AM +, Chris Co wrote: > This adds support for processing EDID data on NXP i.MX platforms. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Christopher Co > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Michael D Kinney > --- > Sil

Re: [edk2] [PATCH 1/6] AppPkg: fix webserver build for !Ia32/X64

2018-11-01 Thread Leif Lindholm
On 1 November 2018 at 17:19, Kinney, Michael D wrote: > > Leif, > > The MSR definitions are only used by Mtrr.c, and Mtrr.c is only > used for IA32 and X64 builds in the INF file. Ah, yes, that actually means the rest of the application may be completely valid on ARM. > It would be simpler to mo

Re: [edk2] [PATCH edk2-platforms 06/27] Silicon/NXP: Add I2C library support for i.MX platforms

2018-11-01 Thread Leif Lindholm
On Fri, Sep 21, 2018 at 08:25:57AM +, Chris Co wrote: > This adds support for I2C controller on NXP i.MX platforms. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Christopher Co > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Michael D Kinney > --- > Silicon/N

Re: [edk2] [PATCH 3/6] IntelFrameworkPkg: fix build for AARCH64/ARM

2018-11-01 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Thursday, November 1, 2018 8:37 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; > Gao, Liming > Subject: [PATCH 3/6] IntelFrameworkPkg: fix build for > AAR

Re: [edk2] [PATCH 1/6] AppPkg: fix webserver build for !Ia32/X64

2018-11-01 Thread Kinney, Michael D
Leif, The MSR definitions are only used by Mtrr.c, and Mtrr.c is only used for IA32 and X64 builds in the INF file. It would be simpler to move the #include into Mtrr.c. That would avoid the use of #if. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.0

Re: [edk2] Capsules and versions

2018-11-01 Thread Sean Brogan via edk2-devel
Tom, Short answer: It is tool dependent. On Windows where the ESRT and FMP have been used for years there is another file that contains that information (Capsules are just driver packages so there is an INF and CAT file along with the BIN). Once the firmware gets to processing the actual pa

[edk2] [PATCH 5/6] SecurityPkg: fix package build on ARM

2018-11-01 Thread Leif Lindholm
The CompilerIntrinsicsLib and BaseStackCheckLib need to be included in order for an ARM build of the package .dsc to succeed - so add them. Cc: Chao Zhang Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm --- SecurityPkg/SecurityPkg.dsc | 11 ++

[edk2] [PATCH 6/6] SignedCapsulePkg: enable package build for AARCH64/ARM

2018-11-01 Thread Leif Lindholm
This package is used by several platforms in edk2-platforms, so ensure it can be built directly by adding AARCH64/ARM to SUPPORTED_ARCHITECTURES. Also force-include CompilerIntrinsicsLib, BaseStackCheckLib and create a resolution for ArmSoftFloatLib for ARM. Cc: Jiewen Yao Contributed-under: Tia

[edk2] [PATCH 1/6] AppPkg: fix webserver build for !Ia32/X64

2018-11-01 Thread Leif Lindholm
The WebServer application is really quite Ia32/X64 specific, but fundamentally it builds for other architectures as long as the architecture-specific #include header file is filtered out. So add an architecture-based filter on that to enable AppPkg.dsc to build for AARCH64/ARM (both listed in SU

[edk2] [PATCH 4/6] MdeModulePkg: drop DebugSupportDxe from AARCH64 components

2018-11-01 Thread Leif Lindholm
DebugSupportDxe.inf was listed in [Components.IA32, Components.X64, Components.AARCH64], but the plumbing that would be required to actually build it does not exist. Move the component to [Components.IA32, Components.X64] to permit build of MdeModulePkg.dsc on AARCH64. Cc: Star Zeng Cc: Jian J W

[edk2] [PATCH 3/6] IntelFrameworkPkg: fix build for AARCH64/ARM

2018-11-01 Thread Leif Lindholm
Contrary to what the name suggests, some modules in this package are used on other architecture. ARM is already listed in SUPPORTED_ARCHITECTURES in the .dsc, but AARCH64 was never added - so do that. Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Sig

[edk2] [PATCH 0/6] fix top-level package builds for AARCH64/ARM

2018-11-01 Thread Leif Lindholm
Most of the top-level packages should be buildable for all architectures Here is a fairly trivial set that makes that happen. Leif Lindholm (6): AppPkg: fix webserver build for !Ia32/X64 IntelFrameworkModulePkg: fix build for AARCH64/ARM IntelFrameworkPkg: fix build for AARCH64/ARM MdeModu

[edk2] [PATCH 2/6] IntelFrameworkModulePkg: fix build for AARCH64/ARM

2018-11-01 Thread Leif Lindholm
Contrary to what the name suggests, some modules in this package are used on other architecture. ARM is already listed in SUPPORTED_ARCHITECTURES in the .dsc, but AARCH64 was never added. Add that, and force inclusion of CompilerIntrinsicsLib and BaseStackCheckLib for AARCH64/ARM to make the build

[edk2] [Patch] BaseTools: Use common cc flag for building PcdValueInit.

2018-11-01 Thread BobCF
Use common cc flags for building PcdValueInit. The common cc flags include the cc flag which is under common Arch and under all build Arches. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- .../Source/Python/Workspace/DscBuildData.py | 48 +++

Re: [edk2] [PATCH v5 1/1] ArmPkg/OpteeLib: Add APIs to communicate with OP-TEE

2018-11-01 Thread Sumit Garg
On Thu, 1 Nov 2018 at 17:13, Leif Lindholm wrote: > > Hi Sumit, > > Actually, this module does not compile for ARM (32-bit). > --- > /work/git/edk2/ArmPkg/Library/OpteeLib/Optee.c: In function > ‘OpteeOpenSession’: > /work/git/edk2/ArmPkg/Library/OpteeLib/Optee.c:216:25: error: cast from > point

[edk2] [Patch] BaseTools: Add checking to EFI variable attribute.

2018-11-01 Thread BobCF
This patch is going to add a check that only if the attribute of a EFI variable include 'NV', it will be added into PcdNvStoreDefaultValueBuffer. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py | 2 ++

[edk2] [Patch] BaseTool: Filter out unused structure pcds

2018-11-01 Thread BobCF
V2: Fixed the issue that V1 adds new check to the Pcds in the platform unused library INF files. It breaks the existing platform. V1: The current code handle all the structure pcds even if there is no module or library use them. This patch is going to filter out the unused structure pcds. Contrib

[edk2] [Patch 1/1] BaseTools tools_def.template: Add GCC link script in X86 ASLDLINK_FLAGS

2018-11-01 Thread Liming Gao
This fix refers to commit 14ca435fb6c059eaeb7fe6eedbe4738ffaf336d0. GCC link script is used to discard the unused section data from ELF image. ASLDLINK_FLAGS requires it to remove the unnecessary section data, then GenFw can be used to retrieve the correct data section from ELF image. Contributed-

[edk2] Capsules and versions

2018-11-01 Thread Tomas Pilar (tpilar)
Hi, I am trying to implement FMP in our IHV UEFI driver so that we can update firmware and the driver using capsules. I get the ESRT populated by the platform EsrtFmpDxe, that's all great. However, it seems that EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER does not contain any version informat

[edk2] [Patch] MdeModulePkg: Remove the trailing space in three source files.

2018-11-01 Thread Liming Gao
The recent changes in these three source files introduce the trailing space. This patch removes them to follow edk2 coding style. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Star Zeng --- MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.c

Re: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all module types

2018-11-01 Thread Gao, Liming
Jeff: Thanks for your case. PrePiMemoryAllocationLib is a MemoryAllocationLib implementation that doesn't depend on PEI or DXE service. So, MemoryAllocationLib may be used in BASE type. And, I find MdeModulePkg\Library\BaseBmpSupportLib\BaseBmpSupportLib.inf is BASE type and consumes MemoryAl

Re: [edk2] [PATCH] Platform/ARM: Fix FVP broken build with "-D DT_SUPPORT"

2018-11-01 Thread Thomas Abraham
On Thu, Nov 1, 2018 at 5:18 PM Leif Lindholm wrote: > > Thanks Andrew, > > Thomas, Nariman - can I have a review from one of you guys before I > push? > > Regards, > > Leif > > On Thu, Nov 01, 2018 at 11:35:42AM +, Andrew Turner wrote: > > The UEFI build fails for ArmVExpress-FVP-AArch64 when

Re: [edk2] [PATCH] Platform/ARM: Fix FVP broken build with "-D DT_SUPPORT"

2018-11-01 Thread Thomas Abraham
On Thu, Nov 1, 2018 at 5:18 PM Leif Lindholm wrote: > > Thanks Andrew, > > Thomas, Nariman - can I have a review from one of you guys before I > push? > > Regards, > > Leif > > On Thu, Nov 01, 2018 at 11:35:42AM +, Andrew Turner wrote: > > The UEFI build fails for ArmVExpress-FVP-AArch64 when

Re: [edk2] [PATCH] Platform/ARM: Fix FVP broken build with "-D DT_SUPPORT"

2018-11-01 Thread Leif Lindholm
Thanks Andrew, Thomas, Nariman - can I have a review from one of you guys before I push? Regards, Leif On Thu, Nov 01, 2018 at 11:35:42AM +, Andrew Turner wrote: > The UEFI build fails for ArmVExpress-FVP-AArch64 when using the > "-D DT_SUPPORT" buildoption. > > ArmVExpressDtPlatformDtbLoa

[edk2] [PATCH] Platform/ARM: Fix FVP broken build with "-D DT_SUPPORT"

2018-11-01 Thread Andrew Turner
The UEFI build fails for ArmVExpress-FVP-AArch64 when using the "-D DT_SUPPORT" buildoption. ArmVExpressDtPlatformDtbLoaderLib is missing the ArmVExpressPkg.dec package and fails with: .../Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h:19:33: fatal error: VExpressMotherBoard.h: No su

Re: [edk2] [PATCH v5 1/1] ArmPkg/OpteeLib: Add APIs to communicate with OP-TEE

2018-11-01 Thread Leif Lindholm
Hi Sumit, Actually, this module does not compile for ARM (32-bit). --- /work/git/edk2/ArmPkg/Library/OpteeLib/Optee.c: In function ‘OpteeOpenSession’: /work/git/edk2/ArmPkg/Library/OpteeLib/Optee.c:216:25: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] if (

Re: [edk2] [PATCH 1/3] Maintainers.txt: Remove EdkShellPkg and EkdShellBinPkg

2018-11-01 Thread Leif Lindholm
On Thu, Nov 01, 2018 at 06:03:22AM +, Zhang, Shenglei wrote: > Hi Leif, > > Thanks for your comments. Actually there is a cover letter. > https://lists.01.org/pipermail/edk2-devel/2018-October/031666.html Ah, I missed that one since I was on cc on the rest of the set, but not the cover lette

Re: [edk2] [PATCH edk2-platforms 01/27] Platform/Microsoft: Add OpteeClientPkg dec

2018-11-01 Thread Sumit Garg
Hi Christopher, Optee Client library has recently been merged to edk2 source code. It tries to provide a generic interface [1] to OP-TEE based trusted applications (pseudo/early). AFAIK, you don't need any platform specific hook in client interface to work with upstream OP-TEE. So instead you sho

Re: [edk2] [PATCH V3 4/4] MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer

2018-11-01 Thread Leif Lindholm
On Thu, Nov 01, 2018 at 09:12:04AM +0800, Zeng, Star wrote: > > > I believe the performance data really depends on > > > 1. How many AsyncInterruptTransfer handlers (the number of USB keyboard > > > and/or USB bluetooth keyboard?) > > > 2. Data size (for flushing data from PCI controller specific a

Re: [edk2] [PATCH v1] Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with NetworkPkg drivers.

2018-11-01 Thread Leif Lindholm
On Thu, Nov 01, 2018 at 12:43:32AM +, Fu, Siyuan wrote: > Hi, Leif > > So you have tested all the platform build? That's great, thanks a lot. Build test only, no runtime tests. > Do you want me to merge these 3 patches to a combo v2 patch, or can > you help to commit the patch set to edk2-pl

Re: [edk2] D06 ACPI

2018-11-01 Thread Ming Huang
Hi Leif & Al Stone, Some questions about this fixes: 1 Is need modify [0001] to [0004] in proximmity Domain? +[0001] Proximity Domain : 0001 2 Is need modify Revision to 1 for type 2 node? 3 Is need add [0001] and [0003] for this two line? +Memory Si

Re: [edk2] Reminder for deleting 3 network drivers in MdeModulePkg

2018-11-01 Thread Leif Lindholm
On Thu, Nov 01, 2018 at 06:01:31AM +, Gao, Liming wrote: > Leif: > If all Stewards agree this change to remove MdeModulePkg > Tcp4Dxe/UefiPxeBcDxe/IScsiDxe, we will try to include it in > edk2-stable201811 stable tag. > > Andrew and Mike: > Do you agree this change to happen in near ed

Re: [edk2] [PATCH edk2-platforms 05/27] Silicon/NXP: Add UART library support for i.MX platforms

2018-11-01 Thread Leif Lindholm
On Fri, Sep 21, 2018 at 08:25:56AM +, Chris Co wrote: > This adds support for interact with the UART controller on > NXP i.MX platforms. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Christopher Co > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Michael D Kinne

Re: [edk2] [PATCH v2 4/5] EmulatorPkg: Remove EdkShellBinPkg in FDF and DEC

2018-11-01 Thread Jordan Justen
On 2018-10-31 23:26:38, shenglei wrote: > Remove EdkShellBinPkg in EmulatorPkg.dec and > EmulatorPkg.fdf. > https://bugzilla.tianocore.org/show_bug.cgi?id=1108 > > v2: Remove USE_OLD_SHELL in DSC because it will be > unnecessary to use it. > > Cc: Jordan Justen > Cc: Ruiyu Ni > Cc: Andrew F

Re: [edk2] [PATCH v2 0/4] SdMmcOverride extension

2018-11-01 Thread Wu, Hao A
Hi Marcin and Ard, > -Original Message- > From: Marcin Wojtas [mailto:m...@semihalf.com] > Sent: Friday, October 05, 2018 9:25 PM > To: edk2-devel@lists.01.org > Cc: Tian, Feng; Kinney, Michael D; Gao, Liming; leif.lindh...@linaro.org; Wu, > Hao A; ard.biesheu...@linaro.org; nad...@marvell

Re: [edk2] [PATCH v2 4/4] MdeModulePkg/SdMmcPciHcDxe: Allow overriding base clock frequency

2018-11-01 Thread Wu, Hao A
Hi Marcin, > -Original Message- > From: Marcin Wojtas [mailto:m...@semihalf.com] > Sent: Friday, October 05, 2018 9:25 PM > To: edk2-devel@lists.01.org > Cc: Tian, Feng; Kinney, Michael D; Gao, Liming; leif.lindh...@linaro.org; Wu, > Hao A; ard.biesheu...@linaro.org; nad...@marvell.com; >

Re: [edk2] [PATCH v2 3/4] MdeModulePkg/SdMmcPciHcDxe: Add SwitchClockFreqPost to SdMmcOverride

2018-11-01 Thread Wu, Hao A
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Marcin Wojtas > Sent: Friday, October 05, 2018 9:25 PM > To: edk2-devel@lists.01.org > Cc: Tian, Feng; t...@semihalf.com; Wu, Hao A; nad...@marvell.com; Gao, > Liming; Kinney, Michael D > Subject

Re: [edk2] [PATCH v2 2/4] MdeModulePkg/SdMmcPciHcDxe: Add UhsSignaling to SdMmcOverride protocol

2018-11-01 Thread Wu, Hao A
Hi Marcin, > -Original Message- > From: Marcin Wojtas [mailto:m...@semihalf.com] > Sent: Friday, October 05, 2018 9:25 PM > To: edk2-devel@lists.01.org > Cc: Tian, Feng; Kinney, Michael D; Gao, Liming; leif.lindh...@linaro.org; Wu, > Hao A; ard.biesheu...@linaro.org; nad...@marvell.com; >