Re: [edk2] [edk2-test][RFC PATCH 11/12] uefi-sct/SctPkg: sbbr: Bugfix for MemoryMap Check Test.

2018-11-19 Thread Jin, Eric
Add the maintainer Supreeth. Hello Sakar, Thank for the patches in this series. The common comments is: The keyword 'SBBR' exists on the FilePath or in the FileName. But 'SBBR' string or related description is not mentioned in UEFI spec at all. Could you please add more detail for the checkpoi

Re: [edk2] [PATCH v4 0/4] SdMmcOverride extension

2018-11-19 Thread Marcin Wojtas
wt., 20 lis 2018 o 06:59 Wu, Hao A napisał(a): > > > -Original Message- > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > > Wu, Hao A > > Sent: Tuesday, November 13, 2018 4:29 PM > > To: Marcin Wojtas > > Cc: Tomasz Michalec; Grzegorz Jaszczyk; edk2-devel-01; Gao

[edk2] [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h and Acpi62.h

2018-11-19 Thread Gary Lin
The GUID for VIRTUAL_CD_REGION_PERSISTENT was using the closing square bracket mistakenly. Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Gary Lin --- MdePkg/Include/IndustryStandard/Acpi61.h | 2 +- MdePkg/Include/IndustryStandard/Ac

Re: [edk2] [PATCH edk2-platforms v2 00/15] Fix D06 SBSA/SBBR issue and improve

2018-11-19 Thread Ming Huang
On 11/20/2018 2:42 AM, Leif Lindholm wrote: > On Fri, Nov 16, 2018 at 02:56:47PM +0800, Ming Huang wrote: >> Main Change since v1: >> 1. Add IORT patch; >> 2. Add HIDs/UIDs bug for PciHostBridgeLib; >> 3. Drop Pv660; >> 4. Drop two patchs: >>Modify for SBBR fwts SetTime_Func test case; >>

Re: [edk2] [PATCH edk2-platforms v2 10/15] Hisilicon/D06: Modify Gic base

2018-11-19 Thread Ming Huang
On 11/20/2018 2:20 AM, Leif Lindholm wrote: > You said in reply to my comment on v1: > > --- > The PcdGicInterruptInterfaceBase(0xFE00) is wrong, it just copy > from D05/D03, > maybe somewhere will need the right value of Pcd. > --- > > Please split that out as a separate change, with the

[edk2] [edk2-test][PATCH] SctPkg/build: Add support for GenBin tool build

2018-11-19 Thread Lokesh B V
As the GenBin tool is necessary for SCT build, it is appropriate to support it's build in the SCT build procedure. Signed-off-by: Lokesh B V --- uefi-sct/SctPkg/build.sh | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/uefi-sct/SctPkg/build.sh b

[edk2] [edk2-test][PATCH] SctPkg/Tools: Fix incorrect line ending detection by GenBin tool

2018-11-19 Thread Lokesh B V
Some windows editors uses "\r\n" for line feed. While processing uefi testcase info file, the GenBin tool logic to skip line feed doesn't consider the presence of carraige return(\r) in line feed. So this results in incorrect format error. Signed-off-by: Lokesh B V --- uefi-sct/SctPkg/Tools/Sour

[edk2] [edk2-test][PATCH] SctPkg/UEFI: Fix invalid GUID value format error

2018-11-19 Thread Lokesh B V
Fix all GUID values that are defined with a invalid GUID value format. Signed-off-by: Lokesh B V --- uefi-sct/SctPkg/UEFI/UEFI.dec | 202 +- 1 file changed, 101 insertions(+), 101 deletions(-) diff --git a/uefi-sct/SctPkg/UEFI/UEFI.dec b/uefi-sct/SctPkg/U

[edk2] [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7

2018-11-19 Thread Lokesh B V
EDK2 supports EFI version 2.7 and so allow UEFI-SCT to be usable with this version of EFI. Signed-off-by: Lokesh B V --- uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Includ

Re: [edk2] [PATCH edk2-platforms v2 07/15] Hisilicon/D0x: Fix secure boot bug in FlashFvbDxe

2018-11-19 Thread Ming Huang
On 11/20/2018 2:19 AM, Ard Biesheuvel wrote: > On Thu, 15 Nov 2018 at 22:57, Ming Huang wrote: >> >> When SECURE_BOOT_ENABLE is TRUE, FlashFvbDxe should use >> gEfiAuthenticatedVariableGuid, When SECURE_BOOT_ENABLE >> is FALSE, gEfiVariableGuid should be used. >> > > Can we fix the driver inst

Re: [edk2] [PATCH edk2-platforms v2 07/15] Hisilicon/D0x: Fix secure boot bug in FlashFvbDxe

2018-11-19 Thread Ming Huang
On 11/20/2018 2:13 AM, Leif Lindholm wrote: > On Fri, Nov 16, 2018 at 02:56:54PM +0800, Ming Huang wrote: >> When SECURE_BOOT_ENABLE is TRUE, FlashFvbDxe should use >> gEfiAuthenticatedVariableGuid, When SECURE_BOOT_ENABLE >> is FALSE, gEfiVariableGuid should be used. >> > > Other platforms see

Re: [edk2] [PATCH edk2-platforms v2 06/15] Hisilicon/D06: Move some functions to OemMiscLib

2018-11-19 Thread Ming Huang
On 11/20/2018 2:30 AM, Leif Lindholm wrote: > On Fri, Nov 16, 2018 at 02:56:53PM +0800, Ming Huang wrote: >> As M41T83RealTimeClockLib is common library, so move two cpld >> relative functions to OemMiscLib and rename this two functions. >> >> Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH v4 0/4] SdMmcOverride extension

2018-11-19 Thread Wu, Hao A
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Wu, Hao A > Sent: Tuesday, November 13, 2018 4:29 PM > To: Marcin Wojtas > Cc: Tomasz Michalec; Grzegorz Jaszczyk; edk2-devel-01; Gao, Liming; > nad...@marvell.com; Kinney, Michael D > Subject: R

[edk2] [RFC] Proposal to remove DuetPkg

2018-11-19 Thread Ni, Ruiyu
All, DuetPkg depends on Legacy BIOS to provide a UEFI environment. It was invented in the era when UEFI environment is hard to find. Since now UEFI is very popular in PC area, we could stop the official support of this package and remove it from the master. Anyone who wants to use it still can j

Re: [edk2] [PATCH] IntelFsp2WrapperPkg: Revert 90c5bc08

2018-11-19 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Chiu, Chasel Sent: Tuesday, November 20, 2018 11:53 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Zeng, Star ; Chiu, Chasel Subject: [PATCH] IntelFsp2WrapperPkg: Revert 90c5bc08 Commit message issue and reverted commit 90c5bc081d15d07

[edk2] [PATCH] IntelFsp2WrapperPkg: Revert 90c5bc08

2018-11-19 Thread Chasel, Chiu
Commit message issue and reverted commit 90c5bc081d15d077606131a61114ddfdefe62e61. Will re-submit with correct formats. Cc: Jiewen Yao Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chasel Chiu --- IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c |

Re: [edk2] [patch] MdePkg: Check input Ptrs in GetSectionFromAnyFvByFileType

2018-11-19 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Bi, Dandan > Sent: Monday, November 19, 2018 10:09 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > > Subject: [patch] MdePkg: Check input Ptrs in GetSectionFromAnyFvByFileType > > REF: https://bugzilla.tianoc

Re: [edk2] [patch] MdePkg: check Length para before use in DevPathToTextUsbWWID

2018-11-19 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Bi, Dandan > Sent: Monday, November 19, 2018 10:09 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > > Subject: [patch] MdePkg: check Length para before use in DevPathToTextUsbWWID > > REF: https://bugzilla.tia

[edk2] [PATCH v2] SecurityPkg: Update TCG PFP spec revision.

2018-11-19 Thread Zhang, Chao B
UEFI TCG has aligned with TCG PFP 1.03 v51 along with Errata Version 1.0. Update spec version accordingly. Spec Link: https://trustedcomputinggroup.org/wp-content/uploads/PC-ClientSpecific_Platform_Profile_for_TPM_2p0_Systems_v51.pdf https://trustedcomputinggroup.org/wp-content/uploads/PC-Client-Sp

[edk2] [Patch] SecurityPkg: Update TCG PTP spec revision.

2018-11-19 Thread Zhang, Chao B
UEFI TCG has aligned with TCG PTP 1.03 v51 along with Errata Version 1.0. Update spec version accordingly. Spec Link: https://trustedcomputinggroup.org/wp-content/uploads/PC-ClientSpecific_Platform_Profile_for_TPM_2p0_Systems_v51.pdf https://trustedcomputinggroup.org/wp-content/uploads/PC-Client-Sp

Re: [edk2] [PATCH edk2-non-osi v2 0/4] Upload D06 binary modules for SBSA test

2018-11-19 Thread Ming Huang
On 11/20/2018 2:46 AM, Leif Lindholm wrote: > On Fri, Nov 16, 2018 at 04:13:02PM +0800, Ming Huang wrote: >> Main Change since v1: >> 1 Modify comments; >> >> Code can also be found in github: >> https://github.com/hisilicon/OpenPlatformPkg.git >> branch: d06-acs-non-osi-v2 > > From the black-b

Re: [edk2] [Patch] SecurityPkg: TCG Add more Event type

2018-11-19 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zhang, Chao B > Sent: Saturday, November 17, 2018 11:43 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] SecurityPkg: TCG Add more Event type > > Add

Re: [edk2] [PATCH v2 0/3] Remove S3Lib and RecoveryLib class

2018-11-19 Thread Wang, Jian J
Shenglei, I think it would be better to split the patch series in following order: 1. package dec/dsc/uni 2. changes of each module (one patch per module) 3. public header files Regards, Jian > -Original Message- > From: Zhang, Shenglei > Sent: Monday, November 19, 2018 3:30 PM >

Re: [edk2] EmulatorPkg Unix Host Segmentation fault.

2018-11-19 Thread Andrew Fish
> On Nov 19, 2018, at 2:29 PM, Jordan Justen wrote: > > On 2018-11-19 13:22:27, Andrew Fish wrote: >> >> >>> On Nov 19, 2018, at 11:16 AM, Jordan Justen >>> wrote: >>> >>> On 2018-11-18 17:13:21, Jordan Justen wrote: On 2018-11-18 14:37:09, Andrew Fish wrote: > > >> On

Re: [edk2] [Patch] BaseTools: Fix the problem using FILE_GUID override in .dsc

2018-11-19 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Friday, November 16, 2018 10:12 AM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Carsey, Jaben > >Subject: [Patch] BaseTools: Fix the problem using FILE_GUID override in .dsc > >https://bugzilla.tianocore.org/show_bug

Re: [edk2] EmulatorPkg Unix Host Segmentation fault.

2018-11-19 Thread Andrew Fish
> On Nov 19, 2018, at 2:12 PM, Laszlo Ersek wrote: > > Jordan wrote: > So, is it safe to adjust rbp? Unknown. It may not be if rbp is not used as a frame pointer. Is it safe to *not* adjust rbp and potentially allow the old temp ram stack to be used? Unknown. > > Andrew wrote:

Re: [edk2] EmulatorPkg Unix Host Segmentation fault.

2018-11-19 Thread Jordan Justen
On 2018-11-19 13:22:27, Andrew Fish wrote: > > > > On Nov 19, 2018, at 11:16 AM, Jordan Justen > > wrote: > > > > On 2018-11-18 17:13:21, Jordan Justen wrote: > >> On 2018-11-18 14:37:09, Andrew Fish wrote: > >>> > >>> > On Nov 18, 2018, at 4:07 AM, Liu Yu wrote: > > sorry y

Re: [edk2] EmulatorPkg Unix Host Segmentation fault.

2018-11-19 Thread Laszlo Ersek
Jordan wrote: >>> So, is it safe to adjust rbp? Unknown. It may not be if rbp is not >>> used as a frame pointer. Is it safe to *not* adjust rbp and >>> potentially allow the old temp ram stack to be used? Unknown. Andrew wrote: > Looks like OvmfPkg uses SetJump()/LongJump() to change the stack.

Re: [edk2] [edk2-wiki PATCH v2] release planning: announce the soft and hard feature freezes

2018-11-19 Thread Laszlo Ersek
On 11/14/18 01:06, Gao, Liming wrote: > Reviewed-by: Liming Gao Thank you, pushed as commit 8e311ba71992. Laszlo >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Laszlo Ersek >> Sent: Tuesday, November 13, 2018 11:30 PM >> To: edk2-devel

Re: [edk2] EmulatorPkg Unix Host Segmentation fault.

2018-11-19 Thread Andrew Fish
> On Nov 19, 2018, at 11:16 AM, Jordan Justen wrote: > > On 2018-11-18 17:13:21, Jordan Justen wrote: >> On 2018-11-18 14:37:09, Andrew Fish wrote: >>> >>> On Nov 18, 2018, at 4:07 AM, Liu Yu wrote: sorry your path can't fix this issue. if this path just turn off op

Re: [edk2] [edk2-announce] December Community Meeting

2018-11-19 Thread stephano
Ops, mea culpa. Updated to reflect "APAC/NAMO" in the link. Good catch, thank you! Cheers, Stephano On 11/19/2018 12:23 PM, Laszlo Ersek wrote: Hi Stephano, On 11/15/18 22:06, stephano wrote: We will be holding monthly community meetings starting in December on the first Thursday of the mont

Re: [edk2] [PATCH 2/2] MdeModulePkg/SdMmcPciHcDxe: Add V4 64bit ADMA2 support.

2018-11-19 Thread Ashish Singhal
Hi, I was planning on submitting SDMA changes as a separate patch but that would have broken SDMA if only ADMA2 patch would have been picked. I have sent V2 patches which combine SDMA as well as ADMA2 changes. I have tested the changes to be working on V3 as well V4 mode usage both with and wit

[edk2] [PATCH v2 2/2] MdeModulePkg/SdMmcPciHcDxe: Add V4 64bit SDMA and ADMA2 support.

2018-11-19 Thread Ashish Singhal
If V4 64 bit address mode is enabled in compatibility register, program controller to enable V4 host mode. Use appropriate ADMA2 descriptors supporting 64 bit addresses. Use appropriate registers for SDMA mode operation. Change-Id: I1f6c984368988e51999eb289aa29677f9b0cdf49 Contributed-under: Tiano

[edk2] [PATCH v2 1/2] MdeModulePkg/SdMmcPciHcDxe: Declare V4 64 bit address capability

2018-11-19 Thread Ashish Singhal
Add capability declaration for V4.x 64 bit system address support. This would be used for host controllers working in version 4. Enable 64 bit DMA support in PCI layer if V3 or V4 64 bit support is enabled in host capability register. The usage of this new field does not need a guard for version c

Re: [edk2] [PATCH 2/2] ArmVirtPkg/NorFlashQemuLib: discover NOR flash banks dynamically

2018-11-19 Thread Ard Biesheuvel
On Mon, 19 Nov 2018 at 12:02, Laszlo Ersek wrote: > > On 11/17/18 01:45, Ard Biesheuvel wrote: > > NorFlashQemuLib is one of the last remaining drivers in ArmVirtPkg > > that are not based on the device tree received from QEMU. > > > > For ArmVirtQemu, this does not really matter, given that the N

Re: [edk2] [edk2-announce] December Community Meeting

2018-11-19 Thread Laszlo Ersek
Hi Stephano, On 11/15/18 22:06, stephano wrote: > We will be holding monthly community meetings starting in December on > the first Thursday of the month. Details for the next meeting are here: > > https://github.com/tianocore/tianocore.github.io/wiki/Community-Virtual-Meetings the second ICS li

Re: [edk2] [PATCH 6/8] IntelFrameworkPkg: Remove the redundant INFs

2018-11-19 Thread Kinney, Michael D
Liming, We need to look at how to remove those dependencies now so the entire package can be retired. For example the only consumer of 8259 is the 8254 driver. The 8254 module can be replaced with the HPET driver that does not use 8259 at all. If we can convert all platforms that are currently

Re: [edk2] [PATCH 2/2] ArmVirtPkg/NorFlashQemuLib: discover NOR flash banks dynamically

2018-11-19 Thread Laszlo Ersek
On 11/17/18 01:45, Ard Biesheuvel wrote: > NorFlashQemuLib is one of the last remaining drivers in ArmVirtPkg > that are not based on the device tree received from QEMU. > > For ArmVirtQemu, this does not really matter, given that the NOR > flash banks are always the same: the PEI code is linked t

Re: [edk2] [PATCH 2/2] ArmVirtPkg/NorFlashQemuLib: discover NOR flash banks dynamically

2018-11-19 Thread Leif Lindholm
On Mon, Nov 19, 2018 at 11:27:22AM -0800, Ard Biesheuvel wrote: > > > > > > In this case, NorFlashQemuLib should not expose the first flash bank > > > > > > at all. > > > > > > > > > > > > To prevent introducing too much internal knowledge about which flash > > > > > > bank is accessible under whic

Re: [edk2] [PATCH edk2-platforms] Platform/ARM: replace hardcoded VenHW() device paths referring to NOR flash

2018-11-19 Thread Ard Biesheuvel
On Mon, 19 Nov 2018 at 11:30, Leif Lindholm wrote: > > Hmm, a follow-up question (which does not affect my r-b): > > We still keep the manually generated GUIDs in > ArmVirtPkg/Library/NorFlashQemuLib/NorFlashQemuLib.c, > Platform/ARM/JunoPkg/Library/NorFlashJunoLib/NorFlashJuno.c, > Platform/ARM/S

Re: [edk2] [PATCH edk2-platforms] Platform/ARM: replace hardcoded VenHW() device paths referring to NOR flash

2018-11-19 Thread Leif Lindholm
Hmm, a follow-up question (which does not affect my r-b): We still keep the manually generated GUIDs in ArmVirtPkg/Library/NorFlashQemuLib/NorFlashQemuLib.c, Platform/ARM/JunoPkg/Library/NorFlashJunoLib/NorFlashJuno.c, Platform/ARM/SgiPkg/Library/NorFlashLib/NorFlashLib.c, Platform/ARM/VExpressPkg

Re: [edk2] [PATCH 0/2] Clear frame pointer in startup code on AARCH64 systems

2018-11-19 Thread Ard Biesheuvel
On Mon, 19 Nov 2018 at 10:56, Leif Lindholm wrote: > > On Fri, Nov 16, 2018 at 02:55:56PM -0800, Ard Biesheuvel wrote: > > The backtrace code on AARCH64 does not sanitize the frame pointer values > > it pulls of the stack when attempting to do a backtrace, and so junk left > > in the frame pointer

Re: [edk2] [PATCH 2/2] ArmVirtPkg/NorFlashQemuLib: discover NOR flash banks dynamically

2018-11-19 Thread Ard Biesheuvel
On Mon, 19 Nov 2018 at 11:24, Leif Lindholm wrote: > > > On Mon, Nov 19, 2018 at 11:16:09AM -0800, Ard Biesheuvel wrote: > > On Mon, 19 Nov 2018 at 11:10, Leif Lindholm > > wrote: > > > > > > On Fri, Nov 16, 2018 at 05:29:05PM -0800, Ard Biesheuvel wrote: > > > > On Fri, 16 Nov 2018 at 16:45, Ar

Re: [edk2] [PATCH 2/2] ArmVirtPkg/NorFlashQemuLib: discover NOR flash banks dynamically

2018-11-19 Thread Leif Lindholm
On Mon, Nov 19, 2018 at 11:16:09AM -0800, Ard Biesheuvel wrote: > On Mon, 19 Nov 2018 at 11:10, Leif Lindholm wrote: > > > > On Fri, Nov 16, 2018 at 05:29:05PM -0800, Ard Biesheuvel wrote: > > > On Fri, 16 Nov 2018 at 16:45, Ard Biesheuvel > > > wrote: > > > > > > > > NorFlashQemuLib is one of

Re: [edk2] [PATCH 1/2] ArmPlatformPkg/NorFlashDxe: use one GUID plus index to identify flash banks

2018-11-19 Thread Leif Lindholm
On Mon, Nov 19, 2018 at 11:09:32AM -0800, Ard Biesheuvel wrote: > > > @@ -121,11 +124,12 @@ NorFlashCreateInstance ( > > >Instance->Size = NorFlashSize; > > > > > >Instance->BlockIoProtocol.Media = &Instance->Media; > > > - Instance->Media.MediaId = MediaId; > > > + Instance->Media.MediaI

Re: [edk2] [PATCH 1/2] ArmPlatformPkg/NorFlashDxe: use one GUID plus index to identify flash banks

2018-11-19 Thread Laszlo Ersek
On 11/17/18 01:45, Ard Biesheuvel wrote: > Currently, each flash bank controlled by ArmPlatformPkg/NorFlashDxe > has its own VendorHw GUID, and instances of NorFlashPlatformLib > describe each bank to the driver, along with the GUID for each. > > This works ok for bare metal platforms, but it woul

Re: [edk2] EmulatorPkg Unix Host Segmentation fault.

2018-11-19 Thread Jordan Justen
On 2018-11-18 17:13:21, Jordan Justen wrote: > On 2018-11-18 14:37:09, Andrew Fish wrote: > > > > > > > On Nov 18, 2018, at 4:07 AM, Liu Yu wrote: > > > > > > sorry your path can't fix this issue. if this path just turn off > > > optimization option within sec.c not global project. > > > >

Re: [edk2] [PATCH 2/2] ArmVirtPkg/NorFlashQemuLib: discover NOR flash banks dynamically

2018-11-19 Thread Ard Biesheuvel
On Mon, 19 Nov 2018 at 11:10, Leif Lindholm wrote: > > On Fri, Nov 16, 2018 at 05:29:05PM -0800, Ard Biesheuvel wrote: > > On Fri, 16 Nov 2018 at 16:45, Ard Biesheuvel > > wrote: > > > > > > NorFlashQemuLib is one of the last remaining drivers in ArmVirtPkg > > > that are not based on the device

Re: [edk2] [PATCH edk2-platforms] Platform/ARM: replace hardcoded VenHW() device paths referring to NOR flash

2018-11-19 Thread Leif Lindholm
On Fri, Nov 16, 2018 at 05:23:08PM -0800, Ard Biesheuvel wrote: > The ArmPlatformPkg NOR flash driver has been updated to use device paths > consisting of a fixed GUID and a numeric index rather than a separate GUID > for each flash bank on a given system. This means all explicit device path > refe

Re: [edk2] [PATCH 2/2] ArmVirtPkg/NorFlashQemuLib: discover NOR flash banks dynamically

2018-11-19 Thread Leif Lindholm
On Fri, Nov 16, 2018 at 05:29:05PM -0800, Ard Biesheuvel wrote: > On Fri, 16 Nov 2018 at 16:45, Ard Biesheuvel > wrote: > > > > NorFlashQemuLib is one of the last remaining drivers in ArmVirtPkg > > that are not based on the device tree received from QEMU. > > > > For ArmVirtQemu, this does not r

Re: [edk2] [PATCH 1/2] ArmPlatformPkg/NorFlashDxe: use one GUID plus index to identify flash banks

2018-11-19 Thread Ard Biesheuvel
On Mon, 19 Nov 2018 at 11:05, Leif Lindholm wrote: > > On Fri, Nov 16, 2018 at 04:45:23PM -0800, Ard Biesheuvel wrote: > > Currently, each flash bank controlled by ArmPlatformPkg/NorFlashDxe > > has its own VendorHw GUID, and instances of NorFlashPlatformLib > > describe each bank to the driver, a

Re: [edk2] [PATCH 1/2] ArmPlatformPkg/NorFlashDxe: use one GUID plus index to identify flash banks

2018-11-19 Thread Leif Lindholm
On Fri, Nov 16, 2018 at 04:45:23PM -0800, Ard Biesheuvel wrote: > Currently, each flash bank controlled by ArmPlatformPkg/NorFlashDxe > has its own VendorHw GUID, and instances of NorFlashPlatformLib > describe each bank to the driver, along with the GUID for each. > > This works ok for bare metal

Re: [edk2] [PATCH 0/2] Clear frame pointer in startup code on AARCH64 systems

2018-11-19 Thread Leif Lindholm
On Fri, Nov 16, 2018 at 02:55:56PM -0800, Ard Biesheuvel wrote: > The backtrace code on AARCH64 does not sanitize the frame pointer values > it pulls of the stack when attempting to do a backtrace, and so junk left > in the frame pointer register may result in a recursive exception and a > truncate

Re: [edk2] [PATCH 0/2] Clear frame pointer in startup code on AARCH64 systems

2018-11-19 Thread Laszlo Ersek
On 11/16/18 23:55, Ard Biesheuvel wrote: > The backtrace code on AARCH64 does not sanitize the frame pointer values > it pulls of the stack when attempting to do a backtrace, and so junk left > in the frame pointer register may result in a recursive exception and a > truncated backtrace. > > Ard B

Re: [edk2] [PATCH edk2-non-osi v2 0/4] Upload D06 binary modules for SBSA test

2018-11-19 Thread Leif Lindholm
On Fri, Nov 16, 2018 at 04:13:02PM +0800, Ming Huang wrote: > Main Change since v1: > 1 Modify comments; > > Code can also be found in github: > https://github.com/hisilicon/OpenPlatformPkg.git > branch: d06-acs-non-osi-v2 >From the black-box standpoint, this series look fine. Are there any impli

Re: [edk2] [PATCH edk2-platforms v2 00/15] Fix D06 SBSA/SBBR issue and improve

2018-11-19 Thread Leif Lindholm
On Fri, Nov 16, 2018 at 02:56:47PM +0800, Ming Huang wrote: > Main Change since v1: > 1. Add IORT patch; > 2. Add HIDs/UIDs bug for PciHostBridgeLib; > 3. Drop Pv660; > 4. Drop two patchs: >Modify for SBBR fwts SetTime_Func test case; >Fix SBBR-SCT AuthVar issue > > Code can also be found

Re: [edk2] [PATCH edk2-platforms v2 06/15] Hisilicon/D06: Move some functions to OemMiscLib

2018-11-19 Thread Leif Lindholm
On Fri, Nov 16, 2018 at 02:56:53PM +0800, Ming Huang wrote: > As M41T83RealTimeClockLib is common library, so move two cpld > relative functions to OemMiscLib and rename this two functions. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang I did not see any

Re: [edk2] [PATCH] Silicon/SynQuacer: remove bogus PL011 _HID from DSDT ACPI table

2018-11-19 Thread Ard Biesheuvel
On Mon, 19 Nov 2018 at 09:48, Leif Lindholm wrote: > > On Mon, Nov 19, 2018 at 08:03:38AM -0800, Ard Biesheuvel wrote: > > PL011 is not a valid ACPI identifier so don't expose it as a _CID. > > Since _CID (Comptable ID) is optional, let's just drop it. > > > > Contributed-under: TianoCore Contribu

Re: [edk2] [PATCH v2 edk2-platforms] Silicon/SynQuacerPciCpuIo2Dxe: fix PCIe I/O translation

2018-11-19 Thread Ard Biesheuvel
On Fri, 9 Nov 2018 at 05:34, Leif Lindholm wrote: > > > On Fri, Nov 09, 2018 at 08:58:48AM +0100, Ard Biesheuvel wrote: > > Commit 9dd8190e4995 ("Silicon/SynQuacer: tweak PCI I/O windows for > > ACPI/Linux support") updated the min/max/offset definitions for the > > PCIe I/O resource windows on Sy

Re: [edk2] [PATCH edk2-platforms v2 10/15] Hisilicon/D06: Modify Gic base

2018-11-19 Thread Leif Lindholm
You said in reply to my comment on v1: --- The PcdGicInterruptInterfaceBase(0xFE00) is wrong, it just copy from D05/D03, maybe somewhere will need the right value of Pcd. --- Please split that out as a separate change, with the above mentioned in the commit message. But if I understand corre

Re: [edk2] [PATCH edk2-platforms v2 07/15] Hisilicon/D0x: Fix secure boot bug in FlashFvbDxe

2018-11-19 Thread Ard Biesheuvel
On Thu, 15 Nov 2018 at 22:57, Ming Huang wrote: > > When SECURE_BOOT_ENABLE is TRUE, FlashFvbDxe should use > gEfiAuthenticatedVariableGuid, When SECURE_BOOT_ENABLE > is FALSE, gEfiVariableGuid should be used. > Can we fix the driver instead so we don't need to make this distinction? Please refe

Re: [edk2] [PATCH edk2-platforms v2 07/15] Hisilicon/D0x: Fix secure boot bug in FlashFvbDxe

2018-11-19 Thread Leif Lindholm
On Fri, Nov 16, 2018 at 02:56:54PM +0800, Ming Huang wrote: > When SECURE_BOOT_ENABLE is TRUE, FlashFvbDxe should use > gEfiAuthenticatedVariableGuid, When SECURE_BOOT_ENABLE > is FALSE, gEfiVariableGuid should be used. > Other platforms seem to resolve this by doing something like: !if $(SECURE

Re: [edk2] [PATCH] Silicon/SynQuacer: remove bogus PL011 _HID from DSDT ACPI table

2018-11-19 Thread Leif Lindholm
On Mon, Nov 19, 2018 at 08:03:38AM -0800, Ard Biesheuvel wrote: > PL011 is not a valid ACPI identifier so don't expose it as a _CID. > Since _CID (Comptable ID) is optional, let's just drop it. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-b

[edk2] [PATCH] Silicon/SynQuacer: remove bogus PL011 _HID from DSDT ACPI table

2018-11-19 Thread Ard Biesheuvel
PL011 is not a valid ACPI identifier so don't expose it as a _CID. Since _CID (Comptable ID) is optional, let's just drop it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl | 1 - 1 file changed, 1 deletio

Re: [edk2] [PATCH v3 edk2-platforms 5/5] Platform/ARM/Sgi: Add initial support for SGI-Clark.Helios platform

2018-11-19 Thread Leif Lindholm
On Mon, Nov 12, 2018 at 05:11:56PM +0530, Chandni Cherukuri wrote: > Add the initial support for ARM's System Guidance for Infrastructure > SGI-Clark.Helios platform. The ACPI tables for this platform are > installed. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Cc: Leif Lindholm

Re: [edk2] [PATCH v3 edk2-platforms 4/5] Platform/ARM/Sgi: Add ACPI tables for SGI-Clark.Helios platform

2018-11-19 Thread Leif Lindholm
On Mon, Nov 12, 2018 at 05:11:55PM +0530, Chandni Cherukuri wrote: > Added ACPI tables and GUID name 'gSgiClarkHeliosAcpiTablesFileGuid' > for SGI-Clark.Helios platform. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Signed-off-by: Chandni

Re: [edk2] [PATCH v3 edk2-platforms 2/5] Platform/ARM/Sgi: Add ACPI tables for SGI-Clark.Ares platform

2018-11-19 Thread Leif Lindholm
On Mon, Nov 12, 2018 at 05:11:53PM +0530, Chandni Cherukuri wrote: > Added ACPI tables and GUID name 'gSgiClarkAresAcpiTablesFileGuid' > for SGI-Clark.Ares platform. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Signed-off-by: Chandni Cher

Re: [edk2] [PATCH v3 edk2-platforms 3/5] Platform/ARM/Sgi: Add initial support for SGI-Clark.Ares platform

2018-11-19 Thread Leif Lindholm
On Mon, Nov 12, 2018 at 05:11:54PM +0530, Chandni Cherukuri wrote: > Add the initial support for ARM's System Guidance for Infrastructure > SGI-Clark.Ares platform. The ACPI tables for this platform are > installed. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Cc: Leif Lindholm >

[edk2] [PATCH v2] EmulatorPkg/Unix/Host fixed numeric pad function

2018-11-19 Thread Liu Yu
From: Pedroa Liu origin code in Unix Host numeric pad has no function in shell environment since we can't get "XK_KP_0 ~ XK_KP_9" from XGetKeyboardMapping just can get "numlock" key status. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pedroa Liu --- EmulatorPkg/Unix/

Re: [edk2] [PATCH v3 edk2-platforms 0/5] Platform/ARM/Sgi: Add support for Clark.Ares and Clark.Helios platforms

2018-11-19 Thread Leif Lindholm
Hi Chandni, On Mon, Nov 19, 2018 at 05:00:39PM +0530, chandni cherukuri wrote: > On Mon, Nov 12, 2018 at 9:57 PM Leif Lindholm > wrote: > > > > Hi Chadni, > > > > I will disregard this set. > > Please send out a new v3 containing the changes we've discussed, only > > after I've completed reviewi

Re: [edk2] [PATCH v3 edk2-platforms 0/5] Platform/ARM/Sgi: Add support for Clark.Ares and Clark.Helios platforms

2018-11-19 Thread chandni cherukuri
On Mon, Nov 12, 2018 at 9:57 PM Leif Lindholm wrote: > > Hi Chadni, > > I will disregard this set. > Please send out a new v3 containing the changes we've discussed, only > after I've completed reviewing the set. > > Best Regards, > > Leif > Hi Leif, Can I post the new v3 patchset containing the

Re: [edk2] [edk2-announce][RFC] Collaboration Software

2018-11-19 Thread Tomas Pilar (tpilar)
All of these reasons (along with scalability) is why the linux kernel development hasn't moved from email mailing lists and they have tried several times. Cheers, Tom On 16/11/2018 22:14, Philippe Mathieu-Daudé wrote: > On 16/11/18 21:46, stephano wrote: >> This looks great. >> >> I'm going to

Re: [edk2] [PATCH v2] MdeModulePkg: Remove PcdIdentifyMappingPageTablePtr

2018-11-19 Thread Zeng, Star
Pushed at 316b3a719fd2ee97a01b0d941bba15ef06840d78. Thanks, Star -Original Message- From: Zeng, Star Sent: Monday, November 19, 2018 1:48 PM To: Zhang, Shenglei ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Zeng, Star Subject: RE: [edk2] [PATCH v2] MdeModulePkg: Remove PcdIdentifyMappingPag

[edk2] [PATCH v2 2/3] Vlv2TbltDevicePkg: Remove PeiS3Lib in DSC

2018-11-19 Thread Shenglei Zhang
PeiS3Lib is not actually used in Vlv2TbltDevicePkg, so it is removed in DSC. https://bugzilla.tianocore.org/show_bug.cgi?id=1299 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 3 --- Vlv2TbltDevicePkg/PlatformPk

[edk2] [PATCH v2 0/3] Remove S3Lib and RecoveryLib class

2018-11-19 Thread Shenglei Zhang
S3Lib and RecoveryLib have been deprecated since 2009. There is no code using AcpiS3ResumeOs() interface in S3Lib and PeiRecoverFirmware() interface in RecoveryLib. So they can be removed from edk2 repo. https://bugzilla.tianocore.org/show_bug.cgi?id=1299 v2:Remove S3Lib.h and RecoveryLib.h. in M

[edk2] [PATCH v2 3/3] MdeModulePkg: Remove PeiS3LibNull and PeiRecoveryLibNull

2018-11-19 Thread Shenglei Zhang
As was described in 5933acc3cb1ac1a344a34342d0ac46d3afed929a, there was no code using AcpiS3ResumeOs() interface in S3Lib and PeiRecoverFirmware() interface in RecoveryLib. PeiS3LibNull and PeiRecoveryLibNull were deprecated, so they should be removed. https://bugzilla.tianocore.org/show_bug.cgi?id

[edk2] [PATCH v2 1/3] IntelFrameworkModulePkg: Remove PeiS3Lib and PeiRecoveryLib

2018-11-19 Thread Shenglei Zhang
As was described in 5933acc3cb1ac1a344a34342d0ac46d3afed929a, there was no code using AcpiS3ResumeOs() interface in S3Lib and PeiRecoverFirmware() interface in RecoveryLib. PeiS3Lib and PeiRecoveryLib were deprecated,so they should be removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1299 Cc

[edk2] [platforms: PATCH v6 8/8] Marvell/Drivers: XenonDxe: Switch to use generic SdMmcPciHcDxe

2018-11-19 Thread Marcin Wojtas
From: Tomasz Michalec XenonDxe was copy of SdMmcPciHcDxe from edk2/MdeModulePkg. Now it implements SdMmcOverride protocol which allows to add quirks to the generic SdMmcPciHcDxe. Platforms that were using XenonDxe/SdMmcPciHcDxe have fixed *.fdf and *.dsc.inc files to use new implementation of X