Hi Laszlo,
Thank for your explanation in details and your patience, it is really helpful!
Regards,
Jay Zhou
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, December 25, 2018 6:18 PM
> To: Zhoujian (jay)
> Cc: Yao, Jiewen ; edk2-devel@lists.01.org; H
Thank you Ard and Leif for all the comments, we will work on your review
comments and share the next version soon.
> -Original Message-
> From: Leif Lindholm
> Sent: Saturday, December 22, 2018 12:48 AM
> To: Meenakshi Aggarwal
> Cc: ard.biesheu...@linaro.org; michael.d.kin...@intel.co
Brief answer while I'm on PTO.
(It's difficult to reply to this thread in any sensible manner, because
of the brain-damaged top-posting that outlook and gmail perpetuate. I'll
try my best anyway, but you might have to reverse the order of my
answers for getting a good logical explanation. Again, t
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Zhang, Shenglei
> Sent: Tuesday, December 25, 2018 4:17 PM
> To: edk2-devel@lists.01.org
> Cc: Wang, Jian J; Wu, Hao A; Ni, Ruiyu; Zeng, Star
> Subject: [PATCH v4 5/7] MdeModulePkg/DxeHttpLib: Use BaseLib api
> AsciiT
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Zhang, Shenglei
> Sent: Tuesday, December 25, 2018 4:17 PM
> To: edk2-devel@lists.01.org
> Cc: Wang, Jian J; Wu, Hao A; Ni, Ruiyu; Zeng, Star
> Subject: [PATCH v4 4/7] MdeModulePkg/EbcDebugger: Use AsciiToUpper
> and
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Zhang, Shenglei
> Sent: Tuesday, December 25, 2018 4:17 PM
> To: edk2-devel@lists.01.org
> Cc: Wang, Jian J; Wu, Hao A; Ni, Ruiyu; Zeng, Star
> Subject: [PATCH v4 1/7] MdeModulePkg/EbcDebugger: Change function
> names
Substitute HttpIoCharToUpper with AsciiToUpper which is a public function
with the same effect. And remove the implement of HttpIoCharToUpper.
https://bugzilla.tianocore.org/show_bug.cgi?id=1369
Cc: Jian J Wang
Cc: Hao Wu
Cc: Ruiyu Ni
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agr
Introduce two public functions CharToUpper and AsciiToUpper.
They have the same functions as InternalCharToUpper and
InternalBaseLibAsciiToUpper.Considering the internal functions will
be removed,so directly I change their function names to the public ones'.
https://bugzilla.tianocore.org/show_bug.
Substitute InternalShellCharToUpper with a public function
CharToUpper which has the same function.
Remove the implement of InternalShellCharToUpper.
Cc: Ruiyu Ni
Cc: Jaben Carsey
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
ShellPkg/Application/She
Change UnicodeToUpper to InternalUnicodeToUpper.
Change AsciiToUpper to InternalAsciiToUpper.
These changes are committed for bisectability, or build failure will
occur when 2/7 is applied. Because the introduced function names in
2/7 are the same as ones in EdbSupporting.c.
https://bugzilla.tianoc
InternalUnicodeToUpper and InternalAsciiToUpper are internal functions,
so they are substituted by public functions AsciiToUpper and CharToUpper.
And their implements are removed.
https://bugzilla.tianocore.org/show_bug.cgi?id=1369
Cc: Jian J Wang
Cc: Hao Wu
Cc: Ruiyu Ni
Cc: Star Zeng
Contribu
Introduce public functions CharToUpper and AsciiToUpper.
Remove internal functions InternalCharToUpper and InternalBaseLibAsciiToUpper.
v2: Update the title and commit message of 1/3.
v3: 1.Add a patch to remove AsciiToUpper in EdbSupportString.c.
2.Revert the changes in Basetools.
v4: 1.Add
Substitute InternalShellCharToUpper with CharToUpper which is a public
function with the same effect.
Remove the implement of InternalShellCharToUpper.
https://bugzilla.tianocore.org/show_bug.cgi?id=1369
Cc: Ruiyu Ni
Cc: Jaben Carsey
Contributed-under: TianoCore Contribution Agreement 1.1
Signed
InternalCharToUpper and InternalBaseLibAsciiToUpper are internal functions
and now we will introduce public functions that have the same effects.
So I remove their definitions in BaseLibInternals.h.
https://bugzilla.tianocore.org/show_bug.cgi?id=1369
Cc: Leif Lindholm
Cc: Laszlo Ersek
Cc: Michae
14 matches
Mail list logo
