On Thursday, 7 February 2019 11:30:38 MST stephano wrote:
> My apologies if I was not clear in the minutes. We are not rejecting
> Github, but rather taking time to evaluate how we can supplement
> Github's features to emulate our current patch review requirements. We
> do not want to rush into
On 02/07/19 15:59, Philippe Mathieu-Daudé wrote:
> On 2/7/19 2:04 PM, Ryszard Knop wrote:
>> Hi Philippe, Antoine,
>>
>> On Wed, 2019-02-06 at 23:30 +0100, Philippe Mathieu-Daudé wrote:
>>> Hi Antoine,
>>>
>>> On 2/6/19 6:24 PM, Antoine Coeur wrote:
Fix various typos in CryptoPkg.
Co
Hey Jeremiah,
My apologies if I was not clear in the minutes. We are not rejecting
Github, but rather taking time to evaluate how we can supplement
Github's features to emulate our current patch review requirements. We
do not want to rush into change and risk losing data or causing
frustratio
Apologies on the late reply, I was on vacation for several weeks and just got
back to this.
Regarding "Patch Review System Evaluation", on the call, I disagreed with your
conclusion, but that note is not captured below. My reading of the email and
call discussions, I did not hear our community
Hi Antoine,
On 2/7/19 6:13 PM, Antoine Coeur wrote:
> Thank you Laszlo.
>
> Do you have any recommendations regarding the maximum size of a patch for
> smooth reviewing on this mailing list?
> I have about 9000 lines of additional typos corrections in queue at
> https://github.com/Coeur/edk2/tr
Thank you Laszlo.
Do you have any recommendations regarding the maximum size of a patch for
smooth reviewing on this mailing list?
I have about 9000 lines of additional typos corrections in queue at
https://github.com/Coeur/edk2/tree/typo, but I'm afraid that big patches will
simply be ignored.
> My wonder is about what is the correct use between succeeds/succeeded,
> I'd expect the following diff:
>
> - @retval TRUE The time convertion succeeds.
> + @retval TRUE The time conversion succeeded.
In doubt, I'll just ignore this one. I made a v2 to address Jian review.
Thank you for revie
Fix various typos in CryptoPkg.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Coeur
---
CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c | 2 +-
CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
On 2/7/19 2:04 PM, Ryszard Knop wrote:
> Hi Philippe, Antoine,
>
> On Wed, 2019-02-06 at 23:30 +0100, Philippe Mathieu-Daudé wrote:
>> Hi Antoine,
>>
>> On 2/6/19 6:24 PM, Antoine Coeur wrote:
>>> Fix various typos in CryptoPkg.
>>>
>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>> S
On Thu, 7 Feb 2019 at 12:35, Pete Batard wrote:
>
> On 2019.02.07 02:35, Kinney, Michael D wrote:
> > Hi Pete,
> >
> > When I saw it as a single patch series, I did assume all the
> > patches were for the edk2-platforms repo. And it looked like
> > non-OSI binaries were going into the edk2-platfo
On 02/06/19 16:48, Antoine Coeur wrote:
> Fix various typos in ArmVirtPkg.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Coeur
> ---
> ArmVirtPkg/ArmVirt.dsc.inc | 2 +-
> ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c
On 02/07/19 00:08, Carsey, Jaben wrote:
> I sent this earlier, but failed the mailing list part.
>
> Reviewed-by: Jaben Carsey
> And pushed.
Thanks! This is commit 963517211cae1ad38984821061ad7982c448f934 now.
Laszlo
___
edk2-devel mailing list
edk2-d
Hi Philippe, Antoine,
On Wed, 2019-02-06 at 23:30 +0100, Philippe Mathieu-Daudé wrote:
> Hi Antoine,
>
> On 2/6/19 6:24 PM, Antoine Coeur wrote:
> > Fix various typos in CryptoPkg.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Coeur
> > ---
> > CryptoPkg/Li
On 2019.02.07 02:35, Kinney, Michael D wrote:
Hi Pete,
When I saw it as a single patch series, I did assume all the
patches were for the edk2-platforms repo. And it looked like
non-OSI binaries were going into the edk2-platforms repo.
Patch #0 did not make this clear either that multiple repos
14 matches
Mail list logo
