[edk2] [PATCH] MdeModulePkg/CapsulePei: Update the debug code to print 64bit data

2019-04-01 Thread Zhichao Gao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1677 For some pointer and UINT64 data, the debug code print with '%x'. Which would loss the upper 32bit data. So update '%x' to '%lx' for these data. Change the DEBUG PrintLevel from EFI_D_ version to DEBUG_ version. DEBUG_

[edk2] [PATCH 0/2] Use a pcd to control Platform Recovery behavior

2019-04-01 Thread Zhichao Gao
Add a pcd PcdPlatformRecoverySupport to control the variable PlatformRecovery and the EFI_OS_INDICATIONS_START_PLATFORM_RECOVERY bit of variable "OsIndicationsSupported". Bret Barkelew (2): MdeModulePkg: Add a pcd to set the OS indications bit MdeModulePkg/BdsDxe: Use a pcd to set OS indic

[edk2] [PATCH 2/2] MdeModulePkg/BdsDxe: Use a pcd to set OS indications bit

2019-04-01 Thread Zhichao Gao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1678 Use the pcd PcdPlatformRecoverySupport to control whether to set the PlatformRecovery variable and whether to set the EFI_OS_INDICATIONS_START_PLATFORM_RECOVERY bit of variable "OsIndicationsSupported". Cc: Jian J

[edk2] [PATCH 1/2] MdeModulePkg: Add a pcd to set the OS indications bit

2019-04-01 Thread Zhichao Gao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1678 Add a pcd PcdPlatformRecoverySupport to conditionally set an OS indications bit. Cc: Jian J Wang Cc: Ray Ni Cc: Star Zeng Cc: Liming Gao Cc: Sean Brogan Cc: Michael Turner Cc: Bret Barkelew Contributed-under: Ti

[edk2] [PATCH 2/2] MdeModulePkg/UefiBootManagerlib: Add two event signals

2019-04-01 Thread Zhichao Gao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1676 Add gEfiEventPreReadyToBootGuid signal before gEfiEventReadyToBootGuid and gEfiEventPostReadyToBootGuid after gEfiEventReadyToBootGuid in UefiBootManagerLib. Cc: Jian J Wang Cc: Ray Ni Cc: Star Zeng Cc: Liming Gao

[edk2] [PATCH 1/2] MdeModulePkg: Add event guids

2019-04-01 Thread Zhichao Gao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1676 Add event guids: gEfiEventPreReadyToBootGuid and gEfiEventPostReadyToBootGuid. And add the related header files. These two guid can be used to notify function before and after ReadyToBoot event. Cc: Jian J Wang Cc: Ra

[edk2] [PATCH 0/2] Add event signal before and after ReadyToBoot

2019-04-01 Thread Zhichao Gao
Add two event guids. And signal them immediately before and after the ReadyToBoot signal Event. Bret Barkelew (2): MdeModulePkg: Add event guids MdeModulePkg/UefiBootManagerlib: Add two event signals .../Include/Guid/EventPostReadyToBoot.h | 24 +++ .../Include/Guid/Eve

[edk2] [RFC] Plan to delete ShellBinPkg from edk2/master

2019-04-01 Thread Bi, Dandan
Hi All, ShellBinPkg is the remaining binary package in Edk2 repo. We plan to delete ShellBinPkg from edk2/master, and keep source ShellPkg only in edk2 repo. Before the deletion, I will update the existing consumers in Edk2 and Edk2Platforms to use ShellPkg directly. If you have any concern pl

[edk2] [PATCH v1 1/2] MdeModulePkg/AhciPei: Limit max transfer blocknum for 48-bit address

2019-04-01 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1483 Due to the limited resource on the VTd DMA buffer size in the PEI phase, the driver will limit the maximum transfer block number for 48-bit addressing. This commit aims to prevent the potential failure on calls to the IOMMU 'Map' service. C

[edk2] [PATCH v1 2/2] MdeModulePkg/AhciPei: Add PEI BlockIO support

2019-04-01 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1483 This commit will add the PEI BlockIO (2) PPIs support for AHCI mode ATA devices. More specifically, the driver will consume the ATA AHCI host controller PPI for ATA controllers working under AHCI code within the system. And then produces the

[edk2] [PATCH v1 0/2] Add PEI BlockIO support for ATA AHCI mode devices

2019-04-01 Thread Hao Wu
The series is also available at: https://github.com/hwu25/edk2/tree/ahci_pei_blockio_v1 The series will add the PEI BlockIO support for ATA AHCI mode devices. Cc: Ray Ni Cc: Eric Dong Cc: Jian J Wang Hao Wu (2): MdeModulePkg/AhciPei: Limit max transfer blocknum for 48-bit address MdeModul

Re: [edk2] [PATCH v4 14/14] CorebootModulePkg/SecCore: Remove .S files for IA32 arch

2019-04-01 Thread Ma, Maurice
Looks good to me! Reviewed-by: Maurice Ma Thanks Maurice > -Original Message- > From: Zhang, Shenglei > Sent: Monday, April 1, 2019 1:30 > To: edk2-devel@lists.01.org > Cc: Ma, Maurice ; Agyeman, Prince > ; You, Benjamin > Subject: [PATCH v4 14/14] CorebootModulePkg/SecCore: Remove .S f

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v4 2/3] ClevoOpenBoardPkg/N1xxWU: Flash map update

2019-04-01 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, April 2, 2019 10:47 AM > To: edk2-devel@lists.01.org > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Chiu, Chasel ; Gao, > Liming ; Kinney, Michael D > > Subject: [edk2-platforms/devel-MinPlatform]

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v4 1/3] KabylakeSiliconPkg: Add SPI write support in PEI

2019-04-01 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, April 2, 2019 10:47 AM > To: edk2-devel@lists.01.org > Cc: Desimone, Nathaniel L ; Chiu, Chasel > ; Gao, Liming ; Kinney, Michael > D > Subject: [edk2-platforms/devel-MinPlatform][PATCH v4 1/3] Ka

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v4 3/3] ClevoOpenBoardPkg/N1xxWU: Write PEI debug messages to SPI flash

2019-04-01 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, April 2, 2019 10:47 AM > To: edk2-devel@lists.01.org > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Chiu, Chasel ; Gao, > Liming ; Kinney, Michael D > > Subject: [edk2-platforms/devel-MinPlatform]

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v3 1/3] KabylakeSiliconPkg: Add SPI write support in PEI

2019-04-01 Thread Kubacki, Michael A
Comment added in v4 > -Original Message- > From: Chiu, Chasel > Sent: Monday, April 1, 2019 7:29 PM > To: Kubacki, Michael A ; edk2- > de...@lists.01.org > Cc: Desimone, Nathaniel L ; Gao, Liming > ; Kinney, Michael D > Subject: RE: [edk2-platforms/devel-MinPlatform][PATCH v3 1/3] > Kabyl

[edk2] [edk2-platforms/devel-MinPlatform][PATCH v4 2/3] ClevoOpenBoardPkg/N1xxWU: Flash map update

2019-04-01 Thread Michael Kubacki
Updates the total BIOS flash image size to 0x5E. This size matches the BIOS region size already configured in the SPI flash descriptor. To write an image produced from the N1xxWU board build, write the N1XXWU.fd file (~6 MB) to the beginning of the BIOS region in the SPI flash (currently 0x220

[edk2] [edk2-platforms/devel-MinPlatform][PATCH v4 0/3] Enable SPI flash debug messages

2019-04-01 Thread Michael Kubacki
Adds support to the N1xxWU board series in the ClevoOpenBoardPkg to write debug messages to a dedicated area on SPI flash. This supports simple closed chassis debug. At this time, only a PEI library instance is added since it is anticipated an alternative mechanism will be available in DXE such as

[edk2] [edk2-platforms/devel-MinPlatform][PATCH v4 1/3] KabylakeSiliconPkg: Add SPI write support in PEI

2019-04-01 Thread Michael Kubacki
Adds a new library PeiSpiLib to perform the initialization necessary to perform SPI write cycles in PEI. After initialization, it installs an instance of the PCH_SPI_PPI. Cc: Nate DeSimone Cc: Chasel Chiu Cc: Liming Gao Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1

[edk2] [edk2-platforms/devel-MinPlatform][PATCH v4 3/3] ClevoOpenBoardPkg/N1xxWU: Write PEI debug messages to SPI flash

2019-04-01 Thread Michael Kubacki
Adds a new SerialPortLib instance to the ClevoOpenBoardPkg to support writing debug messages to a dedicated area on SPI flash. This is to enable closed chassis debug support on the system. DXE and later phases after memory initialization are expected to use USB debug. Cc: Ankit Sinha Cc: Nate De

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v3 2/3] ClevoOpenBoardPkg/N1xxWU: Flash map update

2019-04-01 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, April 2, 2019 9:23 AM > To: edk2-devel@lists.01.org > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Chiu, Chasel ; Gao, > Liming ; Kinney, Michael D > > Subject: [edk2-platforms/devel-MinPlatform][

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v3 3/3] ClevoOpenBoardPkg/N1xxWU: Write PEI debug messages to SPI flash

2019-04-01 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, April 2, 2019 9:23 AM > To: edk2-devel@lists.01.org > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Chiu, Chasel ; Gao, > Liming ; Kinney, Michael D > > Subject: [edk2-platforms/devel-MinPlatform][

Re: [edk2] [PATCH v9] UefiCpuPkg\CpuSmm: Save & restore CR2 on-demand paging in SMM

2019-04-01 Thread Desimone, Nathaniel L
Hi Narendra, I see that now, thank you. I now understand your patch. Reviewed-by: Nate DeSimone -Original Message- From: Vanguput, Narendra K Sent: Monday, April 1, 2019 7:32 PM To: Desimone, Nathaniel L ; edk2-devel@lists.01.org Cc: Yao, Jiewen ; Dong, Eric ; Laszlo Ersek Subject:

Re: [edk2] [PATCH v9] UefiCpuPkg\CpuSmm: Save & restore CR2 on-demand paging in SMM

2019-04-01 Thread Vanguput, Narendra K
Hi Nate, The 'PcdCpuSmmStaticPageTable' is only used in the X64 version of PageTbl.c that's why I updated only for 64 bit. SMM always builds static page table for IA32. Please refer my previous mail for more details. Thanks, Narendra > -Original Message- > From: Desimone, Nathaniel L

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v3 3/3] ClevoOpenBoardPkg/N1xxWU: Write PEI debug messages to SPI flash

2019-04-01 Thread Desimone, Nathaniel L
No change from V1 or V2. Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Monday, April 1, 2019 6:23 PM To: edk2-devel@lists.01.org Cc: Sinha, Ankit ; Desimone, Nathaniel L ; Chiu, Chasel ; Gao, Liming ; Kinney, Michael D Subject: [edk2-platforms/devel-Min

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v3 2/3] ClevoOpenBoardPkg/N1xxWU: Flash map update

2019-04-01 Thread Desimone, Nathaniel L
No change from V1 or V2. Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Monday, April 1, 2019 6:23 PM To: edk2-devel@lists.01.org Cc: Sinha, Ankit ; Desimone, Nathaniel L ; Chiu, Chasel ; Gao, Liming ; Kinney, Michael D Subject: [edk2-platforms/devel-Min

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v3 1/3] KabylakeSiliconPkg: Add SPI write support in PEI

2019-04-01 Thread Desimone, Nathaniel L
Look's good! Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Monday, April 1, 2019 6:23 PM To: edk2-devel@lists.01.org Cc: Desimone, Nathaniel L ; Chiu, Chasel ; Gao, Liming ; Kinney, Michael D Subject: [edk2-platforms/devel-MinPlatform][PATCH v3 1/3] Kab

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v3 1/3] KabylakeSiliconPkg: Add SPI write support in PEI

2019-04-01 Thread Chiu, Chasel
Hi Michael, Please see below inline. Thanks! Chasel > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, April 2, 2019 9:23 AM > To: edk2-devel@lists.01.org > Cc: Desimone, Nathaniel L ; Chiu, Chasel > ; Gao, Liming ; Kinney, Michael > D > Subject: [edk2-platforms/devel-M

Re: [edk2] [PATCH 1/2] ArmVirtPkg: add runtime instance of FdtPL011SerialPortLib

2019-04-01 Thread Heyi Guo
Hi Laszlo, Thanks for your time of reviewing and sorry for code style issues. I accept most of comments, with some questions for below ones: (7) coding style -- please use empty // lines before and after the comment line that you have right now. I remember Ard said this rule conflicted some ot

Re: [edk2] [PATCH] UefiPayloadPkg: Enhance UEFI payload for coreboot and Slim Bootloader

2019-04-01 Thread Wu, Hao A
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, April 01, 2019 10:05 PM > To: Ni, Ray; Dong, Guo; edk2-devel@lists.01.org > Cc: Wu, Hao A; Kinney, Michael D; Ma, Maurice; David Woodhouse > Subject: Re: [edk2] [PATCH] UefiPayloadPkg: Enhance UEFI payload

Re: [edk2] [PATCH v4 13/14] SourceLevelDebugPkg/PeCoffExtraActionLibDebug: Remove .S files

2019-04-01 Thread Wu, Hao A
Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Zhang, Shenglei > Sent: Monday, April 01, 2019 4:30 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [PATCH v4 13/14] SourceLevelDebugPkg/PeCoffExtraActionLibDebug: > Remove .S files > > .nasm file has bee

Re: [edk2] [PATCH v3 12/14] SourceLevelDebugPkg/DebugAgentCommon: Remove .S files

2019-04-01 Thread Wu, Hao A
> -Original Message- > From: Zhang, Shenglei > Sent: Monday, April 01, 2019 4:30 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [PATCH v3 12/14] SourceLevelDebugPkg/DebugAgentCommon: > Remove .S files > > .nasm file has been added for X86 arch. .S assembly code > is not requir

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v2 1/3] KabylakeSiliconPkg: Add SPI write support in PEI

2019-04-01 Thread Kubacki, Michael A
Applied both feedback items in v3. > -Original Message- > From: Chiu, Chasel > Sent: Monday, April 1, 2019 6:08 PM > To: Desimone, Nathaniel L ; Kubacki, > Michael A ; edk2-devel@lists.01.org > Cc: Gao, Liming ; Kinney, Michael D > > Subject: RE: [edk2-platforms/devel-MinPlatform][PATCH v

[edk2] [edk2-platforms/devel-MinPlatform][PATCH v3 2/3] ClevoOpenBoardPkg/N1xxWU: Flash map update

2019-04-01 Thread Michael Kubacki
Updates the total BIOS flash image size to 0x5E. This size matches the BIOS region size already configured in the SPI flash descriptor. To write an image produced from the N1xxWU board build, write the N1XXWU.fd file (~6 MB) to the beginning of the BIOS region in the SPI flash (currently 0x220

[edk2] [edk2-platforms/devel-MinPlatform][PATCH v3 1/3] KabylakeSiliconPkg: Add SPI write support in PEI

2019-04-01 Thread Michael Kubacki
Adds a new library PeiSpiLib to perform the initialization necessary to perform SPI write cycles in PEI. After initialization, it installs an instance of the PCH_SPI_PPI. Cc: Nate DeSimone Cc: Chasel Chiu Cc: Liming Gao Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1

[edk2] [edk2-platforms/devel-MinPlatform][PATCH v3 0/3] Enable SPI flash debug messages

2019-04-01 Thread Michael Kubacki
Adds support to the N1xxWU board series in the ClevoOpenBoardPkg to write debug messages to a dedicated area on SPI flash. This supports simple closed chassis debug. At this time, only a PEI library instance is added since it is anticipated an alternative mechanism will be available in DXE such as

[edk2] [edk2-platforms/devel-MinPlatform][PATCH v3 3/3] ClevoOpenBoardPkg/N1xxWU: Write PEI debug messages to SPI flash

2019-04-01 Thread Michael Kubacki
Adds a new SerialPortLib instance to the ClevoOpenBoardPkg to support writing debug messages to a dedicated area on SPI flash. This is to enable closed chassis debug support on the system. DXE and later phases after memory initialization are expected to use USB debug. Cc: Ankit Sinha Cc: Nate De

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v2 2/3] ClevoOpenBoardPkg/N1xxWU: Flash map update

2019-04-01 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, April 2, 2019 6:48 AM > To: edk2-devel@lists.01.org > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Chiu, Chasel ; Gao, > Liming ; Kinney, Michael D > > Subject: [edk2-platforms/devel-MinPlatform][

Re: [edk2] [edk2-platforms][PATCH v1 2/3] ClevoOpenBoardPkg/N1xxWU: Flash map update

2019-04-01 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Monday, April 1, 2019 7:28 AM > To: edk2-devel@lists.01.org > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Chiu, Chasel ; Gao, > Liming ; Kinney, Michael D > > Subject: [edk2-platforms][PATCH v1 2/3] Clevo

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v2 3/3] ClevoOpenBoardPkg/N1xxWU: Write PEI debug messages to SPI flash

2019-04-01 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, April 2, 2019 6:48 AM > To: edk2-devel@lists.01.org > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Chiu, Chasel ; Gao, > Liming ; Kinney, Michael D > > Subject: [edk2-platforms/devel-MinPlatform][

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v2 1/3] KabylakeSiliconPkg: Add SPI write support in PEI

2019-04-01 Thread Chiu, Chasel
Hi Michael, A question in below patch inline, please help to check it. Thanks! Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Tuesday, April 2, 2019 8:09 AM > To: Kubacki, Michael A ; > edk2-devel@lists.01.org > Cc: Chiu, Chasel ; Gao, Liming ; > Kinney, Michael D >

Re: [edk2] [PATCH v9] UefiCpuPkg\CpuSmm: Save & restore CR2 on-demand paging in SMM

2019-04-01 Thread Desimone, Nathaniel L
This patch seems to only add the IN/OUT decorators on function parameters, which is a good change. However, it does not address any of my previous comments: 1. Why would you do this for 64 bit but not 32 bit? 2. Why don't you add the if statement to MpService.c instead of spreading it to PageTb

[edk2] [PATCH] CorebootPayloadPkg/FbGop: Locate correct framebuffer device

2019-04-01 Thread Maurice Ma
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1628 Current FbGop driver might bind to the wrong PCI device if a system has multiple PCI display devices. The original idea was to reuse the generic GraphicsOutputDxe to address this issue. However, after exploring different approaches discussed i

[edk2] [edk2-platforms/devel-MinPlatform][Patch] AdvancedFeaturePkg/AcpiDebug: Add new AcpiDebug modules.

2019-04-01 Thread Eric Dong
V2 change: Update the patch header. Add new AcpiDebug modules which provide ACPI Debug feature. Detail about this feature see the readme.txt in the patch. Cc: Hao Wu Cc: Michael Kubacki Cc: Nate Desimone Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- ...

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v2 1/3] KabylakeSiliconPkg: Add SPI write support in PEI

2019-04-01 Thread Desimone, Nathaniel L
1. The changes in BasePchSpiCommonLib.inf seems to be no longer necessary. 2. Adding #include to SpiCommon.c seems to be no longer necessary. Thanks, Nate -Original Message- From: Kubacki, Michael A Sent: Monday, April 1, 2019 3:48 PM To: edk2-devel@lists.01.org Cc: Desimone, Nathanie

Re: [edk2] [Patch] AdvancedFeaturePkg/AcpiDebug: Add new AcpiDebug modules.

2019-04-01 Thread Dong, Eric
Hi Laszlo, yes, it's for edk2-platforms. Sorry for this one, will follow this rule next time. Thanks, Eric > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, April 2, 2019 12:53 AM > To: Dong, Eric ; edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject:

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v2 2/3] ClevoOpenBoardPkg/N1xxWU: Flash map update

2019-04-01 Thread Desimone, Nathaniel L
No change from V1. Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Monday, April 1, 2019 3:48 PM To: edk2-devel@lists.01.org Cc: Sinha, Ankit ; Desimone, Nathaniel L ; Chiu, Chasel ; Gao, Liming ; Kinney, Michael D Subject: [edk2-platforms/devel-MinPlatfo

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v2 3/3] ClevoOpenBoardPkg/N1xxWU: Write PEI debug messages to SPI flash

2019-04-01 Thread Desimone, Nathaniel L
No change from V1. Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Monday, April 1, 2019 3:48 PM To: edk2-devel@lists.01.org Cc: Sinha, Ankit ; Desimone, Nathaniel L ; Chiu, Chasel ; Gao, Liming ; Kinney, Michael D Subject: [edk2-platforms/devel-MinPlatfo

[edk2] [edk2-platforms/devel-MinPlatform][PATCH v2 3/3] ClevoOpenBoardPkg/N1xxWU: Write PEI debug messages to SPI flash

2019-04-01 Thread Michael Kubacki
Adds a new SerialPortLib instance to the ClevoOpenBoardPkg to support writing debug messages to a dedicated area on SPI flash. This is to enable closed chassis debug support on the system. DXE and later phases after memory initialization are expected to use USB debug. Cc: Ankit Sinha Cc: Nate De

[edk2] [edk2-platforms/devel-MinPlatform][PATCH v2 0/3] Enable SPI flash debug messages

2019-04-01 Thread Michael Kubacki
Adds support to the N1xxWU board series in the ClevoOpenBoardPkg to write debug messages to a dedicated area on SPI flash. This supports simple closed chassis debug. At this time, only a PEI library instance is added since it is anticipated an alternative mechanism will be available in DXE such as

[edk2] [edk2-platforms/devel-MinPlatform][PATCH v2 2/3] ClevoOpenBoardPkg/N1xxWU: Flash map update

2019-04-01 Thread Michael Kubacki
Updates the total BIOS flash image size to 0x5E. This size matches the BIOS region size already configured in the SPI flash descriptor. To write an image produced from the N1xxWU board build, write the N1XXWU.fd file (~6 MB) to the beginning of the BIOS region in the SPI flash (currently 0x220

[edk2] [edk2-platforms/devel-MinPlatform][PATCH v2 1/3] KabylakeSiliconPkg: Add SPI write support in PEI

2019-04-01 Thread Michael Kubacki
Adds a new library PeiSpiLib to perform the initialization necessary to perform SPI write cycles in PEI. After initialization, it installs an instance of the PCH_SPI_PPI. Cc: Nate DeSimone Cc: Chasel Chiu Cc: Liming Gao Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1

Re: [edk2] [edk2-platforms][PATCH v2 0/2] Adding python build scripts to ClevoOpenBoardPkg , KabylakeOpenBoardPkg and PurleyOpenBoardPkg

2019-04-01 Thread Agyeman, Prince
- Added python build scripts to edk2-platforms/Platform/Intel /ClevoOpenBoardPkg , KabylakeOpenBoardPkg and PurleyOpenBoardPkg in v1 - Cc'ed a edk2-platforms maintainer Michael A Kubacki in v2 Prince -Original Message- From: Carsey, Jaben Sent: Monday, April 1, 2019 2:17 PM To:

Re: [edk2] [edk2-platforms][PATCH v2 0/2] Adding python build scripts to ClevoOpenBoardPkg , KabylakeOpenBoardPkg and PurleyOpenBoardPkg

2019-04-01 Thread Carsey, Jaben
Blurb missing. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Agyeman > Sent: Monday, April 01, 2019 2:14 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [edk2-platforms][PATCH v2 0/2] Adding python build scripts > to ClevoOpenBoardPkg ,

[edk2] [edk2-platforms][PATCH v2 1/2] Platform/Intel: Added python build script.

2019-04-01 Thread Agyeman
This change allows building all the platforms in Platform/Intel with a single python script. This script is tested on windows 10 , python 2.7 and python 3.7 with VS2015 Files Added: * BuildBios.py: the main build script build.json: contains general/default build settings * ClevoOpenBoardPkg/N1x

[edk2] [edk2-platforms][PATCH v2 2/2] ReadMe.md: Update the build instructions

2019-04-01 Thread Agyeman
Updated the build instructions to include the python script build instructions Cc: Michael Kubacki Cc: Michael D Kinney Cc: Nate DeSimone Cc: Liming Gao Cc: Ankit Sinha Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Agyeman --- ReadMe.md | 14 ++ 1 file

[edk2] [edk2-platforms][PATCH v2 0/2] Adding python build scripts to ClevoOpenBoardPkg , KabylakeOpenBoardPkg and PurleyOpenBoardPkg

2019-04-01 Thread Agyeman
*** BLURB HERE *** Agyeman (2): Platform/Intel: Added python build script. ReadMe.md: Update the build instructions Platform/Intel/BuildBios.py | 866 ++ .../ClevoOpenBoardPkg/N1xxWU/buildConfig.json | 31 + .../KabylakeRvp3/BuildEx.py |

Re: [edk2] [edk2-test][Patch 1/1] uefi-sct/SctPkg:Fix inf/dec files for EBC test

2019-04-01 Thread Supreeth Venkatesh
Reviewed-by: Supreeth Venkatesh and pushed as 6acb58dab3f5ca44c6ab5d85bcacbfb311a74631 Thanks, Supreeth -Original Message- From: Eric Jin Sent: Saturday, March 30, 2019 2:26 AM To: edk2-devel@lists.01.org Cc: Supreeth Venkatesh Subject: [edk2-test][Patch 1/1] uefi-sct/SctPkg:Fix inf/de

[edk2] [edk2-announce] Design Meeting Update

2019-04-01 Thread stephano
As my friends in PRC reminded me, the 5th is a holiday for them, so it's probably not the best time to start our design meetings. :) We will hold off until the 18th to start our Open Source Design Meetings. I've updated the Groups.io calendar. Sorry for the mix up. Cheers, Stephano __

Re: [edk2] [PATCH v9] UefiCpuPkg\CpuSmm: Save & restore CR2 on-demand paging in SMM

2019-04-01 Thread Andrew Fish via edk2-devel
> On Apr 1, 2019, at 9:47 AM, Laszlo Ersek wrote: > > On 04/01/19 10:16, nkvangup wrote: >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1593 >> >> For every SMI occurrence, save and restore CR2 register only when SMM >> on-demand paging support is enabled in 64 bit operation mode. >> T

Re: [edk2] [edk2-platforms][PATCH v1 3/3] ClevoOpenBoardPkg/N1xxWU: Write PEI debug messages to SPI flash

2019-04-01 Thread Kubacki, Michael A
1. I agree. Due to the total debug message length in PEI, I thought this could be added as a future enhancement. I will come back to it soon. 2. Not at the moment. There is an increasing need for a "common board package". PeiSerialPortLibSpiFlash is abstracted with the PCH_SPI_PPI and SpiLib in a

Re: [edk2] [Patch] AdvancedFeaturePkg/AcpiDebug: Add new AcpiDebug modules.

2019-04-01 Thread Laszlo Ersek
On 04/01/19 05:16, Eric Dong wrote: > Add new AcpiDebug modules which provide ACPI Debug feature. > Detail about this feature see the readme.txt in the patch. > > Change-Id: Ib977ece46f3494301574b04af32282b99045f673 > Cc: Hao Wu > Cc: Michael Kubacki > Contributed-under: TianoCore Contribution A

Re: [edk2] [PATCH v9] UefiCpuPkg\CpuSmm: Save & restore CR2 on-demand paging in SMM

2019-04-01 Thread Laszlo Ersek
On 04/01/19 10:16, nkvangup wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1593 > > For every SMI occurrence, save and restore CR2 register only when SMM > on-demand paging support is enabled in 64 bit operation mode. > This is not a bug but to have better improvement of code. > > Pa

Re: [edk2] [PATCH 2/2] CorebootPayloadPkg: Fix non - CRLF line endings

2019-04-01 Thread Ma, Maurice
This patch series looks good to me. Reviewed-by: Maurice Ma Regards, -Maurice -Original Message- From: Agyeman, Prince Sent: Thursday, March 28, 2019 12:54 To: edk2-devel@lists.01.org Cc: Ma, Maurice ; You, Benjamin Subject: [PATCH 2/2] CorebootPayloadPkg: Fix non - CRLF line endings

Re: [edk2] [edk2-platforms][PATCH v1 1/3] KabylakeSiliconPkg: Add SPI write support in PEI

2019-04-01 Thread Kubacki, Michael A
1. I missed in a local merge, will be fixed in v2. 2. You're correct that SpiProtocolConstructor ( ) is used in PEI+DXE+SMM. PeiSpiLib initializes the SPI BAR before calling SpiProtocolConstructor ( ). > -Original Message- > From: Desimone, Nathaniel L > Sent: Sunday, March 31, 2019 10:37

Re: [edk2] [PATCH 2/2] ArmVirtQemu: enable runtime debug by build flag

2019-04-01 Thread Laszlo Ersek
On 04/01/19 11:06, Heyi Guo wrote: > Introduce a build flag "RT_DEBUG" to enable runtime debug, so that we > can have a handy method for UEFI runtime services debug. > > This build flag only applies to DEBUG build; the reason for not > enabling it for DEBUG build by default is that we are still us

Re: [edk2] [PATCH 1/2] ArmVirtPkg: add runtime instance of FdtPL011SerialPortLib

2019-04-01 Thread Laszlo Ersek
On 04/01/19 11:06, Heyi Guo wrote: > Add a runtime instance of FdtPL011SerialPortLib to support runtime > serial port debug for UEFI runtime services. > > The framework is based on below discussion: > https://lists.01.org/pipermail/edk2-devel/2019-March/037986.html > > We have decided to use an i

Re: [edk2] [Patch] BaseTools:Enable the /MP option of MSVC compiler

2019-04-01 Thread Feng, Bob C
Hi Kilian, It's a good suggestion. Would you please enter a new BZ for this request? I think implement this request in a separate patch would be better. Thanks, Bob From: Minnow Ware [mailto:minnoww...@outlook.com] Sent: Saturday, March 30, 2019 4:15 PM To: Ni, Ray ; Feng, Bob C ; edk2-devel@l

Re: [edk2] [PATCH] UefiPayloadPkg: Enhance UEFI payload for coreboot and Slim Bootloader

2019-04-01 Thread Laszlo Ersek
(+David) On 03/29/19 06:15, Ni, Ray wrote: > > Guo, > Just to double confirm: UefiPayloadPkg will not require Legacy8254 timer > support. > The old packages Coreboot*Pkgs will be removed. > Which means now only QEMU/OVMF needs the Legacy8254 support. > > Laszlo, > Now since QEMU/OVMF is the onl

Re: [edk2] [PATCH 1/4] OvmfPkg/PlatformBootManagerLib: Remove dependency on Mps.h

2019-04-01 Thread Laszlo Ersek
On 03/29/19 02:41, Shenglei Zhang wrote: > Mps.h is included in BdsPlatform.h but not actually used. > So remove it. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > --- > OvmfPkg/Library/

Re: [edk2] [PATCH] Vlv2TbltDevicePkg: Remove PACKAGES_PATH from batch file

2019-04-01 Thread Qian, Yi
Reviewed by Qian, Yi Thanks Qian Yi > -Original Message- > From: Sun, Zailiang > Sent: Monday, April 01, 2019 5:07 PM > To: edk2-devel@lists.01.org > Cc: Wei, David ; Qian, Yi > Subject: [PATCH] Vlv2TbltDevicePkg: Remove PACKAGES_PATH from batch > file > > PACKAGES_PATH is supposed to

[edk2] [PATCH 2/2] ArmVirtQemu: enable runtime debug by build flag

2019-04-01 Thread Heyi Guo
Introduce a build flag "RT_DEBUG" to enable runtime debug, so that we can have a handy method for UEFI runtime services debug. This build flag only applies to DEBUG build; the reason for not enabling it for DEBUG build by default is that we are still using the same UART of OS and it may cause pote

[edk2] [PATCH 1/2] ArmVirtPkg: add runtime instance of FdtPL011SerialPortLib

2019-04-01 Thread Heyi Guo
Add a runtime instance of FdtPL011SerialPortLib to support runtime serial port debug for UEFI runtime services. The framework is based on below discussion: https://lists.01.org/pipermail/edk2-devel/2019-March/037986.html We have decided to use an individual firmware UART for UEFI runtime debug, h

[edk2] [PATCH 0/2] Enable runtime serial port debug for ArmVirtQemu

2019-04-01 Thread Heyi Guo
These patches are based on below discussion: https://lists.01.org/pipermail/edk2-devel/2019-March/037986.html We have decided to use an individual firmware UART for UEFI runtime debug, however this depends on QEMU to provide this virtual device, so we still use the OS visible system UART at the mo

[edk2] [PATCH] Vlv2TbltDevicePkg: Remove PACKAGES_PATH from batch file

2019-04-01 Thread Zailiang Sun
PACKAGES_PATH is supposed to set manually by users. Remove the assignment statement from batch file in this commit. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zailiang Sun Cc: David Wei Cc: Yi Qian --- Vlv2TbltDevicePkg/bld_vlv.bat | 1 - 1 file changed, 1 deletion(

Re: [edk2] [PATCH v9] UefiCpuPkg\CpuSmm: Save & restore CR2 on-demand paging in SMM

2019-04-01 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of nkvangup Sent: Monday, April 1, 2019 4:16 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Dong, Eric ; Laszlo Ersek Subject: [edk2] [PATCH v9] UefiCpuPkg\CpuSmm: Save & rest

[edk2] [PATCH v3 12/14] SourceLevelDebugPkg/DebugAgentCommon: Remove .S files

2019-04-01 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang Reviewed-by: Liming Gao --- .../DebugAgentCommon/Ia32/AsmFuncs

[edk2] [PATCH v4 14/14] CorebootModulePkg/SecCore: Remove .S files for IA32 arch

2019-04-01 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Maurice Ma Cc: Prince Agyeman Cc: Benjamin You Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- CorebootModulePkg

[edk2] [PATCH v3 05/14] MdePkg/BaseLib: Remove .S files for IA32 and X64 arch

2019-04-01 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang Reviewed-by: Liming Gao --- MdePkg/L

[edk2] [PATCH v3 10/14] MdePkg/BaseMemoryLibSse2: Remove .S files for IA32 and X64 arch

2019-04-01 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang Reviewed-by: Liming Gao --- .../Base

[edk2] [PATCH v4 13/14] SourceLevelDebugPkg/PeCoffExtraActionLibDebug: Remove .S files

2019-04-01 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- .../Ia32/IntHandler.S | 28

[edk2] [PATCH v3 07/14] MdePkg/BaseMemoryLibOptDxe: Remove .S files for IA32 and X64 arch

2019-04-01 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang Reviewed-by: Liming Gao --- .../Base

[edk2] [PATCH v3 11/14] CryptoPkg/IntrinsicLib: Remove .S files for IA32 arch

2019-04-01 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Ting Ye Cc: Jian Wang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang Reviewed-by: Jian J Wang Reviewed-by: Liming Ga

[edk2] [PATCH v3 08/14] MdePkg/BaseMemoryLibOptPei: Remove .S files for IA32 and X64 arch

2019-04-01 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang Reviewed-by: Liming Gao --- .../Base

[edk2] [PATCH v3 09/14] MdePkg/BaseMemoryLibRepStr: Remove .S files for IA32 and X64 arch

2019-04-01 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang Reviewed-by: Liming Gao --- .../Base

[edk2] [PATCH v3 06/14] MdePkg/BaseMemoryLibMmx: Remove .S files for IA32 and X64 arch

2019-04-01 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang Reviewed-by: Liming Gao --- .../Base

[edk2] [PATCH v3 03/14] UefiCpuPkg/CpuExceptionHandlerLib:Remove.S files for IA32 and X64 arch

2019-04-01 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang Reviewed-by: Eric Dong Reviewed-by: L

[edk2] [PATCH v3 04/14] MdePkg/BaseCpuLib: Remove .S files for IA32 and X64 arch

2019-04-01 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 v2: Remove CpuSleep.nasm| GCC and CpuFlushTlb.nasm| GCC in X64 arch in BaseCpuLib.inf. Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Cont

[edk2] [PATCH v3 02/14] UefiCpuPkg/BaseUefiCpuLib: Remove .S files for IA32 and X64 arch

2019-04-01 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang Reviewed-by: Eric Dong Reviewed-by: L

[edk2] [PATCH v4 00/14] Remove .S files for IA32 and X64 arch in MdePkg and UefiCpuPkg

2019-04-01 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 v2: Remove some description in 04/10. v3: Add 11/12 and 12/12. v4: Add 13/14 and 14/14. Cc: Michael D Kinney Cc: Liming Gao Cc: Eric Dong Cc: Ray Ni Cc: Hao

[edk2] [PATCH v3 01/14] UefiCpuPkg/SmmCpuFeaturesLib: Remove .S files for IA32 and X64 arch

2019-04-01 Thread Shenglei Zhang
.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang Reviewed-by: Eric Dong Reviewed-by: L

[edk2] [PATCH v9] UefiCpuPkg\CpuSmm: Save & restore CR2 on-demand paging in SMM

2019-04-01 Thread nkvangup
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1593 For every SMI occurrence, save and restore CR2 register only when SMM on-demand paging support is enabled in 64 bit operation mode. This is not a bug but to have better improvement of code. Patch5 is updated with separate functions for Save