On 10/8/2018 10:53 PM, Carsey, Jaben wrote:
Seems good to me.
Any thoughts Ray?
Reviewed-by: Jaben Carsey
Pushed.
--
Thanks,
Ray
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
On 10/11/2018 3:05 PM, Eric Dong wrote:
V5:
1. Add ASSERT to indicate this assumption that environment is 32 bit mode.
2. Add description in INF about this driver's expected result
in different environment.
V4:
Only disable paging when it is enabled.
V3 changes:
No need to change inf file.
On 10/9/2018 4:25 PM, Laszlo Ersek wrote:
On 10/09/18 08:01, Eric Dong wrote:
V3 changes:
No need to change inf file. Also update commit message to include regression
info.
V2 changes:
Only disable paging in 32 bit mode, no matter it is enable or not.
V1 changes:
PEI Stack Guard needs to
On 10/9/2018 4:09 PM, Laszlo Ersek wrote:
Two comments:
1. We'd better not map the PcdCpuStackGuard to paging-enable. Maybe some
other feature also enables the paging in PEI phase but the
PcdCpuStackGuard is FALSE.
I think I agree.
2. When PEI is in 64bit mode, disabling paging may not work
On 10/9/2018 2:01 PM, Eric Dong wrote:
V3 changes:
No need to change inf file. Also update commit message to include regression
info.
V2 changes:
Only disable paging in 32 bit mode, no matter it is enable or not.
V1 changes:
PEI Stack Guard needs to enable paging. This might cause #GP if code
On 10/5/2018 8:19 PM, Tim Lewis wrote:
Jaben --
Following on this: shouldn't this be a spec issue? If you are asking people
to depend on the behavior.
I agree. So I suggest submit a Spec ECR for this change.
Since it was checked in, we can revert it if the ECR is rejected.
Thanks,
Tim
On 10/8/2018 9:23 PM, jim.dai...@dell.com wrote:
-Original Message-
diff --git a/MdePkg/Library/BaseLib/FilePaths.c
b/MdePkg/Library/BaseLib/FilePaths.c
index d6f3758ecb..5d3de01894 100644
--- a/MdePkg/Library/BaseLib/FilePaths.c
+++ b/MdePkg/Library/BaseLib/FilePaths.c
@@ -2,6 +2,7
-devel@lists.01.org
Cc: Ni, Ruiyu ; Laszlo Ersek
Subject: [edk2] [Patch] UefiCpuPkg/S3Resume2Pei: disable paging before
creating new page table.
PEI Stack Guard needs to enable paging. This might cause #GP in the
transition from 32-bit PEI to 64-bit SMM due to the code trying to write CR3
register
On 10/8/2018 11:15 PM, Laszlo Ersek wrote:
On 10/08/18 16:32, Bi, Dandan wrote:
what were the practical consequences (symptoms) of this issue? Did some
checkboxes not work? (I'm asking because SecureBootConfigDxe uses some
checkboxes.)
1. The bug is in function
On 10/4/2018 11:03 PM, jim.dai...@dell.com wrote:
MdePkg-BaseLib: Fix PathCleanUpDirectories() error involving "\..\.."
The loop that removes "\..\" errs when multiple "\.." sequences are
in the path. Before this change the code would modify a path like
"FS0:\efi\tools\..\.." to
On 10/8/2018 11:31 AM, Dandan Bi wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1229
When converting DebugPort device path from text,
current code use VENDOR_DEFINED_MESSAGING_DEVICE_PATH structure
for Debug port device node.
typedef struct {
EFI_DEVICE_PATH_PROTOCOL Header;
On 10/8/2018 11:31 AM, Dandan Bi wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1228
According to UEFI spec,for ACPI Expanded Device Path
when HID=PNP0A03 or CID=PNP0A03 and HID != PNP0A08,
the device path node can be displayed as: PciRoot(UID|UIDSTR)
When HID=PNP0A08 or
On 10/8/2018 11:31 AM, Dandan Bi wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1226
According to UEFI Spec, for ACPI Expanded Device Path,
when HIDSTR=empty, CIDSTR=empty, UID STR!=empty,
the ACPI Expanded Device Path node can be displayed as
AcpiExp(HID,CID,UIDSTR) format.
And if
On 10/8/2018 11:31 AM, Dandan Bi wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1227
According to UEFI Spec, ACPI Expanded Device Path can be display
AcpiEx(HID|HIDSTR,(CID|CIDSTR,UID|UIDSTR)), but current code display
UID|UIDSTR before CID|CIDSTR.
This patch is to fix this issue.
On 10/8/2018 11:31 AM, Dandan Bi wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1225
According to UEFI spec, the string expression of UTF8 vendor
device node should be displayed as: VenUtf8(). Current code
display it as: VenUft8() by mistake when convert device
path node to text.
On 10/4/2018 12:02 AM, jim.dai...@dell.com wrote:
Create a homefilesystem environment variable whose value is the file
system on which the executing shell is located. For example: "FS14:".
This eliminates the need for people to have to try and find the "boot"
file system in their startup
On 9/28/2018 2:18 PM, Ming Huang wrote:
On 9/26/2018 1:00 PM, Ni, Ruiyu wrote:
@@ -507,12 +552,13 @@ BmRepairAllControllers (
FormBrowser2,
[Index],
1
> -Original Message-
> From: Laszlo Ersek
> Sent: Tuesday, October 2, 2018 6:14 PM
> To: Ni, Ruiyu ; Zhang, Chao B
> Cc: Zhang, Shenglei ; edk2-devel@lists.01.org;
> Kinney, Michael D
> Subject: Re: [edk2] [PATCH v3 00/16] Removed unused PCDs
>
> Ray, Chao,
&
name should be fine.
> -Original Message-
> From: Zeng, Star
> Sent: Saturday, September 29, 2018 5:43 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Ni, Ruiyu ; Carsey,
> Jaben
> Subject: [PATCH] ShellPkg ShellLib.h: Fix wrong parameter name
On 9/28/2018 11:08 AM, Zeng, Star wrote:
Good idea.
You prefer to introduce a new feature PCD for this with default value = TRUE?
Could we group the emulator APIs to one structure like below? And add a Version
field for potential further extension?
typedef struct {
UINTN
On 9/27/2018 3:13 PM, edk2-devel-boun...@lists.01.org wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1215
This issue is caused by commit 5267926134d17e86672b84fd57b438f05ffa68e1.
Jian J Wang (2):
Nt32Pkg/Nt32Pkg.dsc: override PCD default to avoid boot failure
On 9/26/2018 6:15 PM, Tomas Pilar (tpilar) wrote:
This fixes unused const variable compilation error with gcc 7.3.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Tomas Pilar
---
ShellPkg/Application/Shell/Shell.c | 3 ---
1 file changed, 3 deletions(-)
diff --git
On 9/27/2018 9:49 AM, Star Zeng wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1214
This patch only updates comment and function description, so has
no functionality impact.
This patch fixes comment typo 'end' to 'start' in GetStartPointer.
GetStartPointer for PEI and DXE has
On 9/26/2018 5:05 PM, Laszlo Ersek wrote:
Hi,
On 09/25/18 21:48, Laszlo Ersek wrote:
Currently, "gcc-4.8.5-28.el7_5.1.x86_64" generates the following code for
me, from the XADD inline assembly added to "X64/GccInline.c" in commit
17634d026f96:
4383 :
UINT32
EFIAPI
> @@ -507,12 +552,13 @@ BmRepairAllControllers (
> FormBrowser2,
> [Index],
> 1,
> - PcdGetPtr (PcdDriverHealthConfigureForm),
> +
On 9/25/2018 10:08 AM, Eric Dong wrote:
Current MSR definition are follow the SDM 2016-09 version. The latest SDM is
2018-05. This patch serial update the MSR related definition to follow the
latest SDM 2018-05 version. MSR related defintion are saved at
UefiCpuPkg\Include\Register\.
V3
On 9/25/2018 10:50 PM, Carsey, Jaben wrote:
I would prefer we just delete this.
Ray,
What do you think?
Not sure I sent it or not.
I also prefer to delete it. Git history can help in future if we need it
again.
___
edk2-devel mailing list
I agree to delete it! We have git history which can tell us how to re-add them
in future.:)
> -Original Message-
> From: Carsey, Jaben
> Sent: Tuesday, September 25, 2018 10:51 PM
> To: Tomas Pilar (tpilar) ; edk2-devel@lists.01.org; Ni,
> Ruiyu
> Subject: RE: [edk2
On 9/25/2018 11:13 AM, Zeng, Star wrote:
On 2018/9/25 10:47, Ni, Ruiyu wrote:
But then there will be a little inconsistent, for example OPERATION_TYPE
is only used by PciRootBridgeIo.c.
Since coding style document doesn't define clear rule for this (I also
don't like a coding style document
On 9/25/2018 10:35 AM, Zeng, Star wrote:
On 2018/9/21 19:12, Laszlo Ersek wrote:
On 09/21/18 09:25, Ruiyu Ni wrote:
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Star Zeng
---
.../Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 26
On 9/25/2018 10:14 AM, Zeng, Star wrote:
Two very small comments are added below.
On 2018/9/21 15:25, Ruiyu Ni wrote:
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Star Zeng
---
.../Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 26
On 9/21/2018 7:12 PM, Laszlo Ersek wrote:
On 09/21/18 09:25, Ruiyu Ni wrote:
Two superficial comments:
- edk2 prefers long parameter names, so I suggest replacing "R" in the
macro definition with "Resource"
- taking the parameter as a pointer is frequently considered more flexible.
#define
On 9/21/2018 7:06 PM, Laszlo Ersek wrote:
On 09/21/18 09:25, Ruiyu Ni wrote:
The interesting thing about this patch is that, if any one of the first
three branches is taken, then the final checks will automatically pass.
That's because, on the first three branches, we select the base & the
On 9/21/2018 3:41 PM, Eric Dong wrote:
-UINT32 CStateRange:3;
-UINT32 Reserved1:13;
-UINT32 Reserved2:32;
+UINT32 CStateRange:7;
+UINT32 Reserved3:9;
+UINT32 Reserved4:32;
Similarly, Reserved2 name doesn't need to change.
--
Thanks,
Ray
On 9/21/2018 3:41 PM, Eric Dong wrote:
UINT32 User:1;
-UINT32 Reserved1:2;
+///
+/// [Bit 4] PwrEvtEn.
+///
+UINT32 PwrEvtEn:1;
+///
+/// [Bit 5] FUPonPTW.
+///
+UINT32 FUPonPTW:1;
///
/// [Bit 6] FabricEn. If (CPUID.(EAX=07H,
> To: Laszlo Ersek
> Cc: Ni, Ruiyu ; edk2-devel@lists.01.org
> Subject: Re: [edk2] How do I access Prefetchable Memory region through
> EFI_PCI_IO_PROTOCOL
>
> Ray, did you get a chance to look at the code and see how Prefetchable
> Memory regions should be handled?
>
On 9/18/2018 10:57 PM, Duran, Leo wrote:
-Original Message-
From: Ni, Ruiyu [mailto:ruiyu...@intel.com]
Sent: Tuesday, September 18, 2018 3:34 AM
To: Laszlo Ersek ; Duran, Leo ;
edk2-devel@lists.01.org
Cc: Dong, Eric
Subject: Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip
On 9/18/2018 9:47 PM, Ard Biesheuvel wrote:
On 18 September 2018 at 02:05, Ni, Ruiyu wrote:
On 9/15/2018 9:28 PM, Ard Biesheuvel wrote:
Now that the EBC machine type is no longer classified as a
natively supported machine type on the architectures that can
support it via the EBC interpreter
On 9/15/2018 2:36 PM, Ming Huang wrote:
When some type raid cards is not healthy, such as Broadcom 3108/3508
raid card, board will enter endless loop in BmRepairAllControllers()
and can't show configuration formset which need to repair raid card.
DriverHealthManagerDxe is added to platform
On 9/15/2018 9:28 PM, Ard Biesheuvel wrote:
Now that the EBC machine type is no longer classified as a
natively supported machine type on the architectures that can
support it via the EBC interpreter, the EBC specific handling
in DXE core is no longer used and can be removed.
Contributed-under:
On 9/18/2018 11:29 AM, shenglei wrote:
PiDxe.h is not used PciSegmentLib.h.
So "#include " is deleted.
https://bugzilla.tianocore.org/show_bug.cgi?id=1183
Cc: Michael D Kinney
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
On 9/18/2018 12:38 AM, Laszlo Ersek wrote:
On 09/17/18 18:20, Duran, Leo wrote:
-Original Message-
From: Ni, Ruiyu
Sent: Thursday, September 13, 2018 11:44 PM
To: Duran, Leo ; Laszlo Ersek ;
edk2-devel@lists.01.org
Cc: Dong, Eric
Subject: Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Add
On 9/18/2018 9:43 AM, Eric Dong wrote:
Current MSR definition are follow the SDM 2016-09 version. The latest
SDM is 2018-05. This patch serial update the MSR related definition to
follow the latest SDM 2018-05 version. MSR related defintion are saved
at UefiCpuPkg\Include\Register\.
The changes
On 9/17/2018 5:08 PM, Star Zeng wrote:
https://bugzilla.tianocore.org/show_bug.cgi?id=967
Request to add a library function for GetAcpiTable() in order
to get ACPI table using signature as input.
After evaluation, we found there are many duplicated code to
find ACPI table by signature in
On 9/17/2018 5:08 PM, Star Zeng wrote:
https://bugzilla.tianocore.org/show_bug.cgi?id=967
Request to add a library function for GetAcpiTable() in order
to get ACPI table using signature as input.
After evaluation, we found there are many duplicated code to
find ACPI table by signature in
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Zeng, Star
> Sent: Thursday, September 13, 2018 6:27 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Younas khan
> ; Kinney, Michael D
> ; Gao, Liming ; Yao,
> Jiewen ; Ni, Ruiyu ; Bi, Dandan
>
On 9/14/2018 3:31 AM, Duran, Leo wrote:
-Original Message-
From: Ni, Ruiyu
Sent: Wednesday, September 12, 2018 9:39 PM
To: Duran, Leo ; Laszlo Ersek ;
edk2-devel@lists.01.org
Cc: Dong, Eric
Subject: RE: [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTRRs
prior to MTRR
On 9/14/2018 12:41 PM, Ni, Ruiyu wrote:
On 9/13/2018 6:26 PM, Star Zeng wrote:
https://bugzilla.tianocore.org/show_bug.cgi?id=967
Request to add a library function for GetAcpiTable() in order
to get ACPI table using signature as input.
After evaluation, we found there are many duplicated code
On 9/13/2018 6:26 PM, Star Zeng wrote:
https://bugzilla.tianocore.org/show_bug.cgi?id=967
Request to add a library function for GetAcpiTable() in order
to get ACPI table using signature as input.
After evaluation, we found there are many duplicated code to
find ACPI table by signature in
Star,
I have two comments. see below.
On 9/13/2018 6:26 PM, Star Zeng wrote:
https://bugzilla.tianocore.org/show_bug.cgi?id=967
Request to add a library function for GetAcpiTable() in order
to get ACPI table using signature as input.
After evaluation, we found there are many duplicated code to
Please ignore this one. It's an incomplete patch. Please check V3.
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of Ruiyu Ni
> Sent: Thursday, September 13, 2018 4:30 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Yao, Jiewen
> ; Gao, Liming
> Subject: [edk2]
On 9/13/2018 10:10 AM, Star Zeng wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1169
PCI spec:
They are also required to always implement function 0 in the device.
Implementing other functions is optional and may be assigned in any
order (i.e., a two-function device must respond to
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of
> Robinson, Herbie
> Sent: Friday, September 7, 2018 8:07 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH 1/1] FatPkg/EnhancedFatDxe Fix Double Cluster
> Allocation
>
> This is a fix for a
MpInitLib and CpuDxe driver.
Thanks/Ray
> -Original Message-
> From: Duran, Leo
> Sent: Thursday, September 13, 2018 2:22 AM
> To: Laszlo Ersek ; edk2-devel@lists.01.org
> Cc: Dong, Eric ; Ni, Ruiyu
> Subject: RE: [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTR
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Bi, Dandan
> Sent: Monday, September 10, 2018 3:12 PM
> To: edk2-devel@lists.01.org
> Cc: Bi, Dandan ; Ni, Ruiyu ; Zeng,
> Star
> Subject: [patch 3/3] MdeModulePkg: Avoid key notification called more
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Bi, Dandan
> Sent: Monday, September 10, 2018 3:12 PM
> To: edk2-devel@lists.01.org
> Cc: Bi, Dandan ; Ni, Ruiyu ; Ard
> Biesheuvel ; Leif Lindholm
>
> Subject: [patch 1/3] EmbeddedPkg/VirtualKeyb
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Bi, Dandan
> Sent: Monday, September 10, 2018 3:12 PM
> To: edk2-devel@lists.01.org
> Cc: Bi, Dandan ; Ni, Ruiyu ; Gao,
> Liming
> Subject: [patch 2/3] IntelFrameworkModulePkg: Avoid key notification ca
Mike,
Do you require to still use MSVC intrinsic function?
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni,
> Ruiyu
> Sent: Tuesday, September 11, 2018 10:27 AM
> To: Kinney, Michael D ; 'edk2-devel@lists.01.org'
>
>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
> Biesheuvel
> Sent: Wednesday, September 12, 2018 5:03 AM
> To: Ni, Ruiyu
> Cc: edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH 0/5] expire the use of PcdSet
On 9/11/2018 4:57 PM, Ard Biesheuvel wrote:
On 11 September 2018 at 07:16, Jian J Wang wrote:
BZ#: https://bugzilla.tianocore.org/show_bug.cgi?id=1116
Since the stack memory is allocated as EfiBootServicesData, its NX protection
can be covered by BIT4 of PcdDxeNxMemoryProtectionPolicy. To
On 9/11/2018 1:16 PM, Jian J Wang wrote:
+if ((PcdGet64 (PcdDxeNxMemoryProtectionPolicy) & BIT4) != 0
I suggest to use (1 << EfiBootServicesData) to replace BIT4.
--
Thanks,
Ray
___
edk2-devel mailing list
edk2-devel@lists.01.org
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, September 11, 2018 10:04 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Ni, Ruiyu ; Wang,
> Jian J ; Wang, Fei1
> Subject: [PATCH] MdeModulePkg XhciDxe: Set HSEE Bi
The reason I didn't remove the GCC version is because Liming told me that there
is a XCODE issue which prevents using NASM for library.
Thanks/Ray
> -Original Message-
> From: Ni, Ruiyu
> Sent: Tuesday, September 11, 2018 10:25 AM
> To: Kinney, Michael D ; edk2-
> de.
11, 2018 12:39 AM
> To: Ni, Ruiyu ; edk2-devel@lists.01.org; Kinney, Michael
> D
> Cc: Yao, Jiewen ; Gao, Liming
>
> Subject: RE: [PATCH] MdePkg/SynchronizationLib: fix
> Interlocked[De|In]crement return value
>
> Ray,
>
> Why are we removing the use of intrins
I didn’t find such instruction in SDM.
发自我的 iPhone
> 在 2018年9月10日，下午7:37，Yao, Jiewen 写道：
>
> Hi
> Can we use XSUB for decrement?
>
> Thank you
> Yao Jiewen
>
>> -Original Message-
>> From: Ni, Ruiyu
>> Sent: Monday, September 10, 2018 6:06 PM
Oops.
Laszlo,
I pushed the fix with only Dandan's R-b.
Outlook groups Dandan's and your mail in different threads.
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of Laszlo
> Ersek
> Sent: Friday, September 7, 2018 6:32 PM
> To: Ni, Ruiyu ; edk2-devel@lists.
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Fu, Siyuan
> Sent: Friday, September 7, 2018 4:48 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Carsey, Jaben
> Subject: [Patch] ShellPkg: Remove trailing white space
>
> REF: https:
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of chenc2
> Sent: Wednesday, June 13, 2018 11:45 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Kinney, Michael D
>
> Subject: [edk2] [PATCH 27/37] PcAtChipsetPkg: Removing ipf
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of shenglei
> Sent: Friday, September 7, 2018 9:52 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ruiyu
> Subject: [edk2] [PATCH] ShellPkg Shell: Remove an unus
Mike,
Do you think that maybe just raising to TPL_NOTIFY is enough for PCI BAR
probing?
Though the timer interrupt still triggers, all callbacks are suspended in
TPL_NOTIFY.
Thanks,
Ray
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Nikita
On 9/6/2018 11:27 AM, Heinrich Schuchardt wrote:
Hello Ruiyu,
currently I am struggling a bit with interpreting the UEFI spec
concerning the EFI_SIMPLE_TEXT_INPUT_PROTOCOL.
In UEFI spec 2.7. chapter 12.1.2 ConsoleIn Definition there is this
sentence:
"Only the control characters defined in
On 9/6/2018 3:47 AM, Andrew Fish wrote:
Laszlo,
gEfiMemoryTypeInformationGuid is an edk2/MdeModulePkg concept used to
give the DXE Core hints on how to reduce fragmentation in the memory
map. Typically there is code in PEI that creates a HOB and may consume a
variable written by the BDS.
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Chen, Chen A
> Sent: Wednesday, June 13, 2018 11:44 AM
> To: edk2-devel@lists.01.org
> Cc: Chen, Chen A ; Ni, Ruiyu ;
> Kinney, Michael D
> Subject: [PATCH 15/37] FatBinPkg: Removing ipf which is no lo
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Chen, Chen A
> Sent: Wednesday, June 13, 2018 11:44 AM
> To: edk2-devel@lists.01.org
> Cc: Chen, Chen A ; Ni, Ruiyu ;
> Kinney, Michael D
> Subject: [PATCH 16/37] FatPkg: Removing ipf which is no longer
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Chen, Chen A
> Sent: Wednesday, June 13, 2018 11:45 AM
> To: edk2-devel@lists.01.org
> Cc: Chen, Chen A ; Ni, Ruiyu ;
> Kinney, Michael D
> Subject: [PATCH 25/37] OptionRomPkg: Removing ipf which is
?
> -Original Message-
> From: Shia, Cinnamon [mailto:cinnamon.s...@hpe.com]
> Sent: Thursday, August 30, 2018 9:58 AM
> To: Ni, Ruiyu ; edk2-devel@lists.01.org
> Subject: RE: [edk2] [PATCH v2 00/12] Add WinHost support in EmulatorPkg
>
> Hi Ray,
>
> Does this change
I prefer S2.
Single interface is more easy for consumer to remember how to use.
Thanks/Ray
> -Original Message-
> From: Yao, Jiewen
> Sent: Monday, September 3, 2018 2:15 PM
> To: Zeng, Star ; Ni, Ruiyu ;
> Kinney, Michael D
> Cc: edk2-devel@lists.01.org; Younas kh
the more flexible
interface.
Thanks/Ray
> -Original Message-
> From: Zeng, Star
> Sent: Monday, September 3, 2018 11:26 AM
> To: Yao, Jiewen ; Ni, Ruiyu ;
> Kinney, Michael D
> Cc: edk2-devel@lists.01.org; Younas khan ;
> Gao, Liming ; Zeng, Star
> Subjec
I think LocateNextAcpiTable() is more proper to handle the multiple tables with
same signature. It will carry three parameters, one is the table header stored
in configuration table, one is the signature, another is the previous located
table. Can we return a common table header other than
I think LocateNextAcpiTable() is more proper to handle the multiple tables with
same signature. It will carry three parameters, one is the table header stored
in configuration table, one is the signature, another is the previous located
table. Can we return a common table header other than
ednesday, August 29, 2018 9:58 AM
> To: Ni, Ruiyu ; edk2-devel@lists.01.org
> Subject: RE: [edk2] [PATCH 00/10] Quality improvement for EmulatorPkg Win
> Host
>
> Hi Ray,
>
> One general-level comment, I saw some file was originally with Unix line
> ending format
On 8/29/2018 9:54 AM, Wu, Hao A wrote:
-Original Message-
From: Ni, Ruiyu
Sent: Monday, August 27, 2018 3:53 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A; Andrew Fish
Subject: [PATCH 07/10] EmulatorPkg/AutoScanPei: Report the correct CPU
address size
REF: https://bugzilla.tianocore.org
On 8/28/2018 10:55 PM, Carsey, Jaben wrote:
looks good to me. Ray?
Reviewed-by: Jaben Carsey
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu
Siyuan
Sent: Monday, August 27, 2018 6:53 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Ye, Ting
On 8/28/2018 11:42 AM, shenglei wrote:
The PCDs below are unused, so they have been removed from inf.
gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize
gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength
Cc: Jaben Carsey
Cc: Ruiyu Ni
Cc: Laszlo Ersek
Contributed-under: TianoCore
On 8/28/2018 11:42 AM, shenglei wrote:
The PCDs below are unused, so they have been removed from inf.
gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize in DpApp.inf
gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize in
DpDynamicCommand.inf
Cc: Jaben Carsey
Cc: Ruiyu Ni
Cc: Laszlo Ersek
On 8/28/2018 11:42 AM, shenglei wrote:
The PCDs below are unused, so they have been removed from inf.
gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize
gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength
Cc: Jaben Carsey
Cc: Ruiyu Ni
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> shenglei
> Sent: Wednesday, August 8, 2018 11:09 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [PATCH 4/6] IntelFrameworkModulePkg
Not tested x64 yet. But I plan to enable it in the next step.
> 在 2018年8月23日，下午11:24，Kinney, Michael D 写道：
>
> Hi Ray,
>
> Does this version support both 32-bit and 64-bit?
>
> Thanks,
>
> Mike
>
>> -Original Message-
>> From: edk2-devel [mailto:edk2-devel-
>> boun...@lists.01.org]
Hello,
Please ignore this patch sets.
I used the wrong mail address.
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of Ruiyu Ni
> Sent: Thursday, August 23, 2018 5:52 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH 00/12] Add WinHost support in EmulatorPkg
>
>
Younas,
Why are you still working on CMOS in now UEFI world?
Detailed answer is in below.
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of
> mohammadyounaskha...@dell.com
> Sent: Thursday, August 16, 2018 12:44 PM
> To: edk2-devel@lists.01.org
> Subject: Re: [edk2]
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Zhang, Shenglei
> Sent: Thursday, August 16, 2018 1:32 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ruiyu
> Subject: [PATCH 4/5] ShellPkg: Remove unused PCDs
>
> The PCDs below are u
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of Eric Dong
> Sent: Wednesday, August 15, 2018 10:15 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Laszlo Ersek
> Subject: [edk2] [Patch v4 1/5] UefiCpuPkg/PiSmmCpuDxeSmm: U
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of Eric Dong
> Sent: Wednesday, August 15, 2018 10:15 AM
> To: edk2-devel@lists.01.org
> Cc: Laszlo Ersek ; Ni, Ruiyu
> Subject: [edk2] [Patch v4 3/5] UefiCpuPkg/CpuS3DataDxe: Ch
Ignore my previous mail.
You could use AllocatePages() instead of directly calling gBS->AllocatePages().
Then rename the AllocateBootServiceMemory() to AllocateZeroPages() to better
reflect the function behavior.
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of
Thanks/Ray
> -Original Message-
> From: Laszlo Ersek
> Sent: Friday, August 10, 2018 11:40 PM
> To: Dong, Eric ; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu
> Subject: Re: [Patch v3 1/5] UefiCpuPkg/PiSmmCpuDxeSmm: Use GDT/IDT
> saved in Smram.
>
> On 08/1
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Dong, Eric
> Sent: Friday, August 10, 2018 12:19 PM
> To: edk2-devel@lists.01.org
> Cc: Marvin Häuser ; Fan Jeff
> ; Laszlo Ersek ; Ni, Ruiyu
>
> Subject: [Patch v3 2/5] UefiCpuPkg/AcpiCpuData.h: Re
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Dong, Eric
> Sent: Friday, August 10, 2018 12:19 PM
> To: edk2-devel@lists.01.org
> Cc: Laszlo Ersek ; Ni, Ruiyu
> Subject: [Patch v3 4/5] UefiCpuPkg/CpuS3DataDxe: Remove below 4G
> lim
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Dong, Eric
> Sent: Friday, August 10, 2018 12:19 PM
> To: edk2-devel@lists.01.org
> Cc: Marvin Häuser ; Fan Jeff
> ; Laszlo Ersek ; Ni, Ruiyu
>
> Subject: [Patch v3 5/5] UefiCpuPkg/Registe
ong, Eric
> Sent: Monday, August 13, 2018 9:51 AM
> To: Laszlo Ersek ; edk2-devel@lists.01.org
> Cc: Marvin Häuser ; Fan Jeff
> ; Ni, Ruiyu
> Subject: RE: [Patch v3 3/5] UefiCpuPkg/CpuS3DataDxe: Change Memory
> Type and address limitation.
>
> Hi Laszlo,
>
> I check
> (3) The "UefiCpuPkg/Include/AcpiCpuData.h" header states that
> ACPI_CPU_DATA (the structure itself) "must be allocated below 4GB from
> memory of type EfiACPIMemoryNVS".
>
> If we have determined that this is no longer necessary, then:
> - we should first update the documentation in
101 - 200 of 1080 matches
Mail list logo
