Re: [edk2] [Patch v2 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: Combine implementation.

> -Original Message- > From: Laszlo Ersek > Sent: Thursday, August 9, 2018 5:29 AM > To: Dong, Eric ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: Re: [edk2] [Patch v2 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: > Combine implementation. > > On 08/08/18 09:

Re: [edk2] [PATCH 04/26] MdeModulePkg EhciDxe: Remove redundant functions

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 4:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star > Subject: [edk2] [PATCH 04/26] MdeModulePkg EhciDxe: Remove redundant > functions > >

Re: [edk2] [PATCH 14/26] MdeModulePkg UsbBusDxe: Remove redundant functions

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 4:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star > Subject: [edk2] [PATCH 14/26] MdeModulePkg UsbBusDxe: Remove > redundant functions >

Re: [edk2] [PATCH 21/26] MdeModulePkg TerminalDxe: Remove a redundant function

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 4:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star > Subject: [edk2] [PATCH 21/26] MdeModulePkg TerminalDxe: Remove a > redundant function

Re: [edk2] [PATCH 18/26] MdeModulePkg Ps2KeyboardDxe: Remove a redundant function

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 4:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star > Subject: [edk2] [PATCH 18/26] MdeModulePkg Ps2KeyboardDxe: Remove a > redundant

Re: [edk2] [PATCH 10/26] MdeModulePkg XhciPei: Remove redundant functions

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 4:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star > Subject: [edk2] [PATCH 10/26] MdeModulePkg XhciPei: Remove redundant > functions > >

Re: [edk2] [PATCH 15/26] MdeModulePkg UsbBusPei: Remove redundant functions

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 4:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star > Subject: [edk2] [PATCH 15/26] MdeModulePkg UsbBusPei: Remove > redundant functions >

Re: [edk2] [PATCH 17/26] MdeModulePkg PiSmmCore: Remove redundant functions

+ Wang Jian. Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 4:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star > Subject: [edk2] [PATCH 17/26] MdeModulePkg PiSmmCore: Remove > redundant functions > > The

Re: [edk2] [PATCH 08/26] MdeModulePkg UhciPei: Remove redundant functions

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 4:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star > Subject: [edk2] [PATCH 08/26] MdeModulePkg UhciPei: Remove redundant > functions > >

Re: [edk2] [PATCH 06/26] MdeModulePkg PciBusDxe: Remove redundant functions

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 4:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star > Subject: [edk2] [PATCH 06/26] MdeModulePkg PciBusDxe: Remove > redundant functions >

Re: [edk2] [PATCH 16/26] MdeModulePkg Core/Dxe: Remove redundant functions

Copying Wang Jian. Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 4:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star > Subject: [edk2] [PATCH 16/26] MdeModulePkg Core/Dxe: Remove >

Re: [edk2] [PATCH 09/26] MdeModulePkg XhciDxe: Remove redundant functions

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 4:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star > Subject: [edk2] [PATCH 09/26] MdeModulePkg XhciDxe: Remove redundant > functions > >

Re: [edk2] [PATCH 3/6] IntelFrameworkModulePkg IdeBusDxe: Remove redundant functions

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 11:09 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH 3/6] IntelFrameworkModulePkg IdeBusDxe: Remove > redundant functions > >

Re: [edk2] [PATCH 2/6] IntelFrameworkModulePkg Ps2KeyboardDxe: Remove a redundant function

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 11:09 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH 2/6] IntelFrameworkModulePkg Ps2KeyboardDxe: > Remove a redundant function

Re: [edk2] [PATCH 1/6] IntelFrameworkModulePkg IsaIoDxe: Remove a redundant protocol

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 11:09 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH 1/6] IntelFrameworkModulePkg IsaIoDxe: Remove a > redundant protocol > >

Re: [edk2] [PATCH 5/6] IntelFrameworkModulePkg LegacyBiosDxe: Remove redundant LibraryClasses

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 11:09 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH 5/6] IntelFrameworkModulePkg LegacyBiosDxe: > Remove redundant

Re: [edk2] [PATCH 6/6] IntelFrameworkModulePkg BdsDxe: Remove redundant functions

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 11:09 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH 6/6] IntelFrameworkModulePkg BdsDxe: Remove > redundant functions > > The

Re: [edk2] [PATCH] ShellPkg/set: Fix EfiShellSetEnv to use case sensitive compare

It's a typo. V2 patch will correct this. Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of > jim.dai...@dell.com > Sent: Wednesday, August 8, 2018 2:27 AM > To: Ni, Ruiyu > Cc: Carsey, Jaben ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PAT

Re: [edk2] [PATCH v2 7/7] ShellPkg/UefiShellLib: rebase ShellOpenFileByDevicePath() to UefiLib API

On 8/3/2018 8:15 PM, Laszlo Ersek wrote: Replace the "old shell method" implementation in ShellOpenFileByDevicePath() with EfiOpenFileByDevicePath() from UefiLib, correcting the following issues: - code duplication between this module and other modules, - local variable name

Re: [edk2] [PATCH v2 6/7] ShellPkg/UefiShellLib: drop DeviceHandle param of ShellOpenFileByDevicePath()

On 8/3/2018 8:15 PM, Laszlo Ersek wrote: The ShellOpenFileByDevicePath() API promises to set the DeviceHandle output parameter to the handle of the filesystem identified by the FilePath input parameter. However, this doesn't actually happen when the UEFI Shell 2.0 method is used (which is

Re: [edk2] [PATCH v2 1/7] MdePkg/UefiLib: introduce EfiOpenFileByDevicePath()

On 8/3/2018 8:15 PM, Laszlo Ersek wrote: The EfiOpenFileByDevicePath() function centralizes functionality from - MdeModulePkg/Universal/Disk/RamDiskDxe - NetworkPkg/TlsAuthConfigDxe - SecurityPkg/VariableAuthenticated/SecureBootConfigDxe - ShellPkg/Library/UefiShellLib unifying the

Re: [edk2] [PATCH 1/6] MdePkg/UefiLib: introduce EfiOpenFileByDevicePath()

On 7/27/2018 8:06 PM, Laszlo Ersek wrote: On 07/27/18 11:28, Ni, Ruiyu wrote: On 7/19/2018 4:50 AM, Laszlo Ersek wrote: +  // +  // Traverse the device path nodes relative to the filesystem. +  // +  while (!IsDevicePathEnd (*FilePath)) { +    // +    // Keep local variables that relate

Re: [edk2] [PATCH 1/6] MdePkg/UefiLib: introduce EfiOpenFileByDevicePath()

On 7/19/2018 4:50 AM, Laszlo Ersek wrote: + // + // Traverse the device path nodes relative to the filesystem. + // + while (!IsDevicePathEnd (*FilePath)) { +// +// Keep local variables that relate to the current device path node tightly +// scoped. +// +

Re: [edk2] [Patch] IntelFrameworkModulePkg IsaSerialDxe: Update algorithm to calculate Divisor

On 7/27/2018 1:53 PM, Liming Gao wrote: To align the way in MdeModulePkg SerialPortLib and PciSioSerialDxe driver, Divisor is added by one when the reminder is more than half (16 * BaudRate). Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Ruiyu Ni ---

Re: [edk2] [PATCH 1/6] MdePkg/UefiLib: introduce EfiOpenFileByDevicePath()

On 7/19/2018 4:50 AM, Laszlo Ersek wrote: +// +// Open the next pathname fragment with EFI_FILE_MODE_CREATE masked out and +// with Attributes set to 0. +// +Status = LastFile->Open ( + LastFile, + , +

Re: [edk2] [Patch v3 3/3] UefiCpuPkg/MpInitLib: Not use disabled AP when call StartAllAPs.

> +if (GetApState (CpuData) == CpuStateDisabled && !WakeUpDisabledAps) { > + continue; > +} > + > CpuData->ApFunction = (UINTN) Procedure; > CpuData->ApFunctionArgument = (UINTN) ProcedureArgument; > SetApState (CpuData, CpuStateReady);

Re: [edk2] [Patch v3 3/3] UefiCpuPkg/MpInitLib: Not use disabled AP when call StartAllAPs.

With that, Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, July 26, 2018 4:36 PM > To: Dong, Eric ; edk2-devel@lists.01.org > Cc: Laszlo Ersek > Subject: RE: [Patch v3 3/3] UefiCpuPkg/MpInitLib: Not use disabled AP when &g

Re: [edk2] [Patch v3 2/3] UefiCpuPkg/MpInitLib: Remove StartCount and volatile definition.

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of Eric Dong > Sent: Wednesday, July 25, 2018 3:50 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Laszlo Ersek > Subject: [edk2] [Patch v3 2/3] UefiCpuPkg/MpInitLib: Remove StartCo

Re: [edk2] [Patch v3 1/3] UefiCpuPkg/MpInitLib: Remove redundant CpuStateFinished State.

Eric, Please also include the state machine in comments for ENUM CPU_STATE definition. Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Dong, Eric > Sent: Wednesday, July 25, 2018 7:15 PM > To: Laszlo Ersek ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu >

Re: [edk2] [Patch v3 3/3] UefiCpuPkg/MpInitLib: Load uCode once for each core.

Thanks/Ray > -Original Message- > From: Dong, Eric > Sent: Wednesday, July 18, 2018 8:12 AM > To: Laszlo Ersek ; Ni, Ruiyu > Cc: edk2-devel@lists.01.org > Subject: RE: [edk2] [Patch v3 3/3] UefiCpuPkg/MpInitLib: Load uCode once > for each core.

Re: [edk2] [Patch v2] UefiCpuPkg/MpInitLib: Optimize get processor number performance.

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Dong, Eric > Sent: Wednesday, July 18, 2018 1:19 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Jeff Fan ; > Laszlo Ersek > Subject: [Patch v2] UefiCpuPkg/MpInitLib: Optimize get processor

Re: [edk2] UefiCpuPkg/MpInitLib: Fix S3 resume hang issue.

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Dong, Eric > Sent: Wednesday, July 18, 2018 1:10 PM > To: edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Ni, Ruiyu > Subject: UefiCpuPkg/MpInitLib: Fix S3 resume hang issue. > > When resume from S3 an

Re: [edk2] [PATCH 1/1] MdeModulePkg/PciBusDxe: Fix small memory leak in FreePciDevice

On 7/3/2018 11:32 PM, Thomas Palmer wrote: When cleaning the PciIoDevice, also free the BusNumberRange Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas Palmer --- MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.c | 5 + 1 file changed, 5 insertions(+) diff

Re: [edk2] [PATCH v1] ShellPkg: add UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc

On 7/17/2018 6:59 PM, AlexeiFedorov wrote: This patch adds UefiShellAcpiViewCommandLib INF file into [Components] section of ShellPkg.dsc so this library can be built in ShellPkg level build. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Alexei Fedorov --- All the

Re: [edk2] [Patch v3 3/3] UefiCpuPkg/MpInitLib: Load uCode once for each core.

On 7/16/2018 11:08 AM, Eric Dong wrote: GetProcessorLocationByApicId (GetInitialApicId (), NULL, NULL, ); + if (ThreadId != 0) { +// +// Skip loading microcode if it is not the first thread in one core. +// +return; + } + Eric, Is it possible that Thread#0 is disabled while

Re: [edk2] [Patch v3 1/3] UefiCpuPkg/MpInitLib: Relocate uCode to memory to save time.

On 7/16/2018 11:08 AM, Eric Dong wrote: Read uCode from memory has better performance than from flash. But it needs extra effort to let BSP copy uCode from flash to memory. Also BSP already enable cache in SEC phase, so it use less time to relocate uCode from flash to memory. After verification,

Re: [edk2] [Patch v3 2/3] UefiCpuPkg/MpInitLib: Use BSP uCode for APs if possible.

On 7/16/2018 11:08 AM, Eric Dong wrote: + + if (IsBspCallIn && (LatestRevision != 0)) { +CpuMpData->ProcessorSignature = Eax.Uint32; +CpuMpData->ProcessorFlags = ProcessorFlags; +CpuMpData->MicrocodeDataAddress = (UINTN) MicrocodeData; +CpuMpData->MicrocodeRevision =

Re: [edk2] [PATCH v4 6/9] ArmPkg/PlatformBDS: Implement PlatformBootManagerUnableToBoot

Can someone give a r-b for this patch? Is Ack-by enough for a check-in? Thanks/Ray > -Original Message- > From: Ard Biesheuvel > Sent: Wednesday, July 11, 2018 10:21 PM > To: Ni, Ruiyu > Cc: edk2-devel@lists.01.org; Leif Lindholm > Subject: Re: [PATCH v4 6/9]

Re: [edk2] [PATCH v4 0/9] Add platform hook for ultimate boot failure.

On 7/4/2018 9:50 AM, Ruiyu Ni wrote: v4: 1. adds missing PlatformBootManagerLib instances modification for platform ArmPkg and ArmVirtPkg. 2. Remove single quote in #1/9 3. Wrap the long comments in #3/9 Ruiyu Ni (9): MdeModulePkg/PlatformBootManager: Add

Re: [edk2] [PATCH v3 0/7] Add platform hook for ultimate boot failure.

On 7/4/2018 9:08 AM, Ni, Ruiyu wrote: -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, July 3, 2018 11:53 PM To: Ni, Ruiyu Cc: edk2-devel@lists.01.org; Leif Lindholm (Linaro address) ; Ard Biesheuvel ; Wei, David ; Guo, Mang Subject: Re: [edk2] [PATCH

Re: [edk2] [PATCH v3 3/7] OvmfPkg/PlatformBds: Implement PlatformBootManagerUnableToBoot

On 7/3/2018 11:37 PM, Laszlo Ersek wrote: On 07/03/18 08:37, Ruiyu Ni wrote: Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Anthony Perard Cc: Julien Grall ---

Re: [edk2] [PATCH v3 0/7] Add platform hook for ultimate boot failure.

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, July 3, 2018 11:53 PM > To: Ni, Ruiyu > Cc: edk2-devel@lists.01.org; Leif Lindholm (Linaro address) > ; Ard Biesheuvel ; Wei, > David ; Guo, Mang > Subject: Re: [edk2] [PA

Re: [edk2] [PATCH 2/2] MdeModulePkg/BmpSupportLib: Check PixelHeight/PixelWidth against 0

UINT32 *BmpImageSize PixelHeight and PixelWidth are parameters. Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Tuesday, July 3, 2018 10:03 AM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Kinney, Michael D Subject: Re: [PATCH 2/2] MdeModulePkg/BmpSupportLib

Re: [edk2] [PATCH 2/2] MdeModulePkg/BmpSupportLib: Check PixelHeight/PixelWidth against 0

On 7/2/2018 6:05 PM, Zeng, Star wrote: Please add reference to bugzilla link into the commit log. https://bugzilla.tianocore.org/show_bug.cgi?id=944 OK Another, is there any reason to only add debug message for " if ((BmpHeader->PixelHeight == 0) || (BmpHeader->PixelWidth == 0)) { ", but

Re: [edk2] [PATCH v3] UefiCpuPkg/MpInitLib: Avoid calling PEI services from AP

On 6/30/2018 3:25 AM, Laszlo Ersek wrote: (1) I think that, right after the above line, you are missing: BufferSize = ALIGN_VALUE (BufferSize, 8); Yes. That's a bug in the patch. I will fix it in V4. It is not noticed in practice because AllocatePages (EFI_SIZE_TO_PAGES

Re: [edk2] Question about memory map entries

Yes. Check the PCD PcdShellMaxHistoryCommandCount (0x20) which sets the maximum command history. The memmap output should be stable after you run more than 0x20 commands. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yao, > Jiewen > Sent:

Re: [edk2] [PATCH v2 1/2] MdeModulePkg/UefiBootManagerLib: new APIs for ultimate boot failure

, June 29, 2018 8:41 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Michael Turner > Subject: Re: [edk2] [PATCH v2 1/2] MdeModulePkg/UefiBootManagerLib: new > APIs for ultimate boot failure > > Hi Ray, > > thanks for this patch; I only have a request for updating a comment:

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: AP uses memory preceding IDT to store CpuMpData

On 6/27/2018 8:00 PM, Laszlo Ersek wrote: Roughly, I figured that we could set the pre-IDT pointer on the BSP, *before* starting up the APs, to a mapping table. The mapping table would consist of two columns, the first containing the APIC ID (of each CPU), the second containing AP-specific

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: handle ultimate boot failure

On 6/28/2018 11:04 PM, Laszlo Ersek wrote: Personally I'd be very happy with the current version of the patch as well, but I agree Sunny's request makes sense. How about this, for BdsDxe: diff --git a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c index

Re: [edk2] [PATCH v2] UefiCpuPkg/MpInitLib: AP uses memory preceding IDT to store CpuMpData

Please ignore this incorrect patch. -- Thanks, Ray ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: AP uses memory preceding IDT to store CpuMpData

On 6/27/2018 2:57 AM, Laszlo Ersek wrote: Second, even assuming that PushCpuMpData() and PopCpuMpData() are atomic, the order in which APs complete the AP procedure is not deterministic, and it need not be the exact reverse of the entry order. We may have the following order, for example: - AP

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: AP uses memory preceding IDT to store CpuMpData

On 6/27/2018 1:20 AM, Andrew Fish wrote: On Jun 26, 2018, at 10:06 AM, Laszlo Ersek > wrote: (replying again to the patch email directly, for keeping context -- adding some people to the CC list. Comments below.) On 06/25/18 04:54, Ruiyu Ni wrote: Today's

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: AP uses memory preceding IDT to store CpuMpData

On 6/27/2018 1:06 AM, Laszlo Ersek wrote: (replying again to the patch email directly, for keeping context -- adding some people to the CC list. Comments below.) On 06/25/18 04:54, Ruiyu Ni wrote: Today's MpInitLib PEI implementation directly calls PeiServices->GetHobList() from AP which may

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: AP uses memory preceding IDT to store CpuMpData

On 6/26/2018 1:01 AM, Laszlo Ersek wrote: On 06/25/18 18:01, Laszlo Ersek wrote: Hello Ray, On 06/25/18 04:54, Ruiyu Ni wrote: Today's MpInitLib PEI implementation directly calls PeiServices->GetHobList() from AP which may cause racing issue. This patch fixes this issue by storing the

Re: [edk2] [PATCH 1/2] MdeModulePkg UsbBusDxe: Fix wrong buffer length used to read hub desc

On 6/25/2018 6:38 PM, Star Zeng wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=973 HUB descriptor has variable length. But the code uses stack (HubDesc in UsbHubInit) with fixed length sizeof(EFI_USB_HUB_DESCRIPTOR) to hold HUB descriptor data. It uses hard code length value (32

Re: [edk2] [PATCH v2 1/4] MdeModulePkg: Add definitions for EDKII PEI NVME host controller PPI

On 6/22/2018 10:38 AM, Hao Wu wrote: Introduces the below PPI: struct EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI { EDKII_NVM_EXPRESS_HC_GET_MMIO_BAR GetNvmeHcMmioBar; EDKII_NVM_EXPRESS_HC_GET_DEVICE_PATHGetNvmeHcDevicePath; }; The GetNvmeHcMmioBar service will provide the caller

Re: [edk2] [Patch] MdeModulePkg BdsDxe: Correct VariableLockProtocol usage to match code logic

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Gao, Liming > Sent: Monday, June 18, 2018 10:58 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Zeng, Star > Subject: [Patch] MdeModulePkg BdsDxe: Correct VariableLockProtocol usage > to match cod

Re: [edk2] [PATCH 3/4] MdeModulePkg: Add GUID for recovery capsule on NVM Express devices

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Friday, June 15, 2018 3:04 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Zeng, Star ; > Dong, Eric ; Ni, Ruiyu ; Yao, > Jiewen > Subject: [PATCH 3/4] MdeModulePkg: Add G

Re: [edk2] [PATCH 4/4] FatPkg/FatPei: Add the recognition of recovery capsule on NVME device

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Friday, June 15, 2018 3:04 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Ni, Ruiyu ; Yao, > Jiewen > Subject: [PATCH 4/4] FatPkg/FatPei: Add the recognition of recovery cap

Re: [edk2] [PATCH 2/4] MdeModulePkg/NvmExpressPei: Add the NVME device PEI BlockIo support

2 minor comments. Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Friday, June 15, 2018 3:04 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Zeng, Star ; > Dong, Eric ; Ni, Ruiyu ; Yao, > Jiewen > Subject: [PATCH 2/4] MdeModulePkg/NvmExpressPei: A

Re: [edk2] Is the PEI Core MP Safe? UefiCpuPkg seems to think so calling GetFirstGuidHob on the APs?

doesn't follow RegisterForShadow() to load the PEIM in memory. Using IDT entry as the storage of global variable is a good idea. We will evaluate. Thanks/Ray > -Original Message- > From: af...@apple.com > Sent: Thursday, June 21, 2018 11:25 AM > To: Ni, Ruiyu > Cc: edk2-d

Re: [edk2] [PATCH v2] MdePkg/UefiFileHandleLib: Fix the Root directory determination.

Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of Marvin > Häuser > Sent: Thursday, May 17, 2018 8:42 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > > Subject: [edk2] [PATCH v2] MdePkg/UefiFileHandleLib: Fix the Root directory > determination.

Re: [edk2] [PATCH] UefiCpuPkg/LocalApicLib: Exclude second SendIpi sequence on AMD processors.

Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of Paolo > Bonzini > Sent: Thursday, June 14, 2018 4:52 AM > To: Laszlo Ersek ; Leo Duran ; > edk2-devel@lists.01.org > Cc: Justen, Jordan L ; Brijesh Singh > ; Jeff Fan ; Gao, Liming > > Subject: Re: [edk2] [PATCH]

Re: [edk2] [PATCH v2] ShellPkg/UefiShellLevel2CommandsLib: Support unspecified local Timezone.

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Marvin Häuser > Sent: Thursday, June 14, 2018 4:30 AM > To: edk2-devel@lists.01.org; Ni, Ruiyu > Cc: Carsey, Jaben > Subject: RE: [PATCH v2] ShellPkg/UefiShellLevel2CommandsLib: Support > unspe

Re: [edk2] [patch V2 2/3] ShellPkg/Dp: Initialize summary date when run DP

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Bi, Dandan > Sent: Monday, June 11, 2018 4:32 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Ni, Ruiyu ; > Carsey, Jaben > Subject: [patch V2 2/3] ShellPkg/Dp: Initialize summary date when run DP &

Re: [edk2] [patch 1/3] ShellPkg/Dp: make sure memory is freed before exit

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Bi, Dandan > Sent: Tuesday, June 5, 2018 4:33 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Ni, Ruiyu ; > Carsey, Jaben > Subject: [patch 1/3] ShellPkg/Dp: make sure memory is freed before exit &g

Re: [edk2] [patch V2 0/2] ShellPkg/UefiShellAcpiViewCommandLib: Fix ECC issues

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Bi, Dandan > Sent: Wednesday, June 6, 2018 8:50 PM > To: edk2-devel@lists.01.org > Cc: alexei.fedo...@arm.com; Sami Mujawar ; > Evan Lloyd ; Carsey, Jaben > ; Ni, Ruiyu > Subject:

Re: [edk2] [PATCH v2 3/4] MdeModulePkg/AtaAtapiPassThru: enable/disable PUIS per policy

I see your point. I prefer to use AhciPuisEnable(). The function name describe the purpose. The function body explains the details. Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Tuesday, June 5, 2018 1:17 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > C

Re: [edk2] [PATCH v2 3/4] MdeModulePkg/AtaAtapiPassThru: enable/disable PUIS per policy

The Set Feature cmd is used to enable/disable PUIS. Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Tuesday, June 5, 2018 11:35 AM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Chiu, Chasel ; Zeng, Star > Subject: RE: [PATCH v2 3/4] MdeModulePkg/AtaAtapi

Re: [edk2] [PATCH v2 2/4] MdeModulePkg: Add AtaAtapiPolicy protocol definition

, Star > Sent: Tuesday, June 5, 2018 10:30 AM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: RE: [PATCH v2 2/4] MdeModulePkg: Add AtaAtapiPolicy protocol > definition > > Ray, > > I could not find code to compare > DeviceSleepEnable/Aggr

Re: [edk2] [PATCH 2/4] MdeModulePkg: Add AtaAtapiPolicy protocol definition

Ok. I will update the comments. Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Monday, June 4, 2018 2:30 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: RE: [PATCH 2/4] MdeModulePkg: Add AtaAtapiPolicy protocol > defini

Re: [edk2] [PATCH 4/4] MdeModulePkg/Ata/AtaAtapiPassThru: Enable/disable DEVSLP per policy

Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Monday, June 4, 2018 2:45 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Chiu, Chasel > Subject: RE: [PATCH 4/4] MdeModulePkg/Ata/AtaAtapiPassThru: > Enable/disable DEVSLP per policy > &

Re: [edk2] [PATCH 4/4] MdeModulePkg/Ata/AtaAtapiPassThru: Enable/disable DEVSLP per policy

Hao, Thanks for the comments. Reply in below. Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Monday, June 4, 2018 2:21 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Chiu, Chasel > Subject: RE: [PATCH 4/4] MdeModulePkg/Ata/AtaAtapiPassThru: > Enab

Re: [edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update usage info for BootLogo protocol

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Gao, Liming > Sent: Tuesday, May 29, 2018 1:54 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [Patch] MdeModulePkg BootManagerMenuApp: Update usage info > for BootLogo protocol &

Re: [edk2] [PATCH 1/3] MdeModulePkg/DxeResetSystemLib: Avoid depending on UefiRuntimeLib

will make a V2 patch to remove runtime driver support. Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Monday, June 4, 2018 10:37 AM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Gao, Liming ; Zeng, Star > Subject: RE: [PATCH 1/3] MdeModulePkg/DxeResetSystemLib:

Re: [edk2] [PATCH 1/3] MdeModulePkg/DxeResetSystemLib: Avoid depending on UefiRuntimeLib

Haha, you are correct! I forgot to update the commit messages! My bad!! I will post a new version to address all concerns, including Star's. Thanks/Ray > -Original Message- > From: Laszlo Ersek > Sent: Saturday, June 2, 2018 3:06 AM > To: Ni, Ruiyu ; edk2-devel@lists.01.o

Re: [edk2] How to Interpret ReadKeyStrokeEX Data

Thanks/Ray > -Original Message- > From: jim.dai...@dell.com > Sent: Saturday, June 2, 2018 2:27 AM > To: Ni, Ruiyu > Cc: Carsey, Jaben ; fel...@mail.ru; edk2- > de...@lists.01.org > Subject: How to Interpret ReadKeyStrokeEX Data > > (Subject changed) >

Re: [edk2] UDK debugger Tool for Qemu under Linux

Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of Liu Yu > Sent: Thursday, May 31, 2018 9:15 AM > To: edk2-devel@lists.01.org > Subject: [edk2] UDK debugger Tool for Qemu under Linux > > Sorry to send a global mail > > Did anyone ever debug uefi program in Qemu with UDK

Re: [edk2] [PATCH] ShellPkg/[hex]edit: use SimpleTextInEx to read console

SHIFT state is not masked off. [Sorry I thought I sent the mail out days ago] > -Original Message- > From: jim.dai...@dell.com [mailto:jim.dai...@dell.com] > Sent: Wednesday, May 23, 2018 3:01 AM > To: Ni, Ruiyu > Cc: Carsey, Jaben ; fel...@mail.ru; edk2- > de..

Re: [edk2] PciSegmentInfoLib instances

understanding, even a platform which has single segment can be implemented as a multiple segments platform. Thanks/Ray > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Laszlo > Ersek > Sent: Wednesday, May 23, 2018 3:38 PM >

Re: [edk2] [PATCH] PcAtChipsetPkg/PcRtc: Add two new PCD for RTC Index/Target registers

Star, Thanks for the comments. I will take #1. For #2, I prefer to remove the macro Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Friday, May 25, 2018 5:06 PM > To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@

Re: [edk2] [PATCH] MdeModulePkg/Library/BaseSerialPortLib16550: Ensure FIFO Polled Mode

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Leo > Duran > Sent: Friday, May 25, 2018 3:08 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric <eric.d.

Re: [edk2] [PATCH] MdePkg/BaseLib: Add GenerateGuid() to BaseLib

Good points! I will hold the patch. Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Wednesday, May 23, 2018 2:11 PM > To: Ni, Ruiyu <ruiyu...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; edk2- > de...@lists.01.org > Cc: Kinney, Michael D <

Re: [edk2] [PATCH] MdePkg/BaseLib: Add GenerateGuid() to BaseLib

n table. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> > Cc: Liming Gao <liming@intel.com> > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Qin Long <qin.l...@intel.com> >

Re: [edk2] [Patch v2 0/5] Remove X86 ASM and S files

""SourceLevelDebugPkg: Remove X86 ASM and S files" looks good. Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Liming > Gao > Sent: Friday, May 18, 201

Re: [edk2] [PATCH] MdePkg/UefiFileHandleLib: Fix potential NULL dereference.

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Marvin > Häuser > Sent: Sunday, May 6, 2018 4:22 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael

Re: [edk2] [PATCH] ShellPkg/UefiShellLevel2CommandsLib: Support unspecified local Timezone.

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Marvin > Häuser > Sent: Sunday, May 6, 2018 4:23 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.ca

Re: [edk2] [PATCH] ShellPkg/UefiShellCommandLib: Do not error-exit when PlatformLang is missing.

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray > -Original Message- > From: Marvin Häuser <marvin.haeu...@outlook.com> > Sent: Sunday, May 6, 2018 8:07 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ruiyu <r

Re: [edk2] Proposition of a BmEnumerateBootOptions() hook.

Thanks/Ray > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Marvin > Häuser > Sent: Wednesday, May 16, 2018 1:15 AM > To: Laszlo Ersek <ler...@redhat.com>; edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com&

Re: [edk2] [patch v2] BaseTools/VfrCompile: Avoid using uninitialized pointer

Dandan, Can you describe the build failure met by Gary Lin in final commit message? The current commit message is not very clear about which issue it may fix. Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of Gary Lin > Sent: Wednesday, May

Re: [edk2] [PATCH 1/2] MdeModulePkg: Add PlatformAcpiLib LibraryClass.

. Otherwise, people new to this project would be lost in many interfaces. Thanks/Ray > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Marvin > H?user > Sent: Wednesday, May 9, 2018 11:38 PM > To: edk2-devel@lists.01.org > Cc: Ni, R

Re: [edk2] [PATCH v2] MdeModulePkg/Bus: Enable to use device address when programming BARs

y, May 10, 2018 4:25 AM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com>; Vladimir Olovyannikov <vladimir.olovyanni...@broadcom.com> Subject: [edk2] [PATCH v2] MdeModulePkg/Bus: Enable to use device address when programming BARs Some SoCs require to use device

Re: [edk2] [PATCH] MdeModulePkg/ConPlatform: Support short-form USB device path

Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Thursday, April 26, 2018 3:05 PM > To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org > Cc: Wu, Hao A <hao.a...@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; Zeng,

Re: [edk2] [PATCH] MdeModulePkg/PciHostBridge: Count the (mm)io overhead when polling

If Multiplicand * Multiplier + Remainder = MAX_UINT64, Even Multiplicand = MAX_UINT64 / Multiplier, Overflow still happens. So ">=" is used here. Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Wednesday, May 2, 2018 11:44 AM > To: Ni, Ruiyu <rui

Re: [edk2] [PATCH] MdeModulePkg/ConPlatform: Support short-form USB device path

> -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Laszlo > Ersek > Sent: Wednesday, April 25, 2018 10:16 PM > To: Ni, Ruiyu <ruiyu...@intel.com> > Cc: Wu, Hao A <hao.a...@intel.com>; Kinney, Michael D > <michae

Re: [edk2] [PATCH] MdeModulePkg/Terminal: Check status of OpenProtocol in BindingStart

r > Sent: Friday, April 13, 2018 1:15 PM > To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org > Cc: Shi, Steven <steven@intel.com>; Zeng, Star <star.z...@intel.com> > Subject: RE: [edk2] [PATCH] MdeModulePkg/Terminal: Check status of > OpenProtocol in Bin

Re: [edk2] [PATCH] MdeModulePkg/PartitionDxe: Add partition type guid to installed handle

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of > jbrasen@qualcommdatacenter.com > Sent: Monday, March 26, 2018 4:57 PM > To: edk2-devel@lists.01.org > Subjec

Re: [edk2] [MdeModulePkg/Usb v2 1/1] MdeModulePkg/Usb: Replace macro USB_BOOT_IO_BLOCKS

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zeng, > Star > Sent: Thursday, March 22, 2018 4:39 PM > To: Ming Huang <ming.hu...@linaro.org>; linaro-u...@lists.linaro.org;

Re: [edk2] [PATCH] OvmfPkg/QemuVideoDxe: handle invalid BltOperation gracefully

n from QemuVideoGraphicsOutputBlt() that prevents this from working in NOOPT and DEBUG builds. Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> Cc: Rocky <xingrong...@intel.com> Cc: Ruiyu Ni <ruiyu...@intel.com> Reported-by: Rocky <xingrong...@intel.com> Analyzed-by: Ruiyu Ni &

Re: [edk2] [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default

On 3/20/2018 8:15 PM, Guo Heyi wrote: I've no idea about how to use Driver; let me spend some time to learn first :) Heyi, you could use "load xxxDriver.efi" to load the dynamic command in shell. After that, you can run "tftp" in shell just as running an internal command. Regards, Heyi

<    1   2   3   4   5   6   7   8   9   10   >