Re: [edk2] [PATCH] MdeModulePkg/PciHostBridgeDxe: Fixed PCI DMA Map/Umap bounce buffer

2017-10-09 Thread Ni, Ruiyu
The "read"/"write" is from the Bus Master's point of view. Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daniil > Egranov > Sent: Monday, October 9, 2017 9:16 AM > To: edk2-devel@lists.01.org > Cc: leif.lindh...@linaro.org; Zeng,

Re: [edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add check to void use null pointer.

2017-10-08 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric > Dong > Sent: Monday, October 9, 2017 11:18 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [edk2] [Patch] UefiCpuPk

Re: [edk2] [PATCH v3] Ifconfig : Fixed False information about Media State.

2017-10-08 Thread Ni, Ruiyu
Do you need to put all the hard-code string in UNI file for localization? Thanks/Ray > -Original Message- > From: Wu, Jiaxin > Sent: Monday, October 9, 2017 9:29 AM > To: Meenakshi Aggarwal ; Carsey, Jaben > ; edk2-devel@lists.01.org; Ni, Ruiyu > > Subject: RE

Re: [edk2] [Patch V2] Build spec: add description for build with binary cache

2017-09-29 Thread Ni, Ruiyu
If use both flags is same as --hash. Can we just get rid of --hash and just use the existing two flags? In this way, we can hide the internal implementation of how to check modification. Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf

Re: [edk2] [PATCH] MdeModulePkg/PciBus: Count multiple hotplug resource paddings

2017-09-29 Thread Ni, Ruiyu
Laszlo, Please check whether this patch can resolve the hang issue you reported. I don't use your suggestion to use the MAX resource paddings. Instead, I count all the resource paddings. If it can work, I will submit another patch to clean up the code in CalculateApertureIo16(). That function cou

Re: [edk2] [Patch v2 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: Combine INIT-SIPI-SIPI.

2017-09-28 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: Dong, Eric Sent: Friday, September 29, 2017 8:27 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Ni, Ruiyu Subject: [Patch v2 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: Combine INIT-SIPI-SIPI. In S3 resume path, current implementation do 2 separate

Re: [edk2] [Patch v2 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Refine code to avoid duplicated code.

2017-09-28 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: Dong, Eric Sent: Friday, September 29, 2017 8:27 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Ni, Ruiyu Subject: [Patch v2 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Refine code to avoid duplicated code. V2: Change function parameter to avoid

Re: [edk2] [PATCH 1/2] ShellPkg/dh: Correct typo in help

2017-09-28 Thread Ni, Ruiyu
Yes I think so. Thanks/Ray > -Original Message- > From: Carsey, Jaben > Sent: Friday, September 29, 2017 2:30 AM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Subject: RE: [PATCH 1/2] ShellPkg/dh: Correct typo in help > > Ray, > > This text is taken directly

Re: [edk2] [Patch 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Refine code to avoid duplicated code.

2017-09-28 Thread Ni, Ruiyu
RegisterTableCount ); 2. How about change MPRendezvousProcedure to InitializeAp? Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Thursday, September 28, 2017 5:31 PM > To: Dong, Eric ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Yao, Jiewen

Re: [edk2] [PATCH v2] ShellPkg/dh: Add the 'dh' dump support for Partition Info protocol

2017-09-28 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Thursday, September 28, 2017 4:33 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Ni, Ruiyu ; Carsey, > Jaben > Subject: [PATCH v2] ShellPkg/dh: Add the 'dh' dump suppor

Re: [edk2] [PATCH] MdeModulePkg/BdsDxe: Don't delete "BootNext" until booting it

2017-09-27 Thread Ni, Ruiyu
Sent: Thursday, September 28, 2017 2:13 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star > Subject: RE: [PATCH] MdeModulePkg/BdsDxe: Don't delete "BootNext" until > booting it > > The commit log is saying the "BootNext"

Re: [edk2] [PATCH] MdeModulePkg/BdsDxe: Don't delete "BootNext" until booting it

2017-09-27 Thread Ni, Ruiyu
This could avoid the "BootNext" set by PlatformBootManagerLib be consumed in *this* boot. If I add "*" around "this", is it more clear? Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Thursday, September 28, 2017 2:00 PM > To: Ni,

Re: [edk2] [patch] ShellPkg/Dh: Refine variable naming style

2017-09-27 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Bi, Dandan > Sent: Thursday, September 28, 2017 10:45 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Carsey, Jaben > Subject: [patch] ShellPkg/Dh: Refine variable naming style > > Avoid using on

Re: [edk2] [Patch] UefiCpuPkg/CpuCommonFeaturesLib: Add check for input parameter.

2017-09-25 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Tuesday, September 26, 2017 10:48 AM To: edk2-devel@lists.01.org Cc: Shao, Ming ; Ni, Ruiyu Subject: [edk2] [Patch] UefiCpuPkg/CpuCommonFeaturesLib: Add check

Re: [edk2] [Patch 01/11] MdePkg: Correct BaseS3PciSegmentLib module name to match its uni file

2017-09-25 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: Gao, Liming Sent: Monday, September 25, 2017 7:06 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu Subject: [Patch 01/11] MdePkg: Correct BaseS3PciSegmentLib module name to match its uni file Contributed-under: TianoCore Contribution

Re: [edk2] [Patch 05/11] ShellPkg: Update Guid usage in ShellLib INF to match source code logic

2017-09-25 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: Gao, Liming Sent: Monday, September 25, 2017 7:06 PM To: edk2-devel@lists.01.org Cc: Carsey, Jaben ; Ni, Ruiyu Subject: [Patch 05/11] ShellPkg: Update Guid usage in ShellLib INF to match source code logic Contributed-under: TianoCore

Re: [edk2] [Patch 03/11] PcAtChipsetPkg: Update GUID usage in PcRtc INF to match the source code

2017-09-25 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: Gao, Liming Sent: Monday, September 25, 2017 7:06 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu Subject: [Patch 03/11] PcAtChipsetPkg: Update GUID usage in PcRtc INF to match the source code Contributed-under: TianoCore Contribution

Re: [edk2] [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic

2017-09-25 Thread Ni, Ruiyu
Liming, There is no keyword such as "SOMETIMES_TO_START"? The DiskIo2 is indeed a TO_START protocol, but optional. -Original Message- From: Gao, Liming Sent: Monday, September 25, 2017 7:06 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu Subject: [Patch 02/11] FatPkg: Update Pp

Re: [edk2] [PATCH] TFTP : tftp fix for full volume case

2017-09-25 Thread Ni, Ruiyu
+ Siyuan and Ting. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Meenakshi Aggarwal Sent: Monday, September 25, 2017 10:37 PM To: edk2-devel@lists.01.org; Ni, Ruiyu ; Carsey, Jaben Cc: leif.lindh...@linaro.org; ard.biesheu...@linaro.org

Re: [edk2] [PATCH v4 0/2] UDF partition driver fix

2017-09-24 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: Paulo Alcantara [mailto:pca...@zytor.com] Sent: Saturday, September 23, 2017 2:12 AM To: edk2-devel@lists.01.org Cc: Paulo Alcantara ; Kinney, Michael D ; Gao, Liming ; Laszlo Ersek ; Ni, Ruiyu ; Zeng, Star ; Yao, Jiewen Subject: [PATCH

Re: [edk2] [PATCH] ShellPkg/DmpStore: fix GCC/CLANG build failure

2017-09-22 Thread Ni, Ruiyu
ed as commit ba30d5f05121. Laszlo -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Friday, September 22, 2017 6:44 AM To: Laszlo Ersek mailto:ler...@redhat.com>> Cc: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>; Carsey, Jaben mailto:jabe

Re: [edk2] [Patch] ShellPkg: Update the parameter type to match function interface in DmpStore

2017-09-22 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Liming Gao > Sent: Friday, September 22, 2017 2:36 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [edk2] [Patch] ShellPkg:

Re: [edk2] [PATCH v3 2/2] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition

2017-09-21 Thread Ni, Ruiyu
Star > -Original Message- > From: Paulo Alcantara [mailto:pca...@gmail.com] > Sent: Thursday, September 21, 2017 10:17 PM > To: Zeng, Star ; Wu, Hao A ; > edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Laszlo Ersek ; Dong, > Eric > Subject: Re: [edk2] [PATCH v3 2/2] MdeModu

Re: [edk2] [PATCH v3 1/2] MdePkg: Add UDF volume structure definitions

2017-09-21 Thread Ni, Ruiyu
gt; To: edk2-devel@lists.01.org > Cc: Paulo Alcantara ; Kinney, Michael D > ; Gao, Liming ; Laszlo > Ersek ; Ni, Ruiyu > Subject: [PATCH v3 1/2] MdePkg: Add UDF volume structure definitions > > This patch adds a few more UDF volume structures in order to detect an UDF > file system

Re: [edk2] [PATCH] ShellPkg/dmpstore: Show name of known variable vendor GUID

2017-09-20 Thread Ni, Ruiyu
l Message- > From: Carsey, Jaben > Sent: Monday, September 18, 2017 11:24 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Li, Huajing > Subject: RE: [PATCH] ShellPkg/dmpstore: Show name of known variable > vendor GUID > > Whats the difference between HEADER_LINE an

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition

2017-09-20 Thread Ni, Ruiyu
t; Sent: Wednesday, September 20, 2017 5:59 PM > To: Ni, Ruiyu ; Paulo Alcantara ; > edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star > Subject: Re: [PATCH v2 2/3] MdeModulePkg/PartitionDxe: Fix creation of > UDF logical partition > > Ray, > > On 09/20/17 10:14,

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition

2017-09-20 Thread Ni, Ruiyu
Thanks/Ray > -Original Message- > From: Paulo Alcantara [mailto:pca...@zytor.com] > Sent: Tuesday, September 19, 2017 12:38 AM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star ; > Laszlo Ersek > Subject: Re: [PATCH v2 2/3] MdeModulePkg/Parti

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/UdfDxe: Rework driver to support PartitionDxe changes

2017-09-20 Thread Ni, Ruiyu
Lsn += ((UINT64)PartitionDesc->PartitionStartingLocation - *LogicalVolEndLsn) + PartitionDesc->PartitionLength - 1; Thanks/Ray > -Original Message- > From: Paulo Alcantara [mailto:pca...@zytor.com] > Sent: Tuesday, September 19, 2017 12:51 AM > To: Ni, Ruiyu ; ed

Re: [edk2] [PATCH 2/2] MdePkg/BaseLib: Avoid reading content beyond string boundary

2017-09-19 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Tuesday, September 19, 2017 7:39 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Ni, Ruiyu ; Kinney, Michael D ; Gao, Liming Subject: [edk2] [PATCH 2/2] MdePkg

Re: [edk2] [PATCH 1/2] ShellPkg/Shell: Avoid reading content beyond string boundary

2017-09-19 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Tuesday, September 19, 2017 7:39 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Ni, Ruiyu ; Carsey, Jaben Subject: [edk2] [PATCH 1/2] ShellPkg/Shell: Avoid

Re: [edk2] [PATCH v2 0/3] UDF partition driver fix

2017-09-17 Thread Ni, Ruiyu
o: edk2-devel@lists.01.org > Cc: Paulo Alcantara ; Kinney, Michael D > ; Gao, Liming ; Laszlo > Ersek ; Ni, Ruiyu ; Zeng, Star > ; Yao, Jiewen > Subject: [PATCH v2 0/3] UDF partition driver fix > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=707 > > Hi, >

Re: [edk2] [PATCH 0/3] UDF partition driver fix

2017-09-17 Thread Ni, Ruiyu
Paulo, I checked carefully of patch #1, 50% carefully of #2, 20% carefully of #3. I could only give comments from the EDKII coding style perspective. I do provide some other comments, but please understand they are from a person that knows very little about UDF. (I know the concept of Volume. But j

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/UdfDxe: Rework driver to support PartitionDxe changes

2017-09-17 Thread Ni, Ruiyu
be no duplicated logic in Partition driver and udf driver. Can you explain more? Thanks/Ray > -Original Message- > From: Paulo Alcantara [mailto:pca...@zytor.com] > Sent: Sunday, September 17, 2017 9:13 PM > To: edk2-devel@lists.01.org > Cc: Paulo Alcantara ; Dong, Eric ; >

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition

2017-09-17 Thread Ni, Ruiyu
:pca...@zytor.com] > Sent: Sunday, September 17, 2017 9:13 PM > To: edk2-devel@lists.01.org > Cc: Paulo Alcantara ; Dong, Eric ; > Ni, Ruiyu ; Zeng, Star ; Laszlo > Ersek > Subject: [PATCH v2 2/3] MdeModulePkg/PartitionDxe: Fix creation of UDF > logical partition > > Do

Re: [edk2] [PATCH v2 1/3] MdePkg: Add UDF volume structure definitions

2017-09-17 Thread Ni, Ruiyu
On Behalf Of Ni, > Ruiyu > Sent: Monday, September 18, 2017 8:29 AM > To: Paulo Alcantara ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Laszlo Ersek > ; Gao, Liming > Subject: Re: [edk2] [PATCH v2 1/3] MdePkg: Add UDF volume structure > definitions >

Re: [edk2] [PATCH v2 1/3] MdePkg: Add UDF volume structure definitions

2017-09-17 Thread Ni, Ruiyu
D, LVD and TD? How about changing _Pointer to _Tag or DescriptorTag? Thanks/Ray > -Original Message- > From: Paulo Alcantara [mailto:pca...@zytor.com] > Sent: Sunday, September 17, 2017 9:13 PM > To: edk2-devel@lists.01.org > Cc: Paulo Alcantara ; Kinney, Michael D > ; Ga

Re: [edk2] Functionality issues in UDF support

2017-09-15 Thread Ni, Ruiyu
Laszlo, Please do not add a PCD for this. Too many PCDs are no good to the project. 发自我的 iPhone > 在 2017年9月16日,上午12:27,Paulo Alcantara 写道: > > Laszlo, > >> On 15/09/2017 12:51, Laszlo Ersek wrote: >>> On 09/15/17 09:38, Ni, Ruiyu wrote: >>> Paulo,

Re: [edk2] [PATCH] MdeModulePkg/UdfDxe: Remove negative comparison of unsigned number

2017-09-15 Thread Ni, Ruiyu
, September 15, 2017 6:15 PM To: Zeng, Star ; Paulo Alcantara ; Ni, Ruiyu ; Yao, Jiewen Cc: Dong, Eric ; Bi, Dandan ; edk2-devel@lists.01.org; Kinney, Michael D ; Ard Biesheuvel ; Leif Lindholm (Linaro address) Subject: Re: [PATCH] MdeModulePkg/UdfDxe: Remove negative comparison of unsigned

Re: [edk2] Functionality issues in UDF support

2017-09-15 Thread Ni, Ruiyu
pattern of existing code to support it should be easy. Thanks, Ray -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, September 15, 2017 7:03 PM To: Ni, Ruiyu ; Paulo Alcantara ; Yao, Jiewen Cc: Wu, Hao A ; edk2-devel@lists.01.org; Zeng, Star Subject:

Re: [edk2] Functionality issues in UDF support

2017-09-15 Thread Ni, Ruiyu
ted a Bugzilla to record this: https://bugzilla.tianocore.org/show_bug.cgi?id=707 Thanks/Ray > -Original Message- > From: Paulo Alcantara [mailto:pca...@zytor.com] > Sent: Friday, September 15, 2017 3:22 PM > To: Ni, Ruiyu ; Laszlo Ersek ; Yao, > Jiewen > Cc: edk2-devel@

Re: [edk2] Functionality issues in UDF support

2017-09-15 Thread Ni, Ruiyu
Paulo, Can current code support multiple volumes in CDROM? Thanks/Ray > -Original Message- > From: Paulo Alcantara [mailto:pca...@zytor.com] > Sent: Friday, September 15, 2017 2:26 PM > To: Ni, Ruiyu ; Laszlo Ersek > Cc: edk2-devel@lists.01.org; Wu, Hao A ; Zeng, Star &

Re: [edk2] Functionality issues in UDF support

2017-09-15 Thread Ni, Ruiyu
Star, Eltorito file system access should work. But UDF support may not work as expected if there are multiple volumes in the CDROM. Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Friday, September 15, 2017 3:01 PM > To: Paulo Alcantara ; Ni, Ruiyu ; > Laszlo Er

Re: [edk2] Functionality issues in UDF support

2017-09-14 Thread Ni, Ruiyu
Paulo, When will you change the implementation to this way? Thanks/Ray > -Original Message- > From: Paulo Alcantara [mailto:pca...@zytor.com] > Sent: Friday, September 15, 2017 1:38 PM > To: Ni, Ruiyu ; Laszlo Ersek > Cc: edk2-devel@lists.01.org; Wu, Hao A ; Zeng, Star &

Re: [edk2] Functionality issues in UDF support

2017-09-14 Thread Ni, Ruiyu
Yes. Your understanding is correct. Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Friday, September 15, 2017 1:34 PM > To: Ni, Ruiyu ; Paulo Alcantara ; > Laszlo Ersek > Cc: edk2-devel@lists.01.org; Wu, Hao A ; Zeng, Star > > Subject: RE: Fun

Re: [edk2] Functionality issues in UDF support

2017-09-14 Thread Ni, Ruiyu
ndles() should contain a for-loop to iterate all the volumes in the CDROM, and create child BLK handle for each volumes, but skipping Eltorito volume. Thanks/Ray > -Original Message- > From: Paulo Alcantara [mailto:pca...@zytor.com] > Sent: Friday, September 15, 2017 12:58 PM &

[edk2] Functionality issues in UDF support

2017-09-14 Thread Ni, Ruiyu
Paulo, Before raising my questions, I'd like to confirm that for a single CD/DVD in UDF format, there might be multiple volumes. One of the volume could be Eltorito type. If my understanding is correct, please continue reading below. We found below mapping table using "map -r" shell command in a

Re: [edk2] [PATCH] MdeModulePkg/PciBusDxe: GetBarAttributes() returns Host address

2017-09-12 Thread Ni, Ruiyu
8 AM > To: Laszlo Ersek ; Ard Biesheuvel > > Cc: Ni, Ruiyu ; edk2-devel@lists.01.org; Dong Wei > ; Andrew Fish > Subject: Re: [edk2] [PATCH] MdeModulePkg/PciBusDxe: GetBarAttributes() > returns Host address > > On Tue, 2017-09-12 at 18:15 +0200, Laszlo Ersek wrote: > &g

Re: [edk2] [PATCH 1/2] MdeModulePkg/UdfDxe: reject reserved values in ICB.Flags[2:0]

2017-09-12 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, September 13, 2017 6:26 AM > To: edk2-devel-01 > Cc: Ard Biesheuvel ; Dong, Eric > ; Paulo Alcantara ; Ni, Ruiyu > ; Zeng, Star > Subject:

Re: [edk2] [PATCH v3 1/3] MdeModulePkg/UdfDxe: Add type cast to fix build failure in VS tools

2017-09-12 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Bi, Dandan > Sent: Tuesday, September 12, 2017 4:56 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Paulo Alcantara ; > Ni, Ruiyu ; Zeng, Star > Subject: [PATCH v3 1/3] MdeModulePkg/UdfDxe: Add t

Re: [edk2] [PATCH v3 2/3] MdeModulePkg/UdfDxe: Initialize the array after declaration

2017-09-12 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Bi, Dandan > Sent: Tuesday, September 12, 2017 4:56 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Paulo Alcantara ; > Ni, Ruiyu ; Zeng, Star > Subject: [PATCH v3 2/3] MdeModulePkg/UdfDxe: Initi

Re: [edk2] [PATCH v3 3/3] MdeModulePkg/PartitionDxe: Initialize the array after declaration

2017-09-12 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Dandan Bi > Sent: Tuesday, September 12, 2017 4:56 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Dong, Eric ; Zeng, > Star > Sub

Re: [edk2] [PATCH 3/5] MdeModulePkg/UdfDxe: replace zero-init of local variables with ZeroMem()

2017-09-12 Thread Ni, Ruiyu
s, > Star > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Sunday, September 10, 2017 8:13 AM > To: edk2-devel-01 > Cc: Ard Biesheuvel ; Dong, Eric > ; Paulo Alcantara ; Ni, Ruiyu > ; Zeng, Star > Subject: [PATCH 3/5] MdeModulePkg/U

Re: [edk2] [PATCH 4/5] MdeModulePkg/PartitionDxe: don't divide 64-bit values with C operators

2017-09-12 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, September 12, 2017 3:59 PM > To: Bi, Dandan ; edk2-devel-01 de...@lists.01.org> > Cc: Ni, Ruiyu ; Dong, Eric ; Zeng, > Star ; Ard Biesheuvel

Re: [edk2] [PATCH] MdeModulePkg/PciBusDxe: GetBarAttributes() returns Host address

2017-09-11 Thread Ni, Ruiyu
al Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Monday, September 11, 2017 2:47 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Dong Wei ; Benjamin Herrenschmidt > ; Andrew Fish ; Ard Biesheuvel > > Subject: Re

Re: [edk2] [PATCH 0/5] MdeModulePkg: UDF fixes and cleanups

2017-09-11 Thread Ni, Ruiyu
Steven, Thanks for capturing the bug using ASAN! -Original Message- From: Shi, Steven Sent: Monday, September 11, 2017 9:08 PM To: Paulo Alcantara ; Laszlo Ersek ; edk2-devel-01 Cc: Ni, Ruiyu ; Dong, Eric ; Zeng, Star ; Ard Biesheuvel Subject: RE: [edk2] [PATCH 0/5] MdeModulePkg: UDF

Re: [edk2] [patch 1/3] MdeModulePkg/PartitionDxe: Don't use non-constant expression in array

2017-09-10 Thread Ni, Ruiyu
.01.org > Cc: Dong, Eric ; Paulo Alcantara ; > Ni, Ruiyu ; Zeng, Star > Subject: [patch 1/3] MdeModulePkg/PartitionDxe: Don't use non-constant > expression in array > > Remove the DescriptorLBAs[] array with non-constant expression to fix non- > constant aggregate

Re: [edk2] [PATCH v6 0/6] read-only UDF file system support

2017-09-08 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Friday, September 8, 2017 9:26 PM To: Paulo Alcantara ; Ni, Ruiyu Cc: Dong, Eric ; Wu, Hao A ; Justen, Jordan L ; edk2-devel@lists.01.org; Andrew Fish

Re: [edk2] [PATCH] MdeModulePkg Xhci: Correct description of Timeout param in XhciReg.h

2017-09-08 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Star Zeng > Sent: Thursday, September 7, 2017 7:13 PM > To: edk2-devel@lists.01.org > Cc: Alexei Fedorov ; Ni, Ruiyu > ; Zeng, Star >

Re: [edk2] [PATCH v5 0/6] read-only UDF file system support

2017-09-07 Thread Ni, Ruiyu
> ; Zeng, Star ; Dong, Eric > ; Doran, Mark ; Ni, Ruiyu > ; Wu, Hao A > Subject: Re: [PATCH v5 0/6] read-only UDF file system support > > Ray, > > On 07/09/2017 20:13, Paulo Alcantara wrote: > > v5: > > - Fixed OVMF IA32 build. > > - Fixed a typo in U

Re: [edk2] [PATCH v5 0/6] read-only UDF file system support

2017-09-07 Thread Ni, Ruiyu
To: edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Justen, Jordan L > ; Andrew Fish ; Kinney, > Michael D ; Gao, Liming > ; Zeng, Star ; Dong, Eric > ; Doran, Mark ; Ni, Ruiyu > ; Wu, Hao A > Subject: Re: [PATCH v5 0/6] read-only UDF file system support > > Ray, > >

Re: [edk2] [PATCH v5 6/6] Nt32Pkg: Enable UDF file system support

2017-09-07 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Paulo Alcantara [mailto:pca...@zytor.com] > Sent: Friday, September 8, 2017 7:13 AM > To: edk2-devel@lists.01.org > Cc: Paulo Alcantara ; Ni, Ruiyu ; Wu, > Hao A ; Laszlo Ersek > Subject: [PATCH v5 6/6

Re: [edk2] [PATCH v1] MdePkg: Add definitions for the SPI protocols introduced in UEFI PI 1.6.

2017-09-07 Thread Ni, Ruiyu
Marvin, Thank you for your contribution. We will need some time to review the definitions against PI Spec. If there is a need to post V2, it might be better to separate the header files in different groups. For example, LegacySpi group, SPI group, SMM SPI group. Thanks/Ray > -Original Messa

Re: [edk2] [PATCH v4 0/6] read-only UDF file system support

2017-09-06 Thread Ni, Ruiyu
Sure. Please. -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, September 6, 2017 10:28 PM To: Ni, Ruiyu ; Zeng, Star Cc: Paulo Alcantara ; edk2-devel@lists.01.org; Dong, Eric ; Wu, Hao A ; Justen, Jordan L ; Andrew Fish ; Gao, Liming ; Kinney, Michael

Re: [edk2] CPU/PCI addressing in PciIoGetAttributes

2017-09-05 Thread Ni, Ruiyu
please correct me if I am wrong. Thanks, Ray From: Bartosz Szczepanek [mailto:b...@semihalf.com] Sent: Monday, September 4, 2017 7:43 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu Subject: [edk2] CPU/PCI addressing in PciIoGetAttributes Hi guys, I have some doubt about PciIoGetAttributes

Re: [edk2] [Patch] Nt32Pkg: Clean up DSC to remove unnecessary build option in SecMain

2017-09-05 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: Gao, Liming Sent: Tuesday, September 5, 2017 2:56 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu Subject: [Patch] Nt32Pkg: Clean up DSC to remove unnecessary build option in SecMain Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [Patch] UefiCpuPkg/Lmce.c Remove useless file.

2017-09-04 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Dong, Eric > Sent: Friday, September 1, 2017 1:59 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [Patch] UefiCpuPkg/Lmce.c Remove useless file. > > Merge the code to MachineCheck.

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Generate boot description for SD/eMMC

2017-09-04 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Tuesday, September 5, 2017 8:33 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Ni, Ruiyu > Subject: [PATCH] MdeModulePkg/UefiBootManagerLib: Generate boot > description for S

Re: [edk2] [PATCH v4 0/6] read-only UDF file system support

2017-09-04 Thread Ni, Ruiyu
; Doran, Mark ; Ni, Ruiyu ; Wu, Hao A Subject: [PATCH v4 0/6] read-only UDF file system support Hi, This series introduces read-only UDF file system support in EDK2. As Laszlo (or Red Hat) seemed to be interested in such support, I'm posting it again after ~3 years. The idea is not repl

Re: [edk2] [PATCH] SourceLevelDebugPkg/DebugCommLibUsb3Pei: Make sure alloc physical mem

2017-08-31 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Friday, September 1, 2017 2:24 PM > To: Zeng, Star ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Zeng, Star > Subject: RE: [edk2] [PATCH] SourceLevelDebugPkg/DebugCommLibUsb3Pei: > Mak

Re: [edk2] [PATCH v3] SourceLevelDebugPkg: Use Pcd for the revision of transfer protocol

2017-08-31 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Friday, September 1, 2017 12:43 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Ni, Ruiyu > Subject: [PATCH v3] SourceLevelDebugPkg: Use Pcd for the revision of > transfer protocol &

Re: [edk2] [PATCH v2] SourceLevelDebugPkg: Use Pcd for the revision of transfer protocol

2017-08-31 Thread Ni, Ruiyu
Hao, I have 2 comments regarding to the INF and DEC change. Check below. Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Friday, September 1, 2017 10:13 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Ni, Ruiyu > Subject: [PATCH v2] SourceLevelDebugPk

Re: [edk2] [PATCH] SourceLevelDebugPkg/DebugCommLibUsb3: Remove IntelFrameworkPkg.dec

2017-08-31 Thread Ni, Ruiyu
Star, Did you test the UDK Debugger functionality with this change? -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Thursday, August 31, 2017 6:00 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Wu, Hao A ; Zeng, Star Subject

Re: [edk2] [Patch] UefiCpuPkg/Mplib.c: Perform complete initialization when enable AP.

2017-08-30 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Dong, Eric > Sent: Wednesday, August 30, 2017 10:22 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Ni, Ruiyu > > Subject: [Patch] UefiCpuPkg/Mplib.c: Perform complete initialization when >

Re: [edk2] [PATCH] SourceLevelDebugPkg/DebugAgentCommon: Use global variable for revision

2017-08-30 Thread Ni, Ruiyu
Yes. I agree with Mike's idea to use FixedAtBuild PCD for the debug agent transfer protocol revision. -Original Message- From: Wu, Hao A Sent: Wednesday, August 30, 2017 7:13 PM To: Kinney, Michael D ; Ard Biesheuvel Cc: Ni, Ruiyu ; edk2-devel@lists.01.org Subject: RE: [edk2] [

Re: [edk2] [PATCH] SourceLevelDebugPkg/DebugAgentCommon: Use global variable for revision

2017-08-29 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: Wu, Hao A Sent: Tuesday, August 29, 2017 9:09 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Ni, Ruiyu Subject: [PATCH] SourceLevelDebugPkg/DebugAgentCommon: Use global variable for revision Since some static code checkers complain that

Re: [edk2] [Patch 0/2] Add CPUID MCA supports check

2017-08-28 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Eric Dong > Sent: Thursday, August 17, 2017 11:44 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch 0/2] Add CPUID MCA supports check > > This patch s

Re: [edk2] [PATCH v4 6/6] Nt32Pkg: Enable UDF file system support

2017-08-24 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Paulo Alcantara [mailto:pca...@zytor.com] > Sent: Friday, August 25, 2017 1:56 AM > To: edk2-devel@lists.01.org > Cc: Paulo Alcantara ; Ni, Ruiyu ; Wu, > Hao A ; Laszlo Ersek > Subject: [PATCH v4 6/6

Re: [edk2] [PATCH] MdeModulePkg XhciDxe: Fix Map and Unmap inconsistency

2017-08-24 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Thursday, August 24, 2017 5:47 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Ni, Ruiyu ; Yao, > Jiewen > Subject: [PATCH] MdeModulePkg XhciDxe: Fix Map and Unmap > inconsist

Re: [edk2] [PATCH v2 0/6] read-only UDF file system support

2017-08-20 Thread Ni, Ruiyu
>To: edk2-devel@lists.01.org >Cc: Paulo Alcantara ; Laszlo Ersek ; >Justen, Jordan L ; >Andrew Fish ; Kinney, Michael D ; >Gao, Liming ; >Zeng, Star ; Dong, Eric ; Doran, >Mark ; Ni, Ruiyu >; Wu, Hao A >Subject: [PATCH v2 0/6] read-only UDF file system support &g

Re: [edk2] any uefi application that can simulator multi processor dispatch logic in OS

2017-08-17 Thread Ni, Ruiyu
I believe what you want is a multi-threading capable tiny OS. I don't know a real project for your purpose. But I guess there should be plenty of such projects there, just need porting effort. Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

Re: [edk2] [EDK2] PCI bus do 2 Enumeration when 2 root bridges under 1 host bridge

2017-08-17 Thread Ni, Ruiyu
Eric, Firstly, PciBus driver can support single-segment-multiple-rootbridge system or multiple-segment-multiple-rootbridge very well. (I agree the enumeration logic confuses you.) Take a platform containing 2 root bridges for example, your understanding is correct. PciBus does the full enumeration

Re: [edk2] [PATCH] Maintainers.txt: Update the maintainer for SourceLevelDebugPkg

2017-08-16 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Wednesday, August 16, 2017 2:20 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Ni, Ruiyu > Subject: [PATCH] Maintainers.txt: Update the maintainer for > SourceLevelDebug

Re: [edk2] [Patch] UefiCpuPkg BaseUefiCpuLib: remove error reference code.

2017-08-16 Thread Ni, Ruiyu
2-devel@lists.01.org > Cc: Ni, Ruiyu ; Shao, Ming > Subject: [edk2] [Patch] UefiCpuPkg BaseUefiCpuLib: remove error reference > code. > > UefiCpuLib inf file reference itself in [LibraryClasses] > section, this is not necessary. This patch remove it. > > Cc: Ruiyu Ni

Re: [edk2] [Patch] UefiCpuPkg RegisterCpuFeaturesLib: Enhance debug messages.

2017-08-16 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Eric Dong > Sent: Tuesday, August 15, 2017 1:32 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Shao, Ming ; > s...@ml01.01.org >

Re: [edk2] [Patch] UefiCpuPkg RegisterCpuFeaturesLib: Fix buffer pointer error usage.

2017-08-14 Thread Ni, Ruiyu
How about to use AllocateCopyPool()? Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Eric Dong > Sent: Tuesday, August 15, 2017 1:32 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Shao, Ming ; > s...@

Re: [edk2] [Patch] Nt32/PlatformBootManagerLib: Enable STD_ERROR on all consoles

2017-08-14 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Kinney, Michael D > Sent: Tuesday, August 15, 2017 6:30 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Wu, Hao A ; > Kinney, Michael D > Subject: [Patch] Nt32/PlatformBootManagerLib: Enable STD_ER

Re: [edk2] [PATCH 0/4] read-only UDF file system support

2017-08-09 Thread Ni, Ruiyu
Regards, Ray >-Original Message- >From: Paulo Alcantara [mailto:pca...@zytor.com] >Sent: Wednesday, August 9, 2017 10:01 PM >To: Ni, Ruiyu ; Zeng, Star ; >edk2-devel@lists.01.org >Cc: Dong, Eric ; Wu, Hao A ; Justen, >Jordan L ; >Andrew Fish ; Gao, Limi

Re: [edk2] [PATCH 05/11] ShellPkg/UefiShellLevel2CommandsLib: Remove unnecessary EFIAPI

2017-08-09 Thread Ni, Ruiyu
I've submitted a tracker for this: https://bugzilla.tianocore.org/show_bug.cgi?id=664 It's in my to-do list. do you need the fix urgent? Regards, Ray >-Original Message- >From: Palmer, Thomas [mailto:thomas.pal...@hpe.com] >Sent: Thursday, August 10, 2017 7:40 AM &g

Re: [edk2] [PATCH 0/2] Notify NVME HW when system reset happens

2017-08-09 Thread Ni, Ruiyu
the normal timeout, so we would fail to boot the NVME disk. I will put above explanation into the commit message as well. Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Monday, August 7, 2017 3:14 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Subject: RE: [e

Re: [edk2] [PATCH 0/4] read-only UDF file system support

2017-08-08 Thread Ni, Ruiyu
usten, Jordan L > ; Andrew Fish ; Kinney, > Michael D ; Gao, Liming > ; Dong, Eric ; Doran, Mark > ; Ni, Ruiyu ; Wu, Hao A > > Subject: RE: [PATCH 0/4] read-only UDF file system support > > Cc Ray and Hao. > > -Original Message- > From: Paulo Alcantara [mailto:pca

Re: [edk2] [Patch 4/7] QuarkSocPkg MtrrLib: Remove reference deprecated macro.

2017-08-06 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Dong, Eric > Sent: Thursday, August 3, 2017 5:32 PM > To: edk2-devel@lists.01.org > Cc: Fan, Jeff ; Ni, Ruiyu ; Kinney, > Michael D > Subject: [Patch 4/7] QuarkSocPkg MtrrLib: Remove reference deprec

Re: [edk2] [Patch 6/7] UefiCpuPkg CpuDxe: Remove reference deprecated macro.

2017-08-06 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Dong, Eric > Sent: Thursday, August 3, 2017 5:32 PM > To: edk2-devel@lists.01.org > Cc: Fan, Jeff ; Ni, Ruiyu > Subject: [Patch 6/7] UefiCpuPkg CpuDxe: Remove reference deprecated > macro. > > C

Re: [edk2] [Patch 7/7] UefiCpuPkg MtrrLib: Remove deprecated micro.

2017-08-06 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Dong, Eric > Sent: Thursday, August 3, 2017 5:32 PM > To: edk2-devel@lists.01.org > Cc: Fan, Jeff ; Ni, Ruiyu > Subject: [Patch 7/7] UefiCpuPkg MtrrLib: Remove deprecated micro. > > Cc:

Re: [edk2] [Patch 3/7] UefiCpuPkg CpuDxe: Enhance get mtrr mask logic.

2017-08-06 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Dong, Eric > Sent: Thursday, August 3, 2017 5:32 PM > To: edk2-devel@lists.01.org > Cc: Fan, Jeff ; Ni, Ruiyu > Subject: [Patch 3/7] UefiCpuPkg CpuDxe: Enhance get mtrr mask logic. > > In order t

Re: [edk2] [Patch 2/7] Vlv2TbltDevicePkg: Enhance get mtrr mask logic.

2017-08-06 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Dong, Eric > Sent: Thursday, August 3, 2017 5:32 PM > To: edk2-devel@lists.01.org > Cc: Fan, Jeff ; Ni, Ruiyu ; Wei, > David > Subject: [Patch 2/7] Vlv2TbltDevicePkg: Enhance get mtrr mask logic. > &

Re: [edk2] [Patch 1/7] QuarkSocPkg MtrrLib: Enhance get mtrr mask logic.

2017-08-06 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Eric Dong > Sent: Thursday, August 3, 2017 5:32 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Kinney, Michael D > ; Fan, Jeff >

Re: [edk2] [Patch v2] Vlv2TbltDevicePkg: Remove reference deprecated macro.

2017-08-06 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Eric Dong > Sent: Friday, August 4, 2017 1:59 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Fan, Jeff ; Wei, > David > S

Re: [edk2] [PATCH 05/11] ShellPkg/UefiShellLevel2CommandsLib: Remove unnecessary EFIAPI

2017-08-06 Thread Ni, Ruiyu
> Palmer, Thomas > Sent: Friday, August 4, 2017 3:07 AM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH 05/11] ShellPkg/UefiShellLevel2CommandsLib: > Remove unnecessary EFIAPI > > Ruiyu, > Sorry for replying to old patch, I was cleaning out some o

Re: [edk2] [PATCH] MdeModulePkg SerialDxe: Process timeout consistently in SerialRead

2017-08-04 Thread Ni, Ruiyu
I thought unit of Stall is 100ns. Then no issues now. Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Friday, August 4, 2017 5:25 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Heyi Guo ; Laszlo Ersek ; > Zeng, Star >

Re: [edk2] [PATCH] MdeModulePkg SerialDxe: Process timeout consistently in SerialRead

2017-08-04 Thread Ni, Ruiyu
Star, 3 minor comments below. Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Friday, August 4, 2017 4:29 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Heyi Guo ; Ni, > Ruiyu ; Laszlo Ersek > Subject: [PATCH] MdeModulePkg SerialDxe: Process ti

<    1   2   3   4   5   6   7   8   9   10   >