ncent [mailto:vincent.zim...@intel.com]
Sent: Wednesday, October 18, 2017 5:58 PM
To: Shah, Tapan ; edk2-devel@lists.01.org
Cc: Spottswood, Jason
Subject: RE: OSRecovery boot options
For #1.
Typically the OS. The platform already has its own PlatformRecovery.
For #2
There's a prototype av
Hi All,
I am looking at EDK2 implementation for OS Recovery boot options but could
not find a code in EDK2 which handles OSRecovery option creation and a code
to parse OSRecoveryOrder variable and launch OS Recovery boot options.
Questions:
1. Who is responsible to create OSRecover
Thanks for fixing this Ray.
Reviewed-by: Tapan Shah
-Original Message-
From: Ruiyu Ni [mailto:ruiyu...@intel.com]
Sent: Thursday, June 08, 2017 10:11 PM
To: edk2-devel@lists.01.org
Cc: Jaben Carsey ; Shah, Tapan
Subject: [PATCH] Shell/alias: Print detailed error when deleting alias
I would suggest to keep FILE/DIR tokens as-is to avoid more code changes. New
token for alias... to match the wording it can be "%s: not found."
-Original Message-
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Thursday, June 08, 2017 11:16 AM
To: Shah, Tapan ; Ni,
Correct.
STR_GEN_ERR_NOT_FOUND should be "alias: '' does not exist."
-Original Message-
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Thursday, June 08, 2017 11:10 AM
To: Shah, Tapan ; Ni, Ruiyu
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] [P
EFI_NOT_FOUND should be handled with the token I mentioned for a clear message.
All other errors should be printed using STR_GEN_ERR_UK.
-Original Message-
From: Ni, Ruiyu [mailto:ruiyu...@intel.com]
Sent: Wednesday, June 07, 2017 5:14 PM
To: Shah, Tapan
Cc: Carsey, Jaben ; edk2-devel
Reviewed-by: Tapan Shah
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hegde,
Nagaraj P
Sent: Thursday, June 08, 2017 1:41 AM
To: edk2-devel@lists.01.org
Cc: jaben.car...@intel.com; ruiyu...@intel.com; siyuan...@intel.com;
jiaxin...@intel.com
S
Ray,
I don't see your check-in includes the change I proposed below.
Tapan
-Original Message-
From: Shah, Tapan
Sent: Tuesday, June 06, 2017 5:03 PM
To: 'Carsey, Jaben' ; Ni, Ruiyu ;
edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH] ShellPkg/alias: Return s
Reviewed-by: Tapan Shah
-Original Message-
From: Ni, Ruiyu [mailto:ruiyu...@intel.com]
Sent: Tuesday, June 06, 2017 3:44 AM
To: Ni, Ruiyu ; edk2-devel@lists.01.org
Cc: Shah, Tapan
Subject: RE: [edk2] [PATCH] ShellPkg/parse: Handle Unicode stream from pipe
correctly
Including Tapan
Reviewed-by: Tapan Shah
-Original Message-
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Tuesday, June 06, 2017 4:37 PM
To: Ni, Ruiyu ; edk2-devel@lists.01.org
Cc: Shah, Tapan
Subject: RE: [edk2] [PATCH] ShellPkg/alias: Return status for alias deletion
I am good with more clear e
It's a bug and should be fixed.
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=589
Thanks,
Tapan
-Original Message-
From: Ni, Ruiyu [mailto:ruiyu...@intel.com]
Sent: Saturday, June 03, 2017 7:48 PM
To: Shah, Tapan ; Carsey, Jaben ;
edk2-devel@lists.01.org
Cc: Kinney, Mi
Cc: Kinney, Michael D ; Shah, Tapan
Subject: RE: [PATCH] ShellPkg/alias: Fix bug to support upper-case alias
Ok. I see now. Thanks!
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Ni, Ruiyu
> Sent: Thursday, June 01, 2017 7:32 PM
> To: Carsey, Jaben ; edk2-devel@
Agree on the number of includes in that header file.
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Friday, February 17, 2017 10:03 AM
To: Shah, Tapan ; Yao, Jiewen ;
Rebecca Cran ; edk2-devel@lists.01.org; Gao, Liming
Cc: Carsey, Jaben
Subject: RE: [edk2
Jaben agreed on this idea of having V1, V2 in UefiHandleParsingLib
when we decided to add FMP V1,V2,V3 decode support in 'dh' command. See
attached old discussion on this agreement.
From: Yao, Jiewen [mailto:jiewen@intel.com]
Sent: Thursday, February 16, 2017 5:13 PM
To: Shah, Tapan
UEFI Spec does not have old FMP image descriptor structures V1 and V2 defined.
MdePkg only follows the spec, so it contains the latest version # 3. But there
are still drivers using old V1, V2 revisions and Shell 'dh' command needs to
support decoding all revisions and needs to remain in ShellPk
Reviewed-by: Tapan Shah
-Original Message-
From: Ruiyu Ni [mailto:ruiyu...@intel.com]
Sent: Wednesday, January 25, 2017 10:34 PM
To: edk2-devel@lists.01.org
Cc: Jaben Carsey ; Phillips, Chris J (Plano, TX)
; Shah, Tapan
Subject: [PATCH] ShellPkg/cd: Do not print the destination dir
Reviewed-by: Tapan Shah
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni
Sent: Wednesday, December 07, 2016 7:45 PM
To: edk2-devel@lists.01.org
Cc: Jaben Carsey ; Chen A Chen
Subject: [edk2] [PATCH] ShellPkg/Application: Fix ">v" cannot u
Reviewed-by: Tapan Shah
-Original Message-
From: Ruiyu Ni [mailto:ruiyu...@intel.com]
Sent: Sunday, November 13, 2016 8:19 PM
To: edk2-devel@lists.01.org
Cc: Chen A Chen ; Jaben Carsey ;
Shah, Tapan
Subject: [PATCH v2] ShellPkg/dmpstore: Support "-sfo"
The patch adds
s for -l/-s flags and do it later after Shell spec. update.
Thanks,
Tapan
-Original Message-
From: Shah, Tapan
Sent: Friday, November 11, 2016 11:21 AM
To: 'Ruiyu Ni' ; edk2-devel@lists.01.org
Cc: Chen A Chen ; Jaben Carsey
Subject: RE: [PATCH] ShellPkg/dmpstore: Support "
: edk2-devel@lists.01.org
Cc: Chen A Chen ; Jaben Carsey ;
Shah, Tapan
Subject: [PATCH] ShellPkg/dmpstore: Support "-sfo"
The patch adds the "-sfo" support to "dmpstore" command.
1. For "-l" (load variable from file), when the variable
content can be update
tied with one flag, then add individual value as a flag
value. There are plenty of ShellPkg commands you can use as a reference.
-Original Message-
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Tuesday, October 18, 2016 12:04 PM
To: Vladimir Olovyannikov ; Shah, Tapan
Thanks for the contribution Vladimir!
Few comments:
1. It's better to refactor the code now before commit and move GPT related code
outside ShellPkg and create a shared library.
2. CLI parameters of this utility are too complex and need to be refactored to
make it similar to other existing Shell
Reviewed-by: Tapan Shah
-Original Message-
From: Vladimir Olovyannikov [mailto:vladimir.olovyanni...@broadcom.com]
Sent: Thursday, October 06, 2016 5:02 PM
To: edk2-devel@lists.01.org; Shah, Tapan ;
jaben.car...@intel.com
Cc: Vladimir Olovyannikov
Subject: [PATCH] ShellPkg: Fix
+if (EFI_ERROR(Status)) {
+ return Status;
+} <<<<<<<<<<<< Missing closing brace
Reviewed-by: Tapan Shah
-Original Message-
From: Vladimir Olovyannikov [mailto:vladimir.olovyanni...@broadcom.com]
Sent: Thursday, October 06, 2016 4:40
Can you send a patch file with this error check added @726 ?
-Original Message-
From: Vladimir Olovyannikov [mailto:vladimir.olovyanni...@broadcom.com]
Sent: Thursday, October 06, 2016 2:58 PM
To: Carsey, Jaben ; Shah, Tapan ;
edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH] ShellPkg
Yes, it has to be case insensitive per the latest Shell spec.
-Original Message-
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Wednesday, October 05, 2016 3:35 PM
To: Shah, Tapan ; Laszlo Ersek ; Andrew
Fish ; Daniil Egranov
Cc: edk2-devel-01 ; Leif Lindholm
; Carsey
; Daniil Egranov
Cc: Carsey, Jaben ; edk2-devel-01
; Leif Lindholm ; Shah, Tapan
Subject: Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the
Reference Platform
On 10/05/16 21:48, Andrew Fish wrote:
>
>> On Oct 5, 2016, at 12:24 PM, Daniil Egranov wrote:
>>
>
0:41 AM
To: Supreeth Venkatesh ; edk2-devel-01
; Shah, Tapan
Cc: Leif Lindholm ; Carsey, Jaben
Subject: RE: Assert in ShellPkg with latest tianocore edk2 source on the
Reference Platform
Tapan,
Could this be a side effect of your patch? Should we allow the UefiShellLib to
continue without this pr
Reviewed-By: Tapan Shah
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Shia,
Cinnamon
Sent: Monday, October 03, 2016 11:37 AM
To: edk2-devel@lists.01.org
Cc: jaben.car...@intel.com; ruiyu...@intel.com
Subject: [edk2] [PATCH v2] ShellPkg/Shell: U
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Tapan Shah
-Original Message-
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Thursday, September 22, 2016 4:14 PM
To: Shah, Tapan ; edk2-devel@lists.01.org
Cc: Carsey, Jaben
Subject: RE: [PATCH] ShellPkg
Typo. Missing company's copyright message in both changed files*
-Original Message-
From: Shah, Tapan
Sent: Thursday, September 08, 2016 12:09 PM
To: 'Laszlo Ersek' ; edk2-de...@ml01.01.org
Cc: Jaben Carsey ; Ruiyu Ni
Subject: RE: [edk2] [PATCH 0/2] ShellPkg: fix as
Missing company's copyright message in both changed filed. Code works fine on
NT32.
Reviewed-by: Tapan Shah
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Thursday, September 08, 2016 11:14 AM
To: edk2-de...@ml01.01.org
Cc:
Reviewed-by: Tapan Shah
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi
Sent: Wednesday, August 31, 2016 12:27 AM
To: edk2-devel@lists.01.org
Cc: Ruiyu Ni ; Jaben Carsey
Subject: [edk2] [patch] ShellPkg: Add the check of parameter numbe
Reviewed-by: Tapan Shah
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi
Sent: Wednesday, August 31, 2016 12:27 AM
To: edk2-devel@lists.01.org
Cc: Ruiyu Ni ; Jaben Carsey
Subject: [edk2] [patch] ShellPkg: Add check for "dump" parameter
Have you already pushed this change?
-Original Message-
From: Shah, Tapan
Sent: Tuesday, August 23, 2016 8:45 AM
To: 'Ruiyu Ni' ; edk2-devel@lists.01.org
Cc: Jaben Carsey
Subject: RE: [edk2] [PATCH 3/3] Revert "ShellPkg: Move
FindFirstCharacter/GetNextParameter to
Series Reviewed By: Tapan Shah
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni
Sent: Monday, August 22, 2016 9:56 PM
To: edk2-devel@lists.01.org
Cc: Jaben Carsey
Subject: [edk2] [PATCH 3/3] Revert "ShellPkg: Move
FindFirstCharacter/GetN
Series Reviewed By: Tapan Shah
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni
Sent: Tuesday, August 09, 2016 12:44 AM
To: edk2-devel@lists.01.org
Cc: Jaben Carsey
Subject: [edk2] [PATCH v2 1/6] ShellPkg: TAB logic incorrectly chops out
Series reviewed-by: Tapan Shah
-Original Message-
From: Hao Wu [mailto:hao.a...@intel.com]
Sent: Monday, June 06, 2016 8:49 PM
To: edk2-devel@lists.01.org; feng.t...@intel.com; Shah, Tapan
; El-Haj-Mahmoud, Samer
Subject: [PATCH v2 2/2] MdeModulePkg/RamDiskDxe: Add Memory Type
pdated on a real HW system.
Thanks,
Tapan
-Original Message-
From: Wu, Hao A [mailto:hao.a...@intel.com]
Sent: Thursday, June 02, 2016 9:18 PM
To: Shah, Tapan ; edk2-devel@lists.01.org
Cc: Carsey, Jaben ; Tian, Feng
Subject: RE: [edk2] [PATCH] MdeModulePkg/RamDiskDxe: Add RAW Ramdisk size
c
Done. See the latest patch files on reflector list.
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Thursday, June 02, 2016 12:24 PM
To: Shah, Tapan ; Gary Ching-Pang Lin
Cc: jaben.car...@intel.com; hao.a...@intel.com; edk2
: Qiu Shumin ; Jaben Carsey ;
Shah, Tapan
Subject: [PATCH] ShellPkg: Add NULL pointer check.
Add pointer check to avoid NULL pointer dereferenced.
Cc: Jaben Carsey
Cc: Tapan Shah
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
.../UefiHandleParsingLib
Jaben / Shumin,
Can you review this one-line fix?
Thanks,
Tapan
ShellPkg: Fix 'drivers' assert issue for a driver name longer than 35 characters
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off by: Tapan Shah mailto:tapands...@hp.com>>
Review
Feng / Star,
Can you review this fix?
Thanks,
Tapan
MdePkg: Perform Left Shift 32 bits of a 32-bit StartAddr[1] and EndingAddr[1]
instead of Right Shift when displaying 64-bit Start and End Address Value
StartAddr[1] and EndingAddr[1] are already a 32-bit val
43 matches
Mail list logo
