Re: [edk2] [PATCH v3] OvmfPkg: simply use the Bochs interface for vmsvga

2018-11-20 Thread yuchenlin via edk2-devel
On 2018-11-21 03:59, Laszlo Ersek wrote: On 11/07/18 18:06, Laszlo Ersek wrote: On 11/07/18 04:47, yuchen...@synology.com wrote: From: yuchenlin BAR |std vga | vmsvga - 0| Framebuffer | I/O space 1| Reserved | Framebuffer 2

Re: [edk2] [PATCH 0/4] OvmfPkg: revert some untimely pushed VMW SVGA reverts

2018-11-09 Thread yuchenlin via edk2-devel
2ea70e31285..revert_revert_bz_1319 -- OvmfPkg/ [nothing] Thanks, and sorry about the churn Laszlo Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Julien Grall Cc: Philippe Mathieu-Daudé Cc: yuchenlin Laszlo Ersek (4): Reapply "OvmfPkg: VMWare SVGA display device register defini

Re: [edk2] OVMF compile error

2018-11-06 Thread yuchenlin via edk2-devel
ule update --recursive And build it again. Thanks, yuchenlin ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH v3] OvmfPkg: simply use the Bochs interface for vmsvga

2018-11-06 Thread yuchenlin via edk2-devel
From: yuchenlin BAR |std vga | vmsvga - 0| Framebuffer | I/O space 1| Reserved | Framebuffer 2| MMIO | FIFO - We cannot recognize VMW SVGA as BOCHS because that would confuse the IsQxl setting in

Re: [edk2] [PATCH v2 5/5] OvmfPkg: simply use the Bochs interface for vmsvga

2018-11-06 Thread yuchenlin via edk2-devel
t range 62ea70e31285..328409ce8de7. Thanks Laszlo! A bit late, but 1-4 reviewed too. Thanks Laszlo Thank you for your effort on this series! Thanks, yuchenlin ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 5/5] OvmfPkg: simply use the Bochs interface for vmsvga

2018-11-06 Thread yuchenlin via edk2-devel
On 2018-11-06 19:47, Laszlo Ersek wrote: I suggest the following: On 11/02/18 04:24, yuchenlin via edk2-devel wrote: From: yuchenlin BAR |std vga | vmsvga - 0| Framebuffer | I/O space 1| Reserved | Framebuffer 2| MMIO

[edk2] [PATCH v2 3/5] Revert "OvmfPkg/QemuVideoDxe: Helper functions for unaligned port I/O."

2018-11-01 Thread yuchenlin via edk2-devel
From: yuchenlin This reverts commit 05a5379458725234de8a05780fcb5da2c12680e4. The VMWare SVGA display device implemented by Qemu (-vga vmware) uses an I/O-type BAR which is laid out such that some register offsets are not aligned to the read/write width with which they are expected to be

[edk2] [PATCH v2 5/5] OvmfPkg: simply use the Bochs interface for vmsvga

2018-11-01 Thread yuchenlin via edk2-devel
From: yuchenlin BAR |std vga | vmsvga - 0| Framebuffer | I/O space 1| Reserved | Framebuffer 2| MMIO | FIFO Because of the PCI BARs difference between std vga and vmsvga, we can not simply recognize the "QEMU VMWare

[edk2] [PATCH v2 0/5] OvmfPkg: simply use the Bochs interface for vmsvga

2018-11-01 Thread yuchenlin via edk2-devel
From: yuchenlin In this series, replace the original vmsvga driver to Bochs interface. Simply revert vmsvga driver implementation. After it, use Bochs interface for initializing vmsvga. Because of the PCI BARs difference between std vga and vmsvga. We can not simply recognize the "QEMU V

[edk2] [PATCH v2 2/5] Revert "OvmfPkg/QemuVideoDxe: VMWare SVGA device support"

2018-11-01 Thread yuchenlin via edk2-devel
From: yuchenlin This reverts commit c137d95081690d4877fbeb5f1856972e84ac32f2. The VMWare SVGA model now -- since commit 104bd1dc70 in QEMU -- falls back to stdvga (that is, Bochs) if we don't setup VMWare SVGA FIFO. To simplify QemuVideoDxe, we don't intend to implement the VMWare

[edk2] [PATCH v2 4/5] Revert "OvmfPkg: VMWare SVGA display device register definitions"

2018-11-01 Thread yuchenlin via edk2-devel
From: yuchenlin This reverts commit 9bcca53fe466cdff397578328d9d87d257aba493. We reverted VMWare SVGA driver. We don't need these definitions too. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: yuchenlin --- OvmfPkg/Include/IndustryStandard/VmwareSvga.h

[edk2] [PATCH v2 1/5] Revert "OvmfPkg/QemuVideoDxe: list "UnalignedIoInternal.h" in the INF file"

2018-11-01 Thread yuchenlin via edk2-devel
From: yuchenlin This reverts commit b2959e9f1a57279506ca46d56bc424fd7fa6b62a. The VMWare SVGA display device implemented by Qemu (-vga vmware) uses an I/O-type BAR which is laid out such that some register offsets are not aligned to the read/write width with which they are expected to be

Re: [edk2] [PATCH 0/4] OvmfPkg: simply use the Bochs interface for vmsvga

2018-11-01 Thread yuchenlin via edk2-devel
On 2018-11-02 03:02, Philippe Mathieu-Daudé wrote: Hi Yu-chen Lin, On 24/10/18 8:40, yuchen...@synology.com wrote: From: yuchenlin In this series, replace the original vmsvga driver to Bochs interface. This is the 'v2' of your previous patch 'OvmfPkg: initialize bochs wh

Re: [edk2] [PATCH 1/4] Revert "OvmfPkg/QemuVideoDxe: VMWare SVGA device support"

2018-11-01 Thread yuchenlin via edk2-devel
On 2018-11-02 02:58, Philippe Mathieu-Daudé wrote: Hi Yu-chen Lin, On 24/10/18 8:40, yuchen...@synology.com wrote: From: yuchenlin This reverts commit c137d95081690d4877fbeb5f1856972e84ac32f2. Can we have a comment here about why we need to revert this patch? (same for patches 2 and 3

Re: [edk2] [PATCH 4/4] OvmfPkg: simply use the Bochs interface for vmsvga

2018-11-01 Thread yuchenlin via edk2-devel
On 2018-11-02 02:54, Philippe Mathieu-Daudé wrote: Hi Yu-chen Lin, On 24/10/18 8:40, yuchen...@synology.com wrote: From: yuchenlin BAR |std vga | vmsvga - 0| Framebuffer | I/O space 1| Reserved | Framebuffer 2| MMIO

[edk2] [PATCH 4/4] OvmfPkg: simply use the Bochs interface for vmsvga

2018-10-23 Thread yuchenlin
From: yuchenlin BAR |std vga | vmsvga - 0| Framebuffer | I/O space 1| Reserved | Framebuffer 2| MMIO | FIFO Because of the PCI BARs difference between std vga and vmsvga, we can not simply recognize the "QEMU VMWare

[edk2] [PATCH 2/4] Revert "OvmfPkg/QemuVideoDxe: Helper functions for unaligned port I/O."

2018-10-23 Thread yuchenlin
From: yuchenlin This reverts commit 05a5379458725234de8a05780fcb5da2c12680e4. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: yuchenlin --- OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf | 6 -- OvmfPkg/QemuVideoDxe/UnalignedIoGcc.c | 70

[edk2] [PATCH 3/4] Revert "OvmfPkg/QemuVideoDxe: list "UnalignedIoInternal.h" in the INF file"

2018-10-23 Thread yuchenlin
From: yuchenlin This reverts commit b2959e9f1a57279506ca46d56bc424fd7fa6b62a. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: yuchenlin --- OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf | 1 - 1 file changed, 1 deletion(-) diff --git a/OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf b

[edk2] [PATCH 0/4] OvmfPkg: simply use the Bochs interface for vmsvga

2018-10-23 Thread yuchenlin
From: yuchenlin In this series, replace the original vmsvga driver to Bochs interface. Simply revert vmsvga driver implementation. After it, use Bochs interface for initializing vmsvga. Because of the PCI BARs difference between std vga and vmsvga. We can not simply recognize the "QEMU V

[edk2] [PATCH 1/4] Revert "OvmfPkg/QemuVideoDxe: VMWare SVGA device support"

2018-10-23 Thread yuchenlin
From: yuchenlin This reverts commit c137d95081690d4877fbeb5f1856972e84ac32f2. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: yuchenlin --- OvmfPkg/QemuVideoDxe/Driver.c | 135 + OvmfPkg/QemuVideoDxe/Gop.c| 65 + OvmfPkg

Re: [edk2] [PATCH] OvmfPkg: initialize bochs when initializing vmsvga

2018-10-23 Thread yuchenlin
e device model. As I wrote previously, it's quite telling that the consequences of QEMU commit 104bd1dc70, from release v2.10.0, are reported only now, more than a year after the release -- VMW SVGA must not be a very popular device model. Yuchenlin, can you then please investigate this a

Re: [edk2] [PATCH] OvmfPkg: initialize bochs when initializing vmsvga

2018-10-23 Thread yuchenlin
ote: From: yuchenlin When driver doesn't set fifo config, the vmsvga will fall back to std vga. However, we don't initialize vbe related port. It causes blank screen in qemu console. (2) The words "when driver doesn't set fifo config" tell me nothing. The QemuVideoDxe direc

[edk2] [PATCH] OvmfPkg: initialize bochs when initializing vmsvga

2018-10-22 Thread yuchenlin
From: yuchenlin When driver doesn't set fifo config, the vmsvga will fall back to std vga. However, we don't initialize vbe related port. It causes blank screen in qemu console. This patch will fix "Guest has not initialized the display (yet)" when using qemu -device v