Re: [edk2] [PATCH] CryptoPkg: Fix various typos

2019-02-07 Thread Laszlo Ersek
On 02/07/19 15:59, Philippe Mathieu-Daudé wrote: > On 2/7/19 2:04 PM, Ryszard Knop wrote: >> Hi Philippe, Antoine, >> >> On Wed, 2019-02-06 at 23:30 +0100, Philippe Mathieu-Daudé wrote: >>> Hi Antoine, >>> >>> On 2/6/19 6:24 PM, Antoine Coeur wrote: Fix various typos in CryptoPkg. Co

Re: [edk2] [PATCH] CryptoPkg: Fix various typos

2019-02-07 Thread Antoine Coeur
> My wonder is about what is the correct use between succeeds/succeeded, > I'd expect the following diff: > > - @retval TRUE The time convertion succeeds. > + @retval TRUE The time conversion succeeded. In doubt, I'll just ignore this one. I made a v2 to address Jian review. Thank you for revie

Re: [edk2] [PATCH] CryptoPkg: Fix various typos

2019-02-07 Thread Philippe Mathieu-Daudé
On 2/7/19 2:04 PM, Ryszard Knop wrote: > Hi Philippe, Antoine, > > On Wed, 2019-02-06 at 23:30 +0100, Philippe Mathieu-Daudé wrote: >> Hi Antoine, >> >> On 2/6/19 6:24 PM, Antoine Coeur wrote: >>> Fix various typos in CryptoPkg. >>> >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> S

Re: [edk2] [PATCH] CryptoPkg: Fix various typos

2019-02-07 Thread Ryszard Knop
Hi Philippe, Antoine, On Wed, 2019-02-06 at 23:30 +0100, Philippe Mathieu-Daudé wrote: > Hi Antoine, > > On 2/6/19 6:24 PM, Antoine Coeur wrote: > > Fix various typos in CryptoPkg. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Coeur > > --- > > CryptoPkg/Li

Re: [edk2] [PATCH] CryptoPkg: Fix various typos

2019-02-06 Thread Wang, Jian J
Coeur, > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Antoine Coeur > Sent: Thursday, February 07, 2019 1:25 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH] CryptoPkg: Fix various typos > > Fix va

Re: [edk2] [PATCH] CryptoPkg: Fix various typos

2019-02-06 Thread Philippe Mathieu-Daudé
Hi Antoine, On 2/6/19 6:24 PM, Antoine Coeur wrote: > Fix various typos in CryptoPkg. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Coeur > --- > CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c | 2 +- > CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 4

[edk2] [PATCH] CryptoPkg: Fix various typos

2019-02-06 Thread Antoine Coeur
Fix various typos in CryptoPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c | 2 +- CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git