Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

2016-07-21 Thread Tian, Feng
:40 AM To: Tian, Feng <feng.t...@intel.com>; Ard Biesheuvel <ard.biesheu...@linaro.org>; Charles Garcia-Tobin <charles.garcia-to...@arm.com> Cc: edk2-devel-01 <edk2-devel@lists.01.org> Subject: Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data Hi Feng, I have to say tha

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

2016-07-21 Thread Haojian Zhuang
harles Garcia-Tobin <charles.garcia-to...@arm.com> Cc: edk2-devel-01 <edk2-devel@lists.01.org> Subject: Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data On 2016/7/21 19:24, Ard Biesheuvel wrote: On 21 July 2016 at 13:17, Haojian Zhuang <haojian.zhu...@linaro.org> wrote: On

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

2016-07-21 Thread Tian, Feng
Of Haojian Zhuang Sent: Thursday, July 21, 2016 9:40 PM To: Ard Biesheuvel <ard.biesheu...@linaro.org>; Charles Garcia-Tobin <charles.garcia-to...@arm.com> Cc: edk2-devel-01 <edk2-devel@lists.01.org> Subject: Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data On 2016/7/21 19:

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

2016-07-21 Thread Haojian Zhuang
On 2016/7/21 19:24, Ard Biesheuvel wrote: On 21 July 2016 at 13:17, Haojian Zhuang wrote: On 2016/7/21 9:52, Haojian Zhuang wrote: 在 07/21/2016 09:51 AM, Haojian Zhuang 写道: Hi Feng, I think the main difference is who to handle the CRC bits. In the designware

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

2016-07-21 Thread Ard Biesheuvel
On 21 July 2016 at 13:17, Haojian Zhuang wrote: > On 2016/7/21 9:52, Haojian Zhuang wrote: >> >> >> >> 在 07/21/2016 09:51 AM, Haojian Zhuang 写道: >>> >>> Hi Feng, >>> >>> I think the main difference is who to handle the CRC bits. In the >>> designware emmc/sd controller,

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

2016-07-21 Thread Haojian Zhuang
On 2016/7/21 9:52, Haojian Zhuang wrote: 在 07/21/2016 09:51 AM, Haojian Zhuang 写道: Hi Feng, I think the main difference is who to handle the CRC bits. In the designware emmc/sd controller, the whole 128-bit value is loaded into the four response registers. There's no any shift on the 128-bit

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

2016-07-20 Thread Tian, Feng
f Of Haojian Zhuang Sent: Tuesday, July 19, 2016 3:38 PM To: Tian, Feng <feng.t...@intel.com> Cc: Haojian Zhuang <haojian.zhu...@linaro.org>; edk2-devel@lists.01.org; guodong...@linaro.org; leif.lindh...@linaro.org; ard.biesheu...@linaro.org Subject: [edk2] [PATCH] EmmcBlockIo: fix to get CSD

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

2016-07-19 Thread Tian, Feng
: Tuesday, July 19, 2016 3:38 PM To: Tian, Feng <feng.t...@intel.com> Cc: Haojian Zhuang <haojian.zhu...@linaro.org>; edk2-devel@lists.01.org; guodong...@linaro.org; leif.lindh...@linaro.org; ard.biesheu...@linaro.org Subject: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data The C

[edk2] [PATCH] EmmcBlockIo: fix to get CSD data

2016-07-19 Thread Haojian Zhuang
The CSD structure is a 128-bit structure. But EmmcGetCsd() only loads 120 bits with 8-bit offset. Now fix it. Signed-off-by: Haojian Zhuang --- MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git