Re: [edk2] [PATCH] uefi-sct/SctPkg:Add conformance test cases for deprecated EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS attribute.

2018-10-26 Thread Leif Lindholm
Laszlo, many thanks for this. Cc:ing some new(ish) maintainers. / Leif On Wed, Oct 17, 2018 at 02:04:01PM +0200, Laszlo Ersek wrote: > Hi Leif, > > On 10/16/18 04:28, Leif Lindholm wrote: > > > Laszlo: a few years ago, you also posted a _really_ useful email about > > the process of being

Re: [edk2] [PATCH] uefi-sct/SctPkg:Add conformance test cases for deprecated EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS attribute.

2018-10-17 Thread Laszlo Ersek
Hi Leif, On 10/16/18 04:28, Leif Lindholm wrote: > Laszlo: a few years ago, you also posted a _really_ useful email about > the process of being a maintainer, and helpful workflows (like "sort > emails to review immediately on reception, even if you don't have time > to review now"). I have

Re: [edk2] [PATCH] uefi-sct/SctPkg:Add conformance test cases for deprecated EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS attribute.

2018-10-16 Thread Supreeth Venkatesh
Reviewed-by: Supreeth Venkatesh If the commit message is broken down into multiple lines less than 80 cols. On 10/13/2018 04:19 PM, Eric Jin wrote: Cc: Supreeth Venkatesh Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin ---

Re: [edk2] [PATCH] uefi-sct/SctPkg:Add conformance test cases for deprecated EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS attribute.

2018-10-15 Thread Leif Lindholm
Hi Eric, 1) Really happy to see the first SCT patch out for public review! 2) Could you go through Laszlo's excellent guide for contributions at https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers ? Specifically the bits

Re: [edk2] [PATCH] uefi-sct/SctPkg:Add conformance test cases for deprecated EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS attribute.

2018-10-15 Thread Supreeth Venkatesh
FYI On 10/15/2018 03:46 AM, Supreeth Venkatesh wrote: Reviewed-by: Supreeth Venkatesh If the commit message is broken down into multiple lines less than 80 cols. On 10/13/2018 04:19 PM, Eric Jin wrote: Cc: Supreeth Venkatesh

[edk2] [PATCH] uefi-sct/SctPkg:Add conformance test cases for deprecated EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS attribute.

2018-10-13 Thread Eric Jin
Cc: Supreeth Venkatesh Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin --- .../AuthVariableServicesBBTestConformance.c | 143 ++ .../VariableServices/BlackBoxTest/Guid.c | 6 +- .../VariableServices/BlackBoxTest/Guid.h