Re: [edk2] [PATCH 03/11] MdeModulePkg/BaseResetSystemLibNull: Implement ResetPlatformSpecific

2016-08-22 Thread Ni, Ruiyu
Feng, The spec says " If the platform does not recognize the EFI_GUID in ResetData the platform must pick a supported reset type to perform". For the NULL instance of ResetSystemLib, I treat it as an implementation for a Certain platform, then it's ok to let it pick a supported reset type to per

Re: [edk2] [PATCH 03/11] MdeModulePkg/BaseResetSystemLibNull: Implement ResetPlatformSpecific

2016-08-22 Thread Tian, Feng
Do you need directly assert in ResetPlatformSpecific() for this NULL instance? Other series look good to me Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Wednesday, August 10, 2016 1:56 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Chan, Amy Subject: [

[edk2] [PATCH 03/11] MdeModulePkg/BaseResetSystemLibNull: Implement ResetPlatformSpecific

2016-08-09 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Feng Tian Cc: Amy Chan --- .../BaseResetSystemLibNull.c | 23 +- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Library/BaseResetSystemLibNu