Re: [edk2] [PATCH 1/9] edksetup.sh: Create the Conf directory if necessary

2016-03-08 Thread Andrew Fish
Leroy P >> Cc: Justen, Jordan L; edk2-devel@lists.01.org; Bjorge, Erik C >> Subject: Re: [edk2] [PATCH 1/9] edksetup.sh: Create the Conf directory if >> necessary >> >> >>> On Mar 4, 2016, at 8:54 AM, Lee Leahy wrote: >>> >>&g

Re: [edk2] [PATCH 1/9] edksetup.sh: Create the Conf directory if necessary

2016-03-06 Thread Gao, Liming
Behalf Of > Andrew Fish > Sent: Saturday, March 05, 2016 2:51 AM > To: Leahy, Leroy P > Cc: Justen, Jordan L; edk2-devel@lists.01.org; Bjorge, Erik C > Subject: Re: [edk2] [PATCH 1/9] edksetup.sh: Create the Conf directory if > necessary > > > > On Mar 4, 2016, at 8:5

Re: [edk2] [PATCH 1/9] edksetup.sh: Create the Conf directory if necessary

2016-03-06 Thread Gao, Liming
-Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jordan Justen > Sent: Saturday, March 05, 2016 2:23 AM > To: Leahy, Leroy P; edk2-devel@lists.01.org; Bjorge, Erik C > Cc: Kinney, Michael D > Subject: Re: [edk2] [PATCH 1/

Re: [edk2] [PATCH 1/9] edksetup.sh: Create the Conf directory if necessary

2016-03-04 Thread Andrew Fish
> On Mar 4, 2016, at 8:54 AM, Lee Leahy wrote: > > Edit the shell script to determine if the Conf directory is present. If > not then create the Conf directory. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Lee Leahy > --- > edksetup.sh | 4 > 1 file changed

Re: [edk2] [PATCH 1/9] edksetup.sh: Create the Conf directory if necessary

2016-03-04 Thread Jordan Justen
On 2016-03-04 08:54:44, Lee Leahy wrote: > Edit the shell script to determine if the Conf directory is present. If > not then create the Conf directory. > With PACKAGES_PATH, I think it might be possible that WORKSPACE is not defined. Mike mentioned that in some scenario my usage of WORKSPACE i

Re: [edk2] [PATCH 1/9] edksetup.sh: Create the Conf directory if necessary

2016-03-04 Thread Andrew Fish
> On Mar 4, 2016, at 8:54 AM, Lee Leahy wrote: > > Edit the shell script to determine if the Conf directory is present. If > not then create the Conf directory. > Lee, What use case is this fixing? The Conf directory is checked into source control? https://github.com/tianocore/edk2/tree/mas

Re: [edk2] [PATCH 1/9] edksetup.sh: Create the Conf directory if necessary

2016-03-04 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge > -Original Message- > From: Leahy, Leroy P > Sent: Friday, March 4, 2016 8:55 AM > To: Justen, Jordan L ; edk2- > de...@lists.01.org; Bjorge, Erik C > Cc: Leahy, Leroy P > Subject: [PATCH 1/9] edksetup.sh: Create the Conf directory if necessary > > Edit the sh

[edk2] [PATCH 1/9] edksetup.sh: Create the Conf directory if necessary

2016-03-04 Thread Lee Leahy
Edit the shell script to determine if the Conf directory is present. If not then create the Conf directory. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Lee Leahy --- edksetup.sh | 4 1 file changed, 4 insertions(+) diff --git a/edksetup.sh b/edksetup.sh index 57