Re: [edk2] [PATCH v4 2/3] ArmVirtPkg: Fix build failure due to Tftp library removal

2017-12-01 Thread Laszlo Ersek
On 12/01/17 02:48, Ni, Ruiyu wrote: > Laszlo, > Thank you very much for that! I will try to become a talkaholic > when writing commit messages next time. I feel a bit of sarcasm directed at me in "talkaholic" :) I do deserve that classification, no questions asked :) Thanks! Laszlo

Re: [edk2] [PATCH v4 2/3] ArmVirtPkg: Fix build failure due to Tftp library removal

2017-11-30 Thread Ni, Ruiyu
t.com> > Cc: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH v4 2/3] ArmVirtPkg: Fix build failure due to Tftp > library removal > > On 30 November 2017 at 12:22, Laszlo Ersek <ler...@redhat.com> wrote: > > On 11/29/17 14:53, Laszlo

Re: [edk2] [PATCH v4 2/3] ArmVirtPkg: Fix build failure due to Tftp library removal

2017-11-30 Thread Ard Biesheuvel
On 30 November 2017 at 12:22, Laszlo Ersek wrote: > On 11/29/17 14:53, Laszlo Ersek wrote: >> Ray, >> >> On 11/29/17 11:14, Ruiyu Ni wrote: >>> The TFTP command was converted from a NULL class library >>> instance to a dynamic shell command in commit 0961002352e9. >>> >>>

Re: [edk2] [PATCH v4 2/3] ArmVirtPkg: Fix build failure due to Tftp library removal

2017-11-30 Thread Laszlo Ersek
On 11/29/17 14:53, Laszlo Ersek wrote: > Ray, > > On 11/29/17 11:14, Ruiyu Ni wrote: >> The TFTP command was converted from a NULL class library >> instance to a dynamic shell command in commit 0961002352e9. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ruiyu Ni

Re: [edk2] [PATCH v4 2/3] ArmVirtPkg: Fix build failure due to Tftp library removal

2017-11-29 Thread Laszlo Ersek
Ray, On 11/29/17 11:14, Ruiyu Ni wrote: > The TFTP command was converted from a NULL class library > instance to a dynamic shell command in commit 0961002352e9. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Reviewed-by: Laszlo Ersek

[edk2] [PATCH v4 2/3] ArmVirtPkg: Fix build failure due to Tftp library removal

2017-11-29 Thread Ruiyu Ni
The TFTP command was converted from a NULL class library instance to a dynamic shell command in commit 0961002352e9. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Reviewed-by: Laszlo Ersek Cc: Ard Biesheuvel