Re: [edk2] [PATCH v5 2/6] OvmfPkg/PciHostBridgeLib: Init PCI aperture to 0

2018-03-05 Thread Guo Heyi
On Fri, Mar 02, 2018 at 11:19:31AM +0100, Laszlo Ersek wrote: > On 03/01/18 11:48, Guo Heyi wrote: > > On Thu, Mar 01, 2018 at 11:17:30AM +0100, Laszlo Ersek wrote: > >> On 03/01/18 07:57, Heyi Guo wrote: > > >>> diff --git a/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c > >>>

Re: [edk2] [PATCH v5 2/6] OvmfPkg/PciHostBridgeLib: Init PCI aperture to 0

2018-03-02 Thread Laszlo Ersek
On 03/01/18 11:48, Guo Heyi wrote: > On Thu, Mar 01, 2018 at 11:17:30AM +0100, Laszlo Ersek wrote: >> On 03/01/18 07:57, Heyi Guo wrote: >>> diff --git a/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c >>> b/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c >>> index 31c63ae19e0a..aaf101dfcb0e 100644

Re: [edk2] [PATCH v5 2/6] OvmfPkg/PciHostBridgeLib: Init PCI aperture to 0

2018-03-02 Thread Laszlo Ersek
On 03/01/18 13:03, Ni, Ruiyu wrote: > On 3/1/2018 6:20 PM, Laszlo Ersek wrote: >> On 03/01/18 07:57, Heyi Guo wrote: >>> Use ZeroMem to initialize all fields in temporary >>> PCI_ROOT_BRIDGE_APERTURE variables to zero. This is not mandatory but >>> is helpful for future extension: when we add new

Re: [edk2] [PATCH v5 2/6] OvmfPkg/PciHostBridgeLib: Init PCI aperture to 0

2018-03-01 Thread Ni, Ruiyu
On 3/1/2018 6:20 PM, Laszlo Ersek wrote: On 03/01/18 07:57, Heyi Guo wrote: Use ZeroMem to initialize all fields in temporary PCI_ROOT_BRIDGE_APERTURE variables to zero. This is not mandatory but is helpful for future extension: when we add new fields to PCI_ROOT_BRIDGE_APERTURE and the default

Re: [edk2] [PATCH v5 2/6] OvmfPkg/PciHostBridgeLib: Init PCI aperture to 0

2018-03-01 Thread Guo Heyi
On Thu, Mar 01, 2018 at 11:17:30AM +0100, Laszlo Ersek wrote: > Hello Heyi, > > On 03/01/18 07:57, Heyi Guo wrote: > > Use ZeroMem to initialize all fields in temporary > > PCI_ROOT_BRIDGE_APERTURE variables to zero. This is not mandatory but > > is helpful for future extension: when we add new

Re: [edk2] [PATCH v5 2/6] OvmfPkg/PciHostBridgeLib: Init PCI aperture to 0

2018-03-01 Thread Guo Heyi
Thanks; I got some trouble in making the subject short and clear :) Regards, Heyi On Thu, Mar 01, 2018 at 11:20:22AM +0100, Laszlo Ersek wrote: > On 03/01/18 07:57, Heyi Guo wrote: > > Use ZeroMem to initialize all fields in temporary > > PCI_ROOT_BRIDGE_APERTURE variables to zero. This is not

Re: [edk2] [PATCH v5 2/6] OvmfPkg/PciHostBridgeLib: Init PCI aperture to 0

2018-03-01 Thread Laszlo Ersek
On 03/01/18 07:57, Heyi Guo wrote: > Use ZeroMem to initialize all fields in temporary > PCI_ROOT_BRIDGE_APERTURE variables to zero. This is not mandatory but > is helpful for future extension: when we add new fields to > PCI_ROOT_BRIDGE_APERTURE and the default value of these fields can > safely

Re: [edk2] [PATCH v5 2/6] OvmfPkg/PciHostBridgeLib: Init PCI aperture to 0

2018-03-01 Thread Laszlo Ersek
Hello Heyi, On 03/01/18 07:57, Heyi Guo wrote: > Use ZeroMem to initialize all fields in temporary > PCI_ROOT_BRIDGE_APERTURE variables to zero. This is not mandatory but > is helpful for future extension: when we add new fields to > PCI_ROOT_BRIDGE_APERTURE and the default value of these fields

[edk2] [PATCH v5 2/6] OvmfPkg/PciHostBridgeLib: Init PCI aperture to 0

2018-02-28 Thread Heyi Guo
Use ZeroMem to initialize all fields in temporary PCI_ROOT_BRIDGE_APERTURE variables to zero. This is not mandatory but is helpful for future extension: when we add new fields to PCI_ROOT_BRIDGE_APERTURE and the default value of these fields can safely be zero, this code will not suffer from an