Re: [edk2] [Patch] MdePkg IndustryStandard: Add DDR3, DDR4 and LPDDR definition per SPD spec

2016-11-14 Thread Gao, Liming
Giri: Thanks for your feedback. I like idea 1 to separate them like ACPI, and define every structure for each device type. I will refine the patch and sent V2. Thanks Liming > -Original Message- > From: Mudusuru, Giri P > Sent: Tuesday, November 15, 2016 6:02 AM > To: Gao, Liming

Re: [edk2] [Patch] MdePkg IndustryStandard: Add DDR3, DDR4 and LPDDR definition per SPD spec

2016-11-14 Thread Mudusuru, Giri P
Thanks Liming for the patch. Few comments below 1) can we split the file into multiple files based on DDR technology like DDR3, DDR4? SdramSpd.h will include others files similar to Acpi.h or Pci.h. May be SdramSpdDdr3.h, SdramSpdDdr4.h etc.. 2) change from 116-102 to 102-116 for consistency

[edk2] [Patch] MdePkg IndustryStandard: Add DDR3, DDR4 and LPDDR definition per SPD spec

2016-11-11 Thread Liming Gao
https://bugzilla.tianocore.org/show_bug.cgi?id=201 Cc: Giri P Mudusuru Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- MdePkg/Include/IndustryStandard/SdramSpd.h | 1682 +++- 1 file