Re: [edk2] [Patch 05/10] OvmfPkg: Add SafeIntLib and BmpSupportLib to DSC files

2018-02-08 Thread Laszlo Ersek
On 02/08/18 10:32, Ard Biesheuvel wrote: > On 8 February 2018 at 09:25, Laszlo Ersek wrote: >> On 02/08/18 09:32, Jordan Justen wrote: >> >>> Given the wording from the contribution agreement, it appears that it >>> would also be fine to just use Mike's Signed-off-by if he is >>> authorized to con

Re: [edk2] [Patch 05/10] OvmfPkg: Add SafeIntLib and BmpSupportLib to DSC files

2018-02-08 Thread Ard Biesheuvel
On 8 February 2018 at 09:25, Laszlo Ersek wrote: > On 02/08/18 09:32, Jordan Justen wrote: > >> Given the wording from the contribution agreement, it appears that it >> would also be fine to just use Mike's Signed-off-by if he is >> authorized to contribute the code even though he didn't author it

Re: [edk2] [Patch 05/10] OvmfPkg: Add SafeIntLib and BmpSupportLib to DSC files

2018-02-08 Thread Laszlo Ersek
On 02/08/18 09:32, Jordan Justen wrote: > Given the wording from the contribution agreement, it appears that it > would also be fine to just use Mike's Signed-off-by if he is > authorized to contribute the code even though he didn't author it. So basically just """ Contributed-under: TianoCo

Re: [edk2] [Patch 05/10] OvmfPkg: Add SafeIntLib and BmpSupportLib to DSC files

2018-02-08 Thread Laszlo Ersek
On 02/08/18 08:43, Ard Biesheuvel wrote: > On 8 February 2018 at 01:35, Laszlo Ersek wrote: >> On 02/08/18 00:48, Kinney, Michael D wrote: >>> Laszlo, >>> >>> The BmpSupportLib content was from contributions from >>> a capsule related branch. However, the BmpSupportLib >>> can be used for UX caps

Re: [edk2] [Patch 05/10] OvmfPkg: Add SafeIntLib and BmpSupportLib to DSC files

2018-02-08 Thread Jordan Justen
On 2018-02-07 23:43:44, Ard Biesheuvel wrote: > On 8 February 2018 at 01:35, Laszlo Ersek wrote: > > On 02/08/18 00:48, Kinney, Michael D wrote: > >> Laszlo, > >> > >> The BmpSupportLib content was from contributions from > >> a capsule related branch. However, the BmpSupportLib > >> can be used

Re: [edk2] [Patch 05/10] OvmfPkg: Add SafeIntLib and BmpSupportLib to DSC files

2018-02-07 Thread Ard Biesheuvel
On 8 February 2018 at 01:35, Laszlo Ersek wrote: > On 02/08/18 00:48, Kinney, Michael D wrote: >> Laszlo, >> >> The BmpSupportLib content was from contributions from >> a capsule related branch. However, the BmpSupportLib >> can be used for UX capsules as well as other places that >> conversions

Re: [edk2] [Patch 05/10] OvmfPkg: Add SafeIntLib and BmpSupportLib to DSC files

2018-02-07 Thread Laszlo Ersek
On 02/08/18 00:48, Kinney, Michael D wrote: > Laszlo, > > The BmpSupportLib content was from contributions from > a capsule related branch. However, the BmpSupportLib > can be used for UX capsules as well as other places that > conversions between BMP and GOP BLT buffers are needed, > so it is

Re: [edk2] [Patch 05/10] OvmfPkg: Add SafeIntLib and BmpSupportLib to DSC files

2018-02-07 Thread Kinney, Michael D
Laszlo, The BmpSupportLib content was from contributions from a capsule related branch. However, the BmpSupportLib can be used for UX capsules as well as other places that conversions between BMP and GOP BLT buffers are needed, so it is a more generic feature. The SafeIntLib was also based on

Re: [edk2] [Patch 05/10] OvmfPkg: Add SafeIntLib and BmpSupportLib to DSC files

2018-02-07 Thread Laszlo Ersek
Hi Mike, On 02/07/18 23:58, Kinney, Michael D wrote: > From: Michael D Kinney > > https://bugzilla.tianocore.org/show_bug.cgi?id=800 > > Based on content from the following branch/commits: > https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport > https://github.com/Microsoft/MS_UEFI/

[edk2] [Patch 05/10] OvmfPkg: Add SafeIntLib and BmpSupportLib to DSC files

2018-02-07 Thread Kinney, Michael D
From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=800 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport https://github.com/Microsoft/MS_UEFI/commit/33bab4031a417d7d5a7d356c15a14c2e60302b2d https://github.com/M