On 12/08/2016 05:11 PM, Andrew Fish wrote:
On Dec 8, 2016, at 9:27 AM, Kurt Kennett wrote:
This seems kind of silly.
Why isn't this just const data? This adds code and memory accesses that are
worthless and happen on every call to the function.
K2,
I think this is an attempt to conform to
tt mailto:kurt.kenn...@microsoft.com>>
Cc: Yao, Jiewen mailto:jiewen@intel.com>>; Bi, Dandan
mailto:dandan...@intel.com>>;
edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>; Ni, Ruiyu
mailto:ruiyu...@intel.com>>
Subject: Re: [edk2] [patch 2/8] FatPkg\Enhanc
Got it ! I will submit a new patch. Thanks!
Regards,
Dandan
-Original Message-
From: Ni, Ruiyu
Sent: Friday, December 9, 2016 8:58 AM
To: Bi, Dandan ; edk2-devel@lists.01.org
Subject: RE: [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable after
declaration
Dandan,
Could you please
Dandan,
Could you please create a global array mMonthDays?
UINT8 mMonthDays[] = { 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 };
Regards,
Ray
>-Original Message-
>From: Bi, Dandan
>Sent: Thursday, December 8, 2016 6:54 PM
>To: edk2-devel@lists.01.org
>Cc: Ni, Ruiyu
>Subject: [patch 2
M
To: Kurt Kennett
Cc: Yao, Jiewen ; Bi, Dandan ;
edk2-devel@lists.01.org; Ni, Ruiyu
Subject: Re: [edk2] [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable
after declaration
> On Dec 8, 2016, at 4:26 PM, Kurt Kennett wrote:
>
> Is the data 'variable'? i.e does it ever
-devel@lists.01.org; Ni, Ruiyu
Subject: Re: [edk2] [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable
after declaration
> On Dec 8, 2016, at 4:26 PM, Kurt Kennett
> mailto:kurt.kenn...@microsoft.com>> wrote:
>
> Is the data 'variable'? i.e does it ever change?
] On Behalf Of
>> Kurt Kennett
>> Sent: Friday, December 9, 2016 1:28 AM
>> To: Bi, Dandan ; edk2-devel@lists.01.org
>> Cc: Ni, Ruiyu
>> Subject: Re: [edk2] [patch 2/8] FatPkg\EnhancedFatDxe: Initialize
>> variable after declaration
>>
>> This seems k
com]
Sent: Thursday, December 8, 2016 3:47 PM
To: Kurt Kennett ; Bi, Dandan
; edk2-devel@lists.01.org
Cc: Ni, Ruiyu
Subject: RE: [edk2] [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable
after declaration
Agree. Maybe we can move it to be a global variable ?
Thank you
Yao Jiewen
> -Ori
> Cc: Ni, Ruiyu
> Subject: Re: [edk2] [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable
> after
> declaration
>
> This seems kind of silly.
> Why isn't this just const data? This adds code and memory accesses that are
> worthless and happen on every call to the
To: edk2-devel@lists.01.org
> Cc: Ruiyu Ni
> Subject: [edk2] [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable after
> declaration
>
> Cc: Ruiyu Ni
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi
> ---
> FatPkg/EnhancedFatDxe/M
ber 8, 2016 2:54 AM
To: edk2-devel@lists.01.org
Cc: Ruiyu Ni
Subject: [edk2] [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable after
declaration
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
FatPkg/EnhancedFatDxe/Misc.c | 14
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
FatPkg/EnhancedFatDxe/Misc.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/FatPkg/EnhancedFatDxe/Misc.c b/FatPkg/EnhancedFatDxe/Misc.c
index f91759c..6ad688c 100
12 matches
Mail list logo
