Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

2016-07-19 Thread Tian, Feng
Hi, Haojian Why I didn't get the lowest byte data is because it's CRC field. I thought nobody will care about it. My assumption is incorrect for your usage model? Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Haojian Zhuang Sent:

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

2016-07-20 Thread Tian, Feng
ssage- From: Tian, Feng Sent: Wednesday, July 20, 2016 10:13 AM To: Haojian Zhuang Cc: edk2-devel@lists.01.org; guodong...@linaro.org; leif.lindh...@linaro.org; ard.biesheu...@linaro.org; Tian, Feng Subject: RE: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data Hi, Haojian Why I didn'

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

2016-07-20 Thread Haojian Zhuang
esday, July 20, 2016 10:13 AM To: Haojian Zhuang Cc: edk2-devel@lists.01.org; guodong...@linaro.org; leif.lindh...@linaro.org; ard.biesheu...@linaro.org; Tian, Feng Subject: RE: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data Hi, Haojian Why I didn't get the lowest byte data is because

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

2016-07-20 Thread Haojian Zhuang
ease correct me if I misunderstand. Thanks Feng -Original Message- From: Tian, Feng Sent: Wednesday, July 20, 2016 10:13 AM To: Haojian Zhuang Cc: edk2-devel@lists.01.org; guodong...@linaro.org; leif.lindh...@linaro.org; ard.biesheu...@linaro.org; Tian, Feng Subject: RE: [edk2] [PATCH]

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

2016-07-21 Thread Haojian Zhuang
On 2016/7/21 9:52, Haojian Zhuang wrote: 在 07/21/2016 09:51 AM, Haojian Zhuang 写道: Hi Feng, I think the main difference is who to handle the CRC bits. In the designware emmc/sd controller, the whole 128-bit value is loaded into the four response registers. There's no any shift on the 128-bit

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

2016-07-21 Thread Ard Biesheuvel
On 21 July 2016 at 13:17, Haojian Zhuang wrote: > On 2016/7/21 9:52, Haojian Zhuang wrote: >> >> >> >> 在 07/21/2016 09:51 AM, Haojian Zhuang 写道: >>> >>> Hi Feng, >>> >>> I think the main difference is who to handle the CRC bits. In the >>> designware emmc/sd controller, the whole 128-bit value is

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

2016-07-21 Thread Haojian Zhuang
On 2016/7/21 19:24, Ard Biesheuvel wrote: On 21 July 2016 at 13:17, Haojian Zhuang wrote: On 2016/7/21 9:52, Haojian Zhuang wrote: 在 07/21/2016 09:51 AM, Haojian Zhuang 写道: Hi Feng, I think the main difference is who to handle the CRC bits. In the designware emmc/sd controller, the whole 1

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

2016-07-21 Thread Tian, Feng
g] On Behalf Of Haojian Zhuang Sent: Thursday, July 21, 2016 9:40 PM To: Ard Biesheuvel ; Charles Garcia-Tobin Cc: edk2-devel-01 Subject: Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data On 2016/7/21 19:24, Ard Biesheuvel wrote: > On 21 July 2016 at 13:17, Haojian Zhuang wrote: &g

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

2016-07-21 Thread Haojian Zhuang
cia-Tobin Cc: edk2-devel-01 Subject: Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data On 2016/7/21 19:24, Ard Biesheuvel wrote: On 21 July 2016 at 13:17, Haojian Zhuang wrote: On 2016/7/21 9:52, Haojian Zhuang wrote: 在 07/21/2016 09:51 AM, Haojian Zhuang 写道: Hi Feng, I think the main

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

2016-07-21 Thread Tian, Feng
16 10:40 AM To: Tian, Feng ; Ard Biesheuvel ; Charles Garcia-Tobin Cc: edk2-devel-01 Subject: Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data Hi Feng, I have to say that lots of SD controllers are not compatible to SDHC, too. Just look at $Linux/drivers/mmc/host. And too many vendors are