Re: [edk2] [PATCH 2/2] MdeModulePkg/UdfDxe: suppress incorrect compiler warning in ReadFile()

2017-09-13 Thread Zeng, Star
Ersek Cc: Ni, Ruiyu ; Dong, Eric ; edk2-devel-01 ; Gao, Liming ; Zeng, Star Subject: Re: [edk2] [PATCH 2/2] MdeModulePkg/UdfDxe: suppress incorrect compiler warning in ReadFile() On 13 September 2017 at 11:49, Laszlo Ersek wrote: > On 09/13/17 08:43, Zeng, Star wrote: >> Beyond the Rb

Re: [edk2] [PATCH 2/2] MdeModulePkg/UdfDxe: suppress incorrect compiler warning in ReadFile()

2017-09-13 Thread Zeng, Star
d Liming, Dandan and Hao, Do you remember how we fix this kind of false alarm before? Just initialize the variable at the beginning of the function? Thanks, Star -Original Message- From: Zeng, Star Sent: Thursday, September 14, 2017 8:43 AM To: Ard Biesheuvel ; Laszlo Ersek Cc: Ni,

Re: [edk2] [PATCH 04/11] IntelSiliconPkg/VTdDxe: Disable PMR

2017-09-13 Thread Zeng, Star
A minor comment. Should or need IntelVTdPmrPei disable PMR at endofpei? Thanks, Star -Original Message- From: Yao, Jiewen Sent: Friday, September 8, 2017 11:04 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [PATCH 04/11] IntelSiliconPkg/VTdDxe: Disable PMR When VTd

Re: [edk2] [PATCH 04/11] IntelSiliconPkg/VTdDxe: Disable PMR

2017-09-13 Thread Zeng, Star
: Zeng, Star ; edk2-devel@lists.01.org Subject: RE: [PATCH 04/11] IntelSiliconPkg/VTdDxe: Disable PMR I did consider that before. I do not disable at EndOfPei purposely that because I want to make sure that the DMA protect is still available in early DXE phase, just in case there is bug in other

Re: [edk2] [PATCH 00/11] Add IOMMU PEI support.

2017-09-13 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Yao, Jiewen Sent: Wednesday, September 13, 2017 6:19 PM To: Zeng, Star ; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH 00/11] Add IOMMU PEI support. Good question. Yes, I think we can put all VTd related components to

Re: [edk2] [PATCH 2/2] MdeModulePkg/UdfDxe: suppress incorrect compiler warning in ReadFile()

2017-09-14 Thread Zeng, Star
Is there GCC compiler version fixed this kind of false alarm? If yes, the lesser versions without fix are what I mean *OLD*. Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, September 14, 2017 4:17 PM To: Zeng, Star ; Ard Biesheuvel Cc: Ni

Re: [edk2] [PATCH 2/2] MdeModulePkg/UdfDxe: suppress incorrect compiler warning in ReadFile()

2017-09-14 Thread Zeng, Star
From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, September 14, 2017 4:20 PM To: Zeng, Star ; Ard Biesheuvel ; Gao, Liming ; Bi, Dandan ; Wu, Hao A Cc: Ni, Ruiyu ; Dong, Eric ; edk2-devel-01 ; Paulo Alcantara Subject: Re: [edk2] [PATCH 2/2] MdeModulePkg/UdfDxe: suppress inco

Re: [edk2] [PATCH 4/4] OvmfPkg/QemuVideoDxe: Update QemuVideoDxe driver to bypass NULL pointer detection if enabled.

2017-09-14 Thread Zeng, Star
; Yao, Jiewen Cc: Dong, Eric ; Justen, Jordan L ; edk2-devel@lists.01.org; Wolman, Ayellet ; Kinney, Michael D ; Zeng, Star Subject: Re: [edk2] [PATCH 4/4] OvmfPkg/QemuVideoDxe: Update QemuVideoDxe driver to bypass NULL pointer detection if enabled. On 09/14/17 10:46, Wang, Jian J wrote

Re: [edk2] [PATCH 4/4] OvmfPkg/QemuVideoDxe: Update QemuVideoDxe driver to bypass NULL pointer detection if enabled.

2017-09-14 Thread Zeng, Star
Ersek Sent: Thursday, September 14, 2017 5:55 PM To: Zeng, Star ; Wang, Jian J ; Yao, Jiewen Cc: Kinney, Michael D ; Justen, Jordan L ; edk2-devel@lists.01.org; Dong, Eric ; Wolman, Ayellet Subject: Re: [edk2] [PATCH 4/4] OvmfPkg/QemuVideoDxe: Update QemuVideoDxe driver to bypass NULL pointer

Re: [edk2] HEADLESS flag in ACPI

2017-09-14 Thread Zeng, Star
; Ard Biesheuvel ; Marc Zyngier ; Catalin Marinas ; edk2-devel (edk2-devel@lists.01.org) ; linaro-a...@lists.linaro.org; Stephanie Hughes-Fitt ; Sudeep Holla ; Dong Wei ; Zeng, Star Subject: Re: [edk2] HEADLESS flag in ACPI + MdeModulePkg maintainers (GOP), linaro-acpi, Graeme, Ard. On Wed

Re: [edk2] [PATCH] MdeModulePkg/UdfDxe: Fix NULL pointer dereference

2017-09-14 Thread Zeng, Star
Reviewed-by: Star Zeng and pushed at 11b4463e096523fe03ac840472d483652ae93904. Thanks, Star -Original Message- From: Paulo Alcantara [mailto:pca...@zytor.com] Sent: Thursday, September 14, 2017 9:59 PM To: Laszlo Ersek ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Dong, Eric ; Zeng, Star

Re: [edk2] [PATCH] MdeModulePkg UdfDxe: Fix VS2010/VS2012 build failure

2017-09-14 Thread Zeng, Star
Thanks. Patch is pushed at 54537008a2f7d4e8a35507af8b523e7b678abacd. Star -Original Message- From: Paulo Alcantara [mailto:pca...@zytor.com] Sent: Thursday, September 14, 2017 10:25 PM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Laszlo Ersek ; Dong, Eric ; Ni, Ruiyu ; Gao, Liming ; Bi

Re: [edk2] Functionality issues in UDF support

2017-09-14 Thread Zeng, Star
F,0x0)/VenMedia(C5BD4D42-1A76-4996-8956-73CDA326CD0A) Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Friday, September 15, 2017 1:08 PM To: Paulo Alcantara ; Laszlo Ersek Cc: edk2-devel@lists.01.org; Wu, Hao A ; Zeng, Star Subject: RE: Functionality issues in UDF support Hi Paulo

Re: [edk2] [PATCH] MdeModulePkg/UdfDxe: Remove negative comparison of unsigned number

2017-09-14 Thread Zeng, Star
an, etc. That is what we(especially me) need to improve in future when developing and reviewing. Anyway, let's help keep improving UDF codes. Thanks, Star -Original Message- From: Paulo Alcantara [mailto:pca...@zytor.com] Sent: Wednesday, September 13, 2017 1:47 PM To: Zeng, Sta

Re: [edk2] [PATCH 4/4] OvmfPkg/QemuVideoDxe: Update QemuVideoDxe driver to bypass NULL pointer detection if enabled.

2017-09-14 Thread Zeng, Star
With this approach, please make sure to do more test, for example, check memory map change and OS boot, etc. Thanks, Star -Original Message- From: Wang, Jian J Sent: Friday, September 15, 2017 2:06 PM To: Wang, Jian J ; Zeng, Star ; Laszlo Ersek ; Yao, Jiewen Cc: Kinney, Michael D

Re: [edk2] Functionality issues in UDF support

2017-09-15 Thread Zeng, Star
-devel@lists.01.org; Wu, Hao A ; Zeng, Star Subject: RE: Functionality issues in UDF support Ray, On September 15, 2017 3:02:11 AM GMT-03:00, "Ni, Ruiyu" wrote: >Paulo, >When will you change the implementation to this way? Unfortunately I can't promise you when I'd

Re: [edk2] [PATCH] MdeModulePkg/UdfDxe: Remove negative comparison of unsigned number

2017-09-15 Thread Zeng, Star
:15 PM To: Zeng, Star ; Paulo Alcantara ; Ni, Ruiyu ; Yao, Jiewen Cc: Dong, Eric ; Bi, Dandan ; edk2-devel@lists.01.org; Kinney, Michael D ; Ard Biesheuvel ; Leif Lindholm (Linaro address) Subject: Re: [PATCH] MdeModulePkg/UdfDxe: Remove negative comparison of unsigned number Hi Star, On 09

Re: [edk2] [PATCH] MdeModulePkg/UdfDxe: Remove negative comparison of unsigned number

2017-09-15 Thread Zeng, Star
://lists.01.org/pipermail/edk2-devel/2017-September/014695.html. Thanks, Star -Original Message- From: Paulo Alcantara [mailto:pca...@zytor.com] Sent: Friday, September 15, 2017 2:49 PM To: Zeng, Star ; Laszlo Ersek (ler...@redhat.com) ; Ni, Ruiyu ; Yao, Jiewen Cc: Dong, Eric ; Bi, Dandan

Re: [edk2] [PATCH] Fix not able to change serial attributes

2017-09-15 Thread Zeng, Star
Pankaj, Thanks for the contribution. Could you help update the title to be like MdeModulePkg SerialDxe: XX? In fact, I agree the fix as it matches the code at MdeModulePkg/Bus/Pci/PciSioSerialDxe/SerialIo.c and IntelFrameworkModulePkg/Bus/Isa/IsaSerialDxe/Serial.c. But I am curious abou

Re: [edk2] [PATCH 0/4] IntelSiliconPkg: move VTd related modules to feature dir.

2017-09-16 Thread Zeng, Star
Thanks for making this. Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Yao, Jiewen Sent: Saturday, September 16, 2017 9:40 AM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [PATCH 0/4] IntelSiliconPkg: move VTd related modules to feature dir. This patch is to

Re: [edk2] [PATCH] MdeModulePkg/RecoveryDevice.h: Remove semicolon after GUID definitions

2018-02-22 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Friday, February 23, 2018 8:50 AM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Dong, Eric ; Zeng, Star Subject: [edk2] [PATCH] MdeModulePkg

Re: [edk2] [PATCH v2 1/3] MdePkg: restrict UefiMultiPhase.h contents if VFRCOMPILE defined

2018-02-22 Thread Zeng, Star
Leif, On 2018/2/23 4:09, Leif Lindholm wrote: Hi Star, I lost track of this one during my sabbatical until Ard's patch earlier today jogged my memory. On Sun, Dec 17, 2017 at 11:23:10AM +0000, Zeng, Star wrote: You may submit a bugzilla for the long term approach as Liming suggested

Re: [edk2] [Patch v2 0/3] MdeModulePkg: Add Boot Logo 2 Protocol

2018-02-22 Thread Zeng, Star
tion'? Thanks, Star -Original Message- From: Kinney, Michael D Sent: Friday, February 16, 2018 6:52 AM To: edk2-devel@lists.01.org Cc: Sean Brogan ; Bret Barkelew ; Yao, Jiewen ; Zeng, Star ; Dong, Eric ; Kinney, Michael D Subject: [Patch v2 0/3] MdeModulePkg: Add Boot Logo 2

Re: [edk2] [PATCH] MdeModulePkg/PlatformLogo.h: Correct function header comments

2018-02-24 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Saturday, February 24, 2018 3:47 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [edk2] [PATCH] MdeModulePkg/PlatformLogo.h: Correct

Re: [edk2] [PATCH] MdeModulePkg/Logo.idf: Remove incorrect comments.

2018-02-24 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Saturday, February 24, 2018 4:05 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [edk2] [PATCH] MdeModulePkg/Logo.idf: Remove incorrect

Re: [edk2] [PATCH] MdeModulePkg/Terminal: ReadKeyStrokeEx always return key state

2018-02-24 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Saturday, February 24, 2018 3:14 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [edk2] [PATCH] MdeModulePkg/Terminal: ReadKeyStrokeEx

Re: [edk2] [Patch] MdeModulePkg PCD: Fix the issue to set the big SkuId

2018-02-26 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Tuesday, February 27, 2018 1:37 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [edk2] [Patch] MdeModulePkg PCD: Fix the issue to set

Re: [edk2] [Patch] MdeModulePkg PCD: Add more debug message to show SkuId update

2018-02-26 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Gao, Liming Sent: Tuesday, February 27, 2018 1:38 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [Patch] MdeModulePkg PCD: Add more debug message to show SkuId update Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH 2/2] MdeModulePkg/BaseSerialPortLib16550: Prevent truncating constant values.

2018-02-27 Thread Zeng, Star
Could simply use 0xFFFC for this case? Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Marvin H?user Sent: Wednesday, February 28, 2018 2:56 AM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Laszlo Ersek ; Dong, Eric ; Zeng, Star

Re: [edk2] [PATCH 2/2] MdeModulePkg/BaseSerialPortLib16550: Prevent truncating constant values.

2018-03-01 Thread Zeng, Star
ks, Star -Original Message- From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] Sent: Friday, March 2, 2018 1:35 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Ni, Ruiyu ; ler...@redhat.com; Dong, Eric ; Zeng, Star Subject: RE: [edk2] [PATCH 2/2] MdeModulePkg/BaseSerialPortLib16550: Preve

Re: [edk2] [PATCH 0/4] implement runtime debug output protocl

2018-03-01 Thread Zeng, Star
:12 AM To: edk2-devel@lists.01.org Cc: ler...@redhat.com; leif.lindh...@linaro.org; heyi@linaro.org; Zeng, Star ; Dong, Eric ; Kinney, Michael D ; Gao, Liming ; Ard Biesheuvel Subject: [PATCH 0/4] implement runtime debug output protocl As discussed on list, MMIO based UARTs cannot be u

Re: [edk2] [patch] MdeModulePkg: Fix incorrect commit introduced by commit SHA-1:052c98

2018-03-01 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Gao, Liming Sent: Friday, March 2, 2018 1:23 PM To: Bi, Dandan ; edk2-devel@lists.01.org Cc: Zeng, Star ; Ni, Ruiyu Subject: RE: [patch] MdeModulePkg: Fix incorrect commit introduced by commit SHA-1:052c98 Reviewed-by

Re: [edk2] [PATCH 0/5] Fix UsbMassStorage driver for device compatibility

2018-03-02 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Friday, March 2, 2018 7:55 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 0/5] Fix UsbMassStorage driver for device compatibility #1 and #2

Re: [edk2] [PATCH 2/2] MdeModulePkg/Core: Fix feature conflict between NX and Stack guard

2018-03-06 Thread Zeng, Star
A quick minor comment. GetHobList() could be used instead of EfiGetSystemConfigurationTable (&gEfiHobListGuid, &HobList). Thanks, Star -Original Message- From: Wu, Hao A Sent: Tuesday, March 6, 2018 8:11 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Wang, Jian J ; Zeng, Sta

Re: [edk2] [PATCH 1/1] RFC: SecurityPkg: only clear HashInterface informations

2018-03-06 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: marcandre.lur...@redhat.com [mailto:marcandre.lur...@redhat.com] Sent: Wednesday, March 7, 2018 4:27 AM To: edk2-devel@lists.01.org Cc: Marc-André Lureau ; Yao, Jiewen ; Zhang, Chao B ; Zeng, Star ; Laszlo Ersek Subject

Re: [edk2] [PATCH 1/1] RFC: SecurityPkg: only clear HashInterface informations

2018-03-07 Thread Zeng, Star
aceHob) - sizeof (EFI_GUID)) " if to refine the code? Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Wednesday, March 7, 2018 5:06 PM To: marcandre.lur...@redhat.com Cc: edk2-devel@lists.01.org; Yao, Jiewen

Re: [edk2] [PATCH 1/1] RFC: SecurityPkg: only clear HashInterface informations

2018-03-07 Thread Zeng, Star
My head was stuck to say using " ZeroMem (HashInterfaceHob, sizeof (*HashInterfaceHob) - sizeof (EFI_GUID)) ", that is wrong. :( Thanks, Star -Original Message----- From: Zeng, Star Sent: Wednesday, March 7, 2018 5:42 PM To: Laszlo Ersek ; marcandre.lur...@redhat.com Cc: edk2-deve

Re: [edk2] [PATCH v2 1/1] SecurityPkg: fix ZeroMem HashInterfaceHob

2018-03-07 Thread Zeng, Star
018 10:56 PM To: edk2-devel@lists.01.org Cc: Laszlo Ersek ; Yao, Jiewen ; Zhang, Chao B ; Zeng, Star Subject: Re: [edk2] [PATCH v2 1/1] SecurityPkg: fix ZeroMem HashInterfaceHob Hi On Wed, Mar 7, 2018 at 12:24 PM, wrote: > From: Marc-André Lureau > > The ZeroMem() call goe

Re: [edk2] [PATCH v2 1/8] SecurityPkg: also clear HashInterfaceHob.SupportedHashMask

2018-03-07 Thread Zeng, Star
...@redhat.com; Zeng, Star Subject: RE: [PATCH v2 1/8] SecurityPkg: also clear HashInterfaceHob.SupportedHashMask Reviewed-by: Chao Zhang -Original Message- From: marcandre.lur...@redhat.com [mailto:marcandre.lur...@redhat.com] Sent: Wednesday, March 7, 2018 11:58 PM To: edk2-devel@lists.01

Re: [edk2] [PATCH v2 3/8] MdeModulePkg: fix REGISITER -> REGISTER

2018-03-08 Thread Zeng, Star
u.org; javi...@redhat.com; pjo...@redhat.com; Yao, Jiewen ; Zeng, Star ; Dong, Eric Subject: Re: [edk2] [PATCH v2 3/8] MdeModulePkg: fix REGISITER -> REGISTER On 03/07/18 16:57, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Cc: Laszlo Ersek > Contribu

Re: [edk2] [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after supporting IOMMU

2018-03-11 Thread Zeng, Star
Hao, Good catch. :) It is a mistake when splitting patch. Thanks, Star -Original Message- From: Wu, Hao A Sent: Monday, March 12, 2018 10:10 AM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Yao, Jiewen ; Ni, Ruiyu Subject: RE: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements

Re: [edk2] [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after supporting IOMMU

2018-03-11 Thread Zeng, Star
I have handled the mistake at https://github.com/lzeng14/edk2/tree/DebugCommUsb3AfterIOMMUV2_WIP. If you need, I can resend V2 patch. :) Thanks, Star -Original Message- From: Zeng, Star Sent: Monday, March 12, 2018 10:28 AM To: Wu, Hao A ; edk2-devel@lists.01.org Cc: Yao, Jiewen ; Ni

Re: [edk2] [RFC v1 1/1] MdeModulePkg/Usb: Use Pcd for UsbBootIoBlocks

2018-03-12 Thread Zeng, Star
12, 2018 11:47 PM To: Ming Huang ; Ni, Ruiyu ; leif.lindh...@linaro.org; linaro-u...@lists.linaro.org; edk2-devel@lists.01.org; graeme.greg...@linaro.org; Zeng, Star ; Dong, Eric ; Kinney, Michael D Cc: huangmin...@huawei.com; wanghuiqi...@huawei.com; ard.biesheu...@linaro.org; zhangjinso

Re: [edk2] [Patch] MdeModulePkg PCD: Remove unused PCD attribute PCD_TYPE_SKU_ENABLED

2018-03-12 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Gao, Liming Sent: Wednesday, March 7, 2018 4:15 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [Patch] MdeModulePkg PCD: Remove unused PCD attribute PCD_TYPE_SKU_ENABLED PcdDb optimization has handled PCD DB for each

Re: [edk2] [Patch] MdeModulePkg PCD: Remove unused PCD attribute PCD_TYPE_SKU_ENABLED

2018-03-13 Thread Zeng, Star
Please help check the patch at https://lists.01.org/pipermail/edk2-devel/2018-March/022668.html. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Thomas Lamprecht Sent: Tuesday, March 13, 2018 4:33 PM To: Gao, Liming ; edk2-devel@list

Re: [edk2] [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET

2018-03-13 Thread Zeng, Star
Maybe. I am using the MS outlook. Thanks, Star -Original Message- From: Thomas Lamprecht [mailto:t.lampre...@proxmox.com] Sent: Tuesday, March 13, 2018 5:22 PM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Gao, Liming Subject: Re: [edk2] [PATCH] MdeModulePkg PCD: Remove

Re: [edk2] [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET

2018-03-13 Thread Zeng, Star
Not wait more time any more as it is an urgent build failure. Pushed at d154a4dfaec4bf25acaca643e9ac15a3bc8d7a12. Thanks all. Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Tuesday, March 13, 2018 8:42 PM To: Zeng, Star

Re: [edk2] [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after supporting IOMMU

2018-03-13 Thread Zeng, Star
Good finding. The typo has been fixed in local. Thanks very much. Star -Original Message- From: Wu, Hao A Sent: Tuesday, March 13, 2018 8:56 PM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Yao, Jiewen ; Ni, Ruiyu Subject: RE: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements

Re: [edk2] [Patch] MdeModulePkg BrotliLib: Rename function with the specific lib name

2018-03-15 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Gao, Liming Sent: Tuesday, March 13, 2018 3:58 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [Patch] MdeModulePkg BrotliLib: Rename function with the specific lib name This change is to avoid the function conflict

Re: [edk2] [patch] MdeModulePkg: Fix coding style issues in file/function comments

2018-03-17 Thread Zeng, Star
@lists.01.org Cc: Zeng, Star Subject: [patch] MdeModulePkg: Fix coding style issues in file/function comments Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- MdeModulePkg/Include/Protocol/BootLogo2.h| 2 +- MdeModulePkg/Library

Re: [edk2] [RFC PATCH edk2-platforms 4/6] Silicon/SynQuacer: make lowest supported f/w version PCD configurable

2018-03-19 Thread Zeng, Star
[mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Monday, March 19, 2018 4:19 PM To: Leif Lindholm ; Zeng, Star ; Ni, Ruiyu ; Dong, Eric Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [RFC PATCH edk2-platforms 4/6] Silicon/SynQuacer: make lowest supported f/w version PCD

Re: [edk2] [edk2 UsbMassStorageDxe v1 1/1] MdeModulePkg/Usb: Replace macro USB_BOOT_IO_BLOCKS

2018-03-21 Thread Zeng, Star
--Original Message- From: Ming Huang [mailto:ming.hu...@linaro.org] Sent: Thursday, March 15, 2018 8:30 PM To: leif.lindh...@linaro.org; linaro-u...@lists.linaro.org; edk2-devel@lists.01.org; Zeng, Star ; Dong, Eric Cc: ard.biesheu...@linaro.org; Kinney, Michael D ; Gao, Liming ; guoh...@huawei

Re: [edk2] [MdeModulePkg/Usb v2 1/1] MdeModulePkg/Usb: Replace macro USB_BOOT_IO_BLOCKS

2018-03-22 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Ming Huang [mailto:ming.hu...@linaro.org] Sent: Thursday, March 22, 2018 3:44 PM To: linaro-u...@lists.linaro.org; edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric ; Kinney, Michael D ; Gao, Liming ; leif.lindh

Re: [edk2] MdeModulePkg/SerialDxe: SetAttributes() not follow UEFI spec

2018-03-22 Thread Zeng, Star
I agree. Thanks, Star -Original Message- From: Guo Heyi [mailto:heyi@linaro.org] Sent: Thursday, March 22, 2018 7:43 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric ; Ni, Ruiyu Subject: Re: MdeModulePkg/SerialDxe: SetAttributes() not follow UEFI spec +cc Maintainers of

Re: [edk2] [PATCH] MdeModulePkg/UsbKb: fix shell edit cannot read '!@#$%^&*' characters

2018-03-22 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Friday, March 23, 2018 12:46 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [PATCH] MdeModulePkg/UsbKb: fix shell edit cannot read '!@#$%^&*' char

Re: [edk2] MdeModulePkg/SerialDxe: SetAttributes() not follow UEFI spec

2018-03-25 Thread Zeng, Star
input. That should follow UEFI spec and the implementation in MdeModulePkg/Bus/Pci/PciSioSerialDxe and IntelFrameworkModulePkg/Bus/Isa/IsaSerialDxe. Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, March 23, 2018 10:32 PM To: Zeng, Star ; Guo

Re: [edk2] [MdeModulePkg/Usb v2 1/1] MdeModulePkg/Usb: Replace macro USB_BOOT_IO_BLOCKS

2018-03-25 Thread Zeng, Star
Patch has been pushed at https://github.com/tianocore/edk2/commit/824b6e3b5fa080df36626db3eb8465c25a12c053. Thanks for the contribution. Star -Original Message- From: Ni, Ruiyu Sent: Monday, March 26, 2018 10:55 AM To: Zeng, Star ; Ming Huang ; linaro-u...@lists.linaro.org; edk2-devel

Re: [edk2] internal structure of EFI_TLS_CA_CERTIFICATE_VARIABLE

2018-03-27 Thread Zeng, Star
: Wednesday, March 28, 2018 10:32 AM To: Fu, Siyuan ; Wu, Jiaxin Cc: edk2-devel-01 ; Daniel P. Berrange ; Zeng, Star Subject: Re: [edk2] internal structure of EFI_TLS_CA_CERTIFICATE_VARIABLE Hi, On 03/21/18 02:30, Fu, Siyuan wrote: > Hi, Laszlo > > The data structure of EFI_TLS_CA_CERTIFICATE

Re: [edk2] internal structure of EFI_TLS_CA_CERTIFICATE_VARIABLE

2018-03-28 Thread Zeng, Star
Laszlo, There should be some places need to care about. I also need to check the detail. I am ok to make the patch if it is not so urgent. Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, March 28, 2018 6:07 PM To: Zeng, Star ; Fu, Siyuan

Re: [edk2] [PATCH 1/4] MdeModulePkg/Variable/RuntimeDxe: introduce PcdMaxVolatileVariableSize

2018-03-28 Thread Zeng, Star
ursday, March 29, 2018 4:27 AM To: edk2-devel-01 Cc: Dong, Eric ; Ni, Ruiyu ; Zeng, Star Subject: [PATCH 1/4] MdeModulePkg/Variable/RuntimeDxe: introduce PcdMaxVolatileVariableSize The variable driver doesn't distinguish "non-volatile non-authenticated" variables from "

Re: [edk2] [RFC 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion

2018-03-28 Thread Zeng, Star
Cc Jian, Jiewen and Ruiyu. Thanks, Star -Original Message- From: Heyi Guo [mailto:heyi@linaro.org] Sent: Thursday, March 29, 2018 10:32 AM To: edk2-devel@lists.01.org Cc: Heyi Guo ; Yi Li ; Renhao Liang ; Zeng, Star ; Dong, Eric ; Kinney, Michael D ; Gao, Liming Subject: [RFC 1/1

Re: [edk2] [RFC 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion

2018-03-28 Thread Zeng, Star
please provide the special case you are awared? Thanks, Star -Original Message- From: Heyi Guo [mailto:heyi@linaro.org] Sent: Thursday, March 29, 2018 10:32 AM To: edk2-devel@lists.01.org Cc: Heyi Guo ; Yi Li ; Renhao Liang ; Zeng, Star ; Dong, Eric ; Kinney, Michael D ; Gao, Liming

Re: [edk2] [PATCH 1/4] MdeModulePkg/Variable/RuntimeDxe: introduce PcdMaxVolatileVariableSize

2018-03-29 Thread Zeng, Star
No V2 needed for this case, Reviewed-by: Star Zeng with my comment handled. Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, March 29, 2018 8:19 PM To: Zeng, Star ; edk2-devel-01 Cc: Dong, Eric ; Ni, Ruiyu Subject: Re: [PATCH 1/4

Re: [edk2] [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion

2018-03-29 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Heyi Guo [mailto:heyi@linaro.org] Sent: Thursday, March 29, 2018 4:20 PM To: edk2-devel@lists.01.org Cc: Heyi Guo ; Yi Li ; Renhao Liang ; Zeng, Star ; Dong, Eric ; Kinney, Michael D ; Gao, Liming ; Wang, Jian J ; Ni

Re: [edk2] [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion

2018-04-01 Thread Zeng, Star
Pushed at 5b91bf82c67b586b9588cbe4bbffa1588f6b5926. Thanks, Star -Original Message- From: Heyi Guo [mailto:heyi@linaro.org] Sent: Thursday, March 29, 2018 4:20 PM To: edk2-devel@lists.01.org Cc: Heyi Guo ; Yi Li ; Renhao Liang ; Zeng, Star ; Dong, Eric ; Kinney, Michael D ; Gao

Re: [edk2] [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion

2018-04-02 Thread Zeng, Star
, 2018 5:43 AM To: Zeng, Star ; Heyi Guo ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Yi Li ; Renhao Liang ; Dong, Eric ; Gao, Liming ; Wang, Jian J ; Ni, Ruiyu Subject: RE: [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion Star, This commit breaks Vlv2TbltDevicePkg. On this

Re: [edk2] [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion

2018-04-02 Thread Zeng, Star
ent. Seemingly, we also need introduce MemoryAttribute protocol for DXE? Thanks, Star -Original Message- From: Zeng, Star Sent: Tuesday, April 3, 2018 8:59 AM To: Kinney, Michael D ; Heyi Guo ; edk2-devel@lists.01.org Cc: Yi Li ; Renhao Liang ; Dong, Eric ; Gao, Liming ; Wang, Jian J ; Ni, Ru

Re: [edk2] [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion

2018-04-02 Thread Zeng, Star
GCD service. :) Thanks, Star -Original Message- From: Yao, Jiewen Sent: Tuesday, April 3, 2018 10:26 AM To: Wang, Jian J ; Zeng, Star ; Kinney, Michael D ; Heyi Guo ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Yi Li ; Gao, Liming ; Dong, Eric ; Renhao Liang Subject: RE: [PATCH 1/1

Re: [edk2] [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion

2018-04-02 Thread Zeng, Star
-Original Message- From: Yao, Jiewen Sent: Tuesday, April 3, 2018 10:34 AM To: Zeng, Star ; Wang, Jian J ; Kinney, Michael D ; Heyi Guo ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Yi Li ; Gao, Liming ; Dong, Eric ; Renhao Liang Subject: RE: [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute

Re: [edk2] [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion

2018-04-03 Thread Zeng, Star
Sure, I can do that. Thanks, Star -Original Message- From: Kinney, Michael D Sent: Wednesday, April 4, 2018 5:45 AM To: Yao, Jiewen ; Zeng, Star ; Wang, Jian J ; Heyi Guo ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Ni, Ruiyu ; Yi Li ; Gao, Liming ; Dong, Eric ; Renhao Liang

Re: [edk2] [PATCH 1/2] MdeModulePkg SmmMemoryAttribute.h: Refine some comments

2018-04-03 Thread Zeng, Star
Agree (also for patch 2/2). Thanks for the feedback. I will update them before pushing Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, April 3, 2018 7:37 PM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: Re: [edk2] [PATCH 1/2

Re: [edk2] OVMF UsbBulkTransfer returns EFI_OUT_OF_RESOURCES

2018-04-04 Thread Zeng, Star
Good news. Thanks, Star From: Rob Taglang [mailto:r...@taglang.io] Sent: Wednesday, April 4, 2018 12:49 AM To: Laszlo Ersek Cc: Ni, Ruiyu ; edk2-devel@lists.01.org; Ming Huang ; Zeng, Star Subject: Re: [edk2] OVMF UsbBulkTransfer returns EFI_OUT_OF_RESOURCES Hello, Thanks for you help, I got

Re: [edk2] [PATCH V2] MdeModulePkg/Gcd: Filter gCpu->SetMemoryAttributes() calls

2018-04-04 Thread Zeng, Star
Thanks all. Push the patch at 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c. :) Star -Original Message- From: Kinney, Michael D Sent: Thursday, April 5, 2018 4:28 AM To: Yao, Jiewen ; Zeng, Star ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Ni, Ruiyu ; Yi Li ; Dong, Eric ; Renhao Liang

Re: [edk2] [RFC 0/4] Add FmpDevicePkg

2018-04-08 Thread Zeng, Star
Curious about which tool to generate the FMP_PAYLOAD_HEADER? BaseTools needs to be updated? Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney, Michael D Sent: Thursday, April 5, 2018 8:29 AM To: Yao, Jiewen ; edk2-devel@lists.01

Re: [edk2] [RFC 1/4] FmpDevicePkg: Add package, library classes, and PCDs

2018-04-08 Thread Zeng, Star
Since PcdFmpDeviceBuildTimeLowestSupportedVersion is defined to support only FixedAtBuild and PatchableInModule, it is definitely for build time. Do we really need "BuildTime" keyword in the PCD name PcdFmpDeviceBuildTimeLowestSupportedVersion? Thanks, Star -Original Message- From: edk2

Re: [edk2] [PATCH] MdeModulePkg/PiSmmIpl: fix non-executable SMM RAM

2018-04-11 Thread Zeng, Star
@lists.01.org Cc: Zeng, Star ; Dong, Eric ; Yao, Jiewen ; Ni, Ruiyu ; Kinney, Michael D Subject: [PATCH] MdeModulePkg/PiSmmIpl: fix non-executable SMM RAM This patch fixes an issue introduced by commit 5b91bf82c67b586b9588cbe4bbffa1588f6b5926 This issue will only happen if

Re: [edk2] [Patch V2 1/9] MdeModulePkg: Add DisplayUpdateProgressLib class

2018-04-11 Thread Zeng, Star
, Michael D ; Sean Brogan ; Zeng, Star ; Dong, Eric Subject: [Patch V2 1/9] MdeModulePkg: Add DisplayUpdateProgressLib class From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share

Re: [edk2] [PATCH v2] MdeModulePkg/PiSmmIpl: fix non-executable SMM RAM

2018-04-11 Thread Zeng, Star
Has no need to set paging capability as the code is going to clear paging attribute. With that refined, Reviewed-by: Star Zeng . Thanks, Star -Original Message- From: Wang, Jian J Sent: Thursday, April 12, 2018 12:58 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric ; Yao

Re: [edk2] [PATCH 0/2] add sanity check for SetMemoryAttributes

2018-04-11 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J Wang Sent: Wednesday, April 11, 2018 4:39 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 0/2] add sanity check for SetMemoryAttributes Heap Guard feature needs

Re: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

2018-04-11 Thread Zeng, Star
If the cases can be listed completely, then it will be better to also add them in the comments for the two GUIDs, then consumer can easily know them. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Bi, Dandan Sent: Thursday, April 1

Re: [edk2] [PATCH] MdeModulePkg/Terminal: Check status of OpenProtocol in BindingStart

2018-04-12 Thread Zeng, Star
t; in Start() will not happen. Could more detailed information in the commit log or code comments? Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Friday, April 13, 2018 12:14 PM To: edk2-devel@lists.01.org Cc: Zeng

Re: [edk2] [PATCH] MdeModulePkg/Terminal: Check status of OpenProtocol in BindingStart

2018-04-13 Thread Zeng, Star
Thanks Laszlo. If the commit log is updated to reference the BZ link or even add more detailed information. Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, April 13, 2018 5:00 PM To: Zeng, Star ; Ni, Ruiyu ; edk2

Re: [edk2] [PATCH] Nt32Pkg/NtGopInput: ReadKeyStrokeEx always return key state

2018-04-19 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Thursday, April 19, 2018 6:42 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [PATCH] Nt32Pkg/NtGopInput: ReadKeyStrokeEx always return key state Today's implementation only return key state when

Re: [edk2] [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules

2018-04-19 Thread Zeng, Star
I also had another comment to the protocol at https://lists.01.org/pipermail/edk2-devel/2018-April/023720.html before. Thanks, Star -Original Message- From: Yao, Jiewen Sent: Friday, April 20, 2018 12:23 PM To: Kinney, Michael D ; edk2-devel@lists.01.org Cc: Sean Brogan ; Zeng, Star

Re: [edk2] [RFC v2 0/4] Add FmpDevicePkg

2018-04-19 Thread Zeng, Star
I had a minor comment at https://lists.01.org/pipermail/edk2-devel/2018-April/023570.html to PcdFmpDeviceBuildTimeLowestSupportedVersion before. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yao, Jiewen Sent: Friday, April 20, 20

Re: [edk2] [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules

2018-04-22 Thread Zeng, Star
Mike, Thanks for the clarification. Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Kinney, Michael D Sent: Saturday, April 21, 2018 7:12 AM To: Zeng, Star ; Yao, Jiewen ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Sean Brogan ; Dong, Eric ; Wei, David ; Guo, Mang

Re: [edk2] [RFC v2 0/4] Add FmpDevicePkg

2018-04-22 Thread Zeng, Star
Mike, Thanks for the clarification. Star -Original Message- From: Kinney, Michael D Sent: Saturday, April 21, 2018 7:06 AM To: Zeng, Star ; Yao, Jiewen ; edk2-devel@lists.01.org; Kinney, Michael D Subject: RE: [RFC v2 0/4] Add FmpDevicePkg Star, Thanks for the feedback. I think

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: fix AddLoadOptionVariable docs/prototype

2018-04-22 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, April 20, 2018 10:56 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Dong, Eric ; Zeng, Star Subject: Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: fix

Re: [edk2] [PATCH] IntelSiliconPkg MicrocodeUpdateDxe: Honor FIT table

2018-04-23 Thread Zeng, Star
enough space. Thanks, Star -Original Message- From: Yao, Jiewen Sent: Monday, April 23, 2018 4:49 PM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: RE: [PATCH] IntelSiliconPkg MicrocodeUpdateDxe: Honor FIT table Thanks for the update. Would you please share what unit

Re: [edk2] [PATCH] IntelSiliconPkg MicrocodeUpdateDxe: Honor FIT table

2018-04-23 Thread Zeng, Star
I also built VS2015/GCC49 (tool chain in my local), and checked ecc result. Thanks, Star -Original Message- From: Zeng, Star Sent: Monday, April 23, 2018 4:55 PM To: Yao, Jiewen ; edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Zeng, Star Subject: RE: [PATCH] IntelSiliconPkg

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: fix AddLoadOptionVariable docs/prototype

2018-04-23 Thread Zeng, Star
That is fine. :) Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Tuesday, April 24, 2018 2:48 AM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Dong, Eric Subject: Re: [edk2] [PATCH] MdeModulePkg

Re: [edk2] [Patch] MdeModulePkg: Remove unsupported PcdExpression usage in module INF

2017-04-05 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Gao, Liming Sent: Friday, March 31, 2017 1:04 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star Subject: [Patch] MdeModulePkg: Remove unsupported PcdExpression usage in module INF https://bugzilla.tianocore.org

Re: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove GCC -fno-builtin option

2017-04-06 Thread Zeng, Star
- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Thursday, April 6, 2017 4:15 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove GCC -fno-builtin option GCC -fno-builtin option is added into

Re: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove GCC -fno-builtin option

2017-04-06 Thread Zeng, Star
With that, you can have my Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Gao, Liming Sent: Thursday, April 6, 2017 4:40 PM To: Zeng, Star ; edk2-devel@lists.01.org Subject: RE: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove GCC -fno-builtin option Good

Re: [edk2] [ScsiDiskDxe] Implict type conversion bug

2017-04-10 Thread Zeng, Star
Hao has sent patch for this issue. You can search emails with title "[edk2] [PATCH] MdeModulePkg/ScsiDiskDxe: Fix potential implicit sign extension". Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Guoheyi Sent: Monday, April 10, 2017

Re: [edk2] [PATCH] MdeModulePkg: Add EFI_GCD_MEMORY_SPACE_NOTIFY_PROTOCOL

2017-04-12 Thread Zeng, Star
; Kinney, Michael D Cc: Tian, Feng ; Brijesh Singh ; Zeng, Star Subject: RE: [edk2] [PATCH] MdeModulePkg: Add EFI_GCD_MEMORY_SPACE_NOTIFY_PROTOCOL Hi Laszlo and Leo, If you look at the CpuSetMemoryAttributes() function in UefiCpuPkg/CpuDxe/CpuDxe.c, you will see it now calls

Re: [edk2] [Patch] MdeModulePkg DxeCore: Fix issue to print GUID value %g without pointer

2017-04-13 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Gao, Liming Sent: Thursday, April 13, 2017 3:08 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [Patch] MdeModulePkg DxeCore: Fix issue to print GUID value %g without pointer https://bugzilla.tianocore.org/show_bug.cgi?id=474 Cc

Re: [edk2] [PATCH v2 1/1] MdeModulePkg/PiSmmCore: Pad POOL_HEADER to be 8-byte aligned

2017-04-18 Thread Zeng, Star
Good comments. I plan to send the patch for https://bugzilla.tianocore.org/show_bug.cgi?id=407 this week. Since the patch for https://bugzilla.tianocore.org/show_bug.cgi?id=407 can naturally fix the alignment issue, so we can skip this patch. Thanks, Star -Original Message- From: edk2-de

Re: [edk2] [PATCH] MdeModulePkg/TerminalDxe: Avoid always append device path to *Dev

2017-04-18 Thread Zeng, Star
ormDxe):ConPlatformMatchDevicePaths ( Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Wednesday, April 19, 2017 10:43 AM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [edk2] [PATCH] MdeModulePkg/TerminalDxe: Avoid always

Re: [edk2] [PATCH] MdeModulePkg/FirmwarePerformanceDxe: Error Level is not used correctly

2017-04-19 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Fan, Jeff Sent: Thursday, April 20, 2017 2:16 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star Subject: [PATCH] MdeModulePkg/FirmwarePerformanceDxe: Error Level is not used correctly Cc: Feng Tian Cc: Star Zeng Contributed

<    1   2   3   4   5   6   7   8   9   10   >