Re: [edk2] [PATCH] MdeModulePkg: Add support for weakly aligned FVs[PI 1.2.1 Mantis 839].

2013-09-09 Thread Gao, Liming
Star: The patch is good to me. Reviewed-by: Liming Gao Thanks Liming From: Zeng, Star Sent: Friday, September 06, 2013 3:43 PM To: Gao, Liming; Andrew Fish (af...@apple.com) Cc: edk2-devel@lists.sourceforge.net Subject: [edk2] [PATCH] MdeModulePkg: Add support for weakly aligned FVs[PI 1.2.1

[edk2] What happens to Handle on hot-swap?

2013-09-09 Thread David F.
Hi, Say you have located a block device via LocateHandleBuffer, have opened the block protocol and hanging on to the handle for closing later. In the mean time device removed (or removed and inserted). Then you want to close the open protocol so you send the handle you had and the protocol. Was

Re: [edk2] Hot Swap Bugs

2013-09-09 Thread Andrew Fish
I mostly use the EmulatorPkg that supports X64. The QEMU is actively maintained and seems to generate a lot of traffic on this list. You can map real USB devices in the emulator, and use that to simulate hot plug. The generic UEFI code is hardware agnostic, so perfect HW emulation is not needed

Re: [edk2] Hot Swap Bugs

2013-09-09 Thread David F.
It's across different systems. Intel Mother Board, HP Systems, etc.. I tried using QEMU a while back and it wouldn't run correctly on this Win7 x64 system. The Nt32Pkg runs, but everything I have is x64. Do those environments have usb support combined with regular drives that USB can be hot swa

Re: [edk2] Bug in FS FAT driver

2013-09-09 Thread David F.
well, since it's in the firmware and not seeing much there - I guess I'll just report it. Details of this one using ver command in shell shows: UEFI v2.31 (American Megatrends, 0x0004028D) On Mon, Sep 9, 2013 at 11:32 AM, Andrew Fish wrote: > > On Sep 9, 2013, at 11:18 AM, David F. wrote:

Re: [edk2] Hot Swap Bugs

2013-09-09 Thread Andrew Fish
I don't think the current Shell is hot-plug removal safe. You need to post some steps so someone can reproduce the issues. It would be useful if you could reproduce in one of the emulated platforms that everyone has access to: Windows EFI emulator (Visual Studio as debugger): https://svn.cod

[edk2] [MdePkg] maintainer please review a typo in the comments for EfiSetVariable() library function

2013-09-09 Thread Andrew Fish
It looks like the UefiRuntimeLib.h EfiSetVariable() function has a typo that refers to GetNextVariableName() when it should be SetVariable(). https://svn.code.sf.net/p/edk2/code/trunk/edk2/MdePkg/Include/Library/UefiRuntimeLib.h /** This service is a wrapper for the UEFI Runtime Service GetNex

Re: [edk2] Bug in FS FAT driver

2013-09-09 Thread Andrew Fish
On Sep 9, 2013, at 11:18 AM, David F. wrote: > Hi, > > There is a bug in the FAT/32 file system driver (where is source?) http://sourceforge.net/apps/mediawiki/tianocore/index.php?title=Edk2-fat-driver Thanks, Andrew Fish > that creates incorrect ".." parent reference - they always seem to

Re: [edk2] SafeOpenProtocolLib: Suggested Patch.

2013-09-09 Thread Mcdaniel, Daryl
David, Your StdLib patches have been received and are being evaluated for inclusion in StdLib. * backspace_wrapping_and_other.patch * NumericInt.c_fix_stopch_and_negsign.patch * vfwprintf.c.patch Daryl McDaniel From: David F. [mailto:df7...@gmail.com] Sent: Thursday,

[edk2] ArmPkg: Exception Handling SP Adjust

2013-09-09 Thread Cohen, Eugene
Dear ArmPkg Maintainer, The exception handling support code at ArmPkg\Drivers\CpuDxe\ArmV6\ExceptionSupport.asm appears to adjust the stack pointer in the wrong direction. It decrements the stack pointer by 0x60, but this should be an increment (add) for the downward-growing stack. NoAdjustNe

Re: [edk2] Hot Swap Bugs

2013-09-09 Thread Cameron Esfahani
David, Don't take this the wrong way, but until you can actually point out the "fundamental big[sic]", you're not going to get a lot of traction here. Considering companies with very/mostly smart people have shipped millions of systems based on this, you need to bring something more concrete tha

[edk2] Hot Swap Bugs

2013-09-09 Thread David F.
Based on a lot of testing of removing/adding a USB flash drive I've noticed across different machines various issues after a hot-swap. Using the shell on one system with a SCSI controller and SCSI (SAS) hard drive, One internal SATA HD, one Internal SATA DVDRW drive, and the USB flash drive, every

Re: [edk2] Getting actual device name from block devices

2013-09-09 Thread Andrew Fish
David, You should also be checking the version number of EFI/UEFI that is supported by the platform. For example I think you will find the iMac claims to be EFI 1.10, not UEFI 2.3 or UEFI 2.4, and the pass through protocols did not exist in EFI 1.10. There are industry events to work on UEFI

Re: [edk2] Bug in FS FAT driver

2013-09-09 Thread David F.
I also consider it a bug that deleting a directory that isn't empty deletes it without deleting all the contents within it (or just erroring out because not empty). But that can be worked around whereas it creating the wrong .. entry isn't On Mon, Sep 9, 2013 at 11:45 AM, David F. wrote: > wel

[edk2] Bug in FS FAT driver

2013-09-09 Thread David F.
Hi, There is a bug in the FAT/32 file system driver (where is source?) that creates incorrect ".." parent reference - they always seem to be pointing back to the root. Example from shell (or any app), say your on fs0: mkdir \testdir mkdir \testdir\anotherdir the .. entry for anotherdir should p

Re: [edk2] Flush to disk

2013-09-09 Thread Andrew Fish
On Sep 7, 2013, at 10:51 PM, Sergey Isakov wrote: > Ops, corrected > > On 08.09.2013, at 8:34, Sergey Isakov wrote: > >> >> On 08.09.2013, at 4:59, David F. wrote: >> >>> Hi, >>> >>> is there a generic equivalent to something like sync() in Linux or do you >>> loop through block handles

Re: [edk2] [PATCH 0/3] OvmfPkg: QemuBootOrder: preserve some boot options absent from fw_cfg

2013-09-09 Thread Michael Chang
On Fri, Sep 06, 2013 at 11:40:43PM +0200, Laszlo Ersek wrote: > When QemuBootOrder finds at least one match between the "bootorder" > fw_cfg file (after translation) and the enumerated, active UEFI boot > options, QemuBootOrder rewrites the BootOrder variable so that it > reflects the order request