Re: [edk2] [PATCH V2] Move RTSM VExpress variable storage to 256k flash blocks

2014-01-13 Thread Roy Franz
Hi Olivier, On Mon, Jan 13, 2014 at 11:16 AM, Olivier Martin wrote: > Hi Roy, > > I need to think more about it. And I also need your point of view on some > points. > > Here are few questions and thoughts: > - Do you think the flash topology is the only difference between qEmu and > RTSM? I be

[edk2] [PATCH v2] OvmfPkg: unify PcdMaxVariableSize at 0x2000 bytes

2014-01-13 Thread Laszlo Ersek
The Linux persistent store (pstore) feature serves, among other things, for saving the trailing portion of the dmesg in case of a kernel oops. One backend for the pstore facility is "efivars", ie. non-volatile UEFI variables. Linux splits the tail of the dmesg that is to be dumped in 1KB chunks, a

Re: [edk2] [PATCH] OvmfPkg: Split MAINFV into a separate PEI and DXE FVs

2014-01-13 Thread Laszlo Ersek
comments below (diffing with v4) On 01/12/14 19:56, Jordan Justen wrote: > By splitting the PEI and DXE phases into separate FVs, > we can only reserve the PEI FV for ACPI S3 support. > This should save about 7MB. > > Unfortunately, this all has to happen in a single commit. > > DEC: > * Remove

Re: [edk2] [PATCH V2] Move RTSM VExpress variable storage to 256k flash blocks

2014-01-13 Thread Olivier Martin
Hi Roy, I need to think more about it. And I also need your point of view on some points. Here are few questions and thoughts: - Do you think the flash topology is the only difference between qEmu and RTSM? I believe it is not the only difference. I think the Cortex A15 used to not support the

Re: [edk2] assertion failure in Shell when scrolling back

2014-01-13 Thread Carsey, Jaben
Laszlo, I cannot duplicate this failure. Maybe Ray, who changed this file, can shed some light on this. -Jaben -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Monday, January 13, 2014 10:30 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] asserti

Re: [edk2] [PATCH] ShellPkg: Fixed RVCT build error 'statement is unreachable'

2014-01-13 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey jaben.car...@intel.com And commit: 15108 From: Olivier Martin [mailto:olivier.mar...@arm.com] Sent: Monday, January 13, 2014 10:09 AM To: Carsey, Jaben Cc: edk2-devel@lists.sourceforge.net Subject: [PATCH] ShellPkg: Fixed RVCT build error '

Re: [edk2] ShellPkg: Remove UNICODE file tag (FEFF) from files used for input redirection

2014-01-13 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge From: Carsey, Jaben Sent: Monday, January 13, 2014 10:49 AM To: Bjorge, Erik C Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: ShellPkg: Remove UNICODE file tag (FEFF) from files used for input redirection Erik, Can you verify please. ShellPkg: Remove UNI

[edk2] ShellPkg: Remove UNICODE file tag (FEFF) from files used for input redirection

2014-01-13 Thread Carsey, Jaben
Erik, Can you verify please. ShellPkg: Remove UNICODE file tag (FEFF) from files used for input redirection Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jaben Carsey mailto:jaben.car...@intel.com>> ShellParametersProtocol.c.patch Description: ShellParametersProtocol

Re: [edk2] [edk2-ARM] ARMv8 bootloader question

2014-01-13 Thread Olivier Martin
Thanks Bhupesh to have replied to the email. Here are some clarifications. We should not mix ARMv8 / AArch64 / AArch32 / ARMv7. ARMv7 and ARMv8 are the revisions of the ARM Architecture. - ARMv7 (version 7) is 32bit only. - ARMv8 (version 8) covers 32bit and 64bit ARM Architectures. - AArch32 an

[edk2] assertion failure in Shell when scrolling back

2014-01-13 Thread Laszlo Ersek
Hi, I didn't try to bisect the issue but I assume it is due to a recent change. I simply scrolled back as far as I could with Shift+PgUp, in the 2.0 shell, and it triggered an assertion failure, in function UpdateDisplayFromHistory(): ASSERT .../ShellPkg/Application/Shell/ConsoleLogger.c(324): (

Re: [edk2] [PATCH] OvmfPkg: give 1KB pure data to Linux pstore in non-auth PcdMaxVariableSize

2014-01-13 Thread Laszlo Ersek
On 01/13/14 17:01, Seiji Aguchi wrote: >>> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc >>> index 2e13e0e..7dac0fa 100644 >>> --- a/OvmfPkg/OvmfPkgIa32.dsc >>> +++ b/OvmfPkg/OvmfPkgIa32.dsc >>> @@ -278,7 +278,7 @@ >>> !if $(SECURE_BOOT_ENABLE) == TRUE >>>gEfiMdeModulePkgToken

Re: [edk2] ShellPkg: assign pointer to NULL after free to prevent double free

2014-01-13 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge From: Carsey, Jaben Sent: Monday, January 13, 2014 9:21 AM To: Bjorge, Erik C Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: ShellPkg: assign pointer to NULL after free to prevent double free Erik, Can you verify please. ShellPkg: assign pointer to NULL a

[edk2] [PATCH] ShellPkg: Fixed RVCT build error 'statement is unreachable'

2014-01-13 Thread Olivier Martin
Dear ShellPkg maintainer, Please find the attached patch that should fix RVCT build issue. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Olivier Martin Regards, Olivier ShellPkg-Fixed-RVCT-build-error-statement-is-unreachable.patch Description: Binary data ---

[edk2] ShellPkg: assign pointer to NULL after free to prevent double free

2014-01-13 Thread Carsey, Jaben
Erik, Can you verify please. ShellPkg: assign pointer to NULL after free to prevent double free Since the API caller may call twice we need to make sure that we set pointer to NULL so we can tell if already free. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jaben Cars

Re: [edk2] [PATCH] OvmfPkg: give 1KB pure data to Linux pstore in non-auth PcdMaxVariableSize

2014-01-13 Thread Seiji Aguchi
> > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > > index 2e13e0e..7dac0fa 100644 > > --- a/OvmfPkg/OvmfPkgIa32.dsc > > +++ b/OvmfPkg/OvmfPkgIa32.dsc > > @@ -278,7 +278,7 @@ > > !if $(SECURE_BOOT_ENABLE) == TRUE > >gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 > >

Re: [edk2] Getting information from eMMC device

2014-01-13 Thread Rafael Machado
Hi Andrew, You where right. I used other applications to check the hidden partitions and everything was there. Other instances of the BlokIoProtocol were related to the controllers, and not just the partitions. One last question to everyone. I need to read some data just from the emmc devices, but

Re: [edk2] [PATCH v4 16/26] OvmfPkg: PlatformPei: reserve SEC/PEI temp RAM for S3 resume

2014-01-13 Thread Wei Liu
On Fri, Jan 10, 2014 at 03:49:52PM -0800, Jordan Justen wrote: > On Fri, Jan 10, 2014 at 4:16 AM, Wei Liu wrote: > > Thanks for bringing this to Xen-devel! > > On Thu, Jan 09, 2014 at 03:03:06PM -0800, Jordan Justen wrote: > >> On Thu, Jan 9, 2014 at 2:00 PM, Laszlo Ersek wrote: > >> > On 01/09/1