[edk2] FW: Crash in qemu + OVMF after a call to DEBUG()

2014-05-14 Thread Croxon, Nigel
I have reviewed and tested this patch.I have accepted it and will update the gnu-efi package on sourceforge today. -Nigel -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, May 13, 2014 10:25 AM To: edk2-devel@lists.sourceforge.net Cc: Peter Jones; Nige

Re: [edk2] UEFI diagnostic application

2014-05-14 Thread Carsey, Jaben
Jakub, That is definitely a good method. That is the method used by the UEFI Shell command SmbiosView. The code is in this path: https://svn.code.sf.net/p/edk2/code/trunk/edk2/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView -Jaben From: Jakub Radtke [mailto:jara.u...@gmail.com] Sent:

Re: [edk2] UEFI diagnostic application

2014-05-14 Thread Jakub Radtke
Hi Micha?, I think you can also take SMBIOS tables from EFI System Table. Regards, Jakub Radtke Hi Michal. There is a protocol named EFI_SMBIOS_PROTOCOL_GUID defined by the PI Spec. You can take a llok at this protocol. Or you can take a llok at this application code (SMBiosView) and chec

Re: [edk2] edk2-devel Digest, Vol 53, Issue 25 [OvmfPkg/SMBIOS: Add QEMU-2.1 support]

2014-05-14 Thread Laszlo Ersek
On 05/14/14 19:07, Yi Li wrote: > Yes, sorry for my bad expression, but Tim ,you got that ,amazing! > > my original meaning is we should not search "_SM_" below 1M memory only ... > > sorry for the noise :) Gabriel already answered the question, but he didn't emphasize the important point. The

Re: [edk2] ShellPkg: Add error messages to CP when destination file or directory cannot be opened/created

2014-05-14 Thread Shah, Tapan
I proposed a change to remain consistent with the current implementation used for all other error messages which includes %s stuff in it. Thanks, Tapan From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Wednesday, May 14, 2014 11:53 AM To: Shah, Tapan; Bjorge, Erik C Cc: El-Haj-Mahmoud, S

Re: [edk2] [PATCH 2/2] OvmfPkg/SMBIOS: Add QEMU support to OVMF SMBIOS driver

2014-05-14 Thread Jordan Justen
On Wed, May 14, 2014 at 10:02 AM, Gabriel L. Somlo wrote: > On Wed, May 14, 2014 at 09:24:03AM -0700, Jordan Justen wrote: >> On Tue, May 13, 2014 at 3:13 PM, Gabriel L. Somlo wrote: >> > Contributed-under: TianoCore Contribution Agreement 1.0 >> > Signed-off-by: Gabriel Somlo >> >> Can you sync

Re: [edk2] PXE Boot file size

2014-05-14 Thread Ryan Harkin
OK, so it seems I was just a bit too quick off the mark, for Olivier/Brendan have just fixed it in revision 15527: http://sourceforge.net/p/edk2/code/15527 It hasn't hit the git mirror just yet, but I hacked it by hand and it works. Thanks to you all! On 14 May 2014 17:36, Ryan Harkin wrote:

Re: [edk2] edk2-devel Digest, Vol 53, Issue 25 [OvmfPkg/SMBIOS: Add QEMU-2.1 support]

2014-05-14 Thread Yi Li
Yes, sorry for my bad expression, but Tim ,you got that ,amazing! my original meaning is we should not search "_SM_" below 1M memory only ... sorry for the noise :) On Thursday, May 15, 2014 12:54 AM, Tim Lewis wrote: > Gabriel -- > > I think that Yi's point is that this structure method of fi

[edk2] [PATCH] MdeModulePkg/Mtftp4Dxe: Add 'file not found' debug message to MTFTP

2014-05-14 Thread Olivier Martin
Dear MdeModulePkg maintainer, please find the attached patch that clarifies the MTFTP error message. It says if a requested file is not found. It can help user to understand why the file transfer did not work. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brendan Jackman

Re: [edk2] [PATCH 2/2] OvmfPkg/SMBIOS: Add QEMU support to OVMF SMBIOS driver

2014-05-14 Thread Gabriel L. Somlo
On Wed, May 14, 2014 at 09:24:03AM -0700, Jordan Justen wrote: > On Tue, May 13, 2014 at 3:13 PM, Gabriel L. Somlo wrote: > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Gabriel Somlo > > Can you sync this up with the address the patch is being sent from? I will t

Re: [edk2] edk2-devel Digest, Vol 53, Issue 25 [OvmfPkg/SMBIOS: Add QEMU-2.1 support]

2014-05-14 Thread Tim Lewis
Gabriel -- I think that Yi's point is that this structure method of finding the tables is optional and is deprecated. On UEFI system, the tables are found using the EFI System Configuration table, searching it for the GUID he mentioned. Many X86 systems still support both means of finding the t

Re: [edk2] ShellPkg: Add error messages to CP when destination file or directory cannot be opened/created

2014-05-14 Thread Carsey, Jaben
I don't mind those changes. I went back and forth between them myself. I went with the former simply because localization hates when we have the %s stuff in the middle of the string. -Jaben From: Shah, Tapan [mailto:tapands...@hp.com] Sent: Wednesday, May 14, 2014 7:36 AM To: Carsey, Jaben; B

Re: [edk2] edk2-devel Digest, Vol 53, Issue 25 [OvmfPkg/SMBIOS: Add QEMU-2.1 support]

2014-05-14 Thread Gabriel L. Somlo
On Wed, May 14, 2014 at 08:17:30AM +0800, Yi Li wrote: > Hi Gabrie, > > Why do you use legacy method to find SMBIOS entry(like "_SM_") > only in GetQemuSmbiosTables()? > > there is no "_SM_" support on ARM platform, but > SMBIOS_TABLE_GUID is usable, could you consider to add > SMBIOS_T

Re: [edk2] PXE Boot file size

2014-05-14 Thread Ryan Harkin
Thanks for the pointers! Very valuable. On 14 May 2014 17:33, Laszlo Ersek wrote: > On 05/14/14 18:25, Laszlo Ersek wrote: > > On 05/14/14 16:57, Ryan Harkin wrote: > >> I have a platform set up to boot using PXE and I'm getting the following > >> error: > >> > >> PXE-E05: Download buffer

Re: [edk2] [PATCH 1/2] OvmfPkg/SMBIOS: Reuse handles supplied by underlying VM

2014-05-14 Thread Gabriel L. Somlo
On Wed, May 14, 2014 at 02:55:15PM +0100, Wei Liu wrote: > On Wed, May 14, 2014 at 03:31:48PM +0200, Laszlo Ersek wrote: > > On 05/14/14 00:13, Gabriel L. Somlo wrote: > > > The SMBIOS specification requires some structure types to > > > contain reference fields to other structures' handles. When >

Re: [edk2] PXE Boot file size

2014-05-14 Thread Laszlo Ersek
On 05/14/14 18:25, Laszlo Ersek wrote: > On 05/14/14 16:57, Ryan Harkin wrote: >> I have a platform set up to boot using PXE and I'm getting the following >> error: >> >> PXE-E05: Download buffer is smaller than requested file. >> >> I'm using an Ubuntu tftpd-hpa server, so it supports the tsiz

Re: [edk2] PXE Boot file size

2014-05-14 Thread Laszlo Ersek
On 05/14/14 16:57, Ryan Harkin wrote: > I have a platform set up to boot using PXE and I'm getting the following > error: > > PXE-E05: Download buffer is smaller than requested file. > > I'm using an Ubuntu tftpd-hpa server, so it supports the tsize option. > The file I'm downloading is quit

Re: [edk2] [PATCH 2/2] OvmfPkg/SMBIOS: Add QEMU support to OVMF SMBIOS driver

2014-05-14 Thread Jordan Justen
On Tue, May 13, 2014 at 3:13 PM, Gabriel L. Somlo wrote: > Locate QEMU SMBIOS data in fw_cfg and install it via the > SMBIOS protocol. > > Starting with qemu-2.1, on pc/x86 machines of type >= 2.1, full > SMBIOS tables are generated and inserted into fw_cfg (i.e., no > per-field patching of locall

[edk2] PXE Boot file size

2014-05-14 Thread Ryan Harkin
I have a platform set up to boot using PXE and I'm getting the following error: PXE-E05: Download buffer is smaller than requested file. I'm using an Ubuntu tftpd-hpa server, so it supports the tsize option. The file I'm downloading is quite large at approx 8MB. I'm using an aarch64 / arm64

Re: [edk2] ShellPkg: Add error messages to CP when destination file or directory cannot be opened/created

2014-05-14 Thread Shah, Tapan
Reviewed-by: Tapan Shah Please fix .uni files with following suggestions: From: #string STR_CP_DEST_OPEN_FAIL #language en-US "%EError. %NThe destination file failed to open with create.%s\r\n" #string STR_CP_DEST_DIR_FAIL #language en-US "%EError. %NThe destination direction could not b

Re: [edk2] ShellPkg: report error when EfiDecompress is run on a non-compressed file

2014-05-14 Thread Shah, Tapan
Reviewed-by: Tapan Shah From: Bjorge, Erik C [mailto:erik.c.bjo...@intel.com] Sent: Tuesday, May 13, 2014 12:32 PM To: Carsey, Jaben; Shah, Tapan Cc: edk2-devel@lists.sourceforge.net; Lohr, Paul A; El-Haj-Mahmoud, Samer Subject: RE: ShellPkg: report error when EfiDecompress is run on a non-comp

Re: [edk2] [PATCH 1/2] OvmfPkg/SMBIOS: Reuse handles supplied by underlying VM

2014-05-14 Thread Wei Liu
On Wed, May 14, 2014 at 03:31:48PM +0200, Laszlo Ersek wrote: > On 05/14/14 00:13, Gabriel L. Somlo wrote: > > The SMBIOS specification requires some structure types to > > contain reference fields to other structures' handles. When > > InstallAllStructures() rebuilds the SMBIOS tables by traversin

Re: [edk2] [PATCH 2/2] OvmfPkg/SMBIOS: Add QEMU support to OVMF SMBIOS driver

2014-05-14 Thread Laszlo Ersek
one irrelevant style comment in the middle On 05/14/14 00:13, Gabriel L. Somlo wrote: > Locate QEMU SMBIOS data in fw_cfg and install it via the > SMBIOS protocol. > > Starting with qemu-2.1, on pc/x86 machines of type >= 2.1, full > SMBIOS tables are generated and inserted into fw_cfg (i.e., no

Re: [edk2] [PATCH 1/2] OvmfPkg/SMBIOS: Reuse handles supplied by underlying VM

2014-05-14 Thread Laszlo Ersek
On 05/14/14 00:13, Gabriel L. Somlo wrote: > The SMBIOS specification requires some structure types to > contain reference fields to other structures' handles. When > InstallAllStructures() rebuilds the SMBIOS tables by traversing > an existing source table, the use of SMBIOS_HANDLE_PI_RESERVED > c

Re: [edk2] status of MP support work ?

2014-05-14 Thread Rafael Machado
Hi Chen I'm Rafael Machado and I've being in contact with jljusten about this task, because I'll do it as my Msc final work. Thanks and Regards Rafael 2014-05-14 8:00 GMT-03:00 chen.fan.f...@cn.fujitsu.com < chen.fan.f...@cn.fujitsu.com>: > Hi all, > I hope to use OVMF with MP support, a

[edk2] status of MP support work ?

2014-05-14 Thread chen.fan.f...@cn.fujitsu.com
Hi all, I hope to use OVMF with MP support, and I found an URL: http://sourceforge.net/apps/mediawiki/tianocore/index.php?title=Tasks/UefiCpuPkg/CpuDxe_MP_support about MP support described this work. I has used jljusten's ap-startup-example code to build OVMF, but when I run QEMU with built O

Re: [edk2] [PATCH] MdeModulePkg/Network: Fixed build

2014-05-14 Thread Tian, Feng
Thanks, Martin We will review it and if no problem we will check it in. Best Regards Feng -Original Message- From: Olivier Martin [mailto:olivier.mar...@arm.com] Sent: Wednesday, May 14, 2014 13:38 To: Tian, Feng Cc: edk2-devel@lists.sourceforge.net Subject: [PATCH] MdeModulePkg/Network