Re: [edk2] [PATCH 1/2] OvmfPkg: enable SATA controller

I added SataControllerDxe in DuetPkg to support AHCI for Duet that has chipset and platform specific initialization done before the Duet boot. It was thought to be hardly shared and used by real hardware platforms as the platforms (at least all I touched) have their own SataControllerDxe driver w

[edk2] OVFM question...

I’m running: OvmfPkg/build.sh -a X64 qemu -debugcon file:debug.log -global isa-debugcon.iobase=0x402 -s and I’m debugging changes in UefiCpuPkg/Library/CpuExceptionHandlerLib to make it work properly with clang. I’m working through the issues, but I noticed that InternalPrintMessage() is redire

Re: [edk2] TCP4 issues on Intel(R) Desktop Board DQ77MK UEFI 2.3.1 Development Kit

According to TCP4->Receive() protocol definition in UEFI spec, once the receive operation completes, the receive token will be signaled; if the received data size is smaller than the receive buffer length, the DataLength field will be updated to record the full length of received data. When you

Re: [edk2] UEFI Shell Command "ifconfig" Error‏

On Aug 6, 2014, at 6:04 PM, Chris Cuthbert wrote: > Hi Laszlo, > The ethernet device has a pci-pci bridge between itself and the root bridge. > Hence the weird looking device path. > The PCI nodes are Dev/Func as the bus #’s can change from boot to boot. > I poked around some more and saw t

Re: [edk2] INF/DEC file updates to EDK II packages

Tim, I should have put it in the original email. The spec changes will be shared too. We welcome review comments on all spec changes and patches. Thanks, Mike From: Tim Lewis [mailto:tim.le...@insyde.com] Sent: Wednesday, August 06, 2014 2:58 PM To: edk2-devel@lists.sourceforge.net Subject:

Re: [edk2] [PATCH 2/2] MdeModulePkg: Check D2H register status in AhciPioTransfer

Hi, Reza Where shall the "break" statement be? Inside the new "if" or outside? I suppose it should be inside to support an entire read transfer if the D2H is received and the error bit of status register is 0. Thanks Feng -Original Message- From: reza.jel...@tuhh.de [mailto:reza.jel...

Re: [edk2] ShellPkg: Refactor string manipulation in cp command

Reviewed-by: Eric Dong mailto:eric.d...@intel.com>> From: Dong, Eric [mailto:eric.d...@intel.com] Sent: Thursday, August 07, 2014 9:02 AM To: Carsey, Jaben Cc: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] ShellPkg: Refactor string manipulation in cp command Jaben, Verified pass. Thanks,

Re: [edk2] UEFI Shell Command "ifconfig" Error‏

Hi Laszlo, The ethernet device has a pci-pci bridge between itself and the root bridge. Hence the weird looking device path. I poked around some more and saw that MNP DXE driver could not open SNP protocol on any of the handles passed to it and hence it does not bind. It seems odd that "dh" com

Re: [edk2] ShellPkg: Refactor string manipulation in cp command

Jaben, Verified pass. Thanks, Eric From: Carsey, Jaben Sent: Thursday, August 07, 2014 4:55 AM To: Dong, Eric Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: ShellPkg: Refactor string manipulation in cp command Eric, Can you verify please? Note: I am submitting these changes one U

Re: [edk2] INF/DEC file updates to EDK II packages

Hi Tim, In general, we have tried to limit what is in the formal EDK II DEC/INF sections to items that are required to build. Information not required to build goes into comments or UserDefined sections. Given that this proposed user defined section lists a set of files with module/package re

Re: [edk2] license for binary drivers

On 06/08/14 14:51, Andrew Fish wrote: > How you write a GPL licensed FAT driver seems like a legal quagmire. Probably > something better discussed with a lawyer. From the outside looking in it > seems like the IP rights are enforced by charging licensing fees to devices > that support FAT. So f

Re: [edk2] INF/DEC file updates to EDK II packages

Mike -- Since there are dozens of tools in the industry that consume these files, don't you think its better to put the specification changes out where the consumers can read, evaluate and comment on them? I realize that "UserDefined" sections should be skipped by tools (agreed) but that doesn'

Re: [edk2] INF/DEC file updates to EDK II packages

Mike -- I am also curious why this EDK2 behavior is being put into a "UserDefined" section at all, since the file format is owned by the specifications on this web site. why not just create a new [PackageInfo] section and update the revision level? Are the contents of the new .UNI files and t

Re: [edk2] license for binary drivers

On Aug 6, 2014, at 6:44 AM, Paolo Bonzini wrote: > Il 06/08/2014 12:34, Laszlo Ersek ha scritto: >> So no, you can't ship an OVMF binary (or source tarball) that contains >> the FAT driver, bundled as part of the GPLv2 (+compatible) QEMU >> distribution, either in source or in binary form. > >

[edk2] INF/DEC file updates to EDK II packages

Hello, I wanted to let everyone know about a number of patch reviews for EDK II packages that will be sent out over the next couple of weeks. These patches impact the order of content in INF/DEC files and comment blocks in INF/DEC files, and should not have any build or functionality impacts.

Re: [edk2] [IntelFrameworkModulePkg] maintainer: LegacyBiosDxe thunk driver does not link with Xcode/clang.

On Aug 6, 2014, at 10:29 AM, Laszlo Ersek wrote: > On 08/06/14 19:05, Andrew Fish wrote: >> LegacyBiosInt86() sets a pointer to 0 and dereferences it. From a C >> standard point of view this is considered undefined behavior. The clang >> optimizer emits a trap instruction and throws all the code

[edk2] TCP4 issues on Intel(R) Desktop Board DQ77MK UEFI 2.3.1 Development Kit

Hello, I'm currently developing UEFI applications and using the Intel® Desktop Board DQ77MK UEFI 2.3.1 Development Kit(UDK2010) for testing. I'm having some issues while attempting to receive data from the network. Specifically, when calling Tcp4->Receive with a DataLength and FragmentBuffer large

[edk2] ShellPkg: Refactor string manipulation in cp command

Eric, Can you verify please? Note: I am submitting these changes one UEFI Shell command at a time to keep them clear to me. This patch replaces StrCpy with StrnCpy or refactors out the usage of StrCpy through some other means. This patch replaces StrCat with StrnCat or refactors out the usage

Re: [edk2] UEFI Shell Command "ifconfig" Error‏

On 08/06/14 21:34, Chris Cuthbert wrote: > Hi Laszlo, > > Thanx for the comprehensive explanation of the "dh" command. You > diagnosed my problem correctly and also gave me a pointer to an example > SNP implementation. I have looked at this driver and tried to make > changes to mine. Looks like th

[edk2] [PATCH v3 2/3] MdePkg: introduce BaseOrderedCollectionRedBlackTreeLib library instance

edk2 should have a fast and easy-to-use associative array (a dictionary) type. Red-black trees have O(log(n)) worst case time complexity for lookup, insertion, and deletion (where n is the number of nodes in the tree). They support minimum and maximum lookup with the same time complexity, hence re

[edk2] [PATCH v3 0/3] MdePkg: ordered collections, AppPkg: unit tester

Version 3 drops the Validate() function from the public API, introduces the PcdValidateOrderedCollection feature flag instead, and internalizes the validity checks in the library instance(s). Kudos to Mike for the improvement in design. The unit tester in AppPkg has been rebased to the PCD. Change

[edk2] [PATCH v3 1/3] MdePkg: introduce OrderedCollectionLib library class

This library class provides a set of APIs to manage an ordered collection of items: - Init(), - UnInit(), - Insert(), - Delete(), - IsEmpty(), - Next(), - Prev(), - Min(), - Max(), - Find(), - UserStruct(). There are many ways to implement an ordered collection. Depending on the frequency of the d

[edk2] [PATCH v3 3/3] AppPkg: introduce OrderedCollectionTest

In this patch a small application is added to AppPkg, with the following two goals: - demonstrate how to use OrderedCollectionLib, - allow users to test and "fuzz" BaseOrderedCollectionRedBlackTreeLib in particular, entering API "commands" interactively, or providing them from a script file. A

[edk2] [PATCH] CryptoPkg: Fix OpenSslLib build for ARM (new and improved)

Here is the updated patch. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eugene Cohen mailto:eug...@hp.com>> The changes are: 1. Add RVCT ARM build target 2. Add suppression of warnings to get openssl building (1295,550,1293,111,68,177,223,144,513,188) 3.

Re: [edk2] [PATCH v2 1/3] MdePkg: introduce OrderedCollectionLib library class

Laszlo, Yes. Please add to MdePkg.dec at end of [PcdsFeatureFlag] section. For the PCD name, the closest existing example in the MdePkg is the following PCD associated with extra checks in the BaseLib linked list APIs. ## If TRUE, a check will be made to see if a specified node is a

Re: [edk2] Coreboot / Payload Rambi Board

The official list of ChromeOS platform project names does not list Rambi. http://www.chromium.org/chromium-os/developer-information-for-chrome-os-devices But slide 2 of one of their firmware porting docs lists some Rambi sub-projects that are on the above list: https://docs.google.com/presentatio

Re: [edk2] UEFI Shell Command "ifconfig" Error‏

Hi Laszlo, Thanx for the comprehensive explanation of the "dh" command. You diagnosed my problem correctly and also gave me a pointer to an example SNP implementation. I have looked at this driver and tried to make changes to mine. Looks like the binding is still not happening. Here is the 'dh'

Re: [edk2] [PATCH v2 1/3] MdePkg: introduce OrderedCollectionLib library class

On 08/06/14 19:50, Kinney, Michael D wrote: > Laszlo, > > I do have a suggestion on the Validate() API. > > I recommend you add a Feature Flag PCD to enable/disable API > validation with the default value being FALSE, and the lib instance > can call the internal-only Validate() API after each ope

Re: [edk2] [PATCH 1/2] OvmfPkg: enable SATA controller

On 06/08/14 19:10, Laszlo Ersek wrote: > Then, > > > @@ -567,3 +573,4 @@ > > !endif > > > >OvmfPkg/PlatformDxe/Platform.inf > > + IntelFrameworkModulePkg/Universal/DataHubDxe/DataHubDxe.inf > > No clue what this is good for. It seems to produce > gEfiDataHubProtocolGuid, which is consumed b

Re: [edk2] [PATCH v2 1/3] MdePkg: introduce OrderedCollectionLib library class

Laszlo, I do have a suggestion on the Validate() API. I recommend you add a Feature Flag PCD to enable/disable API validation with the default value being FALSE, and the lib instance can call the internal-only Validate() API after each operation from within the lib instance itself in all locat

Re: [edk2] [IntelFrameworkModulePkg] maintainer: LegacyBiosDxe thunk driver does not link with Xcode/clang.

On 08/06/14 19:05, Andrew Fish wrote: > LegacyBiosInt86() sets a pointer to 0 and dereferences it. From a C > standard point of view this is considered undefined behavior. The clang > optimizer emits a trap instruction and throws all the code after the > reference away. The trap is replaced via a c

[edk2] Coreboot / Payload Rambi Board

Hi everyone I just saw at the intel uefi website, that there is a coreboot / payload port for uefi http://uefidk.com/develop#accordions_develop-page-node-2910 The site says that it was developed for the google Rambi board. "Firmware developed with this UEFI payload integrated into it is meant t

Re: [edk2] [PATCH 1/2] OvmfPkg: enable SATA controller

(Ray, I'll ask a question below about SataControllerDxe, thanks for your attention.) On 08/06/14 18:16, reza.jel...@tuhh.de wrote: > From: Reza Jelveh > > Replace the IdeController with a SataController that supports both in the > Ovmf firmware. > > Contributed-under: TianoCore Contribution Ag

[edk2] [IntelFrameworkModulePkg] maintainer: LegacyBiosDxe thunk driver does not link with Xcode/clang.

LegacyBiosInt86() sets a pointer to 0 and dereferences it. From a C standard point of view this is considered undefined behavior. The clang optimizer emits a trap instruction and throws all the code after the reference away. The trap is replaced via a compiler flag to be a function that does not

Re: [edk2] ShellPkg: add size cast to bit operations

Reviewed-by: Erik Bjorge From: Carsey, Jaben Sent: Wednesday, August 06, 2014 9:02 AM To: Mcdaniel, Daryl; Bjorge, Erik C; Rosenbaum, Lee G Cc: edk2-devel@lists.sourceforge.net; Dong, Eric; Carsey, Jaben Subject: ShellPkg: add size cast to bit operations Erik, Daryl, or Lee, Can you verify? Co

[edk2] [PATCH 1/2] OvmfPkg: enable SATA controller

From: Reza Jelveh Replace the IdeController with a SataController that supports both in the Ovmf firmware. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Reza Jelveh --- OvmfPkg/OvmfPkgX64.dsc | 15 +++ OvmfPkg/OvmfPkgX64.fdf | 11 +++ 2 files chang

[edk2] [PATCH 0/2] enable SATA controller for OVMF

From: Reza Jelveh This allows OVMF to be used with Ahci mode in Qemu. You can try it by using the following with your qemu image: -drive id=disk,file=mac_hdd_raw.img,if=none -device ahci,id=ahci -device ide-drive,drive=disk,bus=ahci.0 Some sata controllers send all commands asynchronously the

[edk2] [PATCH 2/2] MdeModulePkg: Check D2H register status in AhciPioTransfer

From: Reza Jelveh Several Ahci controllers including Qemu and several ARM devices send device commands such as identify asynchronously, which leads to the D2H register being set. AtaAtapiPassThru interprets a D2H regardless of the status code as error therefore failing to detect and enable ahci

[edk2] ShellPkg: add size cast to bit operations

Erik, Daryl, or Lee, Can you verify? Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jaben Carsey UefiHandleParsingLib.c.patch Description: UefiHandleParsingLib.c.patch -- Infragistics Profession

Re: [edk2] StdLib: the long standing build error

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: 06 August 2014 16:44 > To: edk2-devel@lists.sourceforge.net > Cc: Mitchell, Mark L; Harry Liebel > Subject: Re: [edk2] StdLib: the long standing build error > > > That's awesome. I was incredulous that no such t

Re: [edk2] StdLib: the long standing build error

On 08/06/14 17:03, Andrew Fish wrote: > > On Aug 6, 2014, at 7:02 AM, Laszlo Ersek > wrote: > >> On 08/06/14 00:31, Olivier Martin wrote: >>> Why do not put '*va_arg(ap, long double *) = res;' which seems to be >>> the valid solution and add a #ifdef for the faulty tool

Re: [edk2] StdLib: the long standing build error

On Aug 6, 2014, at 7:02 AM, Laszlo Ersek wrote: > On 08/06/14 00:31, Olivier Martin wrote: >> Why do not put '*va_arg(ap, long double *) = res;' which seems to be the >> valid solution and add a #ifdef for the faulty toolchains. >> I do not feel fair to keep a workaround by default when it bloc

Re: [edk2] [PATCH v3 1/3] MdePkg: Introduced BaseStackCheckLib

I addressed your comment 1. into my local patch. But for comment 2., I had initially added BaseStackLib to MdePkg.dsc. But it was not building as the FixedPcd was not defined: --- /home/olivier/tianocore/MdePkg/Library/BaseStackCheckLib/BaseStackCheckGcc.c :26:34: error: "_PCD_VALUE_PcdBaseSta

[edk2] [patch] Add new PlatformHookLib library into MdeModulePkg

Hi, all Please help review this patch. MdeModulePkg: new PlatformHookLib library with depex of SerialPortPpi. This library has one depex of SerialPortPpi. Then, the PEIM linked it has this depex so that it is dispatched after SerialPortPpi is installed. SerialPortPpi notifies the platform i

[edk2] [patch]Add Generic AcpiTimerLib into PcAtChipsetPkg

Hi, all Please help review this patch. PcAtChipsetPkg: new AcpiTimerLib libraries. Two library instances are added to support BASE type and DXE type. Those libraries provides basic timer support using the ACPI timer hardware. The performance counter features are provided by the processo

Re: [edk2] [PATCH] Fix StdLib floating point format regression

On 08/06/14 02:55, Mcdaniel, Daryl wrote: > Jaben, Erik, or Lee: could you please review this? > > Could someone else validate this on Linux and/or ARM? With the vfscanf.c change, I could test the patch; this is the output: - Produced by enquire version 5.1a, CWI, Amsterdam http://www

Re: [edk2] StdLib: the long standing build error

On 08/06/14 00:31, Olivier Martin wrote: > Why do not put '*va_arg(ap, long double *) = res;' which seems to be the > valid solution and add a #ifdef for the faulty toolchains. > I do not feel fair to keep a workaround by default when it blocks all the > other toolchains. Would the attached patc

Re: [edk2] license for binary drivers

Il 06/08/2014 12:34, Laszlo Ersek ha scritto: > So no, you can't ship an OVMF binary (or source tarball) that contains > the FAT driver, bundled as part of the GPLv2 (+compatible) QEMU > distribution, either in source or in binary form. What Laszlo said is mostly my understanding too (IANAL etc.).

[edk2] [PATCH] DxeCore Securiy issue on handle the corrupt signed GUIDED section

Hi, all Please help review this patch. MdeModulePkg: DxeCore If GUIDED section has AUTH attribute only, DxeCore may wrongly set its AuthenticationStatus to 0 when its matched GUIDED extraction handler is not installed and Auth data is not verified. For this case, the return AuthenticationStat

Re: [edk2] StdLib: the long standing build error

On 08/06/14 00:31, Olivier Martin wrote: > Why do not put '*va_arg(ap, long double *) = res;' which seems to be the > valid solution and add a #ifdef for the faulty toolchains. > I do not feel fair to keep a workaround by default when it blocks all the > other toolchains. Last night I wanted to

Re: [edk2] [PATCH v2 1/3] MdePkg: introduce OrderedCollectionLib library class

On 08/06/14 00:49, Kinney, Michael D wrote: > I do not have any specific issues with the undefined behavior of > these APIs, and I agree with the limited utility of checking for > NULL. I just wanted to make sure the style difference between this > lib class and other lib classes in the MdePkg w

Re: [edk2] UEFI Shell Command "ifconfig" Error‏

On 08/06/14 05:15, Chris Cuthbert wrote: > Thanx. I fixed it but did not make things better. I tried to debug > this further with "ping" command and it looks like UEFI Shell cannot > find the IPv4/IPv6 protocol handle. When I built a DEBUG release, I > can see the network stack modules being loaded

Re: [edk2] making UEFI driver part of optrom

Sushma, When you say “We placed this UEFI driver ROM image, below the legacy optrom and flashed the same on the PCIe card.”, how exactly did you do this? Did you change the headers in the legacy image to indicated that it no longer is the last image? It’s been several years since I’ve done thi

Re: [edk2] [PATCH] Fix StdLib floating point format regression

On 08/06/14 02:55, Mcdaniel, Daryl wrote: > Jaben, Erik, or Lee: could you please review this? > Could someone else validate this on Linux and/or ARM? > Thanks. > > StdLib: The formatting for double float values, within the gdtoa > library, is improper. > > When running Enquire.

Re: [edk2] making UEFI driver part of optrom

Hi Sushma, It’s depend on the platform BIOS to decide which option rom needs to be invoked. May be the BIOS you are having invokes only Legacy option rom if it’s exists and doesn’t launch the UEFI option rom. I mean to say from the option rom we can’t control which option rom needs to be lau

Re: [edk2] license for binary drivers

On 08/06/14 09:40, Reza Jelveh wrote: > Hello, > > EDK2 integrates FAT as a binary driver. What is the license of the FAT driver? https://svn.code.sf.net/p/edk2/code/trunk/edk2/FatBinPkg/License.txt > What are the guidelines for use of binary drivers with EDK2? Specifically if > you want to bund

Re: [edk2] [PATCH] Fix StdLib floating point format regression

I cannot build StdLib because of the issue raised in "[edk2] StdLib: the long standing build error" This compiler issue blocks us to do any StdLib validation... From: Mcdaniel, Daryl [mailto:daryl.mcdan...@intel.com] Sent: 06 August 2014 01:55 To: edk2-devel@lists.sourceforge.net Subject: [ed

[edk2] license for binary drivers

Hello, EDK2 integrates FAT as a binary driver. What is the license of the FAT driver? What are the guidelines for use of binary drivers with EDK2? Specifically if you want to bundle an OVMF firmware with qemu? In theory an .fd is a disk image right? So when I bundle a GPL driver with EDK2 its no