Hi Jaben,
Can you help to review this patch.
ShellPkg: Fix code style and build failure
1. File has invalid Non-ACSII char.
2. No initialization of a variable as part of its declaration.
3. Close braces for function body must be in the first column.
4. Inconsistent parameter in function comments.
Hi, Reza
Thanks for your effort, Reza. I made a little coding style enhancement based on
your proposed patch. please help view it.
PS: I am a little curious on "some Marvel controllers use D2H only instead of
PIO Setup FIS". If it's that case, does it mean current logic will never break
out th
Thanks for the contribution, Garrett.
Will get back to you if we complete the review.
Best Regards
Feng
From: Kirkendall, Garrett [mailto:garrett.kirkend...@amd.com]
Sent: Wednesday, August 13, 2014 02:59
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [PATCH] Add MdeModulePkg/Include/Ppi/S
Larry -
As a tools developer and a QA team, we (Insyde) can tell you that the existing
EBNF is hard to manage. We have rewritten it to be readable by tools and by
humans. When you start having conditions in the grammar (see the INF spec,
section 3.2), you know you've definitely crossed the line
Hi Tim,
I agree that the EBNF is getting cumbersome and we should really look at
reducing this.
I need to work with my internal development and validation teams (who keep
asking for more EBNF) to figure out a better method.
Our validation team has expressed the desire to have everything in one p
In ArmPkg/Library/ArmLib/AArch64/AArch64Mmu.c:ArmConfigureMmu() there is a
section of code that puzzles me.
// Translate the Memory Attributes into Translation Table Register Attributes
if ((TranslationTableAttribute ==
ARM_MEMORY_REGION_ATTRIBUTE_UNCACHED_UNBUFFERED) ||
(Translatio
Hi Reza,
Take note that regarding SataControllerDxe, there still remains a problem
that effects Qemu functionality.
On this query:
Data32 = AhciReadReg (PciIo, R_AHCI_CAP);
SataPrivateData->IdeInit.ChannelCount = (UINT8) ((Data32 & B_AHCI_CAP_NPS)
+ 1);
qemu seems to always report 1 channel. T
MdeModulePkg maintainers:
Please find the attached patch which adds a PPI definition for an equivalent of
MdePkg/Include/Protocol/SmmControl2.h
Garrett Kirkendall [Description: Description: Description: purple]
SMTS Firmware Engineer | AMD Technology & Engineering
7171 Southwest Parkway, Austi
Support for building BaseTools on AArch64 is available in the tree, but
not currently "plugged in". This patch adds the required snippet.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leif Lindholm
---
Source/C/Makefiles/header.makefile |4
1 file changed, 4 ins
Hi,
This design depends on compiler optimization. If the compiler is smart, it
knows DebugCodeEnabled() always return False and remove the unreachable code.
Thanks
Liming
From: Alexei Fedorov [mailto:alexei.fedo...@arm.com]
Sent: Tuesday, August 12, 2014 10:59 PM
To: edk2-devel@lists.sourceforg
That's correct. That was I was starting to write.
Toolchain with LTO (Linker Time Optimization) should remove this code. It is
the same issue as FeaturePcd reported a couple of month ago.
From: Tim Lewis [mailto:tim.le...@insyde.com]
Sent: 12 August 2014 16:21
To: edk2-devel@lists.sourceforge.net
Alexei -
I'm not sure about GCC, but in Visual Studio 2013 with LTCG turned on, the
binary code will not appear in the output file because link-time code
generation detects the cross-module optimization and removes the code correctly.
Tim
From: Alexei Fedorov [mailto:alexei.fedo...@arm.com]
Se
Hi All,
The description of DEBUG_CODE_BEGIN() and DEBUG_CODE_END() macros in
edk2\MdePkg\Include\Library\DebugLib.h reads:
/**
Macro that marks the beginning of debug source code.
If the DEBUG_PROPERTY_DEBUG_CODE_ENABLED bit of PcdDebugProperyMask is set,
then this macro marks the beginnin
On 11/08/14 01:07, Tian, Feng wrote:
> Hi, Reza
>
> IMHO, it should jump out the loop at the below point if we put break
> statement inside the new if.
>
> PrdCount = *(volatile UINT32 *)
> (&(AhciRegisters->AhciCmdList[0].AhciCmdPrdbc));
> if (PrdCount == DataCount) {
>
Hi Parmeshwr,
Liming Gao has helped identify the solution.
X64 is different from IA64 (IPF).
The value I was looking for was IPF, which is a generic term for all Itanium
based processor (IPF = Itanium Processor Family).
Any way thanks for the response. And yes, I do use the conf folder's target.
Hi Partha,
VfrCompile not support condition op-code for flags filed. Base on your request,
maybe below code can meet?
grayoutif NOT ideqval hf_form.var == 1;
string
varid = hf_form.Name,
questionid = x,
prompt = STRING_TOKEN(y),
help = STRING_TOKEN(z),
flags = INTERACTIVE ,
minsize = 0,
maxsiz
16 matches
Mail list logo
