Jordan:
I verify this patch in GCC46. The patch is good to me.
Reviewed-by: Gao, Liming
Thanks
Liming
-Original Message-
From: Jordan Justen [mailto:jljus...@gmail.com]
Sent: Wednesday, August 27, 2014 1:50 PM
To: edk2-devel@lists.sourceforge.net; Gao, Liming
Subject: Re: [edk2] [PA
On Tue, Aug 26, 2014 at 9:34 PM, Andrew Fish wrote:
> EmulatorPkg:Host: Port emulator to Xcode5
>
> Xcode5 retired gdb, so this patch adds support for using, and loading symbols
> in, lldb.
Cool, but I don't think the subject is right:
-EmulatorPkg:Host: Port emulator to Xcode5
+EmulatorPkg Unix
Regarding subject line of commit message, how about:
-Add support for Xcode5
+BaseTools tools_def: Add XCODE5 toolchain
https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format
On Tue, Aug 26, 2014 at 4:37 PM, Andrew Fish wrote:
> Add support for Xcode5
Is this a duplicate of
On Tue, Aug 19, 2014 at 4:57 PM, Jordan Justen
wrote:
> This series:
> * Adds support for creating object files from .nasm source files to
>allow NASM source files to be linked into libraries and images
> * Adds NASM source files for Thunk16 on IA32 and X64
> * Convert BaseLib to use NASM S
Jordan:
After UPT clean up, those files can still edit easily. UPT tool just changes
section Order and Alignment. The source package can still directly be compared.
So, daily work is no change.
Thanks
Liming
-Original Message-
From: Jordan Justen [mailto:jljus...@gmail.com]
Sent: Wed
EmulatorPkg:Host: Port emulator to Xcode5
Xcode5 retired gdb, so this patch adds support for using, and loading symbols
in, lldb.
The lldb script also supports dumping out the build generated guid database and
it prints guids out with thier Cname if available. lldbefi.py also contains
some EFI
EmulatorPkg:Host: Fix uninitialized variable detected by clang.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anderw Fish
---
EmulatorPkg/Unix/Host/PosixFileSystem.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/EmulatorPkg/Unix/Host/PosixFileSyst
On Tue, Aug 26, 2014 at 7:17 AM, Gao, Liming wrote:
> Jordan:
> UPT clean up main purpose has been mentioned in Mike email. "This allows UDP
> packages installed by UPT to be compared against EDK II trunk/branches using
> standard diff utilities."
I thought we moved away from xml files to have fi
Yes. We don't want to modify LZMA code.
-Original Message-
From: Andrew Fish [mailto:af...@apple.com]
Sent: Wednesday, August 27, 2014 10:48 AM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [BaseTools][PATCH 3/5] Fix clang warnings about asigning a
void * to its self.
On Au
On Aug 26, 2014, at 7:41 PM, Gao, Liming wrote:
> Andrew:
> BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c is LZMA code.
> BaseTools/Source/C/LzmaCompress/LzmaCompress.c is BaseTools wrap code.
>
Maybe it is better to fix it with the compiler flag then?
Thanks,
Andrew Fish
> Thanks
> L
Andrew:
BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c is LZMA code.
BaseTools/Source/C/LzmaCompress/LzmaCompress.c is BaseTools wrap code.
Thanks
Liming
-Original Message-
From: Andrew Fish [mailto:af...@apple.com]
Sent: Wednesday, August 27, 2014 8:06 AM
To: edk2-devel@lists.sour
On Aug 26, 2014, at 7:04 PM, Gao, Liming wrote:
> What's *.S16? GCC 16bit code?
>
We were using it for clang 16-bit assembler. It gets used for the reset vector
code. We don’t currently use NASM.
Thanks,
Andrew Fish
> -Original Message-
> From: Andrew Fish [mailto:af...@apple.com]
Reviewed-by: Eric Dong
-Original Message-
From: Andrew Fish [mailto:af...@apple.com]
Sent: Wednesday, August 27, 2014 7:37 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [BaseTools][PATCH 5/5] BaseTools: Fix clang C++ build error.
Fix clang C++ build error.
Move argument defa
What's *.S16? GCC 16bit code?
-Original Message-
From: Andrew Fish [mailto:af...@apple.com]
Sent: Wednesday, August 27, 2014 7:37 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [BaseTools][PATCH 4/5] Add support for Xcode5
Add support for Xcode5
Xcode 5 changed the flags needed
Andrew:
It is good to me.
Reviewed-by: Elvin Li
Thanks
Elvin
-Original Message-
From: Andrew Fish [mailto:af...@apple.com]
Sent: Wednesday, August 27, 2014 7:37 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [IntelFrameworkModulePkg][PATCH 1/1] LegacyBi
The change is good to me.
Reviewed-by: Gao, Liming
-Original Message-
From: Andrew Fish [mailto:af...@apple.com]
Sent: Wednesday, August 27, 2014 7:37 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [BaseTools] [PATCH 2/5] clang warns that since BaseAddress is
unsigned it can n
Tim,
Add my comments below.
From: Tim Lewis [mailto:tim.le...@insyde.com]
Sent: Wednesday, August 27, 2014 9:12 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] "goto" vfrConstantValue
It appears that the VFR specification has not been updated with the HII_REF
default format, although it
It appears that the VFR specification has not been updated with the HII_REF
default format, although it is used in the DriverSampleDxe. Can I verify the
actual format?
Here is a sample:
default = 0;0;ZERO_GUID;STRING_TOKEN(STR_NULL_STRING),
It appears that this is: question = 0, formid =
The example for catenate (in 2.12.11.1) appears to be incorrect. I believe that
the parameters for catenate should be stringref(STRING_TOKEN), not just
STRING_TOKEN. Or at least the grammar doesn't seem to support a STRING_TOKEN in
vfrExpressionConstant and the current VfrCompiler.exe complains.
On 8/26/2014 6:05 PM, Andrew Fish wrote:
> LzmaCompress.c:46:49: error: explicitly assigning a variable of type 'void *'
> to itself [-Werror,-Wself-assign]
> static void *SzAlloc(void *p, size_t size) { p = p; return MyAlloc(size); }
>
> I’m not sure if any of our tools warn. It probably came fr
Andrew,
A summary section in the build log sounds like a good suggestion. My main
complaint is that it is not easy to find such build results which are buried
deep in the -y/-Y log output.
Thanks,
--Samer
From: Andrew Fish [mailto:af...@apple.com]
Sent: Tuesday, August 26, 2014 12:28 PM
To: ed
On Aug 26, 2014, at 4:52 PM, Bruce Cran wrote:
> On 8/26/2014 5:37 PM, Andrew Fish wrote:
>> -static void *SzAlloc(void *p, size_t size) { p = p; return MyAlloc(size); }
>> -static void SzFree(void *p, void *address) { p = p; MyFree(address); }
>> +static void *SzAlloc(void *p, size_t size) { re
On 8/26/2014 5:37 PM, Andrew Fish wrote:
> -static void *SzAlloc(void *p, size_t size) { p = p; return MyAlloc(size); }
> -static void SzFree(void *p, void *address) { p = p; MyFree(address); }
> +static void *SzAlloc(void *p, size_t size) { return MyAlloc(size); }
> +static void SzFree(void *p, vo
Fix clang C++ build error.
Move argument default to constructor to remove clang warning.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anderw Fish
---
BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp | 2 +-
BaseTools/Source/C/VfrCompile/VfrFormPkg.h | 2 +-
2 files chan
Add support for Xcode5
Xcode 5 changed the flags needed to specify X64 EFIAPI so a new target is
needed.
Also added NOOPT_* target to previous versions of Xcode support.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anderw Fish
---
BaseTools/Conf/build_rule.template |
Fix clang warnings about asigning a void * to its self.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anderw Fish
---
BaseTools/Source/C/LzmaCompress/LzmaCompress.c | 4 ++--
BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c | 2 +-
2 files changed, 3 insertions(+), 3 del
Note: We need to test the flags on other gcc flavors. If they are not
compatible we will need different flags for different tools.
Change compiler flags to make Xcode 5.1.1 compile the BaseTools
-fno-merge-constants is not supported by clang, and it warns it will turn into
a hard error in the f
I'll skip the DSC, FDF and INF files; I assume those are customized
copies from existing platform files. I'll also skip the INF files for now.
On 08/26/14 15:03, Ard Biesheuvel wrote:
> This adds support for executing UEFI in a QEMU/mach-virt emulated environment.
> The following assumptions are m
Remove C undefined behavior.
The C standard defines accessing address zero as undefined behavior and clang
optimizes all code after the access. The volatile is required to allow access
to address zero.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anderw Fish
---
In
clang warns that since BaseAddress is unsigned it can never be < 0.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anderw Fish
---
BaseTools/Source/C/GenVtf/GenVtf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/C/GenVtf/GenVtf.c
b
On 08/26/14 15:03, Ard Biesheuvel wrote:
> This changes the definition and a bunch of references to
> gArmTokenSpaceGuid.PcdSystemMemoryBase and
> gArmTokenSpaceGuid.PcdSystemMemorySize so they can be declared as dynamic PCDs
> by the platform. Also, move the non-SEC call to
> ArmPlatformInitialize
Hi Folks,
I would like to update the Readme.txt file that generated by the Build Server
when we update the BaseTools Win32 binaries. Please provide feedback so that I
will be able to update the Build server scripts that generate the updated
content on Tuesday, Sept. 2.
Liming,
Please review by
Liming,
Please review the attached patch.
Updated GenBootSector, GenCrc32 and GenPage to remove duplicate "Build" word in
the version output, updated the minor number and copyright as needed.
Updated the VolInfo version output to remove the tool description from the
--version output string.
Co
On 26 August 2014 20:32, Laszlo Ersek wrote:
> On 08/26/14 15:03, Ard Biesheuvel wrote:
>> To support booting on virtual machines whose interrupt routing is
>> discovered from the device tree, allow the interrupt numbers to
>> be redeclared as PcdsDynamic by the platform .dsc
>>
>> Contributed-und
On 08/26/14 15:03, Ard Biesheuvel wrote:
> Allow the PCDs gArmTokenSpaceGuid.PcdGicDistributorBase and
> gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase to be redeclared
> as PcdsDynamic by the platform, so virtual machines can set these
> properties during boot. As the PcdGet32() calls now call in
On 08/26/14 15:03, Ard Biesheuvel wrote:
> Allow the PCDs gArmPlatformTokenSpaceGuid.PcdPL031RtcBase and
> gArmPlatformTokenSpaceGuid.PcdPL031RtcPpmAccuracy PCDs to be
> declared as PcdsDynamic by the platform so they can be overridden
> during boot.
>
> Contributed-under: TianoCore Contribution A
On 08/26/14 15:03, Ard Biesheuvel wrote:
> Remove the PCDs gArmTokenSpaceGuid.PcdGicDistributorBase and
> gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase from PrePeiCoreUniCore.inf,
> as they are not in fact used by the module.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-o
On 08/26/14 15:03, Ard Biesheuvel wrote:
> To support booting on virtual machines whose interrupt routing is
> discovered from the device tree, allow the interrupt numbers to
> be redeclared as PcdsDynamic by the platform .dsc
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-of
On 08/26/14 15:03, Ard Biesheuvel wrote:
> From: Michael Casadevall
>
> For virtual machines, the physical architected timer may not be available,
> so we need to allow the virtual timer to be used instead.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Michael Casa
On Aug 26, 2014, at 9:22 AM, El-Haj-Mahmoud, Samer
wrote:
> I take that back, you are correct that the type needs to be one type in the
> DSC. Does the build tool actually check that the multiple instances of PCDs
> (in a DSC build) use a common type?
>
> My request is to add the (optional)
On Aug 26, 2014, at 7:29 AM, Gao, Liming wrote:
> Andrew:
> If the package has been pass UPT clean up, their contents are same to UPT
> output. You can drop these code base by UPT tool, and create the same layout
> to your code base. Then, you can compare them and get the real difference.
>
On 08/26/14 16:33, Paolo Bonzini wrote:
> Il 26/08/2014 03:03, Laszlo Ersek ha scritto:
>>
>> The only way you could reliably fish out tables, operation regions etc.
>> from the qemu payload would be to write a near-full ACPI interpreter.
>> The goal of the interface is the polar opposite, ie. to r
Hi Samer
Thanks for the info.
Assuming your ASM version patch is correct, here is GCC version patch for your
reference.
It passes build only, functionality is not validated.
I will wait for your response to Mike.
Thank you
Yao, Jiewen
From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp
Tim, the issue was not DEBUG calls in the serial port library (these would be
fine since it is self-dependent), the issue is that DebugLib uses PrintLib for
AsciiSPrint and that PrintLIb uses DebugLib for ASSERT.
Liming, if we use BasePrintLib then we won't get the code size benefits from
the D
I take that back, you are correct that the type needs to be one type in the
DSC. Does the build tool actually check that the multiple instances of PCDs (in
a DSC build) use a common type?
My request is to add the (optional) ability to break the build if a PCD shows
up more than once in the DSC
Liming,
"But, PCD type must be set to one type in DSC file."
This is not true. The build tools are not enforcing this. You can have multiple
values for a PCD in the DSC file, and the tools will pick the last one. Hence,
my ask for a modification to the build tools to enforce this and break the
Il 26/08/2014 03:03, Laszlo Ersek ha scritto:
>
> The only way you could reliably fish out tables, operation regions etc.
> from the qemu payload would be to write a near-full ACPI interpreter.
> The goal of the interface is the polar opposite, ie. to require the
> firmware to know the least possi
Andrew:
If the package has been pass UPT clean up, their contents are same to UPT
output. You can drop these code base by UPT tool, and create the same layout to
your code base. Then, you can compare them and get the real difference.
Seemly, you request is to reorganize Package layout witho
Jordan:
UPT clean up main purpose has been mentioned in Mike email. "This allows UDP
packages installed by UPT to be compared against EDK II trunk/branches using
standard diff utilities."
For new added section, they may not follow UPT order. We can clean up them
together on next major rel
PCD value could be overridden. You can give one common value. The different
module could have their value. But, PCD type must be set to one type in DSC
file.
EDKII Build tool provides the option -y and -Y to dump all PCD value and type
for each driver. -y to specify the report file name. -Y spe
Thanks Yingke. Please let me know if you have any questions.
Thanks,
--Samer
From: Liu, Yingke D [mailto:yingke.d@intel.com]
Sent: Monday, August 25, 2014 11:49 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [PATCH] BaseTools: Add support for ${s_*} and ${d_*} macros
in FDF fil
This adds support for retaining UEFI environment variables in the second
emulated NOR flash which resides at phys address 0x0400 (64 MB).
Note that this requires booting QEMU with two -pflash arguments, each of which
points to a NOR image file of exactly 64 MB in size. The second one will be u
Allow the PCDs gArmPlatformTokenSpaceGuid.PcdPL031RtcBase and
gArmPlatformTokenSpaceGuid.PcdPL031RtcPpmAccuracy PCDs to be
declared as PcdsDynamic by the platform so they can be overridden
during boot.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
ArmP
This is v2 of the series that adds a platform config to support QEMU based
virtual machines, either in TCG or KVM mode. These virtual machines declare
their platform configuration by passing a device tree which needs to be parsed
by Tianocore rather than relying on hardcoded peripherals.
Currentl
Allow the PCDs gArmTokenSpaceGuid.PcdGicDistributorBase and
gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase to be redeclared
as PcdsDynamic by the platform, so virtual machines can set these
properties during boot. As the PcdGet32() calls now call into the
PCD database, cache the values that are re
This changes the definition and a bunch of references to
gArmTokenSpaceGuid.PcdSystemMemoryBase and
gArmTokenSpaceGuid.PcdSystemMemorySize so they can be declared as dynamic PCDs
by the platform. Also, move the non-SEC call to
ArmPlatformInitializeSystemMemory() earlier, so a platform has a chance
Remove the PCDs gArmTokenSpaceGuid.PcdGicDistributorBase and
gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase from PrePeiCoreUniCore.inf,
as they are not in fact used by the module.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
ArmPlatformPkg/PrePeiCore
To support booting on virtual machines whose interrupt routing is
discovered from the device tree, allow the interrupt numbers to
be redeclared as PcdsDynamic by the platform .dsc
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
ArmPkg/ArmPkg.dec
From: Michael Casadevall
For virtual machines, the physical architected timer may not be available,
so we need to allow the virtual timer to be used instead.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Casadevall
Signed-off-by: Ard Biesheuvel
---
ArmPkg/ArmP
This adds support for executing UEFI in a QEMU/mach-virt emulated environment.
The following assumptions are made about the target:
- ARM architected timer
- PL011 UART at 0x900
- at least 1 MB of DRAM at 0x4000, containing the device tree blob
The following information is retrieved from t
On 25 August 2014 21:19, Ard Biesheuvel wrote:
> To support booting on virtual machines whose interrupt routing is
> discovered from the device tree, allow the interrupt numbers to
> be redeclared as PcdsDynamic by the platform .dsc
> ---
> ArmPkg/ArmPkg.dec| 2 ++
some comments below, not affecting semantics
On 08/25/14 21:19, Ard Biesheuvel wrote:
> From: Michael Casadevall
>
> For virtual machines, the physical architected timer may not be available,
> so we need to allow the virtual timer to be used instead.
>
> Signed-off-by: Michael Casadevall
> Si
I am not sure the BaseTools has already raised a warning/error on multiple
PCD definitions.
In our build system, it automatically appends
'gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString' at the end of the
DSC file to track the built binaries.
And I have not seen any issue in case PcdFirm
On 26 August 2014 12:32, Olivier Martin wrote:
> Thanks Ard for the contribution, I will try to have a look later this week.
>
> Some quick comments:
> - Which version of EDK2 should apply the patchset? I suspect the patchset
> will not apply... I saw some KVM comments in the timer patches that we
Thanks Ard for the contribution, I will try to have a look later this week.
Some quick comments:
- Which version of EDK2 should apply the patchset? I suspect the patchset
will not apply... I saw some KVM comments in the timer patches that were not
part of the patch.
- I will probably need a new pa
The GUID has already been declared in EmbeddedPkg/Include/Guid/Fdt.h.
I have just pushed some helper functions to load FDT from Firmware Volume (svn
rev15905) or File System (svn rev15908).
These functions could be used by VirtFdtDxe.c.
> -Original Message-
> From: Ard Biesheuvel [mailto
On 26 August 2014 11:39, Laszlo Ersek wrote:
> On 08/25/14 21:19, Ard Biesheuvel wrote:
>> This adds the possibility to include a DTB blob into the firmware image, and
>> have it installed as a configuration under the correct GUID at UEFI init
>> time.
>>
>> Signed-off-by: Ard Biesheuvel
>> ---
On Di, 2014-08-26 at 10:22 +0200, Laszlo Ersek wrote:
> When setting up the list of GOP modes offered on QEMU's stdvga ("VGA")
> and
> QXL ("qxl-vga") video devices, QemuVideoBochsModeSetup() filters those
> modes against the available framebuffer size. (Refer to SVN r15288 /
> git
> commit ec88061
On 08/25/14 21:19, Ard Biesheuvel wrote:
> This adds the possibility to include a DTB blob into the firmware image, and
> have it installed as a configuration under the correct GUID at UEFI init time.
>
> Signed-off-by: Ard Biesheuvel
> ---
> MdeModulePkg/MdeModulePkg.dec |
On 25 August 2014 22:03, Laszlo Ersek wrote:
> On 08/25/14 21:19, Ard Biesheuvel wrote:
>> This series adds a platform config to support QEMU based virtual machines,
>> either in TCG or KVM mode. These virtual machines declare their platform
>> configuration by passing a device tree which needs to
When setting up the list of GOP modes offered on QEMU's stdvga ("VGA") and
QXL ("qxl-vga") video devices, QemuVideoBochsModeSetup() filters those
modes against the available framebuffer size. (Refer to SVN r15288 / git
commit ec88061e.)
The VBE_DISPI_INDEX_VIDEO_MEMORY_64K register of both stdvga
Reviewed-by: Eric Dong
Code checked in revision: 15898.
Thanks,
Eric
From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com]
Sent: Tuesday, August 26, 2014 2:23 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [PATCH] MdeModulePkg: Fix bug in DisplayEngine - global width
constan
72 matches
Mail list logo
