Remove hard-coded list of PCI devices for which the Interrupt Line
register is initialized. Instead, provide a "visitor" function to
initialize the register only for present and applicable PCI devices.
At this time, we match the behavior of SeaBIOS (file src/fw/pciinit.c,
functions *_pci_slot_get_
> On Nov 3, 2014, at 8:58 AM, Andrew Fish wrote:
>
>
>> On Oct 31, 2014, at 2:36 PM, Jordan Justen wrote:
>>
>> On Fri, Oct 31, 2014 at 1:18 PM, Andrew Fish wrote:
>>>
On Oct 31, 2014, at 12:38 PM, Jordan Justen wrote:
Andrew,
Back in February 2011, you added thi
Apologies for the missing contribution info, here goes:
Implement the missing SetMemorySpaceCapabilities function as defined in the PI
Specification version 1.3.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eugene Cohen
-Original Message-
From: Jordan Justen
Reviewed-by: Joe Peterson
From: Carsey, Jaben
Sent: Friday, November 14, 2014 2:47 PM
To: Peterson, Joe; Bjorge, Erik C; Shah, Tapan (tapands...@hp.com)
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: RE: [PATCH 2/2] [USB Decode] ShellPkg: Add extended USB decoding for
consistent de
I don't think so. The setting is defaults to unknown so we just leave it that
way.
From: Peterson, Joe
Sent: Friday, November 14, 2014 2:30 PM
To: Carsey, Jaben; Bjorge, Erik C; Shah, Tapan (tapands...@hp.com)
Cc: edk2-devel@lists.sourceforge.net
Subject: RE: [PATCH 2/2] [USB Decode] ShellPkg: A
Should the switch statement have a default clause?
From: Carsey, Jaben
Sent: Friday, November 14, 2014 1:43 PM
To: Bjorge, Erik C; Peterson, Joe; Shah, Tapan (tapands...@hp.com)
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: [PATCH 2/2] [USB Decode] ShellPkg: Add extended USB decodin
Reviewed-by: Tapan Shah mailto:tapands...@hp.com>>
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Friday, November 14, 2014 3:43 PM
To: Bjorge, Erik C; Peterson, Joe; Shah, Tapan
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: [PATCH 2/2] [USB Decode] ShellPkg: Add extended
Hi All,
I implemented a SATA driver and installed
gEfiIdeControllerInitProtocolGuid. When I attach a SATA disk with 4 GPT
partitions, the PartitionDriverBindingStart is being called repeatedly and
never stops. Logs below. Any reason why this is getting called repeatedly ?
Thanx.
BEFORE WHILE ROU
Reviewed-by: Erik Bjorge
From: Carsey, Jaben
Sent: Friday, November 14, 2014 1:43 PM
To: Bjorge, Erik C; Peterson, Joe; Shah, Tapan (tapands...@hp.com)
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: [PATCH 2/2] [USB Decode] ShellPkg: Add extended USB decoding for
consistent device
Reviewed-by: Erik Bjorge
From: Carsey, Jaben
Sent: Friday, November 14, 2014 1:43 PM
To: Bjorge, Erik C; Gao, Liming; Shah, Tapan (tapands...@hp.com)
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: [PATCH 1/2] [USB Decode] MdeModulePkg: remove usb defined info
Erik, Tapan, and Lim
Reviewed-by: Erik Bjorge
From: Carsey, Jaben
Sent: Friday, November 14, 2014 1:43 PM
To: Gao, Liming; Bjorge, Erik C; Shah, Tapan (tapands...@hp.com)
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: [PATCH 0/2] [USB Decode] MdePkg Add USB Spec constants to Usb.h
Erik, Tapan, and Lim
Reviewed-by: Tapan Shah mailto:tapands...@hp.com>>
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Friday, November 14, 2014 3:43 PM
To: Bjorge, Erik C; Gao, Liming; Shah, Tapan
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: [PATCH 1/2] [USB Decode] MdeModulePkg: remove usb
Reviewed-by: Tapan Shah mailto:tapands...@hp.com>>
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Friday, November 14, 2014 3:43 PM
To: Gao, Liming; Bjorge, Erik C; Shah, Tapan
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: [PATCH 0/2] [USB Decode] MdePkg Add USB Spec cons
Erik, Tapan, and Joe,
Can you verify?
This allows for extended decode of USB devices to determine their type. This
feature is controlled by a PCD, and it's enabled by default.
ShellPkg: Add extended USB decoding for consistent device names
Contributed-under: TianoCore Contribution Agreement
Erik, Tapan, and Liming,
Can you check this?
This removes the constant stuff that was just added to Usb.h.
MdeModulePkg: remove usb defined info
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: jaben carsey
UsbMass.h.patch
Description: UsbMass.h.patch
-
Erik, Tapan, and Liming,
Can you check this?
This adds USB spec constant values to Usb.h. Borrowed from UsbMass.h in
MdeModulePkg.
MdePkg Add USB Spec constants to Usb.h
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: jaben carsey
Usb.h.patch
Description: Us
On 2014-11-14 12:48:10, Cohen, Eugene wrote:
> As discussed offline, here is a patch for review as provided by HP and then
> updated by Intel (thanks!).
>
> Please review.
>
> Signed-off-by: Eugene Cohen
This should also include a commit message and Contributed-under.
(See MdeModulePkg/Contrib
As discussed offline, here is a patch for review as provided by HP and then
updated by Intel (thanks!).
Please review.
Signed-off-by: Eugene Cohen
From: Zeng, Star [mailto:star.z...@intel.com]
Sent: Friday, October 31, 2014 5:59 AM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] DXE
Hi Stefan,
I noticed that the TPM2 Spec volume 3 says TPM2_SetPrimaryPolicy requires an
auth session.
BIOS/platform hierarchy currently use pass word authorization, which does
not require an auth session, so the TPM2_StartAuthSession command is not
supported.
Do you know if TPM2_SetPri
> On Nov 14, 2014, at 9:48 AM, Varad Gautam wrote:
>
> Could using MdeModulePkg/Universal/Variable/EmuRuntimeDxe instead of
> MdeModulePkg/Universal/Variable/RuntimeDxe be the problem, given that
> EmuRuntimeDxe does not support NV storage and UEFI variables (ConIn,
> ConOut) are required to be
On 2014-11-03 00:17:18, Chen Fan wrote:
> if any enabled APs are not in idle state, StartupAllAPs() should return
> immediately,
> and must not change the other idled processor state. so we checked the state
> before
> changed them.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> S
On 2014-11-03 00:17:17, Chen Fan wrote:
> Because TimeoutInMicrosecsond is a unsigned value, converting it to
> signed value will cause the data region changed. so this patch fix
> that.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Chen Fan
> ---
> EmulatorPkg/Cpu
> On Nov 14, 2014, at 7:05 AM, David Cox wrote:
>
> Hi,
>
> If I include my EFI application as a module in an existing BIOS by taking the
> BIOS image, using UEFITool to insert.
Thats scary. Not mention the tool has a bad name since the FV is not defined in
UEFI and not required to exist. T
On 11/14/14 18:45, Sergey Isakov wrote:
> Hi Laszlo,
> I didn’t reproduce the bug.
> Compilation by gcc-4.9.2-linux-gnu with -flto option
> Sizes: with -O0 = 7648, with -Os=7424. It proves optimization was occurred.
> Both outputs are good
Thanks! That's good news. Seems to imply that the issue is
Could using MdeModulePkg/Universal/Variable/EmuRuntimeDxe instead of
MdeModulePkg/Universal/Variable/RuntimeDxe be the problem, given that
EmuRuntimeDxe does not support NV storage and UEFI variables (ConIn,
ConOut) are required to be kept static? Also, this would be how I can
maintain persistence
On 2014-11-14 05:52:47, Gabriel Somlo wrote:
> On Fri, Nov 14, 2014 at 08:30:35AM +, Chen, Fan wrote:
> > On Fri, 2014-11-14 at 08:11 +, Fan, Jeff wrote:
> > > Sounds good idea to send INIT IPI to APs to let it be wait for SIPI state.
> >
> > Yes, this idea looks simple. so I just now did
On 11/14/14 12:49, Anthony PERARD wrote:
> On Thu, Nov 13, 2014 at 05:27:08PM +, Anthony PERARD wrote:
>> Hi,
>>
>> I've took ovmf-ia32-msft-xen.patch from Scott Duplichan and made a few
>> changes.
>>
>> So the first two patchs of this series changes the type of some
>> variables/arguments/fi
On 11/13/14 19:18, Anthony PERARD wrote:
> The fix, having "lock" and the locked instruction on the same line in
> the source.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Anthony PERARD
> ---
> OvmfPkg/XenBusDxe/X64/TestAndClearBit.nasm | 3 +--
> 1 file changed,
On 11/13/14 18:27, Anthony PERARD wrote:
> From: Scott Duplichan
>
> This patch contain type casts and replace one * operation by a
> MultU64x32() call.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Scott Duplichan
> Signed-off-by: Anthony PERARD
> ---
> OvmfPkg
comments below
On 11/13/14 18:27, Anthony PERARD wrote:
> From: Scott Duplichan
>
> This patch contain only type cast.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Scott Duplichan
> Signed-off-by: Anthony PERARD
> ---
> OvmfPkg/XenBusDxe/EventChannel.c | 6 ++
On Fri, Nov 14, 2014 at 03:25:51PM +0100, Laszlo Ersek wrote:
> On 11/14/14 15:12, Paolo Bonzini wrote:
> >
> >
> > On 14/11/2014 14:40, Laszlo Ersek wrote:
> >> Now where is my thought process wrong? You might want to add an assert
> >> somewhere.
>
> I don't think your thought
On 11/13/14 18:27, Anthony PERARD wrote:
> This patch replace some types in GrantTable and the argument Index of
> XenHypercallHvmGetParam to what the types should be.
>
> This avoid to have type cast in code.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Anthony PE
On 11/13/14 18:27, Anthony PERARD wrote:
> Since a message to XenStore have a lenght of type UINT32, have
> XenStore.c deal only with UINT32 instead of a mixmatch with UINTN.
>
> This patch replaces the type of Len in WRITE_REQUEST and the type of the
> argument Len of XenStoreWriteStore and XenSt
Laszlo Ersek [mailto:ler...@redhat.com] wrote:
]Scott,
]
]On 11/13/14 18:27, Anthony PERARD wrote:
]> Hi,
]>
]> I've took ovmf-ia32-msft-xen.patch from Scott Duplichan and made a few
changes.
]>
]> So the first two patchs of this series changes the type of some
]> variables/arguments/fields in
Hi,
If I include my EFI application as a module in an existing BIOS by taking the
BIOS image, using UEFITool to insert. Will UefiMain(...) be executed on boot?
I have successfully done this with a driver, except the driver was only invoked
when the test application used it's protocol. I have
On 11/14/14 15:12, Paolo Bonzini wrote:
>
>
> On 14/11/2014 14:40, Laszlo Ersek wrote:
>> Now where is my thought process wrong? You might want to add an assert
>> somewhere.
I don't think your thought process is wrong. I think I'm being exactly
as right (or as wrong) as Se
On 14/11/2014 14:40, Laszlo Ersek wrote:
>>> >> Now where is my thought process wrong? You might want to add an assert
>>> >> somewhere.
>> >
>> > I don't think your thought process is wrong. I think I'm being exactly
>> > as right (or as wrong) as SeaBIOS under all cases, which is what I was
>>
On 11/14/14 12:51, Long, Qin wrote:
> Laszlo, thanks for catching this. This is one serious parentheses-matching
> issue.
>
> The patch is good. And I also did one quick validation. Please help to
> check-in this fix.
>
> Reviewed-by: Qin Long
Thank you. Committed as SVN r16389.
Cheers
La
On Fri, Nov 14, 2014 at 08:30:35AM +, Chen, Fan wrote:
> On Fri, 2014-11-14 at 08:11 +, Fan, Jeff wrote:
> > Sounds good idea to send INIT IPI to APs to let it be wait for SIPI state.
>
> Yes, this idea looks simple. so I just now did a Win2012R2 installing
> test, it caused a 0x0c4 e
On 11/14/14 14:31, Gabriel Somlo wrote:
> On Fri, Nov 14, 2014 at 10:26:55AM +0100, Laszlo Ersek wrote:
>> One question.
>>
>> On 11/14/14 04:01, Gabriel L. Somlo wrote:
>>> +
>>> + Status = EFI_SUCCESS;
>>> +
>>> + if (PciHdr->Device.InterruptPin != 0) {
>>
>> so here InterruptPin >= 1
>
> Same
On Fri, Nov 14, 2014 at 10:26:55AM +0100, Laszlo Ersek wrote:
> One question.
>
> On 11/14/14 04:01, Gabriel L. Somlo wrote:
> > +
> > + Status = EFI_SUCCESS;
> > +
> > + if (PciHdr->Device.InterruptPin != 0) {
>
> so here InterruptPin >= 1
Same as in SeaBIOS pci_bios_init_device() under "/* m
On Thu, Nov 13, 2014 at 05:27:08PM +, Anthony PERARD wrote:
> Hi,
>
> I've took ovmf-ia32-msft-xen.patch from Scott Duplichan and made a few
> changes.
>
> So the first two patchs of this series changes the type of some
> variables/arguments/fields in order to avoid to have to cast them to a
Laszlo, thanks for catching this. This is one serious parentheses-matching
issue.
The patch is good. And I also did one quick validation. Please help to check-in
this fix.
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Laszlo Ersek [mailto:ler...
Scott,
On 11/13/14 18:27, Anthony PERARD wrote:
> Hi,
>
> I've took ovmf-ia32-msft-xen.patch from Scott Duplichan and made a few
> changes.
>
> So the first two patchs of this series changes the type of some
> variables/arguments/fields in order to avoid to have to cast them to a
> different ty
SVN r16380 ("UEFI 2.4 X509 Certificate Hash and RFC3161 Timestamp
Verification support for Secure Boot") broke the "dbt" variable's
association with its expected namespace GUID.
According to "MdePkg/Include/Guid/ImageAuthentication.h", *all* of the
"db", "dbx", and "dbt" (== EFI_IMAGE_SECURITY_DAT
"The line before the signature block should be empty"
This is not always the case; the S-o-b can be preceded by other *tags*.
For now I'll insert an empty line between each pair of tags.
Thanks
Laszlo
--
Comprehensive S
One question.
On 11/14/14 04:01, Gabriel L. Somlo wrote:
> Remove hard-coded list of PCI devices for which the Interrupt Line
> register is initialized. Instead, provide a "visitor" function to
> initialize the register only for present and applicable PCI devices.
>
> At this time, we match the b
On Do, 2014-11-13 at 22:01 -0500, Gabriel L. Somlo wrote:
> New in version 7: correctly handle Q35 case with more than 24 slots
> on the root bus.
>
> SeaBIOS traverses the device path starting at the leaf and climbing
> toward the root, so the last "slot" value in mch_pci_slot_get_irq()
> is that
Sounds good idea to send INIT IPI to APs to let it be wait for SIPI state.
Jeff
-Original Message-
From: Justen, Jordan L
Sent: Friday, November 14, 2014 3:57 PM
To: Fan, Jeff; edk2-devel@lists.sourceforge.net
Subject: RE: [edk2] qemu + osx + smp vs.
dee9376ffc6e5522bb5e50512b521952a5421
On Do, 2014-11-13 at 15:12 -0500, Gabriel L. Somlo wrote:
> - patch 9/9 (dynamic IRQ Line initialization) now works on non-root
> buses and pci-to-pci bridges, 100% matching SeaBIOS behavior.
The code looks good. Great job!
Reviewed-by: Gerd Hoffmann
cheers,
Gerd
---
50 matches
Mail list logo
