Re: [edk2] patch review feedback about FvSimpleFileSystem module

2014-12-19 Thread Scott Duplichan
Carsey, Jaben [mailto:jaben.car...@intel.com] wrote: ]Sent: Friday, December 19, 2014 11:03 AM ]To: edk2-devel@lists.sourceforge.net; 'Olivier Martin'; Justen, Jordan L; Jin, Eric ]Subject: Re: [edk2] patch review feedback about FvSimpleFileSystem module ] ]Scott, ] ]I know that STATIC has also b

Re: [edk2] CirrusLogic5430 display card

2014-12-19 Thread Jordan Justen
On 2014-12-19 09:45:37, Sergey Isakov wrote: > Why not emulate something more realistic, for example Intel GMA950? Here is something else that was released under the BSD license: http://sourceforge.net/projects/efidevkit/files/Releases/Others/Other%20Contribution/ => GOP_Release.zip It is EDK (no

Re: [edk2] [PATCH v4 00/13] ArmVirtualizationQemu: support fw_cfg, bootorder, '-kernel'

2014-12-19 Thread Jordan Justen
Acked-by: Jordan Justen for the OvmfPkg patches. On 2014-12-17 13:34:38, Laszlo Ersek wrote: > Changes in v4: > - addressing review comments from Olivier & Peter (see per-patch notes) > - the fw_cfg MMIO selector & data registers are big endian now > - public branch: > > https://github.com/ler

Re: [edk2] [PATCH v2] OvmfPkg: enable the IPv6 support

2014-12-19 Thread Laszlo Ersek
On 12/19/14 04:27, Gary Ching-Pang Lin wrote: > There are several network stack drivers in MdeModulePkg or NetworkPkg. > Currently, we only use the drivers from MdeModulePkg which only provides > the IPv4 support. This commit adds the IPv6 drivers in NetworkPkg into > OVMF. > > Here is the table o

Re: [edk2] a question about cache mechanism in EnhancedFatDxe

2014-12-19 Thread Andrew Fish
Sheldon, I think the person that implemented this, a long time ago, is on vacation for the holidays. It is important to remember the FAT driver is required to boot by EFI and thus the size of the driver is also a constraint. It has to fit in the FLASH. It is also important to remember that E

Re: [edk2] `.data' type changed to PROGBITS

2014-12-19 Thread Andrew Fish
> On Dec 19, 2014, at 4:38 AM, Sergey Isakov wrote: > > Hi sirs, > What this message means? > > ld: warning: section `.data' type changed to PROGBITS > > I see it when compiled by GCC49 as well as by XCODE5 some modules: > edk2/DuetPkg/AcpiResetDxe > edk2/DuetPkg/PciBusNoEnumerationDxe

Re: [edk2] CirrusLogic5430 display card

2014-12-19 Thread Sergey Isakov
Why not emulate something more realistic, for example Intel GMA950? On 19 дек. 2014 г., at 17:46, Paolo Bonzini wrote: > > > On 19/12/2014 12:27, tiger...@via-alliance.com wrote: >> Hi, experts: >> >> I found an OptionROM example for CirrusLogic5430 display card in edkii >> source code packag

Re: [edk2] patch review feedback about FvSimpleFileSystem module

2014-12-19 Thread Carsey, Jaben
Scott, I know that STATIC has also been heavily discussed about shell code. I believe that the use of STATIC makes the code both more readable and safer as the compiler protects from certain behaviors. I don't know much about comdat folding, but do you have a patch to fix that root cause of th

[edk2] [Patch] VfrCompile Crash on efivarstore statement

2014-12-19 Thread Aaron Pop
The following VFR statement was causing the VfrCompile to crash: efivarstore UINT8, attribute = 0, name = STRING_TOKEN(STR_TEST3), varsize = 1, guid = { 0xf648132a, 0x4193, 0x4c13, { 0x85, 0x71, 0x33, 0xf0, 0x6d, 0x53, 0x74, 0xa9 } }; In the vfrStatementVarStor

Re: [edk2] CirrusLogic5430 display card

2014-12-19 Thread Paolo Bonzini
On 19/12/2014 12:27, tiger...@via-alliance.com wrote: > Hi, experts: > > I found an OptionROM example for CirrusLogic5430 display card in edkii > source code package. > > So where could I buy this product? > > It seems it is a very old PCI display card. I don't think the driver has been teste

Re: [edk2] patch review feedback about FvSimpleFileSystem module

2014-12-19 Thread Scott Duplichan
Tian, Feng [mailto:feng.t...@intel.com] wrote: ]Hi, Martin ] ]Per EDKII Coding Style 2.0 Spec, STATIC is not recommended for EDKII use. ](if you look into MdeModulePkg and MdePkg, you will find nobody uses this ]keyword as well). I appreciate Martin's use of STATIC for local functions. The recent

[edk2] `.data' type changed to PROGBITS

2014-12-19 Thread Sergey Isakov
Hi sirs, What this message means? ld: warning: section `.data' type changed to PROGBITS I see it when compiled by GCC49 as well as by XCODE5 some modules: edk2/DuetPkg/AcpiResetDxe edk2/DuetPkg/PciBusNoEnumerationDxe edk2/MdeModulePkg/Universal/PCD/Dxe I know, it is safe to ignore them b

[edk2] CirrusLogic5430 display card

2014-12-19 Thread TigerLiu
Hi, experts: I found an OptionROM example for CirrusLogic5430 display card in edkii source code package. So where could I buy this product? It seems it is a very old PCI display card. Best wishes, -- Download BIR

[edk2] Hi, someone hava a solution for Asus TF600T Vivotab RT fs1:\startup.ebl is not a valid path

2014-12-19 Thread Marco Vantellini
hi Please do you have a sulution to solve my problem desctibed below on asus TF600T ? I have a Tablet asus TF600T and after win 8.1 update it don't boot and stay on asus logo. Power and volume down I enter in a commend prompt and said fs1:\startup.ebl is not a valid path. Before to update to win 8.

Re: [edk2] a question about cache mechanism in EnhancedFatDxe

2014-12-19 Thread Sheldon Lu
Hi Sergey, Thanks for your reply! My opinion is: First, Enhanced FAT driver assigns 512KB(32KB/Page * 16Pages) to FAT Cache and 4MB(64KB/Page * 64Pages) to Data Cache. The Cache size is fixed. So full cache will not use more memory. Second, I think cache mechanism should be used t

Re: [edk2] patch review feedback about FvSimpleFileSystem module

2014-12-19 Thread Tian, Feng
Hi, Martin Per EDKII Coding Style 2.0 Spec, STATIC is not recommended for EDKII use. (if you look into MdeModulePkg and MdePkg, you will find nobody uses this keyword as well). For concern about why I create FV_FILESYSTEM_FILE for every Open() operation, yes, it's mainly because of the case yo