Re: [edk2] [PATCH] Don't require optional ISCSI negotiation responses.

2015-01-30 Thread Roy Franz
On Fri, Jan 30, 2015 at 12:17 AM, Ye, Ting wrote: > Hi Franz, > > Thanks for providing the patch. We agree with the update and will check in > your patch recently. > Could you please let us know which Linux iSCSI target triggers this error? We > may add more test items in future. > > Best Regar

Re: [edk2] [PATCH 2/4] UefiCpuPkg/MpService: register NMI handler for wake up AP with hlt state

2015-01-30 Thread Jordan Justen
On 2015-01-29 23:54:44, Chen Fan wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Chen Fan > --- > UefiCpuPkg/CpuDxe/CpuMp.c | 31 +++ > 1 file changed, 31 insertions(+) > > diff --git a/UefiCpuPkg/CpuDxe/CpuMp.c b/UefiCpuPkg/CpuDxe/Cp

Re: [edk2] [PATCH] ShellPkg: Add quotes around NSH index argument replacement

2015-01-30 Thread Peterson, Joe
Reviewed-by: Joe Peterson From: Carsey, Jaben Sent: Friday, January 30, 2015 8:33 AM To: Qiu, Shumin; Peterson, Joe Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: [PATCH] ShellPkg: Add quotes around NSH index argument replacement Joe and Shumin, Can you review this? (just flip pa

[edk2] [PATCH] ShellPkg: Add quotes around NSH index argument replacement

2015-01-30 Thread Carsey, Jaben
Joe and Shumin, Can you review this? (just flip parameter from FALSE to TRUE to automatically add quotes around ones with spaces) [PATCH] ShellPkg: Add quotes around NSH index argument replacement Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jaben Carsey Shell.c.pa

Re: [edk2] [Patch]ShellPkg: Fix typos.

2015-01-30 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey From: Qiu, Shumin Sent: Thursday, January 29, 2015 11:57 PM To: Carsey, Jaben Cc: edk2-devel@lists.sourceforge.net Subject: [edk2][Patch]ShellPkg: Fix typos. Importance: High Hi Jaben, Could you help review this patch? It fix some typos in ShellPkg. Contributed-under:

[edk2] [Test]Send First MSG

2015-01-30 Thread Wirlino
  Test Josiel W.   -- Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software developmen

Re: [edk2] Local APIC's LINT0 / LINT1 Configuration

2015-01-30 Thread Paolo Bonzini
On 30/01/2015 11:41, tiger...@zhaoxin.com wrote: > So, my question is: > BIOS provides MADT table, OS will use APIC mode. > So OS will re-configure LINT0 / LINT1 as other mode? > Yes. Typically LINT1 will remain NMI, while the OS will mask LINT0 and configure the IOAPIC to deliver ISA interru

Re: [edk2] [PATCH v2 16/29] Ovmf/Xen: fix pointer to int cast in XenBusDxe

2015-01-30 Thread Laszlo Ersek
On 01/26/15 20:03, Ard Biesheuvel wrote: > On ARM, xen_pfn_t is 64 bits but the size of a pointer is only > 32 bits, so casting between them needs to go via (UINTN). Also > move the xen_pfn_t cast outside the shift so that we can avoid > shifting 64-bit quantities on 32-bit architectures, which may

Re: [edk2] [PATCH v2 14/29] ArmVirtualizationPkg: Xen/PV relocatable platformlib instance

2015-01-30 Thread Laszlo Ersek
On 01/26/15 20:03, Ard Biesheuvel wrote: > Add a ArmPlatformLib instance that can deal with the self relocation > and truly dynamic discovery of system RAM base and size. > > Signed-off-by: Ard Biesheuvel > --- > > .../ArmVirtualizationPkg/Library/ArmXenRelocatablePlatformLib/AARCH64/MemnodePar

Re: [edk2] [PATCH v2 13/29] ArmVirtualizationPkg: allow patchable PCD for FV base address

2015-01-30 Thread Laszlo Ersek
On 01/26/15 20:03, Ard Biesheuvel wrote: > Allow the use of a patchable PCD for gArmTokenSpaceGuid.PcdFvBaseAddress > by moving it from the [FixedPcd] to the [Pcd] section in the INF file of > PlatformPeiLib. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuv

Re: [edk2] [PATCH v2 12/29] ArmVirtualizationPkg: implement custom MemoryInitPeiLib

2015-01-30 Thread Laszlo Ersek
On 01/26/15 20:03, Ard Biesheuvel wrote: > This implements a MemoryInitPeiLib instance that differs from the > stock ArmPlatformPkg version only in the fact that it does not remove > the memory used by the flash device (FD). The reason is that, when using > PrePi, the DXE core is started immediatel

Re: [edk2] [PATCH v2 08/29] ArmVirtualizationPkg: add padding to FDT allocation

2015-01-30 Thread Laszlo Ersek
On 01/28/15 17:18, Ard Biesheuvel wrote: > On 28 January 2015 at 15:13, Olivier Martin wrote: >> Same question as last time, would it not be better to have a PCD instead of >> hardcoded value? > > Ah yes, I remember reading that but failed to take it into account. > >> Some platforms might want

Re: [edk2] [PATCH v2 07/29] ArmVirtualizationPkg: use a HOB to store device tree blob

2015-01-30 Thread Laszlo Ersek
On 01/28/15 17:04, Ard Biesheuvel wrote: > On 28 January 2015 at 15:04, Olivier Martin wrote: >> I do not have a strong opinion on this patch. >> It would be better to keep the dynamic PCD support in this patch. But I am >> aware it is not possible with PrePi (I had the issue a couple of weeks ago

[edk2] Local APIC's LINT0 / LINT1 Configuration

2015-01-30 Thread TigerLiu
Hi, experts: I have a question about CPU’s LVT configuration. During BIOS Phase, Cpu driver will configure: LINT0 as ExtINT, used to be compatible with 8259 PIC. LINT1 as NMI interrupt, used to receive NMI. So, my question is: BIOS provides MADT table, OS will use APIC mode. So OS will re-configu

Re: [edk2] [PATCH v2 05/29] ArmVirtualizationPkg: allow patchable PCD for device tree base address

2015-01-30 Thread Laszlo Ersek
On 01/26/15 20:03, Ard Biesheuvel wrote: > To allow a runtime self relocating PrePi instance to discover the base > address of the device tree at runtime, allow the use of a patchable PCD > for gArmVirtualizationTokenSpaceGuid.PcdDeviceTreeInitialBaseAddress. > We will not be using the build time p

Re: [edk2] Do EFI drivers ever stopped?

2015-01-30 Thread Sergey Isakov
Thanks, I understand that a custom driver should react on ExitBootSevice to perform needed action. Good drivers already do this. On 30.01.2015, at 12:07, Laszlo Ersek wrote: > On 01/30/15 09:23, Sergey Isakov wrote: >> Dear sirs, >> >> Sorry for the stupid question, I am not found an explanatio

Re: [edk2] Do EFI drivers ever stopped?

2015-01-30 Thread Laszlo Ersek
On 01/30/15 09:23, Sergey Isakov wrote: > Dear sirs, > > Sorry for the stupid question, I am not found an explanation. > If an UEFI BIOS loaded additional drivers then how to stop all of them > at OS started? > I may propose that OnExitBootService do this but > DxeMain.c->CoreExitBootServices () d

[edk2] Do EFI drivers ever stopped?

2015-01-30 Thread Sergey Isakov
Dear sirs, Sorry for the stupid question, I am not found an explanation. If an UEFI BIOS loaded additional drivers then how to stop all of them at OS started? I may propose that OnExitBootService do this but DxeMain.c->CoreExitBootServices () does not contain such codes. So user should do this?

Re: [edk2] [PATCH] Don't require optional ISCSI negotiation responses.

2015-01-30 Thread Ye, Ting
Hi Franz, Thanks for providing the patch. We agree with the update and will check in your patch recently. Could you please let us know which Linux iSCSI target triggers this error? We may add more test items in future. Best Regards, Ye Ting -Original Message- From: Tian, Feng [mailto:

[edk2] [PATCH 3/4] UefiCpuPkg/MpService: update idt table entrance for APs

2015-01-30 Thread Chen Fan
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chen Fan --- UefiCpuPkg/CpuDxe/CpuMp.c | 8 1 file changed, 8 insertions(+) diff --git a/UefiCpuPkg/CpuDxe/CpuMp.c b/UefiCpuPkg/CpuDxe/CpuMp.c index 94b72b7..453dc47 100644 --- a/UefiCpuPkg/CpuDxe/CpuMp.c +++ b/UefiC

[edk2] [PATCH 1/4] Apic: introduce SendNmiIpi() for trigger NMI IPI interrupt

2015-01-30 Thread Chen Fan
After the HLT instruction stops the execution of AP, an enabled interrupt will resume execution. including including NMI and SMI, here we introduce NMI interrupt to wake up AP with hlt state. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chen Fan --- UefiCpuPkg/Include/L

[edk2] [PATCH 4/4] UefiCpuPkg/MpService: Put APs to sleep when not busy

2015-01-30 Thread Chen Fan
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chen Fan --- UefiCpuPkg/CpuDxe/CpuMp.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/UefiCpuPkg/CpuDxe/CpuMp.c b/UefiCpuPkg/CpuDxe/CpuMp.c index 453dc47..e328de7 100644 --- a/UefiCpuPkg/CpuDxe/CpuMp.c +++ b/U

[edk2] [PATCH 2/4] UefiCpuPkg/MpService: register NMI handler for wake up AP with hlt state

2015-01-30 Thread Chen Fan
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chen Fan --- UefiCpuPkg/CpuDxe/CpuMp.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/UefiCpuPkg/CpuDxe/CpuMp.c b/UefiCpuPkg/CpuDxe/CpuMp.c index 71b62be..94b72b7 100644 --- a/UefiCpuPkg/C

[edk2] [PATCH 0/4] UefiCpuPkg/MpService: Put APs to sleep when not busy

2015-01-30 Thread Chen Fan
nowadays, APs are busy running when installing MP protocol in multiple processors environment. so it whould consume much power resource unnecessary. this patchs put APs to sleep when not procedure to run, then via sending NMI IPI by BSP to wake up AP with hlt state. there is a proposal several mon

[edk2] [Patch]ShellPkg: Fix typos.

2015-01-30 Thread Qiu, Shumin
Hi Jaben, Could you help review this patch? It fix some typos in ShellPkg. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin mailto:shumin@intel.com>> Thanks Shumin ShellPkg_Typo.patch Description: ShellPkg_Typo.patch