[edk2] How to build the firmware image with SourceLevelDebugPkg?

Hi, I want do source level debugging with ajays usb 2.0 debug device and I use UDK-debuger-tool-use-manuel-SR1-v1-91 ( https://firmware.intel.com/sites/default/files/UDK-Debugger-Tool-User-Manual-SR1-v1-91_0.pdf ). When I did all changes and executed build -D SOURCE_DEBUG_ENABLE command, com

Re: [edk2] MdeModulePkg Maintainer: The PiDxeS3BootScriptLib does not seem to set EFI_BOOT_SCRIPT_TABLE_HEADER.Version !mS3BootScriptTablePtr->AtRuntime

> On Mar 31, 2015, at 9:45 PM, Zeng, Star wrote: > > Before the event callback, all the drivers(include SMM drivers) share the > same DXE SCRIPT_TABLE_PRIVATE_DATA instance, that means the instance pointed > by mS3BootScriptTablePtr. > After the event callback, all the SMM drivers share the sa

Re: [edk2] MdeModulePkg Maintainer: The PiDxeS3BootScriptLib does not seem to set EFI_BOOT_SCRIPT_TABLE_HEADER.Version !mS3BootScriptTablePtr->AtRuntime

Before the event callback, all the drivers(include SMM drivers) share the same DXE SCRIPT_TABLE_PRIVATE_DATA instance, that means the instance pointed by mS3BootScriptTablePtr. After the event callback, all the SMM drivers share the same SMM SCRIPT_TABLE_PRIVATE_DATA instance, that means the ins

Re: [edk2] MdeModulePkg Maintainer: The PiDxeS3BootScriptLib does not seem to set EFI_BOOT_SCRIPT_TABLE_HEADER.Version !mS3BootScriptTablePtr->AtRuntime

> On Mar 31, 2015, at 8:44 PM, Zeng, Star wrote: > > i Andrew, > > After SmmReadyToLock, only SMM driver is allowed to write boot script. In DXE > SCRIPT_TABLE_PRIVATE_DATA instance, only the TableBase field will be used for > BootScriptExecute at S3 resume, other fields will be not used. >

Re: [edk2] MdeModulePkg Maintainer: The PiDxeS3BootScriptLib does not seem to set EFI_BOOT_SCRIPT_TABLE_HEADER.Version

Hi Andrew, After SmmReadyToLock, only SMM driver is allowed to write boot script. In DXE SCRIPT_TABLE_PRIVATE_DATA instance, only the TableBase field will be used for BootScriptExecute at S3 resume, other fields will be not used. So the TableLength field in DXE SCRIPT_TABLE_PRIVATE_DATA instance

Re: [edk2] MdeModulePkg Maintainer: The PiDxeS3BootScriptLib does not seem to set EFI_BOOT_SCRIPT_TABLE_HEADER.Version

> On Mar 31, 2015, at 6:54 PM, Andrew Fish wrote: > >> >> On Mar 31, 2015, at 6:25 PM, Yao, Jiewen > > wrote: >> >> Yes. It seems a bug. >> We should initialize it. > > Thanks! > > The other thing that looked strange to me was: mS3BootScriptTablePtr and > mS3Boo

Re: [edk2] MdeModulePkg Maintainer: The PiDxeS3BootScriptLib does not seem to set EFI_BOOT_SCRIPT_TABLE_HEADER.Version

> On Mar 31, 2015, at 6:25 PM, Yao, Jiewen wrote: > > Yes. It seems a bug. > We should initialize it. Thanks! The other thing that looked strange to me was: mS3BootScriptTablePtr and mS3BootScriptTableSmmPtr of type SCRIPT_TABLE_PRIVATE_DATA. // // The boot script private data. // typedef str

Re: [edk2] [Patch 0/2] MdeModulePkg: Add two library instances

Jordan: As I mention in this patch, the ones in IntelFrameworkModulePkg are still kept for compatibility. So, I don't remove it now. I attach the patch to keep them in the same mail thread. Seemly, TortoiseGit doesn't support to it. Thanks Liming -Original Message- From: Justen,

Re: [edk2] How to setup ACPI tables for QEMU aarch64 virt hardware

Hi Shannon, I checked your branch and tested; I found there is a minor bug in QEMU ARM ACPI code that will cause FWTS test failed with ACPI syntaxcheck: 1. syntaxcheck: syntaxcheck;INF 00027| Name (_HID, "ACPI007") // _HID: Hardware ID syntaxcheck;INF |

Re: [edk2] MdeModulePkg Maintainer: The PiDxeS3BootScriptLib does not seem to set EFI_BOOT_SCRIPT_TABLE_HEADER.Version

Yes. It seems a bug. We should initialize it. Thank you Yao Jiewen -Original Message- From: Andrew Fish [mailto:af...@apple.com] Sent: Wednesday, April 01, 2015 6:32 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] MdeModulePkg Maintainer: The PiDxeS3BootScriptLib does not seem t

Re: [edk2] Large Vacant.bin in Vlv2TbltDevicePkg

Thanks. We are trying to remove this big empty file. Thanks, David | SSG BIOS -Original Message- From: Justen, Jordan L Sent: Sunday, March 29, 2015 8:25 AM To: Wei, David Cc: Bruce Cran; edk2-devel@lists.sourceforge.net Subject: Large Vacant.bin in Vlv2TbltDevicePkg David, Bruce poi

[edk2] MdeModulePkg Maintainer: The PiDxeS3BootScriptLib does not seem to set EFI_BOOT_SCRIPT_TABLE_HEADER.Version

I don’t see any code in the PiDxeS3BootScriptLib that sets a value to EFI_BOOT_SCRIPT_TABLE_HEADER.Version. The data is allocated via gBS->AllocatePages, and on the system I looked at the Version was set to 0xafaf. It seems like the driver should initialize this member to a known value? Thank

Re: [edk2] edk2[17084] Pkg-Module: CorebootModulePkg

On 2015-03-31 14:48:29, Andrew Fish wrote: > On Mar 31, 2015, at 2:41 PM, Jordan Justen > wrote: > On 2015-03-31 12:03:48, Zimmer, Vincent wrote: > >Good question. >Code has been public in a zip on http://firmware.intel.com for some >time. > > Strange.

Re: [edk2] edk2[17084] Pkg-Module: CorebootModulePkg

> On Mar 31, 2015, at 2:41 PM, Jordan Justen wrote: > > On 2015-03-31 12:03:48, Zimmer, Vincent wrote: >> Good question. >> Code has been public in a zip on http://firmware.intel.com >> for some time. > > Strange. I don't know why posting a .zip on a website would

Re: [edk2] edk2[17084] Pkg-Module: CorebootModulePkg

On 2015-03-31 12:03:48, Zimmer, Vincent wrote: > Good question. > Code has been public in a zip on http://firmware.intel.com for some time. Strange. I don't know why posting a .zip on a website would be preferable to having it in a repo. Was it not under an open source license previously? > We ha

Re: [edk2] edk2[17084] Pkg-Module: CorebootModulePkg

Yes. We should be able to curate the original commit messages and share them out. Let me follow-up w/ Maurice and Prince on this. Vincent -Original Message- From: Andrew Fish [mailto:af...@apple.com] Sent: Tuesday, March 31, 2015 12:07 PM To: edk2-devel@lists.sourceforge.net Cc: Stefan

Re: [edk2] edk2[17084] Pkg-Module: CorebootModulePkg

> On Mar 31, 2015, at 12:03 PM, Zimmer, Vincent > wrote: > > Good question. > Code has been public in a zip on http://firmware.intel.com for some time. > We have received feedback on that zip from coreboot community & others, > including Stefan, that helped inform moving it to live SCM on tia

Re: [edk2] edk2[17084] Pkg-Module: CorebootModulePkg

Good question. Code has been public in a zip on http://firmware.intel.com for some time. We have received feedback on that zip from coreboot community & others, including Stefan, that helped inform moving it to live SCM on tianocore so that it can be evolved with the community. Wiki at https://

Re: [edk2] [Patch 0/2] MdeModulePkg: Add two library instances

On 2015-03-31 03:25:10, Gao, Liming wrote: > Jordan: > Good comments. Here, I attach the patches to clean up Duet, Nt32 > and OvmfPkg. Please help review them. What about the part about removing the IntelFrameworkModulePkg versions? Why not send the other patches with git send-email? -Jordan

Re: [edk2] edk2[17084] Pkg-Module: CorebootModulePkg

Why didn't this get posted for review before being committed? I wonder if Patrick might have had some thoughts from having worked on: https://github.com/pgeorgi/edk2/tree/coreboot-pkg On Mon, Mar 30, 2015 at 6:06 PM, wrote: > Revision: 17084 > http://sourceforge.net/p/edk2/code/17084

Re: [edk2] [PATCH 0/2] ShellPkg: UefiShellDebug1CommandsLib: SETVAR fixes

In 1/2, it seems like the typo came from the Shell spec 2.0, but it was fixed in 2.1. My one minor comment is that in 2/2 it could have been IsStringOfHexBytes, and trivially verified an even number of characters without the extra StrLen call later on. Series Reviewed-by: Jordan Justen On 2015-

Re: [edk2] HII gEfiHiiPackageListProtocolGuid problem with GCC48 (VS2012x86 works)

[replying again, cc'ing edk2-devel this time] On Tue, Mar 31, 2015 at 10:26 AM, Andrew Fish wrote: > > Does you tool chain generate ELF, and then covert to PE/COFF? If so can > you objdump the sections in the ELF file (should be the .dll) and see if it > has a .hii section? > It does, and it do

Re: [edk2] [Patch] ShellPkg: Remove extra quotes surrounding flag values.

Reviewed-by: Jaben Carsey From: Qiu, Shumin Sent: Monday, March 30, 2015 6:32 PM To: Carsey, Jaben Cc: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch] ShellPkg: Remove extra quotes surrounding flag values. Importance: High Hi Jaben , Could you help review the patch? It remove the redund

Re: [edk2] HII gEfiHiiPackageListProtocolGuid problem with GCC48 (VS2012x86 works)

> On Mar 31, 2015, at 8:08 AM, Andrew Fish wrote: > > >> On Mar 31, 2015, at 3:49 AM, Gao, Liming > > wrote: >> >> Bruce: >> VS tool chain will generate HII package list as the resource section into >> the final EFI image. When DxeCore loads this EFI image and f

[edk2] Bug in Boot Maintenance Manager UI (Boot Options Delete/Commit/Change)?

I'm not sure if this is really a bug, but I noticed that if I delete a boot option, commit the changes and then try and delete a boot option under OVMF or on the Minnowboard MAX, I get a message "Question value mismatch with Option value! Press ENTER to continue". e.g.:select Boot Maintenance Man

Re: [edk2] HII gEfiHiiPackageListProtocolGuid problem with GCC48 (VS2012x86 works)

On 3/31/2015 4:49 AM, Gao, Liming wrote: >GCC tool chain doesn’t generate HII package list as the resource > section into the final EFI image. So, its HiiPackageListProtocolGuid is > not installed, and can’t be found. This is a feature gap in GCC tool chain. Ah, that makes sense - thanks! Cou

Re: [edk2] HII gEfiHiiPackageListProtocolGuid problem with GCC48 (VS2012x86 works)

Andrew: I guess so. I need to check GenFw implementation and root cause it. Thanks Liming From: Andrew Fish [mailto:af...@apple.com] Sent: Tuesday, March 31, 2015 11:08 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] HII gEfiHiiPackageListProtocolGuid problem with GCC48 (VS2012x86 w

Re: [edk2] HII gEfiHiiPackageListProtocolGuid problem with GCC48 (VS2012x86 works)

> On Mar 31, 2015, at 3:49 AM, Gao, Liming wrote: > > Bruce: > VS tool chain will generate HII package list as the resource section into > the final EFI image. When DxeCore loads this EFI image and finds its resource > section, DxeCore will install HiiPackageListProtocolGuid on its image han

[edk2] How to create working firmware image for source level debugging on usb2 port?

Hi everybody, I' m new to MinnowBoard Max and I started working on Minnow board month ago. I tried to do source level debug with USB port on MinowBoard Max following instructions in UDK-Debugger-Tool-User-Manual v1.91 and using Ajays tool. We added DebugCommunicationLibUsb in PlatformPkgIA32.dsc.

Re: [edk2] HII gEfiHiiPackageListProtocolGuid problem with GCC48 (VS2012x86 works)

Bruce: VS tool chain will generate HII package list as the resource section into the final EFI image. When DxeCore loads this EFI image and finds its resource section, DxeCore will install HiiPackageListProtocolGuid on its image handle, then the driver calls OpenProtocol() can success. GCC

Re: [edk2] [Patch 0/2] MdeModulePkg: Add two library instances

Jordan: Good comments. Here, I attach the patches to clean up Duet, Nt32 and OvmfPkg. Please help review them. Thanks Liming -Original Message- From: Justen, Jordan L Sent: Tuesday, March 31, 2015 12:08 AM To: edk2-devel@lists.sourceforge.net; Gao, Liming; edk2-devel@lists.sourceforg

[edk2] WinPcap question

Hi, experts: I want to test some network apps with Nt32 Package. I have some questions : 1. WinPcap could be installed on Win7 x64 OS? (or need XP Compatible Mode) 2. SnpNt32Io could run in Win7 x64 OS? Best wishes, 本邮件仅针对指定的收件人发送并可能含有保密或专有内容。任何非指定收件人所为之查阅、转发或使用本信息是不被允许的。 如果您误收到本邮件，请立

Re: [edk2] [PATCH 2/2] OvmfPkg/XenBusDxe: Fix build issue with VS2010

On 03/31/15 09:06, Jordan Justen wrote: > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen > --- > OvmfPkg/XenBusDxe/TestAndClearBit.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/OvmfPkg/XenBusDxe/TestAndC

Re: [edk2] [PATCH 1/2] OvmfPkg/SmbiosPlatformDxe: Fix build issue with VS2010

On 03/31/15 09:06, Jordan Justen wrote: > VS2010 doesn't accept an unsized array within a structure. > > Cc: Gabriel Somlo > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen > --- > OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 12 +++- > 1 file c

Re: [edk2] [PATCH] [MdePkg ] Missing GUID variable in DiskInfo.h

The patch is good. Reviewed-by: Liming Gao liming@intel.com Thanks Liming From: Felix Poludov [mailto:fel...@ami.com] Sent: Tuesday, March 31, 2015 1:16 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [PATCH] [MdePkg ] Missing GUID variable in DiskInfo.h

Re: [edk2] [Patch 0/2] IntelFrameworkModulePkg: Clean up two library instances

On 2015-03-30 19:08:02, Gao, Liming wrote: > Yes. I use TortoiseGit to send all patches together. Hmm, it looks like you had luck with the previous tortoisegit email issue: https://code.google.com/p/tortoisegit/issues/detail?id=2414 Maybe they can fix multiple emails to be sent threaded too? I

[edk2] [PATCH 1/2] OvmfPkg/SmbiosPlatformDxe: Fix build issue with VS2010

VS2010 doesn't accept an unsized array within a structure. Cc: Gabriel Somlo Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen --- OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/Ov

[edk2] [PATCH 2/2] OvmfPkg/XenBusDxe: Fix build issue with VS2010

Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen --- OvmfPkg/XenBusDxe/TestAndClearBit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/XenBusDxe/TestAndClearBit.c b/OvmfPkg/XenBusDxe/TestAndClearBit.c index 4